jlprat commented on a change in pull request #10770:
URL: https://github.com/apache/kafka/pull/10770#discussion_r640512166



##########
File path: docs/security.html
##########
@@ -47,7 +47,7 @@ <h3 class="anchor-heading"><a id="security_ssl" 
class="anchor-link"></a><a href=
             The tool supports two different keystore formats, the Java 
specific jks format which has been deprecated by now, as well as PKCS12.
             PKCS12 is the default format as of Java version 9, to ensure this 
format is being used regardless of the Java version in use all following
             commands explicitly specify the PKCS12 format.
-            <pre class="line-numbers"><code class="language-bash">keytool 
-keystore {keystorefile} -alias localhost -validity {validity} -genkey -keyalg 
RSA -storetype pkcs12</code></pre>
+            <pre class="line-numbers"><code class="language-bash">&gt; keytool 
-keystore {keystorefile} -alias localhost -validity {validity} -genkey -keyalg 
RSA -storetype pkcs12</code></pre>

Review comment:
       The examples present in the documentation, use more frequently the `>` 
character when showing commands. Sometimes a `$` is shown, and really 
occasionally nothing is put in there.
   As `>` was the most common used one already in the codebase, I decided to 
unify on this character.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to