[GitHub] [kafka] abbccdda merged pull request #10017: KAFKA-12260: Avoid hitting NPE for partitionsFor

2021-05-26 Thread GitBox
abbccdda merged pull request #10017: URL: https://github.com/apache/kafka/pull/10017 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pleas

[GitHub] [kafka] dajac commented on pull request #10757: MINOR: Log more information when producer snapshot is written

2021-05-26 Thread GitBox
dajac commented on pull request #10757: URL: https://github.com/apache/kafka/pull/10757#issuecomment-848531545 @ijuma @lbradstreet Thanks for your review. Merging to trunk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] dajac merged pull request #10757: MINOR: Log more information when producer snapshot is written

2021-05-26 Thread GitBox
dajac merged pull request #10757: URL: https://github.com/apache/kafka/pull/10757 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please c

[jira] [Assigned] (KAFKA-12243) Add toString methods to some of the classes introduced by this Epic

2021-05-26 Thread loboxu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] loboxu reassigned KAFKA-12243: -- Assignee: loboxu > Add toString methods to some of the classes introduced by this Epic >

[jira] [Commented] (KAFKA-12243) Add toString methods to some of the classes introduced by this Epic

2021-05-26 Thread loboxu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17351587#comment-17351587 ] loboxu commented on KAFKA-12243: [~jsancio] ,Is there a more detailed description of thi

[GitHub] [kafka] chia7712 commented on a change in pull request #10761: MINOR: Don't ignore deletion of partition metadata file and log topic id clean-ups

2021-05-26 Thread GitBox
chia7712 commented on a change in pull request #10761: URL: https://github.com/apache/kafka/pull/10761#discussion_r639477851 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -325,19 +325,25 @@ class Log(@volatile private var _dir: File, // Ensure we do not try t

[jira] [Created] (KAFKA-12850) Use JDK16 for builds instead of JDK15

2021-05-26 Thread Josep Prat (Jira)
Josep Prat created KAFKA-12850: -- Summary: Use JDK16 for builds instead of JDK15 Key: KAFKA-12850 URL: https://issues.apache.org/jira/browse/KAFKA-12850 Project: Kafka Issue Type: Improvement

[GitHub] [kafka] mdedetrich commented on pull request #10762: KAFKA-12819: Add assert messages to MirrorMaker tests plus other qual…

2021-05-26 Thread GitBox
mdedetrich commented on pull request #10762: URL: https://github.com/apache/kafka/pull/10762#issuecomment-848553078 Okay PR is ready, some tests are failing but it seems to be due to unstable CI -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[jira] [Commented] (KAFKA-12430) emit.heartbeats.enabled = false should disable heartbeats topic creation

2021-05-26 Thread Matthew de Detrich (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17351617#comment-17351617 ] Matthew de Detrich commented on KAFKA-12430: I think I might just create a s

[GitHub] [kafka] mdedetrich commented on pull request #10648: KAFKA-9726: Add IdentityReplicationPolicy for MM2

2021-05-26 Thread GitBox
mdedetrich commented on pull request #10648: URL: https://github.com/apache/kafka/pull/10648#issuecomment-848567812 As discussed in the mailing list, the other PR is more suitable since it doesn't require a KIP, I will close this PR (it can be reopened later if something else changes) --

[GitHub] [kafka] mdedetrich closed pull request #10648: KAFKA-9726: Add IdentityReplicationPolicy for MM2

2021-05-26 Thread GitBox
mdedetrich closed pull request #10648: URL: https://github.com/apache/kafka/pull/10648 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, ple

[GitHub] [kafka] cadonna opened a new pull request #10765: KAFKA-12519: Remove built-in Streams metrics for versions 0.10.0-2.4

2021-05-26 Thread GitBox
cadonna opened a new pull request #10765: URL: https://github.com/apache/kafka/pull/10765 As specified in KIP-743, this PR removes the built-in metrics in Streams that are superseded by the refactoring proposed in KIP-444. ### Committer Checklist (excluded from commit message) -

[GitHub] [kafka] cadonna commented on pull request #10765: KAFKA-12519: Remove built-in Streams metrics for versions 0.10.0-2.4

2021-05-26 Thread GitBox
cadonna commented on pull request #10765: URL: https://github.com/apache/kafka/pull/10765#issuecomment-848628471 Sorry for this massive cleanup PR: @guozhangwang @mjsax @ableegoldman @vvcephei @abbccdda -- This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [kafka] showuon commented on a change in pull request #10765: KAFKA-12519: Remove built-in Streams metrics for versions 0.10.0-2.4

2021-05-26 Thread GitBox
showuon commented on a change in pull request #10765: URL: https://github.com/apache/kafka/pull/10765#discussion_r639585452 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImpl.java ## @@ -175,11 +171,7 @@ public StreamsMe

[GitHub] [kafka] cadonna commented on a change in pull request #10765: KAFKA-12519: Remove built-in Streams metrics for versions 0.10.0-2.4

2021-05-26 Thread GitBox
cadonna commented on a change in pull request #10765: URL: https://github.com/apache/kafka/pull/10765#discussion_r639602759 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImpl.java ## @@ -52,8 +51,7 @@ public class Strea

[GitHub] [kafka] cadonna commented on pull request #10765: KAFKA-12519: Remove built-in Streams metrics for versions 0.10.0-2.4

2021-05-26 Thread GitBox
cadonna commented on pull request #10765: URL: https://github.com/apache/kafka/pull/10765#issuecomment-848661315 >I did a search, and found there are still 2 places with related variables that should be handled. @showuon Nice catch! -- This is an automated message from the Apache

[jira] [Commented] (KAFKA-5892) Connector property override does not work unless setting ALL converter properties

2021-05-26 Thread dc-heros (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17351691#comment-17351691 ] dc-heros commented on KAFKA-5892: - Hi [~jsahu], are you working on this? Can I take this

[GitHub] [kafka] dengziming commented on pull request #10467: KAFKA-12609: Rewrite ListOffsets using AdminApiDriver

2021-05-26 Thread GitBox
dengziming commented on pull request #10467: URL: https://github.com/apache/kafka/pull/10467#issuecomment-848674442 Helli @dajac , are you interested in reviewing this PR, the current `ListOffsets` implementation is very complex and can be simplified tremendously if we use `AdminApiDriver`

[GitHub] [kafka] jlprat opened a new pull request #10766: MINOR: Fix indentation for several doc pages

2021-05-26 Thread GitBox
jlprat opened a new pull request #10766: URL: https://github.com/apache/kafka/pull/10766 Fixes the indentation of the code listings for: * api.html * configuration.html * design.html * implementation.html * toc.html These changes consist of whitespaces added or removed

[GitHub] [kafka] jlprat commented on a change in pull request #10766: MINOR: Fix indentation for several doc pages

2021-05-26 Thread GitBox
jlprat commented on a change in pull request #10766: URL: https://github.com/apache/kafka/pull/10766#discussion_r639680136 ## File path: docs/toc.html ## @@ -86,26 +86,26 @@ Increasing replication factor 6.2 Datace

[GitHub] [kafka] cadonna commented on a change in pull request #10428: KAFKA-12572: Add import ordering checkstyle rule and configure an automatic formatter

2021-05-26 Thread GitBox
cadonna commented on a change in pull request #10428: URL: https://github.com/apache/kafka/pull/10428#discussion_r639666899 ## File path: eclipse-formatter.xml ## @@ -0,0 +1,60 @@ + + + + + + + + + + + + + + + + + + + + +

[GitHub] [kafka] jlprat opened a new pull request #10767: MINOR: Fix code listings in quickstart

2021-05-26 Thread GitBox
jlprat opened a new pull request #10767: URL: https://github.com/apache/kafka/pull/10767 Uses the right character for shell scripts (`>` instead of `$`) Uses the right syntax highlighting ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementati

[GitHub] [kafka] jlprat opened a new pull request #10768: MINOR: fix code listings for ops

2021-05-26 Thread GitBox
jlprat opened a new pull request #10768: URL: https://github.com/apache/kafka/pull/10768 Fixes indentation, uses the right character for bash (`>`), and fixes syntax highlighting for listings ### Committer Checklist (excluded from commit message) - [ ] Verify design and implemen

[GitHub] [kafka] jlprat opened a new pull request #10769: MINOR: fix code listings connect

2021-05-26 Thread GitBox
jlprat opened a new pull request #10769: URL: https://github.com/apache/kafka/pull/10769 Uses the right tool to show code listings, so it is consistent with the rest of the examples ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation

[GitHub] [kafka] jlprat opened a new pull request #10770: MINOR: fix code listings security.html

2021-05-26 Thread GitBox
jlprat opened a new pull request #10770: URL: https://github.com/apache/kafka/pull/10770 Fix examples under security.html so they use the right bash icon (`>` instead of `$`) and also uses the right tool for showing code listings Some of the diffs are caused also by the IDE alignin

[GitHub] [kafka] jlprat commented on pull request #10766: MINOR: Fix indentation for several doc pages

2021-05-26 Thread GitBox
jlprat commented on pull request #10766: URL: https://github.com/apache/kafka/pull/10766#issuecomment-848762136 CC. @cadonna as you reviewed the last doc changes on formatting and styling, you might want to review these as well. I split the changes in several PRs so it's more bearable to r

[GitHub] [kafka] jlprat commented on pull request #10768: MINOR: fix code listings for ops.html

2021-05-26 Thread GitBox
jlprat commented on pull request #10768: URL: https://github.com/apache/kafka/pull/10768#issuecomment-848762557 CC. @cadonna as you reviewed the last doc changes on formatting and styling, you might want to review these as well. I split the changes in several PRs so it's more bearable to r

[GitHub] [kafka] jlprat commented on pull request #10767: MINOR: Fix code listings in quickstart.html

2021-05-26 Thread GitBox
jlprat commented on pull request #10767: URL: https://github.com/apache/kafka/pull/10767#issuecomment-848762425 CC. @cadonna as you reviewed the last doc changes on formatting and styling, you might want to review these as well. I split the changes in several PRs so it's more bearable to r

[GitHub] [kafka] jlprat commented on pull request #10770: MINOR: fix code listings security.html

2021-05-26 Thread GitBox
jlprat commented on pull request #10770: URL: https://github.com/apache/kafka/pull/10770#issuecomment-848762769 CC. @cadonna as you reviewed the last doc changes on formatting and styling, you might want to review these as well. I split the changes in several PRs so it's more bearable to r

[GitHub] [kafka] jlprat commented on pull request #10769: MINOR: fix code listings connect.html

2021-05-26 Thread GitBox
jlprat commented on pull request #10769: URL: https://github.com/apache/kafka/pull/10769#issuecomment-848762697 CC. @cadonna as you reviewed the last doc changes on formatting and styling, you might want to review these as well. I split the changes in several PRs so it's more bearable to r

[GitHub] [kafka] showuon commented on pull request #10338: KAFKA-10251: wait for consumer rebalance completed before consuming records

2021-05-26 Thread GitBox
showuon commented on pull request #10338: URL: https://github.com/apache/kafka/pull/10338#issuecomment-848770650 @mumrah , could you please take a look again? Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] KahnCheny commented on pull request #10746: MINOR: remove unneccessary public keyword from ProducerInterceptor/ConsumerInterceptor interface

2021-05-26 Thread GitBox
KahnCheny commented on pull request #10746: URL: https://github.com/apache/kafka/pull/10746#issuecomment-848777456 jenkins pr-merge passes? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[jira] [Commented] (KAFKA-7500) MirrorMaker 2.0 (KIP-382)

2021-05-26 Thread jorge arada (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17351807#comment-17351807 ] jorge arada commented on KAFKA-7500: Any ideia when the SinkConnector will be release

[GitHub] [kafka] vvcephei commented on a change in pull request #10731: KAFKA-12815: Update JavaDocs of ValueTransformerWithKey

2021-05-26 Thread GitBox
vvcephei commented on a change in pull request #10731: URL: https://github.com/apache/kafka/pull/10731#discussion_r639778036 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/ValueTransformerWithKey.java ## @@ -75,14 +75,20 @@ void init(final ProcessorC

[GitHub] [kafka] jolshan commented on a change in pull request #10761: MINOR: Don't ignore deletion of partition metadata file and log topic id clean-ups

2021-05-26 Thread GitBox
jolshan commented on a change in pull request #10761: URL: https://github.com/apache/kafka/pull/10761#discussion_r639833755 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -325,19 +325,25 @@ class Log(@volatile private var _dir: File, // Ensure we do not try to

[jira] [Commented] (KAFKA-12257) Consumer mishandles topics deleted and recreated with the same name

2021-05-26 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17351898#comment-17351898 ] Justine Olshan commented on KAFKA-12257: With the changes from [KIP-516|https:/

[GitHub] [kafka] socutes closed pull request #10596: KAFKA-12715: ACL authentication, Host field support IP network segment

2021-05-26 Thread GitBox
socutes closed pull request #10596: URL: https://github.com/apache/kafka/pull/10596 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [kafka] socutes commented on pull request #10596: KAFKA-12715: ACL authentication, Host field support IP network segment

2021-05-26 Thread GitBox
socutes commented on pull request #10596: URL: https://github.com/apache/kafka/pull/10596#issuecomment-848901314 PR is a little hasty, I submit each KIP to initiate the operation -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[jira] [Comment Edited] (KAFKA-12257) Consumer mishandles topics deleted and recreated with the same name

2021-05-26 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17351898#comment-17351898 ] Justine Olshan edited comment on KAFKA-12257 at 5/26/21, 4:05 PM:

[jira] [Comment Edited] (KAFKA-12257) Consumer mishandles topics deleted and recreated with the same name

2021-05-26 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17351898#comment-17351898 ] Justine Olshan edited comment on KAFKA-12257 at 5/26/21, 4:05 PM:

[jira] [Comment Edited] (KAFKA-12257) Consumer mishandles topics deleted and recreated with the same name

2021-05-26 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17351898#comment-17351898 ] Justine Olshan edited comment on KAFKA-12257 at 5/26/21, 4:05 PM:

[jira] [Updated] (KAFKA-12849) Consider migrating TaskMetadata to interface with internal implementation

2021-05-26 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-12849: --- Labels: needs-kip newbie newbie++ (was: ) > Consider migrating TaskMetadata

[jira] [Commented] (KAFKA-5892) Connector property override does not work unless setting ALL converter properties

2021-05-26 Thread Jitendra Sahu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17351916#comment-17351916 ] Jitendra Sahu commented on KAFKA-5892: -- Sure,go ahead. > Connector property overrid

[GitHub] [kafka] ableegoldman commented on a change in pull request #10755: MINOR: deprecate TaskMetadata constructor and add KIP-740 notes to upgrade guide

2021-05-26 Thread GitBox
ableegoldman commented on a change in pull request #10755: URL: https://github.com/apache/kafka/pull/10755#discussion_r639896963 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/TaskMetadata.java ## @@ -40,6 +40,18 @@ private final Optional timeCur

[GitHub] [kafka] cmccabe commented on a change in pull request #10752: KAFKA-12620 Allocate Producer IDs in KRaft controller

2021-05-26 Thread GitBox
cmccabe commented on a change in pull request #10752: URL: https://github.com/apache/kafka/pull/10752#discussion_r639919437 ## File path: core/src/main/scala/kafka/server/BrokerServer.scala ## @@ -246,9 +245,16 @@ class BrokerServer( // Create transaction coordinator,

[GitHub] [kafka] cmccabe commented on a change in pull request #10752: KAFKA-12620 Allocate Producer IDs in KRaft controller

2021-05-26 Thread GitBox
cmccabe commented on a change in pull request #10752: URL: https://github.com/apache/kafka/pull/10752#discussion_r639919977 ## File path: core/src/main/scala/kafka/server/BrokerServer.scala ## @@ -22,7 +22,6 @@ import java.util.concurrent.atomic.AtomicBoolean import java.util.

[GitHub] [kafka] cmccabe commented on a change in pull request #10752: KAFKA-12620 Allocate Producer IDs in KRaft controller

2021-05-26 Thread GitBox
cmccabe commented on a change in pull request #10752: URL: https://github.com/apache/kafka/pull/10752#discussion_r639922279 ## File path: core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala ## @@ -259,6 +260,10 @@ class BrokerMetadataListener( clientQuo

[GitHub] [kafka] cmccabe commented on pull request #10752: KAFKA-12620 Allocate Producer IDs in KRaft controller

2021-05-26 Thread GitBox
cmccabe commented on pull request #10752: URL: https://github.com/apache/kafka/pull/10752#issuecomment-848944712 Thanks for this, @mumrah . Very clean PR overall. Can you add a test that the RPC fails if we don't have cluster authorization, in `ControllerApisTest.scala`? Should be ve

[GitHub] [kafka] cmccabe commented on a change in pull request #10752: KAFKA-12620 Allocate Producer IDs in KRaft controller

2021-05-26 Thread GitBox
cmccabe commented on a change in pull request #10752: URL: https://github.com/apache/kafka/pull/10752#discussion_r639928477 ## File path: metadata/src/main/java/org/apache/kafka/controller/QuorumController.java ## @@ -1199,6 +1213,22 @@ public void processBatchEndOffset(long o

[jira] [Commented] (KAFKA-12849) Consider migrating TaskMetadata to interface with internal implementation

2021-05-26 Thread Josep Prat (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17351935#comment-17351935 ] Josep Prat commented on KAFKA-12849: I would like to work on this one. Shall I first

[jira] [Issue Comment Deleted] (KAFKA-12849) Consider migrating TaskMetadata to interface with internal implementation

2021-05-26 Thread Josep Prat (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josep Prat updated KAFKA-12849: --- Comment: was deleted (was: I would like to work on this one. Shall I first create the KIP?) > Consi

[jira] [Commented] (KAFKA-12849) Consider migrating TaskMetadata to interface with internal implementation

2021-05-26 Thread Josep Prat (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17351936#comment-17351936 ] Josep Prat commented on KAFKA-12849: I would like to work on this one. Shall I creat

[jira] [Assigned] (KAFKA-12849) Consider migrating TaskMetadata to interface with internal implementation

2021-05-26 Thread Josep Prat (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josep Prat reassigned KAFKA-12849: -- Assignee: Josep Prat > Consider migrating TaskMetadata to interface with internal implementat

[jira] [Commented] (KAFKA-12824) Remove Deprecated method KStream#branch

2021-05-26 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17351939#comment-17351939 ] Matthias J. Sax commented on KAFKA-12824: - It's not totally clear, but 4.0 shoul

[jira] [Commented] (KAFKA-12849) Consider migrating TaskMetadata to interface with internal implementation

2021-05-26 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17351940#comment-17351940 ] A. Sophie Blee-Goldman commented on KAFKA-12849: Yep – it _should_ be re

[GitHub] [kafka] ableegoldman commented on a change in pull request #10755: MINOR: deprecate TaskMetadata constructor and add KIP-740 notes to upgrade guide

2021-05-26 Thread GitBox
ableegoldman commented on a change in pull request #10755: URL: https://github.com/apache/kafka/pull/10755#discussion_r639936420 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/TaskMetadata.java ## @@ -40,6 +40,18 @@ private final Optional timeCur

[GitHub] [kafka] mumrah commented on a change in pull request #10752: KAFKA-12620 Allocate Producer IDs in KRaft controller

2021-05-26 Thread GitBox
mumrah commented on a change in pull request #10752: URL: https://github.com/apache/kafka/pull/10752#discussion_r639938409 ## File path: core/src/main/scala/kafka/server/BrokerServer.scala ## @@ -22,7 +22,6 @@ import java.util.concurrent.atomic.AtomicBoolean import java.util.c

[GitHub] [kafka] mjsax commented on a change in pull request #10755: MINOR: deprecate TaskMetadata constructor and add KIP-740 notes to upgrade guide

2021-05-26 Thread GitBox
mjsax commented on a change in pull request #10755: URL: https://github.com/apache/kafka/pull/10755#discussion_r639948650 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/TaskMetadata.java ## @@ -40,6 +40,18 @@ private final Optional timeCurrentIdl

[jira] [Commented] (KAFKA-9168) Integrate JNI direct buffer support to RocksDBStore

2021-05-26 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17351946#comment-17351946 ] A. Sophie Blee-Goldman commented on KAFKA-9168: --- Sounds good! This shouldn'

[jira] [Commented] (KAFKA-12849) Consider migrating TaskMetadata to interface with internal implementation

2021-05-26 Thread Josep Prat (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17351947#comment-17351947 ] Josep Prat commented on KAFKA-12849: I'll prepare the KIP tomorrow > Consider migra

[jira] [Commented] (KAFKA-12848) Add some basic benchmarks for Kafka Streams

2021-05-26 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17351948#comment-17351948 ] A. Sophie Blee-Goldman commented on KAFKA-12848: [~sagarrao] John actual

[jira] [Commented] (KAFKA-12849) Consider migrating TaskMetadata to interface with internal implementation

2021-05-26 Thread Josep Prat (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17351965#comment-17351965 ] Josep Prat commented on KAFKA-12849: Just to be sure, the intention is to convert Ta

[GitHub] [kafka] ableegoldman commented on pull request #10755: MINOR: deprecate TaskMetadata constructor and add KIP-740 notes to upgrade guide

2021-05-26 Thread GitBox
ableegoldman commented on pull request #10755: URL: https://github.com/apache/kafka/pull/10755#issuecomment-848974085 Unrelated test failures: `DynamicBrokerConfigTest.testPasswordConfigEncoderSecretChange()` `RaftClusterTest` `RaftEventSimulationTest.canMakeProgressIfMajorityIsReac

[jira] [Created] (KAFKA-12851) Flaky Test RaftEventSimulationTest.canMakeProgressIfMajorityIsReachable

2021-05-26 Thread A. Sophie Blee-Goldman (Jira)
A. Sophie Blee-Goldman created KAFKA-12851: -- Summary: Flaky Test RaftEventSimulationTest.canMakeProgressIfMajorityIsReachable Key: KAFKA-12851 URL: https://issues.apache.org/jira/browse/KAFKA-12851

[GitHub] [kafka] ableegoldman merged pull request #10755: MINOR: deprecate TaskMetadata constructor and add KIP-740 notes to upgrade guide

2021-05-26 Thread GitBox
ableegoldman merged pull request #10755: URL: https://github.com/apache/kafka/pull/10755 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, p

[jira] [Commented] (KAFKA-12849) Consider migrating TaskMetadata to interface with internal implementation

2021-05-26 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17351970#comment-17351970 ] A. Sophie Blee-Goldman commented on KAFKA-12849: That's something we'll

[jira] [Commented] (KAFKA-12849) Consider migrating TaskMetadata to interface with internal implementation

2021-05-26 Thread Josep Prat (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17351974#comment-17351974 ] Josep Prat commented on KAFKA-12849: Thanks a lot for the explanation! It's all clea

[jira] [Commented] (KAFKA-12848) Add some basic benchmarks for Kafka Streams

2021-05-26 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17351978#comment-17351978 ] Sagar Rao commented on KAFKA-12848: --- [~ableegoldman], I think I have seen it in the AK

[GitHub] [kafka] mjsax commented on a change in pull request #10731: KAFKA-12815: Update JavaDocs of ValueTransformerWithKey

2021-05-26 Thread GitBox
mjsax commented on a change in pull request #10731: URL: https://github.com/apache/kafka/pull/10731#discussion_r640004045 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/ValueTransformerWithKey.java ## @@ -75,14 +75,20 @@ void init(final ProcessorCont

[GitHub] [kafka] tang7526 commented on a change in pull request #10534: KAFKA-806: Index may not always observe log.index.interval.bytes

2021-05-26 Thread GitBox
tang7526 commented on a change in pull request #10534: URL: https://github.com/apache/kafka/pull/10534#discussion_r640016337 ## File path: core/src/main/scala/kafka/log/LogSegment.scala ## @@ -162,15 +162,43 @@ class LogSegment private[log] (val log: FileRecords, // appe

[GitHub] [kafka] tang7526 commented on a change in pull request #10534: KAFKA-806: Index may not always observe log.index.interval.bytes

2021-05-26 Thread GitBox
tang7526 commented on a change in pull request #10534: URL: https://github.com/apache/kafka/pull/10534#discussion_r640016337 ## File path: core/src/main/scala/kafka/log/LogSegment.scala ## @@ -162,15 +162,43 @@ class LogSegment private[log] (val log: FileRecords, // appe

[GitHub] [kafka] tang7526 commented on pull request #10534: KAFKA-806: Index may not always observe log.index.interval.bytes

2021-05-26 Thread GitBox
tang7526 commented on pull request #10534: URL: https://github.com/apache/kafka/pull/10534#issuecomment-849014645 > @tang7526: Thanks for the PR. A few comments below. Also, could we add a unit test for this? Done. -- This is an automated message from the Apache Git Service. To re

[GitHub] [kafka] tang7526 removed a comment on pull request #10534: KAFKA-806: Index may not always observe log.index.interval.bytes

2021-05-26 Thread GitBox
tang7526 removed a comment on pull request #10534: URL: https://github.com/apache/kafka/pull/10534#issuecomment-825051965 @chia7712 Could you help to review this PR? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[jira] [Commented] (KAFKA-9531) java.net.UnknownHostException loop on VM rolling update using CNAME

2021-05-26 Thread Britt Bolen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17352010#comment-17352010 ] Britt Bolen commented on KAFKA-9531: I see a similar issue using both the cli produce

[jira] [Comment Edited] (KAFKA-9531) java.net.UnknownHostException loop on VM rolling update using CNAME

2021-05-26 Thread Britt Bolen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17352010#comment-17352010 ] Britt Bolen edited comment on KAFKA-9531 at 5/26/21, 6:27 PM: -

[jira] [Comment Edited] (KAFKA-9531) java.net.UnknownHostException loop on VM rolling update using CNAME

2021-05-26 Thread Britt Bolen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17352010#comment-17352010 ] Britt Bolen edited comment on KAFKA-9531 at 5/26/21, 6:28 PM: -

[GitHub] [kafka] tang7526 commented on a change in pull request #10534: KAFKA-806: Index may not always observe log.index.interval.bytes

2021-05-26 Thread GitBox
tang7526 commented on a change in pull request #10534: URL: https://github.com/apache/kafka/pull/10534#discussion_r640024597 ## File path: core/src/main/scala/kafka/log/LogSegment.scala ## @@ -162,15 +162,43 @@ class LogSegment private[log] (val log: FileRecords, // appe

[GitHub] [kafka] tang7526 commented on a change in pull request #10534: KAFKA-806: Index may not always observe log.index.interval.bytes

2021-05-26 Thread GitBox
tang7526 commented on a change in pull request #10534: URL: https://github.com/apache/kafka/pull/10534#discussion_r640027627 ## File path: core/src/main/scala/kafka/log/LogSegment.scala ## @@ -162,15 +162,43 @@ class LogSegment private[log] (val log: FileRecords, // appe

[GitHub] [kafka] tang7526 commented on a change in pull request #10534: KAFKA-806: Index may not always observe log.index.interval.bytes

2021-05-26 Thread GitBox
tang7526 commented on a change in pull request #10534: URL: https://github.com/apache/kafka/pull/10534#discussion_r640027627 ## File path: core/src/main/scala/kafka/log/LogSegment.scala ## @@ -162,15 +162,43 @@ class LogSegment private[log] (val log: FileRecords, // appe

[GitHub] [kafka] mumrah commented on a change in pull request #10752: KAFKA-12620 Allocate Producer IDs in KRaft controller

2021-05-26 Thread GitBox
mumrah commented on a change in pull request #10752: URL: https://github.com/apache/kafka/pull/10752#discussion_r640070688 ## File path: metadata/src/main/java/org/apache/kafka/controller/QuorumController.java ## @@ -1199,6 +1213,22 @@ public void processBatchEndOffset(long of

[GitHub] [kafka] kowshik commented on pull request #10684: MINOR: Improve Log layer segment iteration logic and few other areas

2021-05-26 Thread GitBox
kowshik commented on pull request #10684: URL: https://github.com/apache/kafka/pull/10684#issuecomment-849086875 Thanks for the review @junrao! I have addressed your comments in 4b836034415c3d5f6b84384ef9be1e75b66edc4b. -- This is an automated message from the Apache Git Service. To resp

[GitHub] [kafka] junrao merged pull request #10756: MINOR: Log constructor: Flip logical NOT for readability

2021-05-26 Thread GitBox
junrao merged pull request #10756: URL: https://github.com/apache/kafka/pull/10756 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[jira] [Created] (KAFKA-12852) Log.splitOverflowedSegment() doesn't generate producer snapshot for new segment

2021-05-26 Thread Jun Rao (Jira)
Jun Rao created KAFKA-12852: --- Summary: Log.splitOverflowedSegment() doesn't generate producer snapshot for new segment Key: KAFKA-12852 URL: https://issues.apache.org/jira/browse/KAFKA-12852 Project: Kafka

[GitHub] [kafka] mjsax commented on a change in pull request #10668: MINOR: Apply try-with-resource to KafkaStreamsTest

2021-05-26 Thread GitBox
mjsax commented on a change in pull request #10668: URL: https://github.com/apache/kafka/pull/10668#discussion_r640126531 ## File path: streams/src/test/java/org/apache/kafka/streams/KafkaStreamsTest.java ## @@ -491,25 +493,23 @@ public void testStateThreadClose() throws Except

[GitHub] [kafka] mjsax commented on a change in pull request #10668: MINOR: Apply try-with-resource to KafkaStreamsTest

2021-05-26 Thread GitBox
mjsax commented on a change in pull request #10668: URL: https://github.com/apache/kafka/pull/10668#discussion_r640127195 ## File path: streams/src/test/java/org/apache/kafka/streams/KafkaStreamsTest.java ## @@ -525,14 +525,13 @@ public void testStateGlobalThreadClose() throws

[jira] [Created] (KAFKA-12853) Implement broker-side KRaft snapshots

2021-05-26 Thread Colin McCabe (Jira)
Colin McCabe created KAFKA-12853: Summary: Implement broker-side KRaft snapshots Key: KAFKA-12853 URL: https://issues.apache.org/jira/browse/KAFKA-12853 Project: Kafka Issue Type: Improvement

[jira] [Created] (KAFKA-12854) Add a config to allow skipping metadata cache update when topic partition is unassigned

2021-05-26 Thread Lincong Li (Jira)
Lincong Li created KAFKA-12854: -- Summary: Add a config to allow skipping metadata cache update when topic partition is unassigned Key: KAFKA-12854 URL: https://issues.apache.org/jira/browse/KAFKA-12854 P

[jira] [Assigned] (KAFKA-12550) Introduce RESTORING state to the KafkaStreams FSM

2021-05-26 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman reassigned KAFKA-12550: -- Assignee: (was: A. Sophie Blee-Goldman) > Introduce RESTORING sta

[jira] [Updated] (KAFKA-12550) Introduce RESTORING state to the KafkaStreams FSM

2021-05-26 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-12550: --- Priority: Major (was: Blocker) > Introduce RESTORING state to the KafkaStre

[jira] [Updated] (KAFKA-12550) Introduce RESTORING state to the KafkaStreams FSM

2021-05-26 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-12550: --- Fix Version/s: (was: 3.0.0) 4.0.0 > Introduce RESTORI

[GitHub] [kafka] lbradstreet commented on pull request #10704: KAFKA-12791: ConcurrentModificationException in AbstractConfig use by KafkaProducer

2021-05-26 Thread GitBox
lbradstreet commented on pull request #10704: URL: https://github.com/apache/kafka/pull/10704#issuecomment-849144204 @ijuma I figured out the cause with some state change checks. The problem is that we're passing a recording map through to the channel/principal builders, and the recording

[GitHub] [kafka] ableegoldman commented on pull request #10657: KAFKA-5876: Apply InvalidStateStorePartitionException for Interactive Queries

2021-05-26 Thread GitBox
ableegoldman commented on pull request #10657: URL: https://github.com/apache/kafka/pull/10657#issuecomment-849145231 Hey @vitojeng , was this the final PR for KIP-216? If not is the next one available yet? No rush, just want to make sure you haven't been waiting on reviews this whole time

[GitHub] [kafka] lbradstreet edited a comment on pull request #10704: KAFKA-12791: ConcurrentModificationException in AbstractConfig use by KafkaProducer

2021-05-26 Thread GitBox
lbradstreet edited a comment on pull request #10704: URL: https://github.com/apache/kafka/pull/10704#issuecomment-849144204 @ijuma I figured out the cause with some state change checks. The problem is that we're passing a recording map through to the channel/principal builders, and the rec

[jira] [Updated] (KAFKA-5876) IQ should throw different exceptions for different errors

2021-05-26 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-5876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-5876: -- Description: Currently, IQ does only throws {{InvalidStateStoreException}} for

[GitHub] [kafka] ableegoldman edited a comment on pull request #10657: KAFKA-5876: Apply InvalidStateStorePartitionException for Interactive Queries

2021-05-26 Thread GitBox
ableegoldman edited a comment on pull request #10657: URL: https://github.com/apache/kafka/pull/10657#issuecomment-849145231 Hey @vitojeng , was this the final PR for KIP-216? If not is the next one available yet? No rush, just want to make sure you haven't been waiting on reviews this who

[jira] [Commented] (KAFKA-12845) Rollback change which requires join key to be non null on KStream->GlobalKTable

2021-05-26 Thread Pedro Gontijo (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17352111#comment-17352111 ] Pedro Gontijo commented on KAFKA-12845: --- Thanks for the reply [~mjsax] I see what

[jira] [Comment Edited] (KAFKA-12845) Rollback change which requires join key to be non null on KStream->GlobalKTable

2021-05-26 Thread Pedro Gontijo (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17352111#comment-17352111 ] Pedro Gontijo edited comment on KAFKA-12845 at 5/26/21, 10:43 PM:

[GitHub] [kafka] prince-mahajan opened a new pull request #10771: Update implementation.html

2021-05-26 Thread GitBox
prince-mahajan opened a new pull request #10771: URL: https://github.com/apache/kafka/pull/10771 Fixing the link to a cited blog. The existing link now points to a steroid website so need to pull the blog from internet archives. *More detailed description of your change, if necess

[GitHub] [kafka] vitojeng commented on pull request #10657: KAFKA-5876: Apply InvalidStateStorePartitionException for Interactive Queries

2021-05-26 Thread GitBox
vitojeng commented on pull request #10657: URL: https://github.com/apache/kafka/pull/10657#issuecomment-849170302 @ableegoldman Thanks for your concern, KIP-216 still in progress. 🙂 It's really busy in the last two weeks, some bad things continue to happen in Taiwan. I will stick to

[GitHub] [kafka] ijuma commented on a change in pull request #10704: KAFKA-12791: ConcurrentModificationException in AbstractConfig use by KafkaProducer

2021-05-26 Thread GitBox
ijuma commented on a change in pull request #10704: URL: https://github.com/apache/kafka/pull/10704#discussion_r640186978 ## File path: clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java ## @@ -106,7 +107,7 @@ public AbstractConfig(ConfigDef definition, M

  1   2   >