[GitHub] [kafka] ijuma commented on a change in pull request #10704: KAFKA-12791: ConcurrentModificationException in AbstractConfig use by KafkaProducer

[GitBox]

ijuma commented on a change in pull request #10704:
URL: https://github.com/apache/kafka/pull/10704#discussion_r640186978



##########
File path: 
clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java
##########
@@ -106,7 +107,7 @@ public AbstractConfig(ConfigDef definition, Map<?, ?> 
originals,  Map<String, ?>
 
         this.originals = resolveConfigVariables(configProviderProps, 
(Map<String, Object>) originals);
         this.values = definition.parse(this.originals);
-        this.used = Collections.synchronizedSet(new HashSet<>());
+        this.used = ConcurrentHashMap.newKeySet();

Review comment:
       Can we initialize this where the field is defined and add a comment on 
why it has to be concurrent?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org