[jira] [Commented] (KAFKA-12801) High CPU load after restarting brokers subsequent to quorum loss

2021-05-22 Thread loboxu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17349631#comment-17349631 ] loboxu commented on KAFKA-12801: Let me try to repeat the error > High CPU load after r

[GitHub] [kafka] soarez commented on pull request #10650: KAFKA-12763 NoSuchElementException during checkpointLogStartOffsets

2021-05-22 Thread GitBox
soarez commented on pull request #10650: URL: https://github.com/apache/kafka/pull/10650#issuecomment-846401654 @kowshik I see, that makes sense. My theory about how this happens does not hold. The race must happen after the constructor exits. I'm going to patch our brokers to log ex

[GitHub] [kafka] dejan2609 commented on pull request #10698: KAFKA-12770: introduce `checkstyleVersion` build option (for overriding CheckStyle project-defined dependency version)

2021-05-22 Thread GitBox
dejan2609 commented on pull request #10698: URL: https://github.com/apache/kafka/pull/10698#issuecomment-846435855 Makes sense @showuon ! I totally understand your point: writing concise comments is a vital thing. I made some changes according to your suggestion, feel free to check

[jira] [Commented] (KAFKA-12773) Use UncheckedIOException when wrapping IOException

2021-05-22 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17349823#comment-17349823 ] Jose Armando Garcia Sancio commented on KAFKA-12773: The {{raft}} mo

[jira] [Updated] (KAFKA-12773) Use UncheckedIOException when wrapping IOException

2021-05-22 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio updated KAFKA-12773: --- Description: The {{raft}} module may not be fully consistent on this

[jira] [Comment Edited] (KAFKA-12773) Use UncheckedIOException when wrapping IOException

2021-05-22 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17349823#comment-17349823 ] Jose Armando Garcia Sancio edited comment on KAFKA-12773 at 5/22/21, 7:49 PM:

[jira] [Commented] (KAFKA-12834) Remove Deprecated method MockProcessorContext#setTimestamp

2021-05-22 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17349834#comment-17349834 ] Matthias J. Sax commented on KAFKA-12834: - KIP-622 was only merged in 3.0.0, so

[jira] [Commented] (KAFKA-12833) Remove Deprecated methods under TopologyTestDriver

2021-05-22 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17349835#comment-17349835 ] Matthias J. Sax commented on KAFKA-12833: - KIP-622 was only merged in 2.8 so I t

[jira] [Commented] (KAFKA-12832) Remove Deprecated methods under RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapter

2021-05-22 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17349837#comment-17349837 ] Matthias J. Sax commented on KAFKA-12832: - KIP-471 was only merged in 3.0.0, so

[jira] [Comment Edited] (KAFKA-12833) Remove Deprecated methods under TopologyTestDriver

2021-05-22 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17349835#comment-17349835 ] Matthias J. Sax edited comment on KAFKA-12833 at 5/22/21, 8:24 PM: ---

[jira] [Commented] (KAFKA-12830) Remove Deprecated constructor in TimeWindowedDeserializer and TimeWindowedSerde

2021-05-22 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17349838#comment-17349838 ] Matthias J. Sax commented on KAFKA-12830: - KIP-659 was only merged in 2.8 so I t

[jira] [Commented] (KAFKA-12827) Remove Deprecated method KafkaStreams#setUncaughtExceptionHandler

2021-05-22 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17349839#comment-17349839 ] Matthias J. Sax commented on KAFKA-12827: - KIP-663 was only merged in 2.8, so I

[jira] [Commented] (KAFKA-12824) Remove Deprecated method KStream#branch

2021-05-22 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17349840#comment-17349840 ] Matthias J. Sax commented on KAFKA-12824: - KIP-418 was only merged in 2.8 so I t

[jira] [Commented] (KAFKA-5676) MockStreamsMetrics should be in o.a.k.test

2021-05-22 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-5676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17349843#comment-17349843 ] Matthias J. Sax commented on KAFKA-5676: Sure, feel free to pick it up. I never l

[GitHub] [kafka] mjsax commented on pull request #10690: MINOR: clarify message ordering with max in-flight requests and idempotent producer

2021-05-22 Thread GitBox
mjsax commented on pull request #10690: URL: https://github.com/apache/kafka/pull/10690#issuecomment-846464379 From my side: ship it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] mjsax commented on a change in pull request #10722: MINOR: update java doc for deprecated methods

2021-05-22 Thread GitBox
mjsax commented on a change in pull request #10722: URL: https://github.com/apache/kafka/pull/10722#discussion_r637451696 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/Produced.java ## @@ -26,7 +26,11 @@ /** * This class is used to provide the option

[GitHub] [kafka] mjsax merged pull request #10703: MINOR: Fix deprecation warnings in SlidingWindowedCogroupedKStreamImplTest

2021-05-22 Thread GitBox
mjsax merged pull request #10703: URL: https://github.com/apache/kafka/pull/10703 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please c

[jira] [Created] (KAFKA-12839) SlidingWindow with size 0 fails

2021-05-22 Thread Matthias J. Sax (Jira)
Matthias J. Sax created KAFKA-12839: --- Summary: SlidingWindow with size 0 fails Key: KAFKA-12839 URL: https://issues.apache.org/jira/browse/KAFKA-12839 Project: Kafka Issue Type: Bug

[GitHub] [kafka] mjsax opened a new pull request #10745: MINOR: add window verification to sliding-window co-group test

2021-05-22 Thread GitBox
mjsax opened a new pull request #10745: URL: https://github.com/apache/kafka/pull/10745 Follow up to #10703 \cc @ijuma -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [kafka] mjsax commented on pull request #10703: MINOR: Fix deprecation warnings in SlidingWindowedCogroupedKStreamImplTest

2021-05-22 Thread GitBox
mjsax commented on pull request #10703: URL: https://github.com/apache/kafka/pull/10703#issuecomment-846473111 Thanks. Did a follow up PR: https://github.com/apache/kafka/pull/10745 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [kafka] mjsax commented on a change in pull request #10745: MINOR: add window verification to sliding-window co-group test

2021-05-22 Thread GitBox
mjsax commented on a change in pull request #10745: URL: https://github.com/apache/kafka/pull/10745#discussion_r637459718 ## File path: streams/src/test/java/org/apache/kafka/streams/kstream/internals/SlidingWindowedCogroupedKStreamImplTest.java ## @@ -169,34 +167,37 @@ public

[GitHub] [kafka] showuon commented on pull request #10722: MINOR: update java doc for deprecated methods

2021-05-22 Thread GitBox
showuon commented on pull request #10722: URL: https://github.com/apache/kafka/pull/10722#issuecomment-846490355 @mjsax , thanks for the comment. I've updated, please take a look again. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [kafka] showuon commented on a change in pull request #10722: MINOR: update java doc for deprecated methods

2021-05-22 Thread GitBox
showuon commented on a change in pull request #10722: URL: https://github.com/apache/kafka/pull/10722#discussion_r637474843 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/Produced.java ## @@ -26,7 +26,11 @@ /** * This class is used to provide the opti

[jira] [Assigned] (KAFKA-12839) SlidingWindow with size 0 fails

2021-05-22 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen reassigned KAFKA-12839: - Assignee: Luke Chen > SlidingWindow with size 0 fails > --- > >

[jira] [Commented] (KAFKA-12773) Use UncheckedIOException when wrapping IOException

2021-05-22 Thread loboxu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17349920#comment-17349920 ] loboxu commented on KAFKA-12773: All right, I'll take it > Use UncheckedIOException whe

[GitHub] [kafka] jsancio commented on a change in pull request #10593: KAFKA-10800 Validate the snapshot id when the state machine creates a snapshot

2021-05-22 Thread GitBox
jsancio commented on a change in pull request #10593: URL: https://github.com/apache/kafka/pull/10593#discussion_r637470950 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -2268,6 +2269,25 @@ private Long append(int epoch, List records, boolean

[jira] [Comment Edited] (KAFKA-12773) Use UncheckedIOException when wrapping IOException

2021-05-22 Thread loboxu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17349920#comment-17349920 ] loboxu edited comment on KAFKA-12773 at 5/23/21, 5:38 AM: -- Ther