[
https://issues.apache.org/jira/browse/KAFKA-12773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17349920#comment-17349920
]
loboxu edited comment on KAFKA-12773 at 5/23/21, 5:38 AM:
----------------------------------------------------------
There are currently three ways to handle IOExceptions in Raft Module:
* Wrap it with RuntimeException and add the prompt message as follows:
* Throw an IOException to the upper layer without wrapping it
* Wrack it as UnCheckeDioException and add the prompt message as follows:
I need to ask for your opinion on two issues:
# Does this KIP only need to deal with the case of 2 above? That is, where
there may be IOExceptions, package and handle them
# When wrapping an exception, ask whether the community wants RuntimeException
or UncheckedioException to handle it.
was (Author: loboxu):
All right, I'll take it
> Use UncheckedIOException when wrapping IOException
> --------------------------------------------------
>
> Key: KAFKA-12773
> URL: https://issues.apache.org/jira/browse/KAFKA-12773
> Project: Kafka
> Issue Type: Sub-task
> Reporter: Jose Armando Garcia Sancio
> Assignee: loboxu
> Priority: Major
> Labels: kip-500, newbie
>
> The {{raft}} module may not be fully consistent on this but in general in
> that module we have decided to not throw the checked {{IOException}}. We have
> been avoiding checked {{IOException}} exceptions by wrapping them in
> {{RuntimeException}}. The {{raft}} module should instead wrap {{IOException}}
> in {{UncheckedIOException}}. This change should be limited to the {{raft}}
> module.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
