[GitHub] [kafka] dajac commented on a change in pull request #10599: KAFKA-12716; Add `Admin` API to abort transactions

dajac commented on a change in pull request #10599: URL: https://github.com/apache/kafka/pull/10599#discussion_r621881429 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/AbortTransactionResult.java ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] dajac commented on a change in pull request #10599: KAFKA-12716; Add `Admin` API to abort transactions

dajac commented on a change in pull request #10599: URL: https://github.com/apache/kafka/pull/10599#discussion_r621882118 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/AbortTransactionSpec.java ## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] [kafka] vitojeng commented on a change in pull request #10597: KAFKA-5876: Apply StreamsNotStartedException for Interactive Queries

vitojeng commented on a change in pull request #10597: URL: https://github.com/apache/kafka/pull/10597#discussion_r621901521 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -344,7 +345,7 @@ private boolean isRunningOrRebalancing() { p

[GitHub] [kafka] showuon commented on a change in pull request #10509: KAFKA-12464: enhance constrained sticky Assign algorithm

showuon commented on a change in pull request #10509: URL: https://github.com/apache/kafka/pull/10509#discussion_r621951920 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -108,6 +107,8 @@ private boolean allSub

[GitHub] [kafka] kowshik commented on a change in pull request #10271: KAFKA-12429: Added serdes for the default implementation of RLMM based on an internal topic as storage.

kowshik commented on a change in pull request #10271: URL: https://github.com/apache/kafka/pull/10271#discussion_r621909685 ## File path: raft/src/main/java/org/apache/kafka/raft/metadata/AbstractApiMessageSerde.java ## @@ -0,0 +1,93 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] kowshik commented on a change in pull request #10271: KAFKA-12429: Added serdes for the default implementation of RLMM based on an internal topic as storage.

kowshik commented on a change in pull request #10271: URL: https://github.com/apache/kafka/pull/10271#discussion_r621925315 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/serialization/RemoteLogMetadataSerde.java ## @@ -0,0 +1,105 @@ +/

[GitHub] [kafka] highluck removed a comment on pull request #9786: MINOR: remove unnecessary code AND Type clarification

highluck removed a comment on pull request #9786: URL: https://github.com/apache/kafka/pull/9786#issuecomment-785059958 ping @chia7712 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [kafka] highluck commented on pull request #9786: MINOR: remove unnecessary code AND Type clarification

highluck commented on pull request #9786: URL: https://github.com/apache/kafka/pull/9786#issuecomment-828285957 ping @chia7712 thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [kafka] tombentley commented on pull request #9441: KAFKA-10614: Ensure group state (un)load is executed in the submitted order

tombentley commented on pull request #9441: URL: https://github.com/apache/kafka/pull/9441#issuecomment-828333212 @hachikuji Thanks, I was being slow on the uptake, but what you describe makes perfect sense. I've moved the logic to the GroupMetadataManager, am using the max observed epoch

[GitHub] [kafka] showuon commented on a change in pull request #10509: KAFKA-12464: enhance constrained sticky Assign algorithm

showuon commented on a change in pull request #10509: URL: https://github.com/apache/kafka/pull/10509#discussion_r622040343 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -263,16 +279,59 @@ private boolean allS

[GitHub] [kafka] showuon commented on a change in pull request #10509: KAFKA-12464: enhance constrained sticky Assign algorithm

showuon commented on a change in pull request #10509: URL: https://github.com/apache/kafka/pull/10509#discussion_r622040343 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -263,16 +279,59 @@ private boolean allS

[GitHub] [kafka] showuon commented on a change in pull request #10509: KAFKA-12464: enhance constrained sticky Assign algorithm

showuon commented on a change in pull request #10509: URL: https://github.com/apache/kafka/pull/10509#discussion_r622040343 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -263,16 +279,59 @@ private boolean allS

[jira] [Created] (KAFKA-12723) Potential NPE in SnapshottableHashTable.java

loyi created KAFKA-12723: Summary: Potential NPE in SnapshottableHashTable.java Key: KAFKA-12723 URL: https://issues.apache.org/jira/browse/KAFKA-12723 Project: Kafka Issue Type: Bug Affects Vers

[jira] [Updated] (KAFKA-12723) Potential NPE in SnapshottableHashTable.java

[ https://issues.apache.org/jira/browse/KAFKA-12723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] loyi updated KAFKA-12723: - Description: The method mergeFrom of {color:#de350b}HashTier{color} maybe has potential NPE ,  the attribute de

[jira] [Updated] (KAFKA-12723) Potential NPE in SnapshottableHashTable.java

[ https://issues.apache.org/jira/browse/KAFKA-12723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] loyi updated KAFKA-12723: - Description: The method mergeFrom of {color:#de350b}HashTier{color} maybe has potential NPE ,  the attribute de

[GitHub] [kafka] saddays opened a new pull request #10601: KAFKA-12723: Fix potential NPE in HashTier

saddays opened a new pull request #10601: URL: https://github.com/apache/kafka/pull/10601 Fix potential NPE , [kafka-12723](https://issues.apache.org/jira/browse/KAFKA-12723) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[jira] [Updated] (KAFKA-12723) Potential NPE in SnapshottableHashTable.java

[ https://issues.apache.org/jira/browse/KAFKA-12723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] loyi updated KAFKA-12723: - Description: The method mergeFrom of {color:#de350b}HashTier{color} maybe has potential NPE ,  the attribute de

[GitHub] [kafka] showuon commented on a change in pull request #10509: KAFKA-12464: enhance constrained sticky Assign algorithm

showuon commented on a change in pull request #10509: URL: https://github.com/apache/kafka/pull/10509#discussion_r622064430 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -263,16 +279,59 @@ private boolean allS

[GitHub] [kafka] showuon commented on a change in pull request #10509: KAFKA-12464: enhance constrained sticky Assign algorithm

showuon commented on a change in pull request #10509: URL: https://github.com/apache/kafka/pull/10509#discussion_r622064430 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -263,16 +279,59 @@ private boolean allS

[GitHub] [kafka] showuon commented on a change in pull request #10509: KAFKA-12464: enhance constrained sticky Assign algorithm

showuon commented on a change in pull request #10509: URL: https://github.com/apache/kafka/pull/10509#discussion_r622064430 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -263,16 +279,59 @@ private boolean allS

[GitHub] [kafka] showuon commented on a change in pull request #10509: KAFKA-12464: enhance constrained sticky Assign algorithm

showuon commented on a change in pull request #10509: URL: https://github.com/apache/kafka/pull/10509#discussion_r622064430 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -263,16 +279,59 @@ private boolean allS

[GitHub] [kafka] tombentley commented on pull request #10023: KAFKA-12263: Change MockClient.RequestMatcher to RequestAssertion

tombentley commented on pull request #10023: URL: https://github.com/apache/kafka/pull/10023#issuecomment-828376561 @hachikuji any chance you could review this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] showuon commented on a change in pull request #10509: KAFKA-12464: enhance constrained sticky Assign algorithm

showuon commented on a change in pull request #10509: URL: https://github.com/apache/kafka/pull/10509#discussion_r622040343 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -263,16 +279,59 @@ private boolean allS

[GitHub] [kafka] showuon commented on a change in pull request #10509: KAFKA-12464: enhance constrained sticky Assign algorithm

showuon commented on a change in pull request #10509: URL: https://github.com/apache/kafka/pull/10509#discussion_r622040343 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -263,16 +279,59 @@ private boolean allS

[GitHub] [kafka] showuon commented on a change in pull request #10509: KAFKA-12464: enhance constrained sticky Assign algorithm

showuon commented on a change in pull request #10509: URL: https://github.com/apache/kafka/pull/10509#discussion_r622064430 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -263,16 +279,59 @@ private boolean allS

[GitHub] [kafka] showuon commented on a change in pull request #10509: KAFKA-12464: enhance constrained sticky Assign algorithm

showuon commented on a change in pull request #10509: URL: https://github.com/apache/kafka/pull/10509#discussion_r622064430 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -263,16 +279,59 @@ private boolean allS

[GitHub] [kafka] showuon commented on a change in pull request #10509: KAFKA-12464: enhance constrained sticky Assign algorithm

showuon commented on a change in pull request #10509: URL: https://github.com/apache/kafka/pull/10509#discussion_r622064430 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -263,16 +279,59 @@ private boolean allS

[GitHub] [kafka] showuon commented on a change in pull request #10509: KAFKA-12464: enhance constrained sticky Assign algorithm

showuon commented on a change in pull request #10509: URL: https://github.com/apache/kafka/pull/10509#discussion_r622064430 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -263,16 +279,59 @@ private boolean allS

[GitHub] [kafka] showuon commented on pull request #10509: KAFKA-12464: enhance constrained sticky Assign algorithm

showuon commented on pull request #10509: URL: https://github.com/apache/kafka/pull/10509#issuecomment-828440406 @ableegoldman , thanks for your great comments! If there's a best reviewer contest, I'd definitely vote for you! :) I've replied the `getUnassignedPartitions` comments. Please t

[GitHub] [kafka] showuon edited a comment on pull request #10509: KAFKA-12464: enhance constrained sticky Assign algorithm

showuon edited a comment on pull request #10509: URL: https://github.com/apache/kafka/pull/10509#issuecomment-828440406 @ableegoldman , thanks for your great comments! If there's a best reviewer contest, I'd definitely vote for you! :) I've replied your `getUnassignedPartitions` comments.

[jira] [Created] (KAFKA-12724) Add 2.8.0 to system tests and streams upgrade tests

Kamal Chandraprakash created KAFKA-12724: Summary: Add 2.8.0 to system tests and streams upgrade tests Key: KAFKA-12724 URL: https://issues.apache.org/jira/browse/KAFKA-12724 Project: Kafka

[jira] [Updated] (KAFKA-12724) Add 2.8.0 to system tests and streams upgrade tests

[ https://issues.apache.org/jira/browse/KAFKA-12724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamal Chandraprakash updated KAFKA-12724: - Description: Kafka v2.8.0 is released. We should add this version to the system

[GitHub] [kafka] kamalcph opened a new pull request #10602: KAFKA-12724: Add 2.8.0 to system tests and streams upgrade tests.

kamalcph opened a new pull request #10602: URL: https://github.com/apache/kafka/pull/10602 * Ran `./gradlew streams:testAll` to verify the streams upgrade test. * Ran individual system test in my local setup. ### Committer Checklist (excluded from commit message) - [ ] Verify de

[GitHub] [kafka] kamalcph commented on a change in pull request #10602: KAFKA-12724: Add 2.8.0 to system tests and streams upgrade tests.

kamalcph commented on a change in pull request #10602: URL: https://github.com/apache/kafka/pull/10602#discussion_r622198249 ## File path: streams/upgrade-system-tests-28/src/test/java/org/apache/kafka/streams/tests/SmokeTestClient.java ## @@ -0,0 +1,299 @@ +/* + * Licensed to

[GitHub] [kafka] kamalcph commented on pull request #10602: KAFKA-12724: Add 2.8.0 to system tests and streams upgrade tests.

kamalcph commented on pull request #10602: URL: https://github.com/apache/kafka/pull/10602#issuecomment-828471522 @chia7712 @mjsax @ijuma Ping for review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [kafka] showuon commented on a change in pull request #10509: KAFKA-12464: enhance constrained sticky Assign algorithm

showuon commented on a change in pull request #10509: URL: https://github.com/apache/kafka/pull/10509#discussion_r622210601 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -263,16 +279,59 @@ private boolean allS

[GitHub] [kafka] wcarlson5 opened a new pull request #10603: WIP: handle missing sink topics in a separate way

wcarlson5 opened a new pull request #10603: URL: https://github.com/apache/kafka/pull/10603 handle all missing sink topic separately ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status -

[GitHub] [kafka] rondagostino commented on a change in pull request #10604: MINOR: system test spelling/pydoc/dead code fixes

rondagostino commented on a change in pull request #10604: URL: https://github.com/apache/kafka/pull/10604#discussion_r622254888 ## File path: tests/kafkatest/services/kafka/kafka.py ## @@ -237,13 +237,14 @@ def __init__(self, context, num_nodes, zk, security_protocol=Security

[GitHub] [kafka] rondagostino opened a new pull request #10604: MINOR: system test spelling/pydoc/dead code fixes

rondagostino opened a new pull request #10604: URL: https://github.com/apache/kafka/pull/10604 Fixes some pydoc, corrects spelling, and removes dead code in system tests. Renames `server_prop_overides` to `server_prop_overrides` to correct spelling. *Summary of testing strateg

[GitHub] [kafka] wcarlson5 commented on pull request #10603: WIP: handle missing sink topics in a separate way

wcarlson5 commented on pull request #10603: URL: https://github.com/apache/kafka/pull/10603#issuecomment-828525217 @ableegoldman @rodesai @cadonna as a rough improvement what do you think? I don't think that we need to get this perfect right now but I think that any differentiation of sink

[GitHub] [kafka] hachikuji merged pull request #10599: KAFKA-12716; Add `Admin` API to abort transactions

hachikuji merged pull request #10599: URL: https://github.com/apache/kafka/pull/10599 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, plea

[jira] [Resolved] (KAFKA-12716) Admin API for aborting transactions

[ https://issues.apache.org/jira/browse/KAFKA-12716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-12716. - Resolution: Fixed > Admin API for aborting transactions > --

[GitHub] [kafka] jolshan commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

jolshan commented on a change in pull request #9590: URL: https://github.com/apache/kafka/pull/9590#discussion_r622292494 ## File path: core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala ## @@ -1267,6 +1266,64 @@ class PlaintextConsumerTest extends BaseConsum

[GitHub] [kafka] jolshan commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

jolshan commented on a change in pull request #9590: URL: https://github.com/apache/kafka/pull/9590#discussion_r622293267 ## File path: core/src/test/scala/unit/kafka/log/LogCleanerTest.scala ## @@ -984,19 +1003,26 @@ class LogCleanerTest { def distinctValuesBySegment =

[jira] [Created] (KAFKA-12725) Add transaction start offset to WriteTxnMarker API

Jason Gustafson created KAFKA-12725: --- Summary: Add transaction start offset to WriteTxnMarker API Key: KAFKA-12725 URL: https://issues.apache.org/jira/browse/KAFKA-12725 Project: Kafka Iss

[GitHub] [kafka] hachikuji commented on a change in pull request #10599: KAFKA-12716; Add `Admin` API to abort transactions

hachikuji commented on a change in pull request #10599: URL: https://github.com/apache/kafka/pull/10599#discussion_r622308954 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/AbortTransactionSpec.java ## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Softwar

[GitHub] [kafka] AndroideRob commented on a change in pull request #10591: Fix minor bugs in the existing documentation

AndroideRob commented on a change in pull request #10591: URL: https://github.com/apache/kafka/pull/10591#discussion_r622314052 ## File path: docs/ops.html ## @@ -78,7 +78,7 @@ auto.leader.rebalance.enable=true You can also set this to false, but you will then need

[GitHub] [kafka] AndroideRob commented on a change in pull request #10591: Fix minor bugs in the existing documentation

AndroideRob commented on a change in pull request #10591: URL: https://github.com/apache/kafka/pull/10591#discussion_r622314643 ## File path: docs/security.html ## @@ -319,7 +319,7 @@ SSL key and certificates in PEM format We need to configure the following propert

[GitHub] [kafka] AndroideRob commented on a change in pull request #10591: Fix minor bugs in the existing documentation

AndroideRob commented on a change in pull request #10591: URL: https://github.com/apache/kafka/pull/10591#discussion_r622319407 ## File path: docs/security.html ## @@ -319,7 +319,7 @@ SSL key and certificates in PEM format We need to configure the following propert

[GitHub] [kafka] chia7712 merged pull request #10547: KAFKA-12284: increase request timeout to make tests reliable

chia7712 merged pull request #10547: URL: https://github.com/apache/kafka/pull/10547 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pleas

[GitHub] [kafka] jolshan commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

jolshan commented on a change in pull request #9590: URL: https://github.com/apache/kafka/pull/9590#discussion_r622321621 ## File path: clients/src/main/java/org/apache/kafka/common/record/MemoryRecords.java ## @@ -386,6 +390,13 @@ public long maxOffset() { return

[GitHub] [kafka] jolshan commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

jolshan commented on a change in pull request #9590: URL: https://github.com/apache/kafka/pull/9590#discussion_r622321621 ## File path: clients/src/main/java/org/apache/kafka/common/record/MemoryRecords.java ## @@ -386,6 +390,13 @@ public long maxOffset() { return

[jira] [Created] (KAFKA-12726) misbehaving Task.stop() can prevent other Tasks from stopping

Ryanne Dolan created KAFKA-12726: Summary: misbehaving Task.stop() can prevent other Tasks from stopping Key: KAFKA-12726 URL: https://issues.apache.org/jira/browse/KAFKA-12726 Project: Kafka

[jira] [Assigned] (KAFKA-12726) misbehaving Task.stop() can prevent other Tasks from stopping

[ https://issues.apache.org/jira/browse/KAFKA-12726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryanne Dolan reassigned KAFKA-12726: Assignee: Ryanne Dolan > misbehaving Task.stop() can prevent other Tasks from stopping >

[GitHub] [kafka] chia7712 commented on pull request #10598: MINOR: rename wrong topic id variable name and description

chia7712 commented on pull request #10598: URL: https://github.com/apache/kafka/pull/10598#issuecomment-828584408 @showuon Could you share your email to me? GitHub profiler does not show your email. I can see an email from your public repo (https://github.com/showuon/js2ts/commit/d7711b632

[GitHub] [kafka] jolshan commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

jolshan commented on a change in pull request #9590: URL: https://github.com/apache/kafka/pull/9590#discussion_r622355520 ## File path: core/src/test/scala/unit/kafka/log/LogCleanerManagerTest.scala ## @@ -540,13 +540,34 @@ class LogCleanerManagerTest extends Logging { w

[GitHub] [kafka] jolshan commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

jolshan commented on a change in pull request #9590: URL: https://github.com/apache/kafka/pull/9590#discussion_r622360387 ## File path: core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala ## @@ -1267,6 +1266,64 @@ class PlaintextConsumerTest extends BaseConsum

[GitHub] [kafka] JoelWee commented on pull request #8923: KAFKA-6435: KIP-623 Add internal topics option to streamResetter

JoelWee commented on pull request #8923: URL: https://github.com/apache/kafka/pull/8923#issuecomment-828616051 Thanks @ableegoldman! :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [kafka] junrao commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

junrao commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r617932245 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -662,11 +662,21 @@ class KafkaApis(val requestChannel: RequestChannel, val versionI

[GitHub] [kafka] hachikuji commented on a change in pull request #10480: KAFKA-12265: Move the BatchAccumulator in KafkaRaftClient to LeaderState

hachikuji commented on a change in pull request #10480: URL: https://github.com/apache/kafka/pull/10480#discussion_r622378516 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -1859,15 +1819,14 @@ private void appendBatch( offset

[GitHub] [kafka] ryannedolan opened a new pull request #10605: KAFKA-12726 prevent a stuck Task.stop() from blocking subsequent Task.stops()s

ryannedolan opened a new pull request #10605: URL: https://github.com/apache/kafka/pull/10605 A misbehaving Task.stop() can prevent other Tasks from stopping, even when a graceful shutdown timeout is configured. We improve the situation as follows: - prior to task.shutdown.graceful.t

[GitHub] [kafka] jolshan commented on pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on pull request #9944: URL: https://github.com/apache/kafka/pull/9944#issuecomment-828663698 Thanks @junrao for taking another look > A lot of the complexity is the additional logic for propagating unresolved partitions from FetchRequest to FetchSession and the mainte

[GitHub] [kafka] jsancio commented on a change in pull request #10593: KAFKA-10800 Validate the snapshot id when the state machine creates a snapshot

jsancio commented on a change in pull request #10593: URL: https://github.com/apache/kafka/pull/10593#discussion_r620232416 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -2268,6 +2269,20 @@ private Long append(int epoch, List records, boolean

[GitHub] [kafka] ijuma commented on pull request #10466: KAFKA-12417 "streams" module: switch deprecated Gradle configuration `testRuntime`

ijuma commented on pull request #10466: URL: https://github.com/apache/kafka/pull/10466#issuecomment-828682155 Unrelated failures, merging to trunk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] ijuma merged pull request #10466: KAFKA-12417: streams `copyDependentLibs` should not copy testRuntime configuration jars

ijuma merged pull request #10466: URL: https://github.com/apache/kafka/pull/10466 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please c

[GitHub] [kafka] jsancio commented on a change in pull request #10593: KAFKA-10800 Validate the snapshot id when the state machine creates a snapshot

jsancio commented on a change in pull request #10593: URL: https://github.com/apache/kafka/pull/10593#discussion_r622425656 ## File path: raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientSnapshotTest.java ## @@ -1335,6 +1313,57 @@ public void testFetchSnapshotRequestCl

[GitHub] [kafka] dielhennr closed pull request #10480: KAFKA-12265: Move the BatchAccumulator in KafkaRaftClient to LeaderState

dielhennr closed pull request #10480: URL: https://github.com/apache/kafka/pull/10480 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, plea

[jira] [Resolved] (KAFKA-12417) streams module should use `testRuntimeClasspath` instead of `testRuntime` configuration

[ https://issues.apache.org/jira/browse/KAFKA-12417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dejan Stojadinović resolved KAFKA-12417. Resolution: Done Resolving as done (commit is merged into trunk). > streams modul

[jira] [Created] (KAFKA-12727) Flaky test ListConsumerGroupTest.testListConsumerGroupsWithStates

A. Sophie Blee-Goldman created KAFKA-12727: -- Summary: Flaky test ListConsumerGroupTest.testListConsumerGroupsWithStates Key: KAFKA-12727 URL: https://issues.apache.org/jira/browse/KAFKA-12727

[jira] [Reopened] (KAFKA-9295) KTableKTableForeignKeyInnerJoinMultiIntegrationTest#shouldInnerJoinMultiPartitionQueryable

[ https://issues.apache.org/jira/browse/KAFKA-9295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman reopened KAFKA-9295: --- Still failing, saw this on both the Java 8 and Java 11 build of a PR: Stacktrace

[GitHub] [kafka] hachikuji commented on pull request #9441: KAFKA-10614: Ensure group state (un)load is executed in the submitted order

hachikuji commented on pull request #9441: URL: https://github.com/apache/kafka/pull/9441#issuecomment-828703078 @tombentley Thanks for the updates. I made a few small changes in this patch: https://github.com/hachikuji/kafka/commit/27ba937cc7b7da230ccc4f0c8220f680c4a542fe. The main thing

[GitHub] [kafka] jolshan commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

jolshan commented on a change in pull request #9590: URL: https://github.com/apache/kafka/pull/9590#discussion_r622456807 ## File path: core/src/test/scala/unit/kafka/log/LogCleanerTest.scala ## @@ -984,19 +1003,26 @@ class LogCleanerTest { def distinctValuesBySegment =

[GitHub] [kafka] jolshan commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

jolshan commented on a change in pull request #9590: URL: https://github.com/apache/kafka/pull/9590#discussion_r622456807 ## File path: core/src/test/scala/unit/kafka/log/LogCleanerTest.scala ## @@ -984,19 +1003,26 @@ class LogCleanerTest { def distinctValuesBySegment =

[jira] [Created] (KAFKA-12728) Update Gradle version: 6.8 -->> 7.0

Dejan Stojadinović created KAFKA-12728: -- Summary: Update Gradle version: 6.8 -->> 7.0 Key: KAFKA-12728 URL: https://issues.apache.org/jira/browse/KAFKA-12728 Project: Kafka Issue Type: I

[GitHub] [kafka] jsancio commented on a change in pull request #10480: KAFKA-12265: Move the BatchAccumulator in KafkaRaftClient to LeaderState

jsancio commented on a change in pull request #10480: URL: https://github.com/apache/kafka/pull/10480#discussion_r622455380 ## File path: raft/src/main/java/org/apache/kafka/raft/LeaderState.java ## @@ -67,6 +74,30 @@ protected LeaderState( } this.grantingVote

[jira] [Commented] (KAFKA-9295) KTableKTableForeignKeyInnerJoinMultiIntegrationTest#shouldInnerJoinMultiPartitionQueryable

[ https://issues.apache.org/jira/browse/KAFKA-9295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17334937#comment-17334937 ] A. Sophie Blee-Goldman commented on KAFKA-9295: --- It's failing on {noformat

[GitHub] [kafka] ableegoldman commented on a change in pull request #10597: KAFKA-5876: Apply StreamsNotStartedException for Interactive Queries

ableegoldman commented on a change in pull request #10597: URL: https://github.com/apache/kafka/pull/10597#discussion_r622464617 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -344,7 +345,7 @@ private boolean isRunningOrRebalancing() {

[GitHub] [kafka] dejan2609 opened a new pull request #10606: KAFKA-12728: [Work In Progress] gradle version upgrade: 6.8 -->> 7.0

dejan2609 opened a new pull request #10606: URL: https://github.com/apache/kafka/pull/10606 **_JIRA ticket:_** https://issues.apache.org/jira/browse/KAFKA-12728 **_Related pull requests:_** - #10203 - #10466 Note: we will wait for a Gradle 7.0.1 patch ◀️ -- This is

[GitHub] [kafka] hachikuji commented on a change in pull request #10480: KAFKA-12265: Move the BatchAccumulator in KafkaRaftClient to LeaderState

hachikuji commented on a change in pull request #10480: URL: https://github.com/apache/kafka/pull/10480#discussion_r622470077 ## File path: raft/src/main/java/org/apache/kafka/raft/LeaderState.java ## @@ -67,6 +74,30 @@ protected LeaderState( } this.grantingVo

[GitHub] [kafka] ableegoldman commented on a change in pull request #10509: KAFKA-12464: enhance constrained sticky Assign algorithm

ableegoldman commented on a change in pull request #10509: URL: https://github.com/apache/kafka/pull/10509#discussion_r622472215 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -263,16 +279,59 @@ private boolean

[GitHub] [kafka] hachikuji commented on a change in pull request #10480: KAFKA-12265: Move the BatchAccumulator in KafkaRaftClient to LeaderState

hachikuji commented on a change in pull request #10480: URL: https://github.com/apache/kafka/pull/10480#discussion_r622470077 ## File path: raft/src/main/java/org/apache/kafka/raft/LeaderState.java ## @@ -67,6 +74,30 @@ protected LeaderState( } this.grantingVo

[GitHub] [kafka] hachikuji commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

hachikuji commented on a change in pull request #9590: URL: https://github.com/apache/kafka/pull/9590#discussion_r622473204 ## File path: core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala ## @@ -1267,6 +1266,64 @@ class PlaintextConsumerTest extends BaseCons

[GitHub] [kafka] ableegoldman commented on a change in pull request #10509: KAFKA-12464: enhance constrained sticky Assign algorithm

ableegoldman commented on a change in pull request #10509: URL: https://github.com/apache/kafka/pull/10509#discussion_r622474244 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -263,16 +279,59 @@ private boolean

[GitHub] [kafka] jsancio commented on pull request #10278: KAFKA-10526: leader fsync deferral on write

jsancio commented on pull request #10278: URL: https://github.com/apache/kafka/pull/10278#issuecomment-828720442 @vamossagar12 Can you add a description to the PR? It is helpful when reviewing this PR to know what strategy you are using to manage the flush offset and log flush. -- This

[jira] [Commented] (KAFKA-12718) SessionWindows are closed too early

[ https://issues.apache.org/jira/browse/KAFKA-12718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17334964#comment-17334964 ] Matthias J. Sax commented on KAFKA-12718: - I was just looking into `suppress()`

[GitHub] [kafka] jsancio commented on a change in pull request #10480: KAFKA-12265: Move the BatchAccumulator in KafkaRaftClient to LeaderState

jsancio commented on a change in pull request #10480: URL: https://github.com/apache/kafka/pull/10480#discussion_r622489394 ## File path: raft/src/main/java/org/apache/kafka/raft/LeaderState.java ## @@ -67,6 +74,30 @@ protected LeaderState( } this.grantingVote

[jira] [Updated] (KAFKA-12724) Add 2.8.0 to system tests and streams upgrade tests

[ https://issues.apache.org/jira/browse/KAFKA-12724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-12724: Component/s: system tests streams > Add 2.8.0 to system tests and streams

[GitHub] [kafka] mjsax commented on a change in pull request #10602: KAFKA-12724: Add 2.8.0 to system tests and streams upgrade tests.

mjsax commented on a change in pull request #10602: URL: https://github.com/apache/kafka/pull/10602#discussion_r622492083 ## File path: streams/upgrade-system-tests-28/src/test/java/org/apache/kafka/streams/tests/StreamsUpgradeTest.java ## @@ -0,0 +1,86 @@ +/* + * Licensed to

[GitHub] [kafka] mjsax commented on a change in pull request #10602: KAFKA-12724: Add 2.8.0 to system tests and streams upgrade tests.

mjsax commented on a change in pull request #10602: URL: https://github.com/apache/kafka/pull/10602#discussion_r622492627 ## File path: streams/upgrade-system-tests-28/src/test/java/org/apache/kafka/streams/tests/StreamsUpgradeTest.java ## @@ -0,0 +1,86 @@ +/* + * Licensed to

[GitHub] [kafka] mjsax commented on pull request #10602: KAFKA-12724: Add 2.8.0 to system tests and streams upgrade tests.

mjsax commented on pull request #10602: URL: https://github.com/apache/kafka/pull/10602#issuecomment-828736200 \cc @vvcephei who was RM for 2.8 for tracking. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [kafka] jolshan commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

jolshan commented on a change in pull request #9590: URL: https://github.com/apache/kafka/pull/9590#discussion_r622505823 ## File path: core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala ## @@ -1267,6 +1266,64 @@ class PlaintextConsumerTest extends BaseConsum

[jira] [Commented] (KAFKA-8613) Set default grace period to 0

[ https://issues.apache.org/jira/browse/KAFKA-8613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17334984#comment-17334984 ] Israel Ekpo commented on KAFKA-8613: I noticed that the method signature in the KIP h

[GitHub] [kafka] ableegoldman commented on pull request #10573: KAFKA-12574: KIP-732, Deprecate eos-alpha and replace eos-beta with eos-v2

ableegoldman commented on pull request #10573: URL: https://github.com/apache/kafka/pull/10573#issuecomment-828751235 Tons of flaky test failures, all unrelated. Mostly Connect and Raft, a few Streams tests that are known to be flaky which I left some thoughts on the ticket for. Going to m

[GitHub] [kafka] ableegoldman merged pull request #10573: KAFKA-12574: KIP-732, Deprecate eos-alpha and replace eos-beta with eos-v2

ableegoldman merged pull request #10573: URL: https://github.com/apache/kafka/pull/10573 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, p

[GitHub] [kafka] ableegoldman commented on pull request #10573: KAFKA-12574: KIP-732, Deprecate eos-alpha and replace eos-beta with eos-v2

ableegoldman commented on pull request #10573: URL: https://github.com/apache/kafka/pull/10573#issuecomment-828752351 Merged to trunk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Updated] (KAFKA-10800) Validate the snapshot id when the state machine creates a snapshot

[ https://issues.apache.org/jira/browse/KAFKA-10800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio updated KAFKA-10800: --- Description: When the state machine attempts to create a snapshot wr

[GitHub] [kafka] wcarlson5 commented on pull request #10603: WIP: handle missing sink topics in a separate way

wcarlson5 commented on pull request #10603: URL: https://github.com/apache/kafka/pull/10603#issuecomment-828769426 This will not work without significant other changes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [kafka] wcarlson5 closed pull request #10603: WIP: handle missing sink topics in a separate way

wcarlson5 closed pull request #10603: URL: https://github.com/apache/kafka/pull/10603 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, plea

[GitHub] [kafka] wcarlson5 removed a comment on pull request #10603: WIP: handle missing sink topics in a separate way

wcarlson5 removed a comment on pull request #10603: URL: https://github.com/apache/kafka/pull/10603#issuecomment-828525217 @ableegoldman @rodesai @cadonna as a rough improvement what do you think? I don't think that we need to get this perfect right now but I think that any differentiation

[jira] [Commented] (KAFKA-8613) Set default grace period to 0

[ https://issues.apache.org/jira/browse/KAFKA-8613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17335015#comment-17335015 ] Israel Ekpo commented on KAFKA-8613: I have the initial changes (without the Unit tes

  1   2   >