wenbingshen commented on pull request #10558:
URL: https://github.com/apache/kafka/pull/10558#issuecomment-822238285
> @wenbingshen Thanks for the patch. Should we add a unit test to verify
this or perhaps extend an existing one?
@dajac Thank you for your comment. Later today I will
[
https://issues.apache.org/jira/browse/KAFKA-7888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17324796#comment-17324796
]
Shuchita commented on KAFKA-7888:
-
Hi [~junrao], team,
Is there a fix/workaround availa
showuon commented on pull request #10552:
URL: https://github.com/apache/kafka/pull/10552#issuecomment-822292217
Failed tests are unrelated. Thanks.
```
Build / JDK 8 and Scala 2.12 /
org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationSSLTest.testReplication()
dengziming opened a new pull request #10560:
URL: https://github.com/apache/kafka/pull/10560
*More detailed description of your change*
1. Do not update the commit-sensor if the commit failed and add test logic.
2. Also add 2 unit tests, the first for `OFFSET_METADATA_TOO_LARGE` error,
dengziming commented on pull request #10535:
URL: https://github.com/apache/kafka/pull/10535#issuecomment-822307180
@chia7712 , PTAL at `RequestConvertToJsonTest` since it's the same with your
refactor in #9964;
@abbccdda , I remove `RequestTestUtils.serializeResponseWithHeader` since
i
dengziming commented on pull request #10560:
URL: https://github.com/apache/kafka/pull/10560#issuecomment-822311410
ping @hachikuji , also cc @guozhangwang since the
`OFFSET_METADATA_TOO_LARGE` is added by you.
--
This is an automated message from the Apache Git Service.
To respond to th
chia7712 commented on a change in pull request #9861:
URL: https://github.com/apache/kafka/pull/9861#discussion_r615706373
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredTimestampedKeyValueStore.java
##
@@ -96,7 +96,7 @@ public boolean putI
tombentley commented on a change in pull request #9441:
URL: https://github.com/apache/kafka/pull/9441#discussion_r615722282
##
File path: core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala
##
@@ -87,6 +87,8 @@ class GroupCoordinator(val brokerId: Int,
priv
tombentley commented on a change in pull request #9441:
URL: https://github.com/apache/kafka/pull/9441#discussion_r615722539
##
File path: core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala
##
@@ -905,19 +907,33 @@ class GroupCoordinator(val brokerId: Int,
*
tombentley commented on pull request #9441:
URL: https://github.com/apache/kafka/pull/9441#issuecomment-822355393
@hachikuji I've addressed your comments, if you want to take another look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
tombentley commented on pull request #9878:
URL: https://github.com/apache/kafka/pull/9878#issuecomment-822360291
CI faliures are unrelated. @ijuma and/or @chia7712 could one of you review
this please?
--
This is an automated message from the Apache Git Service.
To respond to the message
cadonna commented on pull request #9821:
URL: https://github.com/apache/kafka/pull/9821#issuecomment-822384633
@vitojeng @mjsax @ableegoldman
My 2 euro cent:
Looking at the code for `allMetadataForStore` and `queryMetadataForKey` it
seems like the case when a state store is not unkn
dajac commented on pull request #10553:
URL: https://github.com/apache/kafka/pull/10553#issuecomment-822407305
Test failures are not related. Merging to trunk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
dajac merged pull request #10553:
URL: https://github.com/apache/kafka/pull/10553
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please c
chia7712 commented on pull request #10446:
URL: https://github.com/apache/kafka/pull/10446#issuecomment-822411562
```
Build / JDK 8 and Scala 2.12 /
org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationSSLTest.testReplication()
Build / JDK 11 and Scala 2.13 /
org.ap
alozano3 commented on pull request #7284:
URL: https://github.com/apache/kafka/pull/7284#issuecomment-822411760
I close this PR because #9549 has been merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
alozano3 closed pull request #7284:
URL: https://github.com/apache/kafka/pull/7284
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
Tom Bentley created KAFKA-12685:
---
Summary: ReplicaStateMachine attempts invalid transition
Key: KAFKA-12685
URL: https://issues.apache.org/jira/browse/KAFKA-12685
Project: Kafka
Issue Type: Bug
dongjinleekr commented on pull request #9414:
URL: https://github.com/apache/kafka/pull/9414#issuecomment-822452651
Hi @guozhangwang,
Thanks for your mention. I completed applying @vvcephei's comment (on March
25, 2021) and awaiting review and merging, with maintaining the PR to the
chia7712 merged pull request #10498:
URL: https://github.com/apache/kafka/pull/10498
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, pleas
wenbingshen commented on pull request #10556:
URL: https://github.com/apache/kafka/pull/10556#issuecomment-822476286
Dear @chia7712 According to your instructions, I have reverted all imports.
In your free time, please help me to review again. Thanks. :)
--
This is an automated message f
lct45 commented on pull request #10519:
URL: https://github.com/apache/kafka/pull/10519#issuecomment-822486388
Thanks @ketulgupta1995 , looks good to me. @mjsax or @ableegoldman can we
get a +1 and merge?
--
This is an automated message from the Apache Git Service.
To respond to the mess
ijuma commented on pull request #10559:
URL: https://github.com/apache/kafka/pull/10559#issuecomment-822496169
cc @jsancio
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
David Arthur created KAFKA-12686:
Summary: Race condition in AlterIsr response handling
Key: KAFKA-12686
URL: https://issues.apache.org/jira/browse/KAFKA-12686
Project: Kafka
Issue Type: Bug
ning2008wisc commented on pull request #10547:
URL: https://github.com/apache/kafka/pull/10547#issuecomment-822535696
thanks for the PR :) change seems reasonable and lgtm (if consistent test
results can be verified by multiple runs). The final review will be done by the
committer.
--
David Arthur created KAFKA-12687:
Summary: Add request cancellation to
BrokerToControllerChannelManager
Key: KAFKA-12687
URL: https://issues.apache.org/jira/browse/KAFKA-12687
Project: Kafka
C0urante commented on a change in pull request #10549:
URL: https://github.com/apache/kafka/pull/10549#discussion_r615928396
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/DelegatingClassLoader.java
##
@@ -187,17 +192,24 @@ private stati
mumrah opened a new pull request #10561:
URL: https://github.com/apache/kafka/pull/10561
Copied from the JIRA:
> In Partition.scala, there is a race condition between the handling of an
AlterIsrResponse and a LeaderAndIsrRequest. This is a pretty rare scenario and
would involve the
C0urante commented on a change in pull request #10549:
URL: https://github.com/apache/kafka/pull/10549#discussion_r615928396
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/DelegatingClassLoader.java
##
@@ -187,17 +192,24 @@ private stati
kpatelatwork commented on a change in pull request #10549:
URL: https://github.com/apache/kafka/pull/10549#discussion_r615310932
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/DelegatingClassLoader.java
##
@@ -187,17 +192,24 @@ private s
[
https://issues.apache.org/jira/browse/KAFKA-10800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jose Armando Garcia Sancio reassigned KAFKA-10800:
--
Assignee: Jose Armando Garcia Sancio
> Validate the snapshot
[
https://issues.apache.org/jira/browse/KAFKA-10800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jose Armando Garcia Sancio reassigned KAFKA-10800:
--
Assignee: Haoran Xuan (was: Jose Armando Garcia Sancio)
> Va
[
https://issues.apache.org/jira/browse/KAFKA-10800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17325140#comment-17325140
]
Jose Armando Garcia Sancio commented on KAFKA-10800:
Yes. Please tak
wenbingshen commented on a change in pull request #10558:
URL: https://github.com/apache/kafka/pull/10558#discussion_r615967262
##
File path: core/src/test/scala/unit/kafka/admin/LeaderElectionCommandTest.scala
##
@@ -273,6 +273,48 @@ final class LeaderElectionCommandTest exten
highluck commented on a change in pull request #9861:
URL: https://github.com/apache/kafka/pull/9861#discussion_r615971825
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredTimestampedKeyValueStore.java
##
@@ -96,7 +96,7 @@ public boolean putI
wenbingshen commented on pull request #10556:
URL: https://github.com/apache/kafka/pull/10556#issuecomment-822583575
> Dear @chia7712 According to your instructions, I have reverted all
imports. In your free time, please help me to review again. Thanks. :)
--
This is an automated
wenbingshen closed pull request #10556:
URL: https://github.com/apache/kafka/pull/10556
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, pl
wenbingshen commented on pull request #10556:
URL: https://github.com/apache/kafka/pull/10556#issuecomment-822587200
@chia7712 These test failures seem to have nothing to do with this pr.
Apart from merging the backbone, can we still trigger the inspection? I do not
know what to do.
--
wenbingshen commented on pull request #10556:
URL: https://github.com/apache/kafka/pull/10556#issuecomment-822586978
> > Dear @chia7712 According to your instructions, I have reverted all
imports. In your free time, please help me to review again. Thanks. :)
--
This is an automated m
wenbingshen closed pull request #10327:
URL: https://github.com/apache/kafka/pull/10327
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, pl
vvcephei opened a new pull request #10562:
URL: https://github.com/apache/kafka/pull/10562
Add the 2.8 release to our tests.
Before this will work, someone with access will have to upload these
artifacts: ( https://home.apache.org/~vvcephei/2.8.0-mirror/ ) to this bucket:
s3://kafka
rhauch commented on a change in pull request #9541:
URL: https://github.com/apache/kafka/pull/9541#discussion_r615975188
##
File path:
connect/api/src/main/java/org/apache/kafka/connect/data/ConnectSchema.java
##
@@ -266,7 +267,7 @@ public static void validateValue(String name
[
https://issues.apache.org/jira/browse/KAFKA-12675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17325181#comment-17325181
]
A. Sophie Blee-Goldman commented on KAFKA-12675:
Nice! It would be great
[
https://issues.apache.org/jira/browse/KAFKA-9168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17325182#comment-17325182
]
Sagar Rao commented on KAFKA-9168:
--
hey [~guozhang], the benchmarks that I had talked ab
[
https://issues.apache.org/jira/browse/KAFKA-12313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sagar Rao updated KAFKA-12313:
--
Comment: was deleted
(was: https://github.com/apache/kafka/pull/10468#pullrequestreview-628083086)
>
vamossagar12 commented on pull request #9779:
URL: https://github.com/apache/kafka/pull/9779#issuecomment-822621642
hey @guozhangwang , would you be able to review this whenever you get the
chance?
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
vamossagar12 commented on pull request #10278:
URL: https://github.com/apache/kafka/pull/10278#issuecomment-822622340
hey @jsancio / @hachikuji could you plz review the PR whenever you get the
chance?
--
This is an automated message from the Apache Git Service.
To respond to the message
vamossagar12 commented on a change in pull request #9756:
URL: https://github.com/apache/kafka/pull/9756#discussion_r616018340
##
File path: raft/src/main/java/org/apache/kafka/raft/RaftConfig.java
##
@@ -76,6 +76,11 @@
"wait for writes to accumulate before flushing th
vamossagar12 commented on a change in pull request #10468:
URL: https://github.com/apache/kafka/pull/10468#discussion_r616018841
##
File path: raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientTest.java
##
@@ -1673,6 +1673,69 @@ public void testLeaderGracefulShutdownTimeo
ableegoldman commented on pull request #9821:
URL: https://github.com/apache/kafka/pull/9821#issuecomment-822625233
Fine with me. It does seem odd that we'd be inconsistent, but I don't think
we need to solve everything with this one KIP/PR. Let's just file a ticket for
this so we don't f
[
https://issues.apache.org/jira/browse/KAFKA-9168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17325187#comment-17325187
]
A. Sophie Blee-Goldman commented on KAFKA-9168:
---
[~sagarrao] Feel free to p
[
https://issues.apache.org/jira/browse/KAFKA-10231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Randall Hauch updated KAFKA-10231:
--
Description:
As a Kafka Connect operator I would expect a more definitive error when the
inte
[
https://issues.apache.org/jira/browse/KAFKA-10231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Randall Hauch updated KAFKA-10231:
--
Description:
As a Kafka Connect operator I would expect a more definitive error when the
inte
jsancio commented on pull request #10559:
URL: https://github.com/apache/kafka/pull/10559#issuecomment-822658214
@showuon Do we need to disable the entire suite of tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
kpatelatwork commented on pull request #10530:
URL: https://github.com/apache/kafka/pull/10530#issuecomment-822663074
@tombentley could you please review and merge this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
C0urante opened a new pull request #10563:
URL: https://github.com/apache/kafka/pull/10563
[Jira](https://issues.apache.org/jira/browse/KAFKA-12487)
Currently, the `WorkerSinkTask`'s consumer rebalance listener (and related
logic) is hardcoded to assume eager rebalancing, which means
[
https://issues.apache.org/jira/browse/KAFKA-12675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17325234#comment-17325234
]
Guozhang Wang commented on KAFKA-12675:
---
Wow this is super! Thanks [~showuon] [~tw
kpatelatwork commented on a change in pull request #10549:
URL: https://github.com/apache/kafka/pull/10549#discussion_r616073878
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/DelegatingClassLoader.java
##
@@ -187,17 +192,24 @@ private s
kpatelatwork commented on a change in pull request #10549:
URL: https://github.com/apache/kafka/pull/10549#discussion_r616074220
##
File path:
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/isolation/DelegatingClassLoaderTest.java
##
@@ -129,4 +133,32 @@ public
Cosmin Giurgiu created KAFKA-12688:
--
Summary: Sources and maven artifact in runtime classpath
Key: KAFKA-12688
URL: https://issues.apache.org/jira/browse/KAFKA-12688
Project: Kafka
Issue Typ
cmccabe commented on pull request #10550:
URL: https://github.com/apache/kafka/pull/10550#issuecomment-822694203
Thanks for tackling this.
Please keep in mind that this is a plugin architecture. The ZK-based
authorizer shouldn't get any special treatment, nor should its setup be don
cmccabe edited a comment on pull request #10550:
URL: https://github.com/apache/kafka/pull/10550#issuecomment-822694203
Thanks for tackling this, @rondagostino !
We have to be a bit careful about the structure here. This is a plugin
architecture, which means that the ZK-based author
cmccabe edited a comment on pull request #10550:
URL: https://github.com/apache/kafka/pull/10550#issuecomment-822694203
Thanks for tackling this, @rondagostino !
We have to be a bit careful about the structure here. This is a plugin
architecture, which means that the ZK-based author
cmccabe edited a comment on pull request #10550:
URL: https://github.com/apache/kafka/pull/10550#issuecomment-822694203
Thanks for tackling this, @rondagostino !
We have to be a bit careful about the structure here. This is a plugin
architecture, which means that the ZK-based author
cmccabe commented on a change in pull request #10561:
URL: https://github.com/apache/kafka/pull/10561#discussion_r616115604
##
File path: core/src/main/scala/kafka/cluster/Partition.scala
##
@@ -1341,13 +1335,15 @@ class Partition(val topicPartition: TopicPartition,
isrSta
rhauch commented on a change in pull request #10549:
URL: https://github.com/apache/kafka/pull/10549#discussion_r616119723
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/DelegatingClassLoader.java
##
@@ -196,8 +214,10 @@ private static P
A. Sophie Blee-Goldman created KAFKA-12689:
--
Summary: Remove deprecated EOS configs
Key: KAFKA-12689
URL: https://issues.apache.org/jira/browse/KAFKA-12689
Project: Kafka
Issue Type:
kpatelatwork commented on a change in pull request #10549:
URL: https://github.com/apache/kafka/pull/10549#discussion_r616169919
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/DelegatingClassLoader.java
##
@@ -208,6 +228,22 @@ protected
A. Sophie Blee-Goldman created KAFKA-12690:
--
Summary: Remove deprecated Producer#sendOffsetsToTransaction
Key: KAFKA-12690
URL: https://issues.apache.org/jira/browse/KAFKA-12690
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-12690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman updated KAFKA-12690:
---
Description: In
[KIP-732|https://cwiki.apache.org/confluence/display/KAFKA/K
C0urante commented on pull request #10563:
URL: https://github.com/apache/kafka/pull/10563#issuecomment-822792962
@ncliang @gharris1727 do either of you have time to take a look?
@ableegoldman @showuon @guozhangwang FYI, this should be the only change to
Connect necessary for KIP-726
Walker Carlson created KAFKA-12691:
--
Summary: TaskMetadata timeSinceIdlingStarted not reporting
correctly
Key: KAFKA-12691
URL: https://issues.apache.org/jira/browse/KAFKA-12691
Project: Kafka
cmccabe opened a new pull request #10564:
URL: https://github.com/apache/kafka/pull/10564
Centralize leader and ISR changes in generateLeaderAndIsrUpdates.
Consolidate handleNodeDeactivated and handleNodeActivated into this
function.
Rename BrokersToIsrs#noLeaderIterator to
Bro
Ryan Dielhenn created KAFKA-12692:
-
Summary: Enforce config types in ConfigurationControlManager
Key: KAFKA-12692
URL: https://issues.apache.org/jira/browse/KAFKA-12692
Project: Kafka
Issue T
kpatelatwork commented on a change in pull request #10549:
URL: https://github.com/apache/kafka/pull/10549#discussion_r616208904
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/DelegatingClassLoader.java
##
@@ -196,8 +214,10 @@ private st
[
https://issues.apache.org/jira/browse/KAFKA-12502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17325345#comment-17325345
]
Ryan Dielhenn commented on KAFKA-12502:
---
Added KAFKA-12692 as a prerequisite.
> Q
[
https://issues.apache.org/jira/browse/KAFKA-12692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ryan Dielhenn updated KAFKA-12692:
--
Priority: Major (was: Minor)
> Enforce config types in ConfigurationControlManager
>
junrao commented on a change in pull request #10271:
URL: https://github.com/apache/kafka/pull/10271#discussion_r616081872
##
File path:
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/serialization/RemoteLogMetadataSerdes.java
##
@@ -0,0 +1,54 @@
+/*
wcarlson5 opened a new pull request #10565:
URL: https://github.com/apache/kafka/pull/10565
Currently task is reporting the time it started idling as when the task is
suspended where it should also take into account enforced non processing.
### Committer Checklist (excluded from comm
wcarlson5 commented on pull request #10565:
URL: https://github.com/apache/kafka/pull/10565#issuecomment-822850426
@rodesai @ableegoldman @abbccdda @mjsax
Turns out there is another case where we should consider a task to be
idling. If you can give this a review soon that would be great.
guozhangwang commented on a change in pull request #10462:
URL: https://github.com/apache/kafka/pull/10462#discussion_r616218643
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java
##
@@ -60,20 +83,44 @@
}
private
[
https://issues.apache.org/jira/browse/KAFKA-12675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17324358#comment-17324358
]
Travis Bischel edited comment on KAFKA-12675 at 4/19/21, 11:58 PM:
---
junrao commented on a change in pull request #10564:
URL: https://github.com/apache/kafka/pull/10564#discussion_r616258845
##
File path:
metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java
##
@@ -1119,6 +1039,77 @@ void validateManualPartitionAssi
showuon commented on pull request #10559:
URL: https://github.com/apache/kafka/pull/10559#issuecomment-822883918
@jsancio , good question. I just checked the recent 10 trunk builds, and
found that there are only 3 tests flaky. So, I updated to only disable 3 tests.
Thanks.
--
This is an
mjsax commented on a change in pull request #10462:
URL: https://github.com/apache/kafka/pull/10462#discussion_r616264850
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImplJoin.java
##
@@ -118,20 +142,47 @@
final ProcessorGraphN
satishd commented on a change in pull request #10478:
URL: https://github.com/apache/kafka/pull/10478#discussion_r616265276
##
File path: core/src/main/scala/kafka/log/Log.scala
##
@@ -255,19 +261,21 @@ case object SnapshotGenerated extends
LogStartOffsetIncrementReason {
@th
mjsax commented on a change in pull request #10462:
URL: https://github.com/apache/kafka/pull/10462#discussion_r616266276
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/LeftOrRightValue.java
##
@@ -0,0 +1,113 @@
+/*
+ * Licensed to the Apache Soft
mjsax commented on a change in pull request #10462:
URL: https://github.com/apache/kafka/pull/10462#discussion_r616266276
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/LeftOrRightValue.java
##
@@ -0,0 +1,113 @@
+/*
+ * Licensed to the Apache Soft
mjsax commented on a change in pull request #10462:
URL: https://github.com/apache/kafka/pull/10462#discussion_r616268402
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java
##
@@ -93,23 +136,118 @@ public void process(final K
mjsax commented on a change in pull request #10462:
URL: https://github.com/apache/kafka/pull/10462#discussion_r616269613
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java
##
@@ -93,23 +136,118 @@ public void process(final K
[
https://issues.apache.org/jira/browse/KAFKA-12207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17325405#comment-17325405
]
Yi Ding commented on KAFKA-12207:
-
We can remove the restriction on `max.in.flight.reque
showuon edited a comment on pull request #10552:
URL: https://github.com/apache/kafka/pull/10552#issuecomment-822292217
Failed tests are all flaky and unrelated. Thanks.
```
Build / JDK 8 and Scala 2.12 /
org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationSSLTe
showuon commented on pull request #10552:
URL: https://github.com/apache/kafka/pull/10552#issuecomment-822906608
@guozhangwang @ableegoldman , PR is ready for review. Thank you. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
showuon edited a comment on pull request #10552:
URL: https://github.com/apache/kafka/pull/10552#issuecomment-822292217
Failed tests are all flaky and unrelated. Thanks.
The fix to flaky `MirrorConnectorsIntegration` tests issue is in my another
PR: https://github.com/apache/kafka/pull/1
[
https://issues.apache.org/jira/browse/KAFKA-7878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17325411#comment-17325411
]
Daniel Huang commented on KAFKA-7878:
-
Also seeing a similar "Task already exists in
showuon edited a comment on pull request #10552:
URL: https://github.com/apache/kafka/pull/10552#issuecomment-822200511
The performance comparison in jenkins for uniform subscription and non-equal
subscription with the setting:
```
topicCount = 500;
partitionCount = 2000;
consum
showuon commented on a change in pull request #10552:
URL: https://github.com/apache/kafka/pull/10552#discussion_r615229166
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java
##
@@ -387,58 +398,121 @@ private boolean all
showuon commented on a change in pull request #10552:
URL: https://github.com/apache/kafka/pull/10552#discussion_r615228600
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java
##
@@ -387,58 +398,121 @@ private boolean all
showuon commented on a change in pull request #10552:
URL: https://github.com/apache/kafka/pull/10552#discussion_r615228600
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java
##
@@ -387,58 +398,121 @@ private boolean all
vitojeng commented on pull request #9821:
URL: https://github.com/apache/kafka/pull/9821#issuecomment-822913986
@cadonna , @ableegoldman
Thanks for great discussion.
I'll rebase trunk and update the streams upgrade guide.
--
This is an automated message from the Apache Git Serv
1 - 100 of 130 matches
Mail list logo
