dengziming opened a new pull request #10560:
URL: https://github.com/apache/kafka/pull/10560


   *More detailed description of your change*
   1. Do not update the commit-sensor if the commit failed and add test logic.
   2. Also add 2 unit tests, the first for `OFFSET_METADATA_TOO_LARGE` error, 
the second is to cover circumstance when one offset is committed and the other 
is failed with `OFFSET_METADATA_TOO_LARGE`, these 2 are not covered currently.
   
   *Summary of testing strategy (including rationale)*
   unit test
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to