dajac opened a new pull request #9903:
URL: https://github.com/apache/kafka/pull/9903
This PR implements the DescribeCluster API in the broker.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build
David Jacot created KAFKA-12210:
---
Summary: AdminClient should use DescribeCluster API when available
Key: KAFKA-12210
URL: https://issues.apache.org/jira/browse/KAFKA-12210
Project: Kafka
Issue
Luke Chen created KAFKA-12211:
-
Summary: NoSuchFileException will be thrown if hasPersistentStores
is false when creating stateDir
Key: KAFKA-12211
URL: https://issues.apache.org/jira/browse/KAFKA-12211
P
showuon opened a new pull request #9904:
URL: https://github.com/apache/kafka/pull/9904
We improved the state directory folder/file permission setting in #9583 .
But we forgot to consider one situation: if user doesn't have Persistent
Stores, we won't create base dir and state dir. And if
showuon commented on a change in pull request #9904:
URL: https://github.com/apache/kafka/pull/9904#discussion_r558097187
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java
##
@@ -94,27 +94,32 @@ public StateDirectory(final Str
showuon commented on pull request #9904:
URL: https://github.com/apache/kafka/pull/9904#issuecomment-760772022
@lct45 @ableegoldman @cadonna , please help review this PR. Thanks.
This is an automated message from the Apache G
David Jacot created KAFKA-12212:
---
Summary: Bump Metadata API version to remove
`ClusterAuthorizedOperations` fields
Key: KAFKA-12212
URL: https://issues.apache.org/jira/browse/KAFKA-12212
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-12211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen updated KAFKA-12211:
--
Fix Version/s: (was: 2.8.0)
> NoSuchFileException will be thrown if hasPersistentStores is false w
[
https://issues.apache.org/jira/browse/KAFKA-12211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen updated KAFKA-12211:
--
Affects Version/s: (was: 2.8.0)
2.7.0
> NoSuchFileException will be thrown
dajac opened a new pull request #9905:
URL: https://github.com/apache/kafka/pull/9905
This PR updates the AdminClient to use the DescribeCluster API when
available. The clients fails back to the Metadata API otherwise.
### Committer Checklist (excluded from commit message)
- [ ] V
g1geordie opened a new pull request #9906:
URL: https://github.com/apache/kafka/pull/9906
Refactor MemoryRecordsBuilderTest/MemoryRecordsTest to avoid a lot of
ignored test cases
I add different Parameter Source to prevent assume method.
if method uses the source only itself
g1geordie commented on pull request #9906:
URL: https://github.com/apache/kafka/pull/9906#issuecomment-760784911
There are no ignore test in those tests .
@chia7712 can you check whether it satisfies your expectation or not ?
---
cadonna commented on a change in pull request #9888:
URL: https://github.com/apache/kafka/pull/9888#discussion_r558149927
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/AdjustStreamThreadCountTest.java
##
@@ -90,24 +91,61 @@ public void setup() {
akamensky commented on pull request #7884:
URL: https://github.com/apache/kafka/pull/7884#issuecomment-760814414
@ConcurrencyPractitioner @junrao this PR has been stale since April 2020.
When would it be ready to merge? We are hitting this issue and it causes
insanely long startup times in
showuon commented on pull request #9733:
URL: https://github.com/apache/kafka/pull/9733#issuecomment-760898836
There's a jenkins timeout build error in jdk8. Made a minor change to
trigger jenkins build again to make sure it's infra's issue, not my change
-
tombentley commented on pull request #9847:
URL: https://github.com/apache/kafka/pull/9847#issuecomment-760914291
@chia7712 thanks for taking a look. It's true that I should have fixed this
on the broker, so it works for non-Java clients too. It turns out that the
three RPCs are remarkably
[
https://issues.apache.org/jira/browse/KAFKA-12199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17266032#comment-17266032
]
Ismael Juma commented on KAFKA-12199:
-
We have already picked Mockito as our mocking
[
https://issues.apache.org/jira/browse/KAFKA-12199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17266034#comment-17266034
]
Chia-Ping Tsai commented on KAFKA-12199:
Thanks for your response. I plan to fil
dajac commented on a change in pull request #9430:
URL: https://github.com/apache/kafka/pull/9430#discussion_r558158660
##
File path: core/src/main/scala/kafka/tools/GetOffsetShell.scala
##
@@ -33,15 +35,26 @@ object GetOffsetShell {
def main(args: Array[String]): Unit = {
dengziming commented on pull request #9890:
URL: https://github.com/apache/kafka/pull/9890#issuecomment-760942669
> @dengziming Could you fix the conflicting files? thanks!
Sorry for the late reply, done!
This is an au
cadonna commented on a change in pull request #9508:
URL: https://github.com/apache/kafka/pull/9508#discussion_r558201109
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java
##
@@ -229,6 +232,13 @@ public V delete(final K key)
ijuma commented on a change in pull request #9906:
URL: https://github.com/apache/kafka/pull/9906#discussion_r558311926
##
File path:
clients/src/test/java/org/apache/kafka/common/record/MemoryRecordsBuilderTest.java
##
@@ -72,19 +70,28 @@ public String toString() {
ijuma merged pull request #9897:
URL: https://github.com/apache/kafka/pull/9897
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
ijuma merged pull request #9896:
URL: https://github.com/apache/kafka/pull/9896
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
dengziming opened a new pull request #9907:
URL: https://github.com/apache/kafka/pull/9907
*More detailed description of your change*
As title
*Summary of testing strategy (including rationale)*
QA
### Committer Checklist (excluded from commit message)
- [ ] Verify des
ijuma commented on a change in pull request #9894:
URL: https://github.com/apache/kafka/pull/9894#discussion_r558314026
##
File path:
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorSourceTaskTest.java
##
@@ -58,26 +58,26 @@ public void testSerde() {
pu
ijuma commented on pull request #9877:
URL: https://github.com/apache/kafka/pull/9877#issuecomment-760952738
Not sure what the original purpose of the test was, but this changes what
it's testing, right? Before producing was happening after subscription and now
before.
--
ijuma commented on pull request #9877:
URL: https://github.com/apache/kafka/pull/9877#issuecomment-760953842
Can we just bump `max.poll.interval.ms`? It doesn't seem like there's any
value in having that be low in this test.
ijuma commented on pull request #9877:
URL: https://github.com/apache/kafka/pull/9877#issuecomment-760954112
Also, thanks so much for diagnosing this! Very awesome. :)
This is an automated message from the Apache Git Service.
ijuma commented on pull request #9872:
URL: https://github.com/apache/kafka/pull/9872#issuecomment-760954971
Do we have to run the full test suite or would it be sufficient to run the
unit tests only?
This is an automated me
ijuma commented on a change in pull request #9865:
URL: https://github.com/apache/kafka/pull/9865#discussion_r558321382
##
File path: docs/upgrade.html
##
@@ -20,6 +20,28 @@
dengziming commented on pull request #9820:
URL: https://github.com/apache/kafka/pull/9820#issuecomment-760960679
@jsancio @hachikuji , Hi, PTAL.
This is an automated message from the Apache Git Service.
To respond to the mes
ijuma commented on a change in pull request #9855:
URL: https://github.com/apache/kafka/pull/9855#discussion_r558338474
##
File path: core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala
##
@@ -1228,10 +1223,10 @@ class PlaintextConsumerTest extends BaseConsume
Piotr Fras created KAFKA-12213:
--
Summary: Kafka Streams aggregation Initializer to accept record key
Key: KAFKA-12213
URL: https://issues.apache.org/jira/browse/KAFKA-12213
Project: Kafka
Issue
jCalamari opened a new pull request #9908:
URL: https://github.com/apache/kafka/pull/9908
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
As per title and ji
[
https://issues.apache.org/jira/browse/KAFKA-12213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Piotr Fras updated KAFKA-12213:
---
Issue Type: New Feature (was: Bug)
> Kafka Streams aggregation Initializer to accept record key
> -
[
https://issues.apache.org/jira/browse/KAFKA-12213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Piotr Fras updated KAFKA-12213:
---
Priority: Minor (was: Major)
> Kafka Streams aggregation Initializer to accept record key
> ---
17hao commented on pull request #9891:
URL: https://github.com/apache/kafka/pull/9891#issuecomment-761026242
hi @chia7712 , I added an ut, PTAL.
This is an automated message from the Apache Git Service.
To respond to the mes
cadonna commented on a change in pull request #9895:
URL: https://github.com/apache/kafka/pull/9895#discussion_r558404376
##
File path: docs/ops.html
##
@@ -2032,17 +2032,25 @@ RocksDB
Metrics
- All of the following metrics have a recording level of debug.
- The metrics are
g1geordie commented on a change in pull request #9906:
URL: https://github.com/apache/kafka/pull/9906#discussion_r558406657
##
File path:
clients/src/test/java/org/apache/kafka/common/record/MemoryRecordsBuilderTest.java
##
@@ -72,19 +70,28 @@ public String toString() {
g1geordie commented on a change in pull request #9906:
URL: https://github.com/apache/kafka/pull/9906#discussion_r558406657
##
File path:
clients/src/test/java/org/apache/kafka/common/record/MemoryRecordsBuilderTest.java
##
@@ -72,19 +70,28 @@ public String toString() {
cadonna commented on a change in pull request #9848:
URL: https://github.com/apache/kafka/pull/9848#discussion_r558414235
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/RepartitionTopics.java
##
@@ -0,0 +1,211 @@
+/*
+ * Licensed to the Apache
dajac commented on pull request #9820:
URL: https://github.com/apache/kafka/pull/9820#issuecomment-761038874
@dengziming Could you address the checkstyle issues?
```
[2021-01-15T14:11:08.434Z] [ant:checkstyle] [ERROR]
/home/jenkins/workspace/Kafka_kafka-pr_PR-9820/clients/src/main/jav
[
https://issues.apache.org/jira/browse/KAFKA-12213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Piotr Fras updated KAFKA-12213:
---
Description:
Sometimes Kafka record key contains useful information for creating a zero
object in a
ijuma commented on a change in pull request #9906:
URL: https://github.com/apache/kafka/pull/9906#discussion_r558416241
##
File path:
clients/src/test/java/org/apache/kafka/common/record/MemoryRecordsBuilderTest.java
##
@@ -72,19 +70,28 @@ public String toString() {
cadonna commented on a change in pull request #9848:
URL: https://github.com/apache/kafka/pull/9848#discussion_r558419237
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java
##
@@ -471,135 +470,22 @@ private boolean ch
[
https://issues.apache.org/jira/browse/KAFKA-12193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot reassigned KAFKA-12193:
---
Assignee: Bob Barrett
> Re-resolve IPs when a client is disconnected
>
g1geordie opened a new pull request #9909:
URL: https://github.com/apache/kafka/pull/9909
- change import
- assertThrows replaces try-catch
This is an automated message from the Apache Git Service.
To respond to the messa
chia7712 merged pull request #9884:
URL: https://github.com/apache/kafka/pull/9884
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
cadonna commented on a change in pull request #9848:
URL: https://github.com/apache/kafka/pull/9848#discussion_r558439866
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/RepartitionTopics.java
##
@@ -0,0 +1,212 @@
+/*
+ * Licensed to the Apache
chia7712 commented on a change in pull request #9906:
URL: https://github.com/apache/kafka/pull/9906#discussion_r558430765
##
File path:
clients/src/test/java/org/apache/kafka/common/record/MemoryRecordsTest.java
##
@@ -201,38 +218,37 @@ public void testHasRoomForMethod(Args a
cadonna commented on a change in pull request #9848:
URL: https://github.com/apache/kafka/pull/9848#discussion_r558440845
##
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/RepartitionTopicsTest.java
##
@@ -0,0 +1,434 @@
+/*
+ * Licensed to the Ap
chia7712 commented on a change in pull request #9855:
URL: https://github.com/apache/kafka/pull/9855#discussion_r558455483
##
File path: core/src/test/scala/unit/kafka/utils/TestUtils.scala
##
@@ -459,41 +459,9 @@ object TestUtils extends Logging {
* Check that the buffer c
hachikuji commented on a change in pull request #9871:
URL: https://github.com/apache/kafka/pull/9871#discussion_r558456316
##
File path: raft/src/main/java/org/apache/kafka/raft/QuorumState.java
##
@@ -196,7 +203,15 @@ public void initialize(OffsetAndEpoch
logEndOffsetAndEpoc
[
https://issues.apache.org/jira/browse/KAFKA-12190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-12190:
Affects Version/s: 2.7.1
> Failure on Windows due to an UnsupportedOperationException when
[
https://issues.apache.org/jira/browse/KAFKA-12190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17266222#comment-17266222
]
Matthias J. Sax commented on KAFKA-12190:
-
Note that `2.7.0` release is not affe
[
https://issues.apache.org/jira/browse/KAFKA-12190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-12190:
Fix Version/s: 2.7.1
> Failure on Windows due to an UnsupportedOperationException when
>
g1geordie commented on pull request #9906:
URL: https://github.com/apache/kafka/pull/9906#issuecomment-761078614
@chia7712 thanks for all suggestions
This is an automated message from the Apache Git Service.
To respond to th
guozhangwang commented on pull request #9681:
URL: https://github.com/apache/kafka/pull/9681#issuecomment-761078960
Cherry-picked to 2.7
This is an automated message from the Apache Git Service.
To respond to the message, ple
[
https://issues.apache.org/jira/browse/KAFKA-12190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-12190:
Fix Version/s: 2.6.2
> Failure on Windows due to an UnsupportedOperationException when
>
guozhangwang commented on pull request #9873:
URL: https://github.com/apache/kafka/pull/9873#issuecomment-761079743
Cherry-picked to 2.7
This is an automated message from the Apache Git Service.
To respond to the message, ple
chia7712 commented on a change in pull request #9855:
URL: https://github.com/apache/kafka/pull/9855#discussion_r558465841
##
File path:
core/src/test/scala/unit/kafka/server/AlterUserScramCredentialsRequestTest.scala
##
@@ -43,20 +41,27 @@ import scala.jdk.CollectionConverter
smccauliff opened a new pull request #9910:
URL: https://github.com/apache/kafka/pull/9910
This moves the Logging trait into companion objects so the loggers are only
instantiated once. Classes import the methods from their companion objects.
Classes that were using inheritance to gain a
[
https://issues.apache.org/jira/browse/KAFKA-10877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17266247#comment-17266247
]
Sean McCauliff commented on KAFKA-10877:
PR added
> Instantiating loggers for e
chia7712 commented on a change in pull request #9855:
URL: https://github.com/apache/kafka/pull/9855#discussion_r558473729
##
File path: core/src/test/scala/unit/kafka/server/FetchRequestMaxBytesTest.scala
##
@@ -58,11 +58,13 @@ class FetchRequestMaxBytesTest extends BaseReques
smccauliff commented on pull request #9910:
URL: https://github.com/apache/kafka/pull/9910#issuecomment-761096689
@gitlw This is the more comprehensive change I was discussing with you.
This is an automated message from the A
ijuma commented on a change in pull request #9871:
URL: https://github.com/apache/kafka/pull/9871#discussion_r558481270
##
File path: raft/src/main/java/org/apache/kafka/raft/QuorumState.java
##
@@ -196,7 +203,15 @@ public void initialize(OffsetAndEpoch
logEndOffsetAndEpoch) t
hachikuji commented on a change in pull request #9600:
URL: https://github.com/apache/kafka/pull/9600#discussion_r558469889
##
File path:
clients/src/test/java/org/apache/kafka/clients/NodeApiVersionsTest.java
##
@@ -125,13 +126,6 @@ public void testUsableVersionCalculationNoK
ijuma commented on a change in pull request #9906:
URL: https://github.com/apache/kafka/pull/9906#discussion_r558484400
##
File path:
clients/src/test/java/org/apache/kafka/common/record/MemoryRecordsBuilderTest.java
##
@@ -72,19 +70,28 @@ public String toString() {
abbccdda commented on a change in pull request #9600:
URL: https://github.com/apache/kafka/pull/9600#discussion_r558484623
##
File path:
clients/src/test/java/org/apache/kafka/clients/NodeApiVersionsTest.java
##
@@ -125,13 +126,6 @@ public void testUsableVersionCalculationNoKn
ijuma commented on a change in pull request #9906:
URL: https://github.com/apache/kafka/pull/9906#discussion_r558486354
##
File path:
clients/src/test/java/org/apache/kafka/common/record/MemoryRecordsBuilderTest.java
##
@@ -72,19 +70,28 @@ public String toString() {
hachikuji commented on pull request #9819:
URL: https://github.com/apache/kafka/pull/9819#issuecomment-761119104
@dengziming @jsancio I'll give my take what I think we should do here, but
let's try to agree before we go any further. Basically I am not really
convinced that we need a new ty
hachikuji commented on a change in pull request #9600:
URL: https://github.com/apache/kafka/pull/9600#discussion_r558529073
##
File path:
core/src/test/scala/unit/kafka/server/AbstractApiVersionsRequestTest.scala
##
@@ -25,6 +27,15 @@ import scala.jdk.CollectionConverters._
chia7712 merged pull request #9890:
URL: https://github.com/apache/kafka/pull/9890
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
chia7712 commented on pull request #9909:
URL: https://github.com/apache/kafka/pull/9909#issuecomment-761135068
@g1geordie Please fix conflicting files :)
This is an automated message from the Apache Git Service.
To respond t
mumrah commented on pull request #9715:
URL: https://github.com/apache/kafka/pull/9715#issuecomment-761171619
The test failures were due to unhappy mocks in KafkaApisTest. It looks
rather tedious to fix the mocks so I ended up moving two of the methods I had
put into RequestChannel back in
vvcephei opened a new pull request #9911:
URL: https://github.com/apache/kafka/pull/9911
We have seen recent system test timeouts associated with this test.
Analysis revealed an excessive amount of time spent searching
for test conditions in the logs.
This change addresses the i
vvcephei commented on pull request #9911:
URL: https://github.com/apache/kafka/pull/9911#issuecomment-761176712
In detail, here's my analysis of a recent timeout:
Looking at the debug log for the test, there seem to be some remote commands
that really burn the clock. Consider this se
[
https://issues.apache.org/jira/browse/KAFKA-12211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-12211:
Component/s: streams
> NoSuchFileException will be thrown if hasPersistentStores is false
[
https://issues.apache.org/jira/browse/KAFKA-12213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-12213:
Labels: needs-kip (was: )
> Kafka Streams aggregation Initializer to accept record key
>
vvcephei commented on a change in pull request #9911:
URL: https://github.com/apache/kafka/pull/9911#discussion_r558572032
##
File path: tests/kafkatest/tests/streams/streams_optimized_test.py
##
@@ -65,30 +66,41 @@ def test_upgrade_optimized_topology(self):
processo
vvcephei commented on pull request #9911:
URL: https://github.com/apache/kafka/pull/9911#issuecomment-761180464
I confirmed this change works both positively and negatively:
```
SESSION REPORT (ALL
[
https://issues.apache.org/jira/browse/KAFKA-12213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17266335#comment-17266335
]
Matthias J. Sax commented on KAFKA-12213:
-
[~MonCalamari] – thanks for creating
ijuma merged pull request #9715:
URL: https://github.com/apache/kafka/pull/9715
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
mjsax commented on pull request #9908:
URL: https://github.com/apache/kafka/pull/9908#issuecomment-761181578
Thanks for the PR @jCalamari - I left a more detailed comment on the Jira
ticket. We cannot just merge public API changes without a KIP. There is KIP-149
and KIP-159 that overlap w
mjsax edited a comment on pull request #9908:
URL: https://github.com/apache/kafka/pull/9908#issuecomment-761181578
Thanks for the PR @jCalamari - I left a more detailed comment on the Jira
ticket. We cannot just merge public API changes without a KIP. (Also your PR
would be provide backw
mjsax edited a comment on pull request #9908:
URL: https://github.com/apache/kafka/pull/9908#issuecomment-761181578
Thanks for the PR @jCalamari - I left a more detailed comment on the Jira
ticket. We cannot just merge public API changes without a KIP. (Also your PR
would not provide API
jsancio commented on pull request #9819:
URL: https://github.com/apache/kafka/pull/9819#issuecomment-761183234
Replying to https://github.com/apache/kafka/pull/9819#issuecomment-761119104
Thanks @hachikuji for thinking about this and for giving a detail reply. For
the long term solut
vvcephei commented on pull request #9911:
URL: https://github.com/apache/kafka/pull/9911#issuecomment-761183334
Hey @bbejeck , I don't suppose you have time for a review of this, since you
had come context?
This is an automa
cmccabe merged pull request #9900:
URL: https://github.com/apache/kafka/pull/9900
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
[
https://issues.apache.org/jira/browse/KAFKA-12208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin McCabe resolved KAFKA-12208.
--
Fix Version/s: 2.8.0
Resolution: Fixed
> Rename AdminManager to ZkAdminManager
> --
[
https://issues.apache.org/jira/browse/KAFKA-12208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin McCabe reassigned KAFKA-12208:
Assignee: Colin McCabe
> Rename AdminManager to ZkAdminManager
>
cmccabe commented on a change in pull request #9883:
URL: https://github.com/apache/kafka/pull/9883#discussion_r558590756
##
File path: core/src/main/scala/kafka/server/KafkaConfig.scala
##
@@ -1453,6 +1456,23 @@ class KafkaConfig(val props: java.util.Map[_, _], doLog:
Boolean
cmccabe commented on pull request #9883:
URL: https://github.com/apache/kafka/pull/9883#issuecomment-761195905
LGTM. I had one small comment.
Thanks, @hachikuji
This is an automated message from the Apache Git Servic
hachikuji opened a new pull request #9912:
URL: https://github.com/apache/kafka/pull/9912
Since we factored out `RequestHandlerHelper`, we may as well make use of it
in `TestRaftRequestHandler`.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and impleme
ableegoldman commented on a change in pull request #9848:
URL: https://github.com/apache/kafka/pull/9848#discussion_r558592503
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java
##
@@ -471,135 +470,22 @@ private boole
ableegoldman commented on pull request #9848:
URL: https://github.com/apache/kafka/pull/9848#issuecomment-761198037
@cadonna looks like `checkstyleTest` is failing
This is an automated message from the Apache Git Service.
To
ableegoldman commented on a change in pull request #9895:
URL: https://github.com/apache/kafka/pull/9895#discussion_r558598465
##
File path: docs/ops.html
##
@@ -2032,17 +2032,26 @@ RocksDB
Metrics
- All of the following metrics have a recording level of debug.
- The metrics
Colin McCabe created KAFKA-12214:
Summary: Generated code does not include UUID or struct fields in
its toString output
Key: KAFKA-12214
URL: https://issues.apache.org/jira/browse/KAFKA-12214
Project:
jsancio commented on a change in pull request #9881:
URL: https://github.com/apache/kafka/pull/9881#discussion_r558601210
##
File path: core/src/main/scala/kafka/raft/RaftManager.scala
##
@@ -168,30 +166,20 @@ class KafkaRaftManager[T](
}
private def buildRaftClient():
1 - 100 of 143 matches
Mail list logo
