hachikuji commented on a change in pull request #9600:
URL: https://github.com/apache/kafka/pull/9600#discussion_r558529073
##########
File path:
core/src/test/scala/unit/kafka/server/AbstractApiVersionsRequestTest.scala
##########
@@ -25,6 +27,15 @@ import scala.jdk.CollectionConverters._
abstract class AbstractApiVersionsRequestTest extends BaseRequestTest {
+ // Configure control plane listener to make sure we have separate listeners
from client,
+ // in order to avoid returning Envelope API version.
Review comment:
It is a little strange for the test case to have a dependence on this.
It seems we should be testing the inter-broker listener as well? I think I
would instead try to modify failing assertions so that they assert the right
thing depending on the listener config.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
