chia7712 commented on a change in pull request #9714:
URL: https://github.com/apache/kafka/pull/9714#discussion_r539086381
##
File path:
clients/src/main/java/org/apache/kafka/common/network/SizeDelimitedSend.java
##
@@ -14,18 +14,22 @@
* See the License for the specific lan
chia7712 edited a comment on pull request #9435:
URL: https://github.com/apache/kafka/pull/9435#issuecomment-741600635
> I thought my suggested comment in the following was clear and concise, but
I'm interested in other opinions:
> #9435 (comment)
@ijuma Sorry that I neglected tha
chia7712 commented on pull request #8552:
URL: https://github.com/apache/kafka/pull/8552#issuecomment-741639187
@dengziming The docs fix LGTM. Maybe we can merge the code about docs fix.
The issue about ```isTraceEnabled``` can be addressed in another PR. WDYT?
---
chia7712 commented on pull request #9494:
URL: https://github.com/apache/kafka/pull/9494#issuecomment-741642937
> the process is not terminating after successful ACL operation.
@senthilm-ms Pardon me. Are there running thread which is not terminated?
---
dajac commented on a change in pull request #9628:
URL: https://github.com/apache/kafka/pull/9628#discussion_r539138004
##
File path: core/src/test/scala/unit/kafka/server/ClientQuotasRequestTest.scala
##
@@ -223,8 +279,34 @@ class ClientQuotasRequestTest extends BaseRequestTes
dengziming commented on pull request #8552:
URL: https://github.com/apache/kafka/pull/8552#issuecomment-741646665
> @dengziming The docs fix LGTM. Maybe we can merge the code about docs fix.
The issue about `isTraceEnabled` can be addressed in another PR. WDYT?
Thank you for your suggest
[
https://issues.apache.org/jira/browse/KAFKA-5386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17246388#comment-17246388
]
Clément MATHIEU commented on KAFKA-5386:
Thanks for the clarification, it matches
lmr3796 commented on pull request #9435:
URL: https://github.com/apache/kafka/pull/9435#issuecomment-741649483
Hi thanks @ijuma @chia7712 ,
I updated the comments accordingly to make it more concise and rebased
latest trunk.
Please let me know if there are any other issues.
chia7712 commented on pull request #8742:
URL: https://github.com/apache/kafka/pull/8742#issuecomment-741650880
This PR may be invalid in trunk branch since ```zkClient``` is required (
see
https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/admin/ConfigCommand.scala#L149)
chia7712 commented on a change in pull request #7641:
URL: https://github.com/apache/kafka/pull/7641#discussion_r539153408
##
File path:
core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala
##
@@ -791,52 +797,52 @@ class GroupMetadataManager(brokerId: Int,
[
https://issues.apache.org/jira/browse/KAFKA-7540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17246404#comment-17246404
]
Bruno Cadonna commented on KAFKA-7540:
--
https://github.com/apache/kafka/pull/9696/ch
cadonna commented on pull request #9696:
URL: https://github.com/apache/kafka/pull/9696#issuecomment-741660036
Unrelated test failure of a known flaky test
`kafka.api.ConsumerBounceTest.testClose` in JDK 8.
@chia7712 Could you merge this PR?
--
chia7712 merged pull request #9696:
URL: https://github.com/apache/kafka/pull/9696
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
chia7712 commented on pull request #9696:
URL: https://github.com/apache/kafka/pull/9696#issuecomment-741661396
@lct45 Thanks for your patch. Merge it to trunk!
This is an automated message from the Apache Git Service.
To res
chia7712 closed pull request #3958:
URL: https://github.com/apache/kafka/pull/3958
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
chia7712 closed pull request #2748:
URL: https://github.com/apache/kafka/pull/2748
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
chia7712 commented on pull request #2748:
URL: https://github.com/apache/kafka/pull/2748#issuecomment-741665929
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
chia7712 commented on pull request #1820:
URL: https://github.com/apache/kafka/pull/1820#issuecomment-741668772
@SinghAsDev Thanks for your patch. The related code was removed by
https://github.com/apache/kafka/commit/f4e9c84c52fbb7ec6a4ca50c9ac35cacbd0df082
so I'm going to close this PR.
chia7712 closed pull request #1820:
URL: https://github.com/apache/kafka/pull/1820
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
dajac commented on pull request #9689:
URL: https://github.com/apache/kafka/pull/9689#issuecomment-741692045
cc @chia7712 @hachikuji
This is an automated message from the Apache Git Service.
To respond to the message, please
[
https://issues.apache.org/jira/browse/KAFKA-10768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17246462#comment-17246462
]
Chia-Ping Tsai commented on KAFKA-10768:
[~parth017] Are you working at this iss
chia7712 commented on a change in pull request #9689:
URL: https://github.com/apache/kafka/pull/9689#discussion_r539254641
##
File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala
##
@@ -160,7 +161,9 @@ abstract class AbstractFetcherThread(name: String,
chia7712 merged pull request #5435:
URL: https://github.com/apache/kafka/pull/5435
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
chia7712 commented on pull request #9435:
URL: https://github.com/apache/kafka/pull/9435#issuecomment-741744599
> I updated the comments accordingly to make it more concise and rebased
latest trunk.
Please let me know if there are any other issues.
@lmr3796 Thanks for updating. wa
mumrah commented on a change in pull request #9715:
URL: https://github.com/apache/kafka/pull/9715#discussion_r539295919
##
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##
@@ -98,6 +97,7 @@ import scala.annotation.nowarn
* Logic to handle the various Kafka requ
[
https://issues.apache.org/jira/browse/KAFKA-7888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17246535#comment-17246535
]
Tomas Matejovic commented on KAFKA-7888:
[~kemalerden] What backup do you mean? C
ijuma commented on a change in pull request #9714:
URL: https://github.com/apache/kafka/pull/9714#discussion_r539323586
##
File path:
clients/src/main/java/org/apache/kafka/common/network/SizeDelimitedSend.java
##
@@ -14,18 +14,22 @@
* See the License for the specific langua
[
https://issues.apache.org/jira/browse/KAFKA-7888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17246535#comment-17246535
]
Tomas Matejovic edited comment on KAFKA-7888 at 12/9/20, 1:53 PM:
-
[
https://issues.apache.org/jira/browse/KAFKA-7888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17246535#comment-17246535
]
Tomas Matejovic edited comment on KAFKA-7888 at 12/9/20, 1:53 PM:
-
ijuma commented on a change in pull request #9714:
URL: https://github.com/apache/kafka/pull/9714#discussion_r539323586
##
File path:
clients/src/main/java/org/apache/kafka/common/network/SizeDelimitedSend.java
##
@@ -14,18 +14,22 @@
* See the License for the specific langua
mumrah commented on a change in pull request #9715:
URL: https://github.com/apache/kafka/pull/9715#discussion_r539329604
##
File path: core/src/main/scala/kafka/server/KafkaRequestHandler.scala
##
@@ -34,6 +34,10 @@ trait ApiRequestHandler {
def handle(request: RequestChanne
mumrah commented on pull request #9715:
URL: https://github.com/apache/kafka/pull/9715#issuecomment-741791066
@chia7712 thanks for the feedback. I've incorporated your suggestions, can
you take another look?
This is an autom
ijuma commented on pull request #9718:
URL: https://github.com/apache/kafka/pull/9718#issuecomment-741791486
Good catch. This looks a bit error prone. Should we be moving some of these
methods to the companion object or something?
--
ijuma commented on pull request #9671:
URL: https://github.com/apache/kafka/pull/9671#issuecomment-741798735
Is this a 2.7.0 blocker? cc @bbejeck
This is an automated message from the Apache Git Service.
To respond to the me
[
https://issues.apache.org/jira/browse/KAFKA-10827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17246558#comment-17246558
]
Ismael Juma commented on KAFKA-10827:
-
cc [~ableegoldman] and [~guozhang] who were l
chia7712 commented on pull request #9714:
URL: https://github.com/apache/kafka/pull/9714#issuecomment-741804931
+ 1 to latest commit
This is an automated message from the Apache Git Service.
To respond to the message, please
bertber commented on a change in pull request #9699:
URL: https://github.com/apache/kafka/pull/9699#discussion_r539354420
##
File path: core/src/main/scala/kafka/tools/StreamsResetter.java
##
@@ -491,17 +491,8 @@ private void resetByDuration(final Consumer client,
ijuma commented on pull request #9435:
URL: https://github.com/apache/kafka/pull/9435#issuecomment-741810105
@chia7712 feel free to merge if it looks good to you. Thanks @lmr3796 for
the patience.
This is an automated messag
ijuma commented on pull request #9701:
URL: https://github.com/apache/kafka/pull/9701#issuecomment-741826230
@tombentley Done.
This is an automated message from the Apache Git Service.
To respond to the message, please log on
ijuma commented on a change in pull request #9715:
URL: https://github.com/apache/kafka/pull/9715#discussion_r539390329
##
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##
@@ -98,6 +97,7 @@ import scala.annotation.nowarn
* Logic to handle the various Kafka reque
ijuma commented on pull request #9703:
URL: https://github.com/apache/kafka/pull/9703#issuecomment-741836419
Thanks for the PR. I don't see `responses` being removed.
This is an automated message from the Apache Git Service.
ijuma commented on pull request #9702:
URL: https://github.com/apache/kafka/pull/9702#issuecomment-741836921
cc @bbejeck @niteshmor
This is an automated message from the Apache Git Service.
To respond to the message, please
ijuma commented on a change in pull request #9694:
URL: https://github.com/apache/kafka/pull/9694#discussion_r539394353
##
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##
@@ -2509,12 +2509,10 @@ class KafkaApis(val requestChannel: RequestChannel,
.se
chia7712 commented on a change in pull request #9715:
URL: https://github.com/apache/kafka/pull/9715#discussion_r539362958
##
File path: core/src/main/scala/kafka/network/RequestChannel.scala
##
@@ -432,6 +432,43 @@ class RequestChannel(val queueSize: Int,
}
}
+ def
chia7712 merged pull request #9435:
URL: https://github.com/apache/kafka/pull/9435
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
chia7712 commented on pull request #9435:
URL: https://github.com/apache/kafka/pull/9435#issuecomment-741847741
@Lincong @lmr3796 Thanks for your efforts!
This is an automated message from the Apache Git Service.
To respond t
[
https://issues.apache.org/jira/browse/KAFKA-10606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-10606.
Fix Version/s: 2.7.0
Resolution: Fixed
> Auto create non-existent topics when fetch
ijuma commented on a change in pull request #9517:
URL: https://github.com/apache/kafka/pull/9517#discussion_r539415671
##
File path:
clients/src/main/java/org/apache/kafka/common/security/authenticator/SaslClientAuthenticator.java
##
@@ -612,6 +612,9 @@ private void
handleSa
ijuma commented on a change in pull request #9520:
URL: https://github.com/apache/kafka/pull/9520#discussion_r539416139
##
File path: clients/src/test/java/org/apache/kafka/clients/NetworkClientTest.java
##
@@ -117,13 +118,12 @@ public void setup() {
selector.reset();
chia7712 commented on a change in pull request #9694:
URL: https://github.com/apache/kafka/pull/9694#discussion_r539416849
##
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##
@@ -2509,12 +2509,10 @@ class KafkaApis(val requestChannel: RequestChannel,
ijuma commented on pull request #9620:
URL: https://github.com/apache/kafka/pull/9620#issuecomment-741859826
It's a bit hard to know when the Lazy version can be used though, right?
This is an automated message from the Apach
chia7712 commented on a change in pull request #9517:
URL: https://github.com/apache/kafka/pull/9517#discussion_r539420751
##
File path:
clients/src/main/java/org/apache/kafka/common/security/authenticator/SaslClientAuthenticator.java
##
@@ -612,6 +612,9 @@ private void
handl
chia7712 commented on a change in pull request #9520:
URL: https://github.com/apache/kafka/pull/9520#discussion_r539422760
##
File path: clients/src/test/java/org/apache/kafka/clients/NetworkClientTest.java
##
@@ -117,13 +118,12 @@ public void setup() {
selector.reset(
ijuma commented on pull request #9516:
URL: https://github.com/apache/kafka/pull/9516#issuecomment-741864178
For some reason, I can't add a comment to the previous discussion. In my
opinion TransportLayer is a fat interface and it seems like a step back to
require it in so many places. Are
ijuma commented on pull request #9548:
URL: https://github.com/apache/kafka/pull/9548#issuecomment-741865282
I think I'll have time to look into this later this week.
This is an automated message from the Apache Git Service.
ijuma commented on a change in pull request #9715:
URL: https://github.com/apache/kafka/pull/9715#discussion_r539429096
##
File path: core/src/main/scala/kafka/server/KafkaRequestHandler.scala
##
@@ -34,6 +34,10 @@ trait ApiRequestHandler {
def handle(request: RequestChannel
chia7712 commented on pull request #9620:
URL: https://github.com/apache/kafka/pull/9620#issuecomment-741868042
> It's a bit hard to know when the Lazy version can be used though, right?
You are right :(
Will go back when I have a better idea.
ijuma commented on pull request #9715:
URL: https://github.com/apache/kafka/pull/9715#issuecomment-741871617
Note that the goal here is not to reduce `KafkaApis` footprint, it is to
allow reuse from `ControllerApis`. The latter is required for the KIP-500
effort. I think it makes sense to
mumrah commented on a change in pull request #9715:
URL: https://github.com/apache/kafka/pull/9715#discussion_r539437410
##
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##
@@ -98,6 +97,7 @@ import scala.annotation.nowarn
* Logic to handle the various Kafka requ
chia7712 commented on pull request #9715:
URL: https://github.com/apache/kafka/pull/9715#issuecomment-741876404
> I think it makes sense to go with a simple change here that extracts
commonly used methods. If we want to discuss breaking up KafkaApis, that is a
fair discussion, but can happ
chia7712 commented on pull request #9516:
URL: https://github.com/apache/kafka/pull/9516#issuecomment-741877277
> Are hasPendingWrites and transferFrom the only methods we cast in order
to access at the moment?
yes
T
splett2 commented on a change in pull request #9628:
URL: https://github.com/apache/kafka/pull/9628#discussion_r539455602
##
File path: core/src/main/scala/kafka/server/AdminManager.scala
##
@@ -920,32 +954,57 @@ class AdminManager(val config: KafkaConfig,
!name.isDefi
ijuma commented on a change in pull request #9516:
URL: https://github.com/apache/kafka/pull/9516#discussion_r539458932
##
File path:
clients/src/main/java/org/apache/kafka/common/network/NetworkReceive.java
##
@@ -89,7 +88,8 @@ public boolean complete() {
return !siz
ijuma commented on pull request #9516:
URL: https://github.com/apache/kafka/pull/9516#issuecomment-741891195
Maybe we can introduce an interface that only adds `hasPendingWrites` and
`transferFrom`. Then use that on the `Send` side. And revert the changes on the
`Receive` side.
-
[
https://issues.apache.org/jira/browse/KAFKA-10772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17246677#comment-17246677
]
Bruno Cadonna commented on KAFKA-10772:
---
I think, I found the bug. If a static mem
lisa2lisa opened a new pull request #9719:
URL: https://github.com/apache/kafka/pull/9719
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing
tombentley commented on pull request #9701:
URL: https://github.com/apache/kafka/pull/9701#issuecomment-741954740
Thanks @ijuma, I've opened
https://cwiki.apache.org/confluence/display/KAFKA/KIP-697%3A+Stricter+parsing+of+addresses+in+configs,
targetting 3.0.
---
tombentley closed pull request #9701:
URL: https://github.com/apache/kafka/pull/9701
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
[
https://issues.apache.org/jira/browse/KAFKA-10713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tom Bentley updated KAFKA-10713:
Fix Version/s: (was: 2.8.0)
> Surprising behaviour when bootstrap servers are separated by sem
[
https://issues.apache.org/jira/browse/KAFKA-10713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tom Bentley reopened KAFKA-10713:
-
> Surprising behaviour when bootstrap servers are separated by semicolons
>
g1geordie commented on pull request #9707:
URL: https://github.com/apache/kafka/pull/9707#issuecomment-741968372
@chia7712 thanks again
This is an automated message from the Apache Git Service.
To respond to the message, pl
niteshmor commented on pull request #9702:
URL: https://github.com/apache/kafka/pull/9702#issuecomment-741973244
Thanks @sirocchj, you beat me to it for this upgrade request.
For older branches, these are the current versions of jackson databind in
use:
```
2.1:2.9.8
hachikuji commented on pull request #9621:
URL: https://github.com/apache/kafka/pull/9621#issuecomment-741974252
@bristy Thanks for the patch. I'd suggest changing to this:
```java
try {
fileChannel.write(buffer)
fileChannel.force(true)
} finally {
[
https://issues.apache.org/jira/browse/KAFKA-10772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17246741#comment-17246741
]
John Roesler commented on KAFKA-10772:
--
Thanks, [~cadonna] !
The scenario you outl
ableegoldman commented on pull request #9671:
URL: https://github.com/apache/kafka/pull/9671#issuecomment-741977437
@ijuma no, I don't think it should be a 2.7 blocker. It's definitely not a
regression, AFAICT this has been around since the beginning. And a restart of
the client will get i
bristy commented on a change in pull request #9621:
URL: https://github.com/apache/kafka/pull/9621#discussion_r539562607
##
File path: core/src/main/scala/kafka/log/ProducerStateManager.scala
##
@@ -437,7 +437,7 @@ object ProducerStateManager {
val fileChannel = FileChan
bristy commented on a change in pull request #9621:
URL: https://github.com/apache/kafka/pull/9621#discussion_r539562607
##
File path: core/src/main/scala/kafka/log/ProducerStateManager.scala
##
@@ -437,7 +437,7 @@ object ProducerStateManager {
val fileChannel = FileChan
guozhangwang commented on a change in pull request #9671:
URL: https://github.com/apache/kafka/pull/9671#discussion_r539567098
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java
##
@@ -853,7 +844,7 @@ public void onSuccess(
guozhangwang commented on a change in pull request #9671:
URL: https://github.com/apache/kafka/pull/9671#discussion_r539568378
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java
##
@@ -248,18 +243,26 @@ protected synchroniz
ijuma commented on pull request #9714:
URL: https://github.com/apache/kafka/pull/9714#issuecomment-741989016
Tests passed, merging to trunk.
This is an automated message from the Apache Git Service.
To respond to the message,
ijuma merged pull request #9714:
URL: https://github.com/apache/kafka/pull/9714
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
guozhangwang merged pull request #9711:
URL: https://github.com/apache/kafka/pull/9711
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
guozhangwang commented on pull request #9711:
URL: https://github.com/apache/kafka/pull/9711#issuecomment-741991812
Thanks for the patch @chia7712 . LGTM!
This is an automated message from the Apache Git Service.
To respond t
ijuma commented on pull request #9671:
URL: https://github.com/apache/kafka/pull/9671#issuecomment-741993693
> And a restart of the client will get it out of the bad state
This is a massive deal though, right?
This is
vvcephei commented on a change in pull request #9697:
URL: https://github.com/apache/kafka/pull/9697#discussion_r539583538
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -444,6 +444,25 @@ private void handleStreamsUncaughtException(final
T
vvcephei commented on a change in pull request #9697:
URL: https://github.com/apache/kafka/pull/9697#discussion_r539584371
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -444,6 +444,18 @@ private void handleStreamsUncaughtException(final
T
[
https://issues.apache.org/jira/browse/KAFKA-10827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17246777#comment-17246777
]
Guozhang Wang commented on KAFKA-10827:
---
[~jaebinyo] I think your reasoning is rig
guozhangwang commented on pull request #9640:
URL: https://github.com/apache/kafka/pull/9640#issuecomment-742006637
@ableegoldman could you also take a look at this PR? Thanks!
This is an automated message from the Apache Git
kowshik commented on pull request #9718:
URL: https://github.com/apache/kafka/pull/9718#issuecomment-742008769
@ijuma Good idea. I can move `Log.rebuildProducerState` into the `Log`
companion object, and consequently the following methods will move too:
`Log.loadProducersFromLog` and `Log.
Kowshik Prakasam created KAFKA-10832:
Summary: Recovery logic is using incorrect ProducerStateManager
instance when updating producers
Key: KAFKA-10832
URL: https://issues.apache.org/jira/browse/KAFKA-10832
vvcephei commented on a change in pull request #9697:
URL: https://github.com/apache/kafka/pull/9697#discussion_r539615678
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/StreamsUncaughtExceptionHandlerIntegrationTest.java
##
@@ -202,6 +213,28 @@ priva
[
https://issues.apache.org/jira/browse/KAFKA-10772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17246797#comment-17246797
]
Bruno Cadonna commented on KAFKA-10772:
---
I think this issue is fixed for brokers 2
[
https://issues.apache.org/jira/browse/KAFKA-10772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17246797#comment-17246797
]
Bruno Cadonna edited comment on KAFKA-10772 at 12/9/20, 8:20 PM:
-
[
https://issues.apache.org/jira/browse/KAFKA-10772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17246797#comment-17246797
]
Bruno Cadonna edited comment on KAFKA-10772 at 12/9/20, 8:22 PM:
-
[
https://issues.apache.org/jira/browse/KAFKA-10772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17246797#comment-17246797
]
Bruno Cadonna edited comment on KAFKA-10772 at 12/9/20, 8:22 PM:
-
sirocchj commented on pull request #9702:
URL: https://github.com/apache/kafka/pull/9702#issuecomment-742027911
Sounds good to me @niteshmor
Want me to open them as separate PRs and as fast follows to this or what do
you propose?
PS: I did see we needed to jump a few patch release
sirocchj edited a comment on pull request #9702:
URL: https://github.com/apache/kafka/pull/9702#issuecomment-742027911
Sounds good to me @niteshmor
Want me to open them as separate PRs and as fast follows to this or what do
you propose?
PS: I did see we needed to jump a few patch
[
https://issues.apache.org/jira/browse/KAFKA-10772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17246806#comment-17246806
]
Bruno Cadonna commented on KAFKA-10772:
---
bq. It seems bad, and quite possibly a re
[
https://issues.apache.org/jira/browse/KAFKA-10772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17246806#comment-17246806
]
Bruno Cadonna edited comment on KAFKA-10772 at 12/9/20, 8:35 PM:
-
wcarlson5 commented on a change in pull request #9697:
URL: https://github.com/apache/kafka/pull/9697#discussion_r539636011
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -444,6 +444,18 @@ private void handleStreamsUncaughtException(final
1 - 100 of 154 matches
Mail list logo
