ijuma commented on a change in pull request #9516:
URL: https://github.com/apache/kafka/pull/9516#discussion_r539458932
##########
File path:
clients/src/main/java/org/apache/kafka/common/network/NetworkReceive.java
##########
@@ -89,7 +88,8 @@ public boolean complete() {
return !size.hasRemaining() && buffer != null &&
!buffer.hasRemaining();
}
- public long readFrom(ScatteringByteChannel channel) throws IOException {
+ @Override
+ public long readFrom(TransportLayer channel) throws IOException {
Review comment:
Do we need to change this? It seems like what we had before was good
enough.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
