Chia-Ping Tsai created KAFKA-10815:
--
Summary: EosTestDriver#verifyAllTransactionFinished should break
loop if all partitions are verified
Key: KAFKA-10815
URL: https://issues.apache.org/jira/browse/KAFKA-10815
chia7712 opened a new pull request #9706:
URL: https://github.com/apache/kafka/pull/9706
If we don't break it when all partitions are verified, the loop will take 10
mins ...
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Ve
chia7712 edited a comment on pull request #9686:
URL: https://github.com/apache/kafka/pull/9686#issuecomment-738813070
@hachikuji It seems the free plan of Travis CI can't support Kafka system
tests totally. Not sure whether we can get more free resources from Travis CI?
If not, maybe we s
chia7712 commented on pull request #9686:
URL: https://github.com/apache/kafka/pull/9686#issuecomment-739773295
the timeout ```StreamsEosTest``` is traced by #9706
This is an automated message from the Apache Git Service.
To
tombentley commented on pull request #9701:
URL: https://github.com/apache/kafka/pull/9701#issuecomment-739816502
OK, but then we either:
1. Make it literally any character, and mark KAFKA-10713 as won't fix, or
2. Make it any character except `;`, in order to prevent KAFKA-10713,
g1geordie opened a new pull request #9707:
URL: https://github.com/apache/kafka/pull/9707
KafkaProducer.flush method in callback will cause deadlock .
because flush method wait the future complete
``` java
// KafkaProducer
public void flush() {
.
try {
g1geordie commented on pull request #9707:
URL: https://github.com/apache/kafka/pull/9707#issuecomment-739827572
@chia7712 Can you help me review?
This is an automated message from the Apache Git Service.
To respond to the me
rhauch commented on a change in pull request #9698:
URL: https://github.com/apache/kafka/pull/9698#discussion_r537598810
##
File path:
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorConnectorsIntegrationTest.java
##
@@ -75,14 +74,45 @@
private static f
rhauch commented on a change in pull request #9698:
URL: https://github.com/apache/kafka/pull/9698#discussion_r537599704
##
File path:
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorConnectorsIntegrationTest.java
##
@@ -194,20 +224,27 @@ private void
waitU
rhauch merged pull request #9698:
URL: https://github.com/apache/kafka/pull/9698
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[
https://issues.apache.org/jira/browse/KAFKA-1043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17245298#comment-17245298
]
highluck commented on KAFKA-1043:
-
[~guozhang]
Is this still a problem?
> Time-consumin
dajac commented on a change in pull request #9628:
URL: https://github.com/apache/kafka/pull/9628#discussion_r537615504
##
File path: core/src/main/scala/kafka/admin/ConfigCommand.scala
##
@@ -864,11 +885,21 @@ object ConfigCommand extends Config {
}
}
+
dajac commented on a change in pull request #9628:
URL: https://github.com/apache/kafka/pull/9628#discussion_r537615920
##
File path: core/src/main/scala/kafka/server/AdminManager.scala
##
@@ -920,32 +954,51 @@ class AdminManager(val config: KafkaConfig,
!name.isDefine
[
https://issues.apache.org/jira/browse/KAFKA-9259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17245308#comment-17245308
]
highluck commented on KAFKA-9259:
-
[~omanges]
Are you working on this task?
> suppress(
[
https://issues.apache.org/jira/browse/KAFKA-10769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17245313#comment-17245313
]
highluck commented on KAFKA-10769:
--
[~parth017]
Are you working on this task?
> Remov
rajinisivaram commented on pull request #9678:
URL: https://github.com/apache/kafka/pull/9678#issuecomment-740016267
@omkreddy Thanks for the review, merging to trunk.
This is an automated message from the Apache Git Service.
rajinisivaram merged pull request #9678:
URL: https://github.com/apache/kafka/pull/9678
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/KAFKA-10798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rajini Sivaram resolved KAFKA-10798.
Reviewer: Manikumar
Resolution: Fixed
> Failed authentication delay doesn't work wit
[
https://issues.apache.org/jira/browse/KAFKA-10575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17245318#comment-17245318
]
highluck commented on KAFKA-10575:
--
[~Yohan123]
Are you working on this task?
> State
[
https://issues.apache.org/jira/browse/KAFKA-10575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
highluck reassigned KAFKA-10575:
Assignee: highluck
> StateRestoreListener#onRestoreEnd should always be triggered
> -
d8tltanc commented on pull request #9485:
URL: https://github.com/apache/kafka/pull/9485#issuecomment-740036778
https://paste.ubuntu.com/p/zKYc6rk6WY/
Benchmark with AclAuthorizer::updateCache
With aclCount=50 and resourceCount=20,
20 call to updateCache took ~35
d8tltanc commented on a change in pull request #9485:
URL: https://github.com/apache/kafka/pull/9485#discussion_r537657552
##
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##
@@ -2109,7 +2104,8 @@ class KafkaApis(val requestChannel: RequestChannel,
sendEr
d8tltanc commented on a change in pull request #9485:
URL: https://github.com/apache/kafka/pull/9485#discussion_r537667755
##
File path: core/src/main/scala/kafka/security/authorizer/AclAuthorizer.scala
##
@@ -550,6 +660,31 @@ class AclAuthorizer extends Authorizer with Logging
Randall Hauch created KAFKA-10816:
-
Summary: Connect REST API should have a resource that can be used
as a readiness probe
Key: KAFKA-10816
URL: https://issues.apache.org/jira/browse/KAFKA-10816
Proje
d8tltanc commented on pull request #9485:
URL: https://github.com/apache/kafka/pull/9485#issuecomment-740056125
Hi @rajinisivaram. Thanks for the detailed review! I’ve addressed all
comments you left. Also, after some optimization on the `resourceCache`, the
benchmark looks much better now
[
https://issues.apache.org/jira/browse/KAFKA-10816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Randall Hauch updated KAFKA-10816:
--
Description:
There are a few ways to accurately detect whether a Connect worker is
*completel
[
https://issues.apache.org/jira/browse/KAFKA-10811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Randall Hauch updated KAFKA-10811:
--
Affects Version/s: (was: 2.5.1)
(was: 2.6.0)
> System exit from
[
https://issues.apache.org/jira/browse/KAFKA-10811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Randall Hauch updated KAFKA-10811:
--
Fix Version/s: (was: 2.6.1)
(was: 2.5.2)
> System exit from MirrorC
Jason Gustafson created KAFKA-10817:
---
Summary: Add clusterId validation to Fetch handling
Key: KAFKA-10817
URL: https://issues.apache.org/jira/browse/KAFKA-10817
Project: Kafka
Issue Type:
hachikuji commented on a change in pull request #9693:
URL: https://github.com/apache/kafka/pull/9693#discussion_r537704021
##
File path: core/src/main/scala/kafka/server/ZkIsrManager.scala
##
@@ -0,0 +1,51 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
lct45 opened a new pull request #9708:
URL: https://github.com/apache/kafka/pull/9708
Adds `withLoggingEnabled` and `withLoggingDisabled` for `StreamJoined` to
give `StreamJoined` the same flexibility as `Materialized`
This
hachikuji commented on a change in pull request #9564:
URL: https://github.com/apache/kafka/pull/9564#discussion_r537709868
##
File path: core/src/main/scala/kafka/server/AlterIsrManager.scala
##
@@ -88,20 +88,33 @@ class AlterIsrManagerImpl(val controllerChannelManager:
Broke
hachikuji opened a new pull request #9709:
URL: https://github.com/apache/kafka/pull/9709
We should configure a reconnect backoff for controller connections to
prevent tight reconnect loops when the controller cannot be reached. I have
borrowed the same configuration we use in `Transaction
hachikuji commented on a change in pull request #9539:
URL: https://github.com/apache/kafka/pull/9539#discussion_r537742991
##
File path: clients/src/main/resources/common/message/LeaderChangeMessage.json
##
@@ -22,7 +22,11 @@
{"name": "LeaderId", "type": "int32", "version
[
https://issues.apache.org/jira/browse/KAFKA-10772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17245456#comment-17245456
]
John Roesler commented on KAFKA-10772:
--
Hey [~bbejeck] , this might be a bit aggres
[
https://issues.apache.org/jira/browse/KAFKA-10772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Roesler updated KAFKA-10772:
-
Priority: Blocker (was: Major)
> java.lang.IllegalStateException: There are insufficient bytes
[
https://issues.apache.org/jira/browse/KAFKA-10772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Roesler updated KAFKA-10772:
-
Fix Version/s: 2.7.0
> java.lang.IllegalStateException: There are insufficient bytes available t
mumrah commented on pull request #9693:
URL: https://github.com/apache/kafka/pull/9693#issuecomment-740123591
@hachikuji yes indeed. I just pushed a commit which does just that (removes
PartitionStateStore)
I also pushed a change which relocates the ISR propagation logic to
ZkIsrMan
[
https://issues.apache.org/jira/browse/KAFKA-10772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17245460#comment-17245460
]
Bill Bejeck commented on KAFKA-10772:
-
Hi [~vvcephei],
Since this appears to be an
[
https://issues.apache.org/jira/browse/KAFKA-10772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bill Bejeck updated KAFKA-10772:
Fix Version/s: (was: 2.7.0)
> java.lang.IllegalStateException: There are insufficient bytes av
hachikuji commented on a change in pull request #9512:
URL: https://github.com/apache/kafka/pull/9512#discussion_r537757487
##
File path: raft/src/test/java/org/apache/kafka/raft/MockLog.java
##
@@ -472,4 +490,106 @@ private EpochStartOffset(int epoch, long startOffset) {
[
https://issues.apache.org/jira/browse/KAFKA-10715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17245470#comment-17245470
]
Ravindra Nath Kakarla commented on KAFKA-10715:
---
Can I contribute this cha
hachikuji commented on a change in pull request #9590:
URL: https://github.com/apache/kafka/pull/9590#discussion_r537776855
##
File path:
clients/src/main/java/org/apache/kafka/common/record/MemoryRecords.java
##
@@ -386,6 +390,10 @@ public long maxOffset() {
retu
hachikuji commented on a change in pull request #9564:
URL: https://github.com/apache/kafka/pull/9564#discussion_r537786674
##
File path:
core/src/main/scala/kafka/server/BrokerToControllerChannelManagerImpl.scala
##
@@ -208,7 +209,9 @@ class BrokerToControllerRequestThread(ne
hachikuji commented on a change in pull request #9564:
URL: https://github.com/apache/kafka/pull/9564#discussion_r537788538
##
File path:
core/src/main/scala/kafka/server/BrokerToControllerChannelManagerImpl.scala
##
@@ -34,8 +34,12 @@ import scala.collection.mutable
import s
[
https://issues.apache.org/jira/browse/KAFKA-10792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Randall Hauch updated KAFKA-10792:
--
Fix Version/s: (was: 2.7.1)
> Source tasks can block herder thread by hanging during stop
hachikuji commented on a change in pull request #9564:
URL: https://github.com/apache/kafka/pull/9564#discussion_r537789168
##
File path:
core/src/main/scala/kafka/server/BrokerToControllerChannelManagerImpl.scala
##
@@ -125,15 +129,25 @@ class BrokerToControllerChannelManager
jolshan commented on a change in pull request #9590:
URL: https://github.com/apache/kafka/pull/9590#discussion_r537791276
##
File path:
clients/src/main/java/org/apache/kafka/common/record/MemoryRecords.java
##
@@ -386,6 +390,10 @@ public long maxOffset() {
return
[
https://issues.apache.org/jira/browse/KAFKA-10715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ravindra Nath Kakarla updated KAFKA-10715:
--
Comment: was deleted
(was: Can I contribute this change?)
> Support Kafka con
jolshan commented on a change in pull request #9590:
URL: https://github.com/apache/kafka/pull/9590#discussion_r537799341
##
File path:
clients/src/main/java/org/apache/kafka/common/record/MemoryRecords.java
##
@@ -198,7 +198,7 @@ private static FilterResult filterTo(TopicPart
[
https://issues.apache.org/jira/browse/KAFKA-10715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17245501#comment-17245501
]
Ravindranath Kakarla commented on KAFKA-10715:
--
Can I contribute this chang
APaMio commented on pull request #9705:
URL: https://github.com/apache/kafka/pull/9705#issuecomment-740157289
This request for change the loop index from wraps type to primitive type and
some relative modify, those indices just used to pass as an argument not as an
object, so I thought it`
jolshan commented on a change in pull request #9590:
URL: https://github.com/apache/kafka/pull/9590#discussion_r537799398
##
File path:
clients/src/main/java/org/apache/kafka/common/record/MemoryRecords.java
##
@@ -386,6 +390,10 @@ public long maxOffset() {
return
hachikuji commented on a change in pull request #9590:
URL: https://github.com/apache/kafka/pull/9590#discussion_r537811235
##
File path:
clients/src/main/java/org/apache/kafka/common/record/MemoryRecords.java
##
@@ -198,7 +198,7 @@ private static FilterResult filterTo(TopicPa
[
https://issues.apache.org/jira/browse/KAFKA-10715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ravindranath Kakarla updated KAFKA-10715:
-
Remaining Estimate: 72h (was: 336h)
Original Estimate: 72h (was: 336h)
>
[
https://issues.apache.org/jira/browse/KAFKA-9126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Leah Thomas reassigned KAFKA-9126:
--
Assignee: Leah Thomas
> Extend `StreamJoined` to allow more store configs
> --
[
https://issues.apache.org/jira/browse/KAFKA-9126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Leah Thomas reassigned KAFKA-9126:
--
Assignee: (was: Leah Thomas)
> Extend `StreamJoined` to allow more store configs
> ---
kowshik opened a new pull request #9710:
URL: https://github.com/apache/kafka/pull/9710
Few call sites in `Log.scala` were passing redundant default values when
making calls to `LogSegment.open(...)`. In this PR, I've cleaned these up.
**Test plan:**
Relying on existing unit and i
kowshik commented on pull request #9710:
URL: https://github.com/apache/kafka/pull/9710#issuecomment-740186296
cc @junrao @ijuma for review
This is an automated message from the Apache Git Service.
To respond to the message,
rayokota commented on pull request #9701:
URL: https://github.com/apache/kafka/pull/9701#issuecomment-740192213
Perhaps we should have a KIP and discussion for this since it changes
existing public behavior? In the meantime, we should probably revert the
original PR.
---
d8tltanc edited a comment on pull request #9485:
URL: https://github.com/apache/kafka/pull/9485#issuecomment-740036778
https://paste.ubuntu.com/p/zKYc6rk6WY/
Benchmark with AclAuthorizer::updateCache
With aclCount=50 and resourceCount=20,
20 call to updateCache t
d8tltanc commented on pull request #9485:
URL: https://github.com/apache/kafka/pull/9485#issuecomment-740199487
Benchmark results run against trunk:
https://paste.ubuntu.com/p/zwKyQSrmDX/
This is an automated message f
ijuma commented on a change in pull request #7409:
URL: https://github.com/apache/kafka/pull/7409#discussion_r537867021
##
File path:
clients/src/main/java/org/apache/kafka/common/requests/AbstractRequest.java
##
@@ -95,21 +93,33 @@ public short version() {
return ver
ijuma commented on a change in pull request #7409:
URL: https://github.com/apache/kafka/pull/7409#discussion_r537867972
##
File path:
clients/src/main/java/org/apache/kafka/common/requests/AbstractRequest.java
##
@@ -95,21 +93,33 @@ public short version() {
return ver
hachikuji merged pull request #9512:
URL: https://github.com/apache/kafka/pull/9512
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
ijuma commented on a change in pull request #7409:
URL: https://github.com/apache/kafka/pull/7409#discussion_r537868629
##
File path:
clients/src/main/java/org/apache/kafka/common/requests/AbstractRequest.java
##
@@ -95,21 +93,33 @@ public short version() {
return ver
lct45 commented on a change in pull request #9697:
URL: https://github.com/apache/kafka/pull/9697#discussion_r537899383
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -444,6 +444,27 @@ private void handleStreamsUncaughtException(final
Thro
lct45 commented on a change in pull request #9697:
URL: https://github.com/apache/kafka/pull/9697#discussion_r537899383
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -444,6 +444,27 @@ private void handleStreamsUncaughtException(final
Thro
abbccdda commented on pull request #9564:
URL: https://github.com/apache/kafka/pull/9564#issuecomment-740244739
Hit unrelated stream test failure, retest
This is an automated message from the Apache Git Service.
To respond to
Ismael Juma created KAFKA-10818:
---
Summary: Skip conversion to `Struct` when serializing generated
requests/responses
Key: KAFKA-10818
URL: https://issues.apache.org/jira/browse/KAFKA-10818
Project: Kafk
[
https://issues.apache.org/jira/browse/KAFKA-10818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ismael Juma updated KAFKA-10818:
Fix Version/s: 2.8.0
> Skip conversion to `Struct` when serializing generated requests/responses
>
ijuma merged pull request #7409:
URL: https://github.com/apache/kafka/pull/7409
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
ijuma commented on pull request #7409:
URL: https://github.com/apache/kafka/pull/7409#issuecomment-740248672
Thanks for the review! Will post the follow up in a bit.
This is an automated message from the Apache Git Service.
T
[
https://issues.apache.org/jira/browse/KAFKA-10818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ismael Juma resolved KAFKA-10818.
-
Resolution: Fixed
> Skip conversion to `Struct` when serializing generated requests/responses
>
ableegoldman commented on a change in pull request #9700:
URL: https://github.com/apache/kafka/pull/9700#discussion_r537917953
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java
##
@@ -199,7 +200,9 @@ private void recordSe
[
https://issues.apache.org/jira/browse/KAFKA-10772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17245586#comment-17245586
]
A. Sophie Blee-Goldman commented on KAFKA-10772:
Hey [~lkokhreidze] and/
splett2 commented on a change in pull request #9628:
URL: https://github.com/apache/kafka/pull/9628#discussion_r537937180
##
File path: core/src/test/scala/unit/kafka/admin/ConfigCommandTest.scala
##
@@ -472,6 +512,134 @@ class ConfigCommandTest extends ZooKeeperTestHarness wit
splett2 commented on a change in pull request #9628:
URL: https://github.com/apache/kafka/pull/9628#discussion_r537937603
##
File path: core/src/test/scala/unit/kafka/admin/ConfigCommandTest.scala
##
@@ -472,6 +512,134 @@ class ConfigCommandTest extends ZooKeeperTestHarness wit
[
https://issues.apache.org/jira/browse/KAFKA-10772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17245587#comment-17245587
]
A. Sophie Blee-Goldman commented on KAFKA-10772:
Specifically, I'm looki
splett2 commented on pull request #9628:
URL: https://github.com/apache/kafka/pull/9628#issuecomment-740266395
Thanks for the feedback @dajac
I went ahead and also refactored some tests in `ConfigCommandTest` that were
a bit repetitive.
Let me know what you think
--
junrao merged pull request #9710:
URL: https://github.com/apache/kafka/pull/9710
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
splett2 commented on a change in pull request #9628:
URL: https://github.com/apache/kafka/pull/9628#discussion_r537945058
##
File path: core/src/main/scala/kafka/admin/ConfigCommand.scala
##
@@ -778,6 +793,10 @@ object ConfigCommand extends Config {
val brokerLogger = pars
splett2 commented on a change in pull request #9628:
URL: https://github.com/apache/kafka/pull/9628#discussion_r537945058
##
File path: core/src/main/scala/kafka/admin/ConfigCommand.scala
##
@@ -778,6 +793,10 @@ object ConfigCommand extends Config {
val brokerLogger = pars
mumrah commented on a change in pull request #9564:
URL: https://github.com/apache/kafka/pull/9564#discussion_r537948141
##
File path: core/src/main/scala/kafka/server/AlterIsrManager.scala
##
@@ -88,20 +88,34 @@ class AlterIsrManagerImpl(val controllerChannelManager:
BrokerTo
apovzner commented on a change in pull request #9685:
URL: https://github.com/apache/kafka/pull/9685#discussion_r537955330
##
File path: core/src/main/scala/kafka/network/SocketServer.scala
##
@@ -1753,9 +1761,9 @@ class ConnectionQuotas(config: KafkaConfig, time: Time,
metric
abbccdda commented on a change in pull request #9564:
URL: https://github.com/apache/kafka/pull/9564#discussion_r537958278
##
File path: core/src/main/scala/kafka/server/AlterIsrManager.scala
##
@@ -88,20 +88,34 @@ class AlterIsrManagerImpl(val controllerChannelManager:
Broker
ableegoldman commented on a change in pull request #9695:
URL: https://github.com/apache/kafka/pull/9695#discussion_r537955392
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -924,22 +924,64 @@ private StreamThread createStreamThread(final l
ableegoldman commented on a change in pull request #9695:
URL: https://github.com/apache/kafka/pull/9695#discussion_r537974578
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -924,22 +924,64 @@ private StreamThread createStreamThread(final l
ableegoldman commented on a change in pull request #9695:
URL: https://github.com/apache/kafka/pull/9695#discussion_r537976391
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -924,22 +924,64 @@ private StreamThread createStreamThread(final l
ableegoldman commented on a change in pull request #9671:
URL: https://github.com/apache/kafka/pull/9671#discussion_r537986486
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java
##
@@ -853,7 +844,7 @@ public void onSuccess(
jsancio commented on a change in pull request #9505:
URL: https://github.com/apache/kafka/pull/9505#discussion_r537990130
##
File path: clients/src/main/resources/common/message/FetchSnapshotRequest.json
##
@@ -0,0 +1,46 @@
+// Licensed to the Apache Software Foundation (ASF) u
jsancio commented on a change in pull request #9505:
URL: https://github.com/apache/kafka/pull/9505#discussion_r537990223
##
File path: clients/src/main/resources/common/message/FetchSnapshotResponse.json
##
@@ -0,0 +1,59 @@
+// Licensed to the Apache Software Foundation (ASF)
ableegoldman commented on a change in pull request #9671:
URL: https://github.com/apache/kafka/pull/9671#discussion_r537990731
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java
##
@@ -248,18 +243,26 @@ protected synchroniz
ableegoldman commented on a change in pull request #9671:
URL: https://github.com/apache/kafka/pull/9671#discussion_r537992012
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java
##
@@ -235,11 +235,6 @@ protected synchronize
jsancio commented on a change in pull request #9553:
URL: https://github.com/apache/kafka/pull/9553#discussion_r537993156
##
File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java
##
@@ -1037,6 +1047,14 @@ private boolean handleFetchResponse(
ableegoldman commented on a change in pull request #9671:
URL: https://github.com/apache/kafka/pull/9671#discussion_r537990731
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java
##
@@ -248,18 +243,26 @@ protected synchroniz
vamossagar12 commented on a change in pull request #9539:
URL: https://github.com/apache/kafka/pull/9539#discussion_r537995450
##
File path: clients/src/main/resources/common/message/LeaderChangeMessage.json
##
@@ -22,7 +22,11 @@
{"name": "LeaderId", "type": "int32", "vers
[
https://issues.apache.org/jira/browse/KAFKA-7819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gwen Shapira resolved KAFKA-7819.
-
Fix Version/s: 2.2.0
Resolution: Fixed
Closing since I noticed the PR was merged.
> Trogd
ableegoldman commented on pull request #9671:
URL: https://github.com/apache/kafka/pull/9671#issuecomment-740339466
Kicked off 30 versions of the system test which has seemed to be flaky due
to this bug:
https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4302/
--
chia7712 commented on pull request #9705:
URL: https://github.com/apache/kafka/pull/9705#issuecomment-740340757
@APaMio Could you rebase code to include
https://github.com/apache/kafka/commit/8db3b1a09af0bad274e07161336994610d616b35?
---
1 - 100 of 123 matches
Mail list logo
