splett2 commented on a change in pull request #9628:
URL: https://github.com/apache/kafka/pull/9628#discussion_r537945058
##########
File path: core/src/main/scala/kafka/admin/ConfigCommand.scala
##########
@@ -778,6 +793,10 @@ object ConfigCommand extends Config {
val brokerLogger = parser.accepts("broker-logger", "The broker's ID for
its logger config.")
.withRequiredArg
.ofType(classOf[String])
+ val ipDefaults = parser.accepts("ip-defaults", "The config defaults for
all IPs.")
+ val ip = parser.accepts("ip", "The IP address.")
Review comment:
this is done. while I was updating the KIP, i noticed that the previous
config documentation was inconsistent with existing configs.
```
Default connection rate quotas for an IP address can be configured by
omitting entity name.
bin/kafka-configs --bootstrap-server localhost:9091 --alter --add-config
'connection_creation_rate=100' --entity-type IPs
```
This isn't the case for any of the existing configs, you get an error:
`an entity-name or default entity must be specified with --alter of users,
clients, brokers`
##########
File path: core/src/main/scala/kafka/admin/ConfigCommand.scala
##########
@@ -778,6 +793,10 @@ object ConfigCommand extends Config {
val brokerLogger = parser.accepts("broker-logger", "The broker's ID for
its logger config.")
.withRequiredArg
.ofType(classOf[String])
+ val ipDefaults = parser.accepts("ip-defaults", "The config defaults for
all IPs.")
+ val ip = parser.accepts("ip", "The IP address.")
Review comment:
done. while I was updating the KIP, i noticed that the previous config
documentation was inconsistent with existing configs.
```
Default connection rate quotas for an IP address can be configured by
omitting entity name.
bin/kafka-configs --bootstrap-server localhost:9091 --alter --add-config
'connection_creation_rate=100' --entity-type IPs
```
This isn't the case for any of the existing configs, you get an error:
`an entity-name or default entity must be specified with --alter of users,
clients, brokers`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
