dajac commented on a change in pull request #9630:
URL: https://github.com/apache/kafka/pull/9630#discussion_r533975842
##
File path: core/src/main/scala/kafka/server/ReplicaManager.scala
##
@@ -1862,23 +1864,51 @@ class ReplicaManager(val config: KafkaConfig,
}
}
-
dajac commented on a change in pull request #9630:
URL: https://github.com/apache/kafka/pull/9630#discussion_r533980942
##
File path:
clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java
##
@@ -3727,15 +3733,24 @@ public void testOffsetValidationR
Montyleo opened a new pull request #9675:
URL: https://github.com/apache/kafka/pull/9675
There is more than 6000 topics and 300 brokers in my kafka cluster, and we
frequently run kafka-preferred-replica-election.sh to rebalance our cluster.
But the reblance process spendes too more time an
cadonna commented on a change in pull request #9609:
URL: https://github.com/apache/kafka/pull/9609#discussion_r533990330
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/SourceGraphNode.java
##
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apach
ramesh-muthusamy commented on pull request #9319:
URL: https://github.com/apache/kafka/pull/9319#issuecomment-737085308
@kkonstantine gentle reminder to help reviewing the comments and updates.
This is an automated message
David Jacot created KAFKA-10795:
---
Summary: Automated protocol should expose Map keyed by
TopicPartition
Key: KAFKA-10795
URL: https://issues.apache.org/jira/browse/KAFKA-10795
Project: Kafka
I
dajac commented on a change in pull request #9630:
URL: https://github.com/apache/kafka/pull/9630#discussion_r533999715
##
File path:
clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java
##
@@ -3727,15 +3733,24 @@ public void testOffsetValidationR
dajac commented on pull request #9630:
URL: https://github.com/apache/kafka/pull/9630#issuecomment-737093030
@hachikuji Thanks for your feedback. I have addressed your points.
This is an automated message from the Apache Git
[
https://issues.apache.org/jira/browse/KAFKA-10794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-10794:
--
Assignee: limeng
> Replica leader election is too slow in the case of too many partit
Montyleo commented on pull request #9675:
URL: https://github.com/apache/kafka/pull/9675#issuecomment-737185013
> @Montyleo nice finding. LGTM
Thanks
This is an automated message from the Apache Git Service.
To respond
Montyleo commented on pull request #9675:
URL: https://github.com/apache/kafka/pull/9675#issuecomment-737187007
@huxihx Please help me review the code, thanks.
This is an automated message from the Apache Git Service.
To re
chia7712 commented on pull request #9675:
URL: https://github.com/apache/kafka/pull/9675#issuecomment-737189029
@Montyleo Is the failed test related to this PR?
This is an automated message from the Apache Git Service.
To res
rajinisivaram commented on a change in pull request #9382:
URL: https://github.com/apache/kafka/pull/9382#discussion_r534117135
##
File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala
##
@@ -426,21 +451,34 @@ abstract class AbstractFetcherThread(name: String,
rajinisivaram commented on a change in pull request #9382:
URL: https://github.com/apache/kafka/pull/9382#discussion_r534117347
##
File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala
##
@@ -669,11 +714,18 @@ abstract class AbstractFetcherThread(name: String,
vamossagar12 commented on a change in pull request #9539:
URL: https://github.com/apache/kafka/pull/9539#discussion_r534118681
##
File path: raft/src/main/java/org/apache/kafka/raft/LeaderState.java
##
@@ -72,11 +73,20 @@ public int epoch() {
return voterReplicaStates.
vamossagar12 commented on a change in pull request #9539:
URL: https://github.com/apache/kafka/pull/9539#discussion_r534120287
##
File path: clients/src/main/resources/common/message/LeaderChangeMessage.json
##
@@ -22,7 +22,11 @@
{"name": "LeaderId", "type": "int32", "vers
Montyleo commented on pull request #9675:
URL: https://github.com/apache/kafka/pull/9675#issuecomment-737199358
> @Montyleo Is the failed test related to this PR?
Hi, chia7712
Thanks for your reply. The failed test is about SaslAuthenticator, not
related to this PR, even not relat
Veerendra Singavarapu created KAFKA-10796:
-
Summary: USE OF BLACK HOLE RACIST TERMINOLOGY
Key: KAFKA-10796
URL: https://issues.apache.org/jira/browse/KAFKA-10796
Project: Kafka
Issue
[
https://issues.apache.org/jira/browse/KAFKA-10791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
KRISHNA SARVEPALLI updated KAFKA-10791:
---
Attachment: Topic-Recreated.png
> Kafka Metadata older epoch problem
> -
[
https://issues.apache.org/jira/browse/KAFKA-10791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17242370#comment-17242370
]
KRISHNA SARVEPALLI commented on KAFKA-10791:
We have validated the logs from
chia7712 commented on pull request #9675:
URL: https://github.com/apache/kafka/pull/9675#issuecomment-737244340
> I'll find the reason.
Is there a existent ticket? If not, could you file a jira to log it? Also,
you can assign the ticket to yourself ( I have given the permission to yo
[
https://issues.apache.org/jira/browse/KAFKA-10796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17242386#comment-17242386
]
Andrew Otto edited comment on KAFKA-10796 at 12/2/20, 2:14 PM:
---
[
https://issues.apache.org/jira/browse/KAFKA-10796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17242386#comment-17242386
]
Andrew Otto commented on KAFKA-10796:
-
Hi, I'd like to learn moer. Why is BlackHole
[
https://issues.apache.org/jira/browse/KAFKA-10796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17242394#comment-17242394
]
Veerendra Singavarapu commented on KAFKA-10796:
---
Hi,
Thanks for your
limeng created KAFKA-10797:
--
Summary: Build / JDK 8 /
org.apache.kafka.common.security.authenticator.SaslAuthenticatorTest.testValidSaslPlainOverSsl
failed
Key: KAFKA-10797
URL: https://issues.apache.org/jira/browse/KAF
Rajini Sivaram created KAFKA-10798:
--
Summary: Failed authentication delay doesn't work with some SASL
authentication failures
Key: KAFKA-10798
URL: https://issues.apache.org/jira/browse/KAFKA-10798
P
[
https://issues.apache.org/jira/browse/KAFKA-10797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
limeng updated KAFKA-10797:
---
Docs Text: (was: org.junit.ComparisonFailure:
expected:<[tXCQA2rulHkZ5bAwvA6x4prne0sKqqtC5Y6DBnMSeKzOJkDto
[
https://issues.apache.org/jira/browse/KAFKA-10796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17242405#comment-17242405
]
Andrew Otto commented on KAFKA-10796:
-
Neither of the articles you link to are claim
[
https://issues.apache.org/jira/browse/KAFKA-10797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
limeng updated KAFKA-10797:
---
Attachment: 截屏2020-12-02 下午10.35.10.png
> Build / JDK 8 /
> org.apache.kafka.common.security.authenticator.
[
https://issues.apache.org/jira/browse/KAFKA-10797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
limeng updated KAFKA-10797:
---
Description:
There is one testcase running failed on jdk 8 version when submmit the
pr:[https://github.com/
[
https://issues.apache.org/jira/browse/KAFKA-10786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17242411#comment-17242411
]
Chia-Ping Tsai commented on KAFKA-10786:
Is this similar to https://issues.apach
Montyleo commented on pull request #9675:
URL: https://github.com/apache/kafka/pull/9675#issuecomment-737283188
> > I'll find the reason.
>
> Is there a existent ticket? If not, could you file a jira to log it? Also,
you can assign the ticket to yourself ( I have given the permission
[
https://issues.apache.org/jira/browse/KAFKA-10797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
limeng updated KAFKA-10797:
---
Attachment: image-2020-12-02-23-01-00-412.png
> Build / JDK 8 /
> org.apache.kafka.common.security.authenti
[
https://issues.apache.org/jira/browse/KAFKA-10797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
limeng updated KAFKA-10797:
---
Description:
There is one testcase running failed on jdk 8 version when submmit the
pr:[https://github.com/
lct45 commented on a change in pull request #9614:
URL: https://github.com/apache/kafka/pull/9614#discussion_r534256605
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImpl.java
##
@@ -214,6 +215,20 @@ public RocksDBMetric
cadonna commented on a change in pull request #9615:
URL: https://github.com/apache/kafka/pull/9615#discussion_r534261843
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -870,43 +899,73 @@ private KafkaStreams(final InternalTopologyBuilder
cadonna commented on a change in pull request #9615:
URL: https://github.com/apache/kafka/pull/9615#discussion_r534263746
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -894,19 +885,88 @@ private KafkaStreams(final InternalTopologyBuilder
tombentley opened a new pull request #9676:
URL: https://github.com/apache/kafka/pull/9676
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
chia7712 commented on pull request #8826:
URL: https://github.com/apache/kafka/pull/8826#issuecomment-737316886
rebase to trigger QA again
This is an automated message from the Apache Git Service.
To respond to the message, p
tombentley commented on pull request #9676:
URL: https://github.com/apache/kafka/pull/9676#issuecomment-737317322
@hachikuji is this what you had in mind for what you described in
[KAFKA-10778](https://issues.apache.org/jira/browse/KAFKA-10778)?
---
mumrah commented on a change in pull request #9564:
URL: https://github.com/apache/kafka/pull/9564#discussion_r534281054
##
File path: core/src/main/scala/kafka/server/AlterIsrManager.scala
##
@@ -88,20 +88,33 @@ class AlterIsrManagerImpl(val controllerChannelManager:
BrokerTo
dajac commented on a change in pull request #9628:
URL: https://github.com/apache/kafka/pull/9628#discussion_r534287486
##
File path: core/src/main/scala/kafka/server/AdminManager.scala
##
@@ -920,32 +954,49 @@ class AdminManager(val config: KafkaConfig,
!name.isDefine
wcarlson5 commented on a change in pull request #9615:
URL: https://github.com/apache/kafka/pull/9615#discussion_r534313845
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -870,43 +899,73 @@ private KafkaStreams(final InternalTopologyBuilder
cadonna commented on a change in pull request #9615:
URL: https://github.com/apache/kafka/pull/9615#discussion_r534319500
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -870,43 +899,73 @@ private KafkaStreams(final InternalTopologyBuilder
hachikuji closed pull request #9666:
URL: https://github.com/apache/kafka/pull/9666
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
hachikuji commented on pull request #9666:
URL: https://github.com/apache/kafka/pull/9666#issuecomment-737369214
Closing in favor of #9652.
This is an automated message from the Apache Git Service.
To respond to the message,
wcarlson5 commented on a change in pull request #9615:
URL: https://github.com/apache/kafka/pull/9615#discussion_r534339275
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -870,43 +899,73 @@ private KafkaStreams(final InternalTopologyBuilder
cmccabe commented on pull request #8555:
URL: https://github.com/apache/kafka/pull/8555#issuecomment-737380941
I'm not familiar with this either. How did you choose a 15 second delay?
This is an automated message from the Ap
abbccdda commented on a change in pull request #9564:
URL: https://github.com/apache/kafka/pull/9564#discussion_r534352532
##
File path: core/src/main/scala/kafka/server/AlterIsrManager.scala
##
@@ -88,20 +88,33 @@ class AlterIsrManagerImpl(val controllerChannelManager:
Broker
cmccabe commented on pull request #8528:
URL: https://github.com/apache/kafka/pull/8528#issuecomment-737387701
This was superseded by #9274 and some other changes. Closing for now
This is an automated message from the Apache
cmccabe closed pull request #8528:
URL: https://github.com/apache/kafka/pull/8528
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
[
https://issues.apache.org/jira/browse/KAFKA-10688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17242571#comment-17242571
]
Matthias J. Sax commented on KAFKA-10688:
-
1) As the topic is empty, it does not
hachikuji commented on a change in pull request #9630:
URL: https://github.com/apache/kafka/pull/9630#discussion_r534379349
##
File path:
clients/src/test/java/org/apache/kafka/common/requests/RequestResponseTest.java
##
@@ -1839,20 +1839,17 @@ private OffsetsForLeaderEpochRes
Jason Gustafson created KAFKA-10799:
---
Summary: AlterIsr path does not update ISR shrink/expand meters
Key: KAFKA-10799
URL: https://issues.apache.org/jira/browse/KAFKA-10799
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-10799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson updated KAFKA-10799:
Priority: Blocker (was: Major)
> AlterIsr path does not update ISR shrink/expand meters
>
[
https://issues.apache.org/jira/browse/KAFKA-10799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson updated KAFKA-10799:
Fix Version/s: 2.7.0
> AlterIsr path does not update ISR shrink/expand meters
> --
[
https://issues.apache.org/jira/browse/KAFKA-10799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson reassigned KAFKA-10799:
---
Assignee: David Arthur
> AlterIsr path does not update ISR shrink/expand meters
> -
guozhangwang commented on a change in pull request #9671:
URL: https://github.com/apache/kafka/pull/9671#discussion_r534377676
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java
##
@@ -853,7 +844,7 @@ public void onSuccess(
ableegoldman commented on a change in pull request #9609:
URL: https://github.com/apache/kafka/pull/9609#discussion_r534424621
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/SourceGraphNode.java
##
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the
ableegoldman commented on a change in pull request #9609:
URL: https://github.com/apache/kafka/pull/9609#discussion_r534424621
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/SourceGraphNode.java
##
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the
mumrah opened a new pull request #9677:
URL: https://github.com/apache/kafka/pull/9677
In #9100, we missed the inclusion of the high level ISR shrink/expand
metrics that are managed by ReplicaManager. This PR adds a small abstraction
that allows us to mark these metrics without bringing Re
rhauch commented on a change in pull request #9669:
URL: https://github.com/apache/kafka/pull/9669#discussion_r534419655
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java
##
@@ -206,16 +203,13 @@ public void cancel() {
publ
rajinisivaram opened a new pull request #9678:
URL: https://github.com/apache/kafka/pull/9678
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgra
d8tltanc commented on a change in pull request #9485:
URL: https://github.com/apache/kafka/pull/9485#discussion_r534447773
##
File path: core/src/main/scala/kafka/security/authorizer/AclAuthorizer.scala
##
@@ -304,6 +308,122 @@ class AclAuthorizer extends Authorizer with Loggin
d8tltanc commented on a change in pull request #9485:
URL: https://github.com/apache/kafka/pull/9485#discussion_r534447894
##
File path: core/src/main/scala/kafka/security/authorizer/AclAuthorizer.scala
##
@@ -456,8 +576,12 @@ class AclAuthorizer extends Authorizer with Logging
C0urante commented on a change in pull request #9669:
URL: https://github.com/apache/kafka/pull/9669#discussion_r534453206
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java
##
@@ -206,16 +203,13 @@ public void cancel() {
pu
hachikuji commented on a change in pull request #9382:
URL: https://github.com/apache/kafka/pull/9382#discussion_r534424325
##
File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala
##
@@ -426,21 +451,35 @@ abstract class AbstractFetcherThread(name: String,
C0urante commented on a change in pull request #9669:
URL: https://github.com/apache/kafka/pull/9669#discussion_r534465543
##
File path:
connect/runtime/src/test/java/org/apache/kafka/connect/integration/BlockingConnectorTest.java
##
@@ -263,145 +332,153 @@ private void verify
jsancio commented on a change in pull request #9539:
URL: https://github.com/apache/kafka/pull/9539#discussion_r534476673
##
File path: clients/src/main/resources/common/message/LeaderChangeMessage.json
##
@@ -22,7 +22,11 @@
{"name": "LeaderId", "type": "int32", "versions"
fml2 commented on a change in pull request #9606:
URL: https://github.com/apache/kafka/pull/9606#discussion_r534476825
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/KGroupedStream.java
##
@@ -381,7 +381,8 @@
* {@link StreamsConfig#COMMIT_INTERVAL_M
jsancio commented on a change in pull request #9539:
URL: https://github.com/apache/kafka/pull/9539#discussion_r534477516
##
File path: raft/src/main/java/org/apache/kafka/raft/LeaderState.java
##
@@ -72,11 +73,20 @@ public int epoch() {
return voterReplicaStates.keySe
d8tltanc commented on a change in pull request #9485:
URL: https://github.com/apache/kafka/pull/9485#discussion_r534477631
##
File path:
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/acl/AclAuthorizerBenchmark.java
##
@@ -69,33 +70,39 @@
@BenchmarkMode(Mode.AverageTime)
d8tltanc commented on a change in pull request #9485:
URL: https://github.com/apache/kafka/pull/9485#discussion_r534477631
##
File path:
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/acl/AclAuthorizerBenchmark.java
##
@@ -69,33 +70,39 @@
@BenchmarkMode(Mode.AverageTime)
hachikuji commented on a change in pull request #9677:
URL: https://github.com/apache/kafka/pull/9677#discussion_r534480994
##
File path: core/src/main/scala/kafka/cluster/Partition.scala
##
@@ -45,6 +45,12 @@ import org.apache.kafka.common.{IsolationLevel,
TopicPartition}
im
d8tltanc commented on a change in pull request #9485:
URL: https://github.com/apache/kafka/pull/9485#discussion_r534477631
##
File path:
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/acl/AclAuthorizerBenchmark.java
##
@@ -69,33 +70,39 @@
@BenchmarkMode(Mode.AverageTime)
hachikuji commented on a change in pull request #9512:
URL: https://github.com/apache/kafka/pull/9512#discussion_r534485088
##
File path: raft/src/main/java/org/apache/kafka/raft/RaftClient.java
##
@@ -100,4 +102,15 @@ default void handleResign() {}
*/
CompletableFut
hachikuji commented on a change in pull request #9512:
URL: https://github.com/apache/kafka/pull/9512#discussion_r534485293
##
File path: raft/src/main/java/org/apache/kafka/snapshot/Snapshots.java
##
@@ -0,0 +1,67 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
hachikuji commented on a change in pull request #9512:
URL: https://github.com/apache/kafka/pull/9512#discussion_r534486002
##
File path: raft/src/main/java/org/apache/kafka/snapshot/Snapshots.java
##
@@ -0,0 +1,67 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
hachikuji commented on a change in pull request #9512:
URL: https://github.com/apache/kafka/pull/9512#discussion_r534487681
##
File path: raft/src/main/java/org/apache/kafka/snapshot/Snapshots.java
##
@@ -0,0 +1,67 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
rhauch commented on a change in pull request #9669:
URL: https://github.com/apache/kafka/pull/9669#discussion_r534489037
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java
##
@@ -206,16 +203,13 @@ public void cancel() {
publ
jsancio commented on a change in pull request #9512:
URL: https://github.com/apache/kafka/pull/9512#discussion_r534489751
##
File path: raft/src/main/java/org/apache/kafka/raft/RaftClient.java
##
@@ -100,4 +102,15 @@ default void handleResign() {}
*/
CompletableFutur
rhauch commented on a change in pull request #9669:
URL: https://github.com/apache/kafka/pull/9669#discussion_r534489678
##
File path:
connect/runtime/src/test/java/org/apache/kafka/connect/integration/BlockingConnectorTest.java
##
@@ -263,145 +332,153 @@ private void verifyNo
mingaliu commented on pull request #9548:
URL: https://github.com/apache/kafka/pull/9548#issuecomment-737507335
Any update? Even KafkaEmbedded is internal but we actually used it in many
places for our unitest. So we would love to find a good alternative solutions.
(Our current workarou
splett2 commented on a change in pull request #9628:
URL: https://github.com/apache/kafka/pull/9628#discussion_r534494510
##
File path: core/src/main/scala/kafka/server/AdminManager.scala
##
@@ -920,32 +954,49 @@ class AdminManager(val config: KafkaConfig,
!name.isDefi
splett2 commented on a change in pull request #9628:
URL: https://github.com/apache/kafka/pull/9628#discussion_r534496946
##
File path: core/src/main/scala/kafka/admin/ConfigCommand.scala
##
@@ -56,11 +56,12 @@ import scala.collection._
* --entity-typ
hachikuji commented on a change in pull request #9676:
URL: https://github.com/apache/kafka/pull/9676#discussion_r534502282
##
File path: core/src/main/scala/kafka/log/Log.scala
##
@@ -1219,6 +1219,9 @@ class Log(@volatile private var _dir: File,
appendInfo.logAp
hachikuji commented on a change in pull request #9676:
URL: https://github.com/apache/kafka/pull/9676#discussion_r534502482
##
File path: core/src/main/scala/kafka/server/LogDirFailureChannel.scala
##
@@ -49,6 +49,13 @@ class LogDirFailureChannel(logDirNum: Int) extends Logging
hachikuji commented on a change in pull request #9677:
URL: https://github.com/apache/kafka/pull/9677#discussion_r534519335
##
File path: core/src/main/scala/kafka/cluster/Partition.scala
##
@@ -107,10 +106,24 @@ object Partition extends KafkaMetricsGroup {
def apply(topicPa
[
https://issues.apache.org/jira/browse/KAFKA-10688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17242772#comment-17242772
]
Guozhang Wang commented on KAFKA-10688:
---
The main reason I did not go through the
[
https://issues.apache.org/jira/browse/KAFKA-10417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17242789#comment-17242789
]
Leah Thomas commented on KAFKA-10417:
-
[~duvholt] are you still planning on working
C0urante commented on pull request #9200:
URL: https://github.com/apache/kafka/pull/9200#issuecomment-737550229
@lbradstreet I think the changes to the MM2 tests may have been unnecessary
or, at least, inadequate. Embedded Connect clusters automatically [mask exit
procedures on
startup](h
mumrah commented on a change in pull request #9677:
URL: https://github.com/apache/kafka/pull/9677#discussion_r534547385
##
File path: core/src/main/scala/kafka/cluster/Partition.scala
##
@@ -1406,10 +1429,13 @@ class Partition(val topicPartition: TopicPartition,
case
C0urante commented on a change in pull request #9669:
URL: https://github.com/apache/kafka/pull/9669#discussion_r534548973
##
File path:
connect/runtime/src/test/java/org/apache/kafka/connect/integration/BlockingConnectorTest.java
##
@@ -263,145 +332,153 @@ private void verify
[
https://issues.apache.org/jira/browse/KAFKA-10417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17242806#comment-17242806
]
John Roesler commented on KAFKA-10417:
--
Hey [~duvholt] , I'm really sorry I missed
apovzner commented on a change in pull request #9628:
URL: https://github.com/apache/kafka/pull/9628#discussion_r534558407
##
File path: core/src/main/scala/kafka/admin/ConfigCommand.scala
##
@@ -56,11 +56,12 @@ import scala.collection._
* --entity-ty
rajinisivaram commented on a change in pull request #9382:
URL: https://github.com/apache/kafka/pull/9382#discussion_r534563375
##
File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala
##
@@ -426,21 +451,35 @@ abstract class AbstractFetcherThread(name: String,
rajinisivaram commented on a change in pull request #9382:
URL: https://github.com/apache/kafka/pull/9382#discussion_r534563570
##
File path: core/src/main/scala/kafka/server/AbstractFetcherManager.scala
##
@@ -64,8 +64,8 @@ abstract class AbstractFetcherManager[T <:
AbstractF
rajinisivaram commented on a change in pull request #9382:
URL: https://github.com/apache/kafka/pull/9382#discussion_r534563838
##
File path: core/src/main/scala/kafka/server/ReplicaManager.scala
##
@@ -1691,6 +1692,18 @@ class ReplicaManager(val config: KafkaConfig,
parti
rajinisivaram commented on pull request #9382:
URL: https://github.com/apache/kafka/pull/9382#issuecomment-737568344
@hachikuji Thanks for the review, I have addressed the comments.
This is an automated message from the Apach
rajinisivaram commented on pull request #9382:
URL: https://github.com/apache/kafka/pull/9382#issuecomment-737572297
The system test run from this morning on this PR branch completed with 6
failures, which are known failures in ConnectDistributedTest that also failed
in the last trunk test
1 - 100 of 132 matches
Mail list logo
