[GitHub] [kafka] hachikuji commented on a change in pull request #9630: KAFKA-10739; Replace EpochEndOffset with automated protocol

[GitBox]

hachikuji commented on a change in pull request #9630:
URL: https://github.com/apache/kafka/pull/9630#discussion_r534379349



##########
File path: 
clients/src/test/java/org/apache/kafka/common/requests/RequestResponseTest.java
##########
@@ -1839,20 +1839,17 @@ private OffsetsForLeaderEpochResponse 
createLeaderEpochResponse() {
             .setPartitions(Arrays.asList(
                 new OffsetForLeaderPartitionResult()
                     .setPartition(0)
-                    .setErrorCode(Errors.NONE.code())
                     .setLeaderEpoch(1)
                     .setEndOffset(0),
                 new OffsetForLeaderPartitionResult()
                     .setPartition(1)
-                    .setErrorCode(Errors.NONE.code())

Review comment:
       In the case of the error code, I think it might be better to be 
explicit. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org