[GitHub] [kafka] twobeeb edited a comment on pull request #9589: KAFKA-10710 - Mirror Maker 2 - Create herders only if source->target.enabled=true

2020-11-17 Thread GitBox
twobeeb edited a comment on pull request #9589: URL: https://github.com/apache/kafka/pull/9589#issuecomment-728593310 @ryannedolan @hachikuji If I understand correctly, when setting up a link A->B.enabled=true (with defaults settings regarding heartbeat), it creates a topic heartbeat wh

[jira] [Created] (KAFKA-10731) have kafka producer & consumer auto-reload ssl certificate

2020-11-17 Thread Yu Yang (Jira)
Yu Yang created KAFKA-10731: --- Summary: have kafka producer & consumer auto-reload ssl certificate Key: KAFKA-10731 URL: https://issues.apache.org/jira/browse/KAFKA-10731 Project: Kafka Issue Typ

[jira] [Updated] (KAFKA-10731) have kafka producer & consumer auto-reload ssl certificate

2020-11-17 Thread Yu Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu Yang updated KAFKA-10731: Affects Version/s: 2.3.1 > have kafka producer & consumer auto-reload ssl certificate >

[GitHub] [kafka] chia7712 commented on pull request #9401: KAFKA-9628 Replace Produce request/response with automated protocol

2020-11-17 Thread GitBox
chia7712 commented on pull request #9401: URL: https://github.com/apache/kafka/pull/9401#issuecomment-728812062 @hachikuji @ijuma It seems to me the root cause of regression is caused by the conversion between old data struct and auto-generated protocol. As we all care for performance, I a

[GitHub] [kafka] chia7712 edited a comment on pull request #9401: KAFKA-9628 Replace Produce request/response with automated protocol

2020-11-17 Thread GitBox
chia7712 edited a comment on pull request #9401: URL: https://github.com/apache/kafka/pull/9401#issuecomment-728812062 @hachikuji @ijuma It seems to me the root cause of regression is caused by the conversion between old data struct and auto-generated protocol. As we all care for performan

[GitHub] [kafka] chia7712 edited a comment on pull request #9401: KAFKA-9628 Replace Produce request/response with automated protocol

2020-11-17 Thread GitBox
chia7712 edited a comment on pull request #9401: URL: https://github.com/apache/kafka/pull/9401#issuecomment-728812062 @hachikuji @ijuma It seems to me the root cause of regression is caused by the conversion between old data struct and auto-generated protocol. As we all care for performan

[GitHub] [kafka] chia7712 edited a comment on pull request #9401: KAFKA-9628 Replace Produce request/response with automated protocol

2020-11-17 Thread GitBox
chia7712 edited a comment on pull request #9401: URL: https://github.com/apache/kafka/pull/9401#issuecomment-728812062 @hachikuji @ijuma It seems to me the root cause of regression is caused by the conversion between old data struct and auto-generated protocol. As we all care for performan

[GitHub] [kafka] chia7712 edited a comment on pull request #9401: KAFKA-9628 Replace Produce request/response with automated protocol

2020-11-17 Thread GitBox
chia7712 edited a comment on pull request #9401: URL: https://github.com/apache/kafka/pull/9401#issuecomment-728812062 @hachikuji @ijuma It seems to me the root cause of regression is caused by the conversion between old data struct and auto-generated protocol. As we all care for performan

[GitHub] [kafka] chia7712 edited a comment on pull request #9401: KAFKA-9628 Replace Produce request/response with automated protocol

2020-11-17 Thread GitBox
chia7712 edited a comment on pull request #9401: URL: https://github.com/apache/kafka/pull/9401#issuecomment-728812062 @hachikuji @ijuma It seems to me the root cause of regression is caused by the conversion between old data struct and auto-generated protocol. As we all care for performan

[GitHub] [kafka] chia7712 edited a comment on pull request #9401: KAFKA-9628 Replace Produce request/response with automated protocol

2020-11-17 Thread GitBox
chia7712 edited a comment on pull request #9401: URL: https://github.com/apache/kafka/pull/9401#issuecomment-728812062 @hachikuji @ijuma It seems to me the root cause of regression is caused by the conversion between old data struct and auto-generated protocol. As we all care for performan

[GitHub] [kafka] chia7712 edited a comment on pull request #9401: KAFKA-9628 Replace Produce request/response with automated protocol

2020-11-17 Thread GitBox
chia7712 edited a comment on pull request #9401: URL: https://github.com/apache/kafka/pull/9401#issuecomment-728812062 @hachikuji @ijuma It seems to me the root cause of regression is caused by the conversion between old data struct and auto-generated protocol. As we all care for performan

[GitHub] [kafka] chia7712 edited a comment on pull request #9401: KAFKA-9628 Replace Produce request/response with automated protocol

2020-11-17 Thread GitBox
chia7712 edited a comment on pull request #9401: URL: https://github.com/apache/kafka/pull/9401#issuecomment-728812062 @hachikuji @ijuma It seems to me the root cause of regression is caused by the conversion between old data struct and auto-generated protocol. As we all care for performan

[GitHub] [kafka] chia7712 edited a comment on pull request #9401: KAFKA-9628 Replace Produce request/response with automated protocol

2020-11-17 Thread GitBox
chia7712 edited a comment on pull request #9401: URL: https://github.com/apache/kafka/pull/9401#issuecomment-728812062 @hachikuji @ijuma It seems to me the root cause of regression is caused by the conversion between old data struct and auto-generated protocol. As we all care for performan

[GitHub] [kafka] twobeeb edited a comment on pull request #9589: KAFKA-10710 - Mirror Maker 2 - Create herders only if source->target.enabled=true

2020-11-17 Thread GitBox
twobeeb edited a comment on pull request #9589: URL: https://github.com/apache/kafka/pull/9589#issuecomment-728593310 @ryannedolan @hachikuji If I understand correctly, when setting up a link A->B.enabled=true (with defaults settings regarding heartbeat), it creates a topic heartbeat an

[jira] [Commented] (KAFKA-10430) Hook support

2020-11-17 Thread Tobias (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17233565#comment-17233565 ] Tobias commented on KAFKA-10430: hi, i would also like be very interested in such a kind

[GitHub] [kafka] cadonna commented on a change in pull request #9487: KAFKA-9331: Add a streams specific uncaught exception handler

2020-11-17 Thread GitBox
cadonna commented on a change in pull request #9487: URL: https://github.com/apache/kafka/pull/9487#discussion_r525161434 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -366,6 +374,63 @@ public void setUncaughtExceptionHandler(final Thread

[jira] [Commented] (KAFKA-10640) Connect Cast and ReplaceField transforms only support top-level fields and Cast does not support complex types.

2020-11-17 Thread Mandy Choi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17233632#comment-17233632 ] Mandy Choi commented on KAFKA-10640: Awesome work! This looks very useful! Are there

[GitHub] [kafka] ijuma commented on pull request #9401: KAFKA-9628 Replace Produce request/response with automated protocol

2020-11-17 Thread GitBox
ijuma commented on pull request #9401: URL: https://github.com/apache/kafka/pull/9401#issuecomment-728974716 Thanks @chia7712. Can you check that the @hachikuji's perf test doesn't result in significantly increased latency?

[GitHub] [kafka] abc863377 opened a new pull request #9603: MINOR: A better way to return an empty Map

2020-11-17 Thread GitBox
abc863377 opened a new pull request #9603: URL: https://github.com/apache/kafka/pull/9603 It's a better way to return an empty Map. Use Collections.emptyMap() instead HashMap This is an automated message from the Apache Gi

[GitHub] [kafka] abc863377 commented on pull request #9603: MINOR: A better way to return an empty Map

2020-11-17 Thread GitBox
abc863377 commented on pull request #9603: URL: https://github.com/apache/kafka/pull/9603#issuecomment-728988458 @chia7712 Could you review it please This is an automated message from the Apache Git Service. To respond to th

[GitHub] [kafka] chia7712 commented on pull request #9401: KAFKA-9628 Replace Produce request/response with automated protocol

2020-11-17 Thread GitBox
chia7712 commented on pull request #9401: URL: https://github.com/apache/kafka/pull/9401#issuecomment-728999480 > Can you check that the @hachikuji's perf test doesn't result in significantly increased latency? I don't observer significantly increased latency on my local. The env is

[GitHub] [kafka] lisa2lisa opened a new pull request #9604: [MINOR] adjust the log level to error

2020-11-17 Thread GitBox
lisa2lisa opened a new pull request #9604: URL: https://github.com/apache/kafka/pull/9604 we recently encounter this log which should be more of a warn, or error message. Even though it checks acks=0, it still should bring people's attention on ``` [2020-11-17 01:05:17,005] INFO [Kaf

[GitHub] [kafka] rajinisivaram opened a new pull request #9605: KAFKA-10727; Handle Kerberos error during re-login as transient failure in clients

2020-11-17 Thread GitBox
rajinisivaram opened a new pull request #9605: URL: https://github.com/apache/kafka/pull/9605 We use a background thread for Kerberos to perform re-login before tickets expire. The thread performs logout() followed by login(), relying on the Java library to clear and then populate credenti

[jira] [Commented] (KAFKA-10722) Timestamped store is used even if not desired

2020-11-17 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17233692#comment-17233692 ] Matthias J. Sax commented on KAFKA-10722: - {quote}But I still fail to see why al

[jira] [Created] (KAFKA-10732) API to ensure Records policy on the broker

2020-11-17 Thread Nikolay Izhikov (Jira)
Nikolay Izhikov created KAFKA-10732: --- Summary: API to ensure Records policy on the broker Key: KAFKA-10732 URL: https://issues.apache.org/jira/browse/KAFKA-10732 Project: Kafka Issue Type:

[jira] [Updated] (KAFKA-10732) API to ensure Records policy on the broker

2020-11-17 Thread Nikolay Izhikov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nikolay Izhikov updated KAFKA-10732: Description: During the adoption of Kafka in large enterprises, it's important to guarante

[jira] [Commented] (KAFKA-10722) Timestamped store is used even if not desired

2020-11-17 Thread fml2 (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17233730#comment-17233730 ] fml2 commented on KAFKA-10722: -- {quote}If you would add a new store (that is not used by –

[jira] [Commented] (KAFKA-10722) Timestamped store is used even if not desired

2020-11-17 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17233740#comment-17233740 ] Matthias J. Sax commented on KAFKA-10722: - {quote}I'm fully satisfied now  {quot

[GitHub] [kafka] mjsax commented on a change in pull request #9570: KAFKA-9274: Handle TimeoutException on commit

2020-11-17 Thread GitBox
mjsax commented on a change in pull request #9570: URL: https://github.com/apache/kafka/pull/9570#discussion_r518540480 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -997,7 +1016,7 @@ void shutdown(final boolean clean)

[GitHub] [kafka] mjsax commented on a change in pull request #9570: KAFKA-9274: Handle TimeoutException on commit

2020-11-17 Thread GitBox
mjsax commented on a change in pull request #9570: URL: https://github.com/apache/kafka/pull/9570#discussion_r525340385 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -817,13 +817,15 @@ private void initializeMetadata() {

[GitHub] [kafka] mjsax commented on a change in pull request #9570: KAFKA-9274: Handle TimeoutException on commit

2020-11-17 Thread GitBox
mjsax commented on a change in pull request #9570: URL: https://github.com/apache/kafka/pull/9570#discussion_r525343321 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -1029,20 +1048,40 @@ int commit(final Collection task

[GitHub] [kafka] hachikuji commented on pull request #9401: KAFKA-9628 Replace Produce request/response with automated protocol

2020-11-17 Thread GitBox
hachikuji commented on pull request #9401: URL: https://github.com/apache/kafka/pull/9401#issuecomment-729081330 @chia7712 Thanks for the updates, looks promising. I'm more inclined to trust your results on linux. I have been testing on macos.Let me see if I can reproduce in a better e

[GitHub] [kafka] kkonstantine merged pull request #9603: MINOR: Initialize ConnectorConfig constructor with emptyMap and avoid instantiating a new Map

2020-11-17 Thread GitBox
kkonstantine merged pull request #9603: URL: https://github.com/apache/kafka/pull/9603 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] scanterog commented on pull request #9545: [mm2] Allow Checkpoints for consumers using static partition assignments

2020-11-17 Thread GitBox
scanterog commented on pull request #9545: URL: https://github.com/apache/kafka/pull/9545#issuecomment-729110030 @mimaison Not sure what we can test here. It is basically just allowing consumers with no members information (generally the case of consumer with static partition assignments)

[GitHub] [kafka] hachikuji commented on a change in pull request #9547: KAFKA-9630; Replace OffsetsForLeaderEpoch request/response with automated protocol

2020-11-17 Thread GitBox
hachikuji commented on a change in pull request #9547: URL: https://github.com/apache/kafka/pull/9547#discussion_r525374659 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/OffsetsForLeaderEpochClient.java ## @@ -61,67 +77,76 @@ protected OffsetF

[jira] [Assigned] (KAFKA-10655) Raft leader should resign after write failures

2020-11-17 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Chen reassigned KAFKA-10655: --- Assignee: Boyang Chen (was: Jason Gustafson) > Raft leader should resign after write failu

[GitHub] [kafka] mjsax commented on a change in pull request #9572: KAFKA-10500: Thread Cache Resizes

2020-11-17 Thread GitBox
mjsax commented on a change in pull request #9572: URL: https://github.com/apache/kafka/pull/9572#discussion_r525399396 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -728,12 +729,8 @@ private KafkaStreams(final InternalTopologyBuilder int

[GitHub] [kafka] mimaison commented on pull request #9545: [mm2] Allow Checkpoints for consumers using static partition assignments

2020-11-17 Thread GitBox
mimaison commented on pull request #9545: URL: https://github.com/apache/kafka/pull/9545#issuecomment-729137112 @scanterog This PR changes the way the Checkpoint connector works. We need a test to exercise the new behaviour. Something simple like this would do: ```java @Test

[GitHub] [kafka] mjsax commented on pull request #7906: KAFKA-9383: Expose consumer group metadata

2020-11-17 Thread GitBox
mjsax commented on pull request #7906: URL: https://github.com/apache/kafka/pull/7906#issuecomment-729139488 I usually do. Seems I missed it for this PR. Sorry about that. :( This is an automated message from the Apache Git S

[GitHub] [kafka] mjsax commented on a change in pull request #8965: KAFKA-8147: Add changelog topic configuration to KTable suppress

2020-11-17 Thread GitBox
mjsax commented on a change in pull request #8965: URL: https://github.com/apache/kafka/pull/8965#discussion_r525425175 ## File path: docs/streams/upgrade-guide.html ## @@ -120,6 +120,11 @@ Streams API We added a --force option in StreamsResetter to force remove left-

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9572: KAFKA-10500: Thread Cache Resizes

2020-11-17 Thread GitBox
wcarlson5 commented on a change in pull request #9572: URL: https://github.com/apache/kafka/pull/9572#discussion_r525425650 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -728,12 +729,8 @@ private KafkaStreams(final InternalTopologyBuilder

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9572: KAFKA-10500: Thread Cache Resizes

2020-11-17 Thread GitBox
wcarlson5 commented on a change in pull request #9572: URL: https://github.com/apache/kafka/pull/9572#discussion_r525426317 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -806,6 +803,13 @@ private KafkaStreams(final InternalTopologyBuilder

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9572: KAFKA-10500: Thread Cache Resizes

2020-11-17 Thread GitBox
wcarlson5 commented on a change in pull request #9572: URL: https://github.com/apache/kafka/pull/9572#discussion_r525427249 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -728,12 +729,8 @@ private KafkaStreams(final InternalTopologyBuilder

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9572: KAFKA-10500: Thread Cache Resizes

2020-11-17 Thread GitBox
wcarlson5 commented on a change in pull request #9572: URL: https://github.com/apache/kafka/pull/9572#discussion_r525427943 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java ## @@ -589,6 +593,10 @@ private void subscribeConsumer

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9572: KAFKA-10500: Thread Cache Resizes

2020-11-17 Thread GitBox
wcarlson5 commented on a change in pull request #9572: URL: https://github.com/apache/kafka/pull/9572#discussion_r525428102 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/ThreadCache.java ## @@ -71,6 +72,26 @@ public long flushes() { retu

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9572: KAFKA-10500: Thread Cache Resizes

2020-11-17 Thread GitBox
wcarlson5 commented on a change in pull request #9572: URL: https://github.com/apache/kafka/pull/9572#discussion_r525430251 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/ThreadCache.java ## @@ -71,6 +72,26 @@ public long flushes() { retu

[GitHub] [kafka] hachikuji commented on a change in pull request #9564: KAFKA-10667: add timeout for forwarding requests

2020-11-17 Thread GitBox
hachikuji commented on a change in pull request #9564: URL: https://github.com/apache/kafka/pull/9564#discussion_r525428214 ## File path: clients/src/main/java/org/apache/kafka/clients/RequestCompletionHandler.java ## @@ -24,4 +24,11 @@ void onComplete(ClientResponse re

[GitHub] [kafka] mjsax merged pull request #9576: KAFKA-10685: strictly parsing the date/time format

2020-11-17 Thread GitBox
mjsax merged pull request #9576: URL: https://github.com/apache/kafka/pull/9576 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] mjsax commented on pull request #9576: KAFKA-10685: strictly parsing the date/time format

2020-11-17 Thread GitBox
mjsax commented on pull request #9576: URL: https://github.com/apache/kafka/pull/9576#issuecomment-729153000 Thanks for the PR @showuon! This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [kafka] mjsax commented on pull request #9576: KAFKA-10685: strictly parsing the date/time format

2020-11-17 Thread GitBox
mjsax commented on pull request #9576: URL: https://github.com/apache/kafka/pull/9576#issuecomment-729153748 Merged to `trunk` -- Can cherry-pick to `2.7` branch after the `2.7.0` release is done to be shipped in `2.7.1`. (Hope I don't forget :) ) -

[GitHub] [kafka] mjsax commented on a change in pull request #9572: KAFKA-10500: Thread Cache Resizes

2020-11-17 Thread GitBox
mjsax commented on a change in pull request #9572: URL: https://github.com/apache/kafka/pull/9572#discussion_r525435452 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -806,6 +803,13 @@ private KafkaStreams(final InternalTopologyBuilder int

[GitHub] [kafka] cadonna commented on a change in pull request #9487: KAFKA-9331: Add a streams specific uncaught exception handler

2020-11-17 Thread GitBox
cadonna commented on a change in pull request #9487: URL: https://github.com/apache/kafka/pull/9487#discussion_r525169791 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -366,6 +377,90 @@ public void setUncaughtExceptionHandler(final Thread

[GitHub] [kafka] mjsax commented on a change in pull request #9572: KAFKA-10500: Thread Cache Resizes

2020-11-17 Thread GitBox
mjsax commented on a change in pull request #9572: URL: https://github.com/apache/kafka/pull/9572#discussion_r525437647 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java ## @@ -589,6 +593,10 @@ private void subscribeConsumer() {

[GitHub] [kafka] mjsax commented on a change in pull request #9572: KAFKA-10500: Thread Cache Resizes

2020-11-17 Thread GitBox
mjsax commented on a change in pull request #9572: URL: https://github.com/apache/kafka/pull/9572#discussion_r525439819 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/ThreadCache.java ## @@ -71,6 +72,26 @@ public long flushes() { return n

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9487: KAFKA-9331: Add a streams specific uncaught exception handler

2020-11-17 Thread GitBox
wcarlson5 commented on a change in pull request #9487: URL: https://github.com/apache/kafka/pull/9487#discussion_r525442248 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -366,6 +377,90 @@ public void setUncaughtExceptionHandler(final Thre

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9487: KAFKA-9331: Add a streams specific uncaught exception handler

2020-11-17 Thread GitBox
wcarlson5 commented on a change in pull request #9487: URL: https://github.com/apache/kafka/pull/9487#discussion_r525444958 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -366,6 +377,90 @@ public void setUncaughtExceptionHandler(final Thre

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9572: KAFKA-10500: Thread Cache Resizes

2020-11-17 Thread GitBox
wcarlson5 commented on a change in pull request #9572: URL: https://github.com/apache/kafka/pull/9572#discussion_r525459352 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -806,6 +803,13 @@ private KafkaStreams(final InternalTopologyBuilder

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9572: KAFKA-10500: Thread Cache Resizes

2020-11-17 Thread GitBox
wcarlson5 commented on a change in pull request #9572: URL: https://github.com/apache/kafka/pull/9572#discussion_r525463165 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java ## @@ -589,6 +593,10 @@ private void subscribeConsumer

[GitHub] [kafka] cadonna commented on a change in pull request #9572: KAFKA-10500: Thread Cache Resizes

2020-11-17 Thread GitBox
cadonna commented on a change in pull request #9572: URL: https://github.com/apache/kafka/pull/9572#discussion_r525463645 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -806,6 +803,13 @@ private KafkaStreams(final InternalTopologyBuilder i

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9572: KAFKA-10500: Thread Cache Resizes

2020-11-17 Thread GitBox
wcarlson5 commented on a change in pull request #9572: URL: https://github.com/apache/kafka/pull/9572#discussion_r525464495 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/ThreadCache.java ## @@ -71,6 +72,26 @@ public long flushes() { retu

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9572: KAFKA-10500: Thread Cache Resizes

2020-11-17 Thread GitBox
wcarlson5 commented on a change in pull request #9572: URL: https://github.com/apache/kafka/pull/9572#discussion_r525488664 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -806,6 +803,13 @@ private KafkaStreams(final InternalTopologyBuilder

[GitHub] [kafka] abbccdda commented on a change in pull request #9564: KAFKA-10667: add timeout for forwarding requests

2020-11-17 Thread GitBox
abbccdda commented on a change in pull request #9564: URL: https://github.com/apache/kafka/pull/9564#discussion_r525507232 ## File path: clients/src/main/java/org/apache/kafka/clients/RequestCompletionHandler.java ## @@ -24,4 +24,11 @@ void onComplete(ClientResponse res

[GitHub] [kafka] kowshik commented on a change in pull request #9596: KAFKA-10723: Fix LogManager shutdown error handling

2020-11-17 Thread GitBox
kowshik commented on a change in pull request #9596: URL: https://github.com/apache/kafka/pull/9596#discussion_r525527982 ## File path: core/src/test/scala/unit/kafka/log/LogManagerTest.scala ## @@ -83,6 +87,51 @@ class LogManagerTest { log.appendAsLeader(TestUtils.singlet

[GitHub] [kafka] fml2 opened a new pull request #9606: doc: Improve JavaDoc for KGroupedStream.aggregate

2020-11-17 Thread GitBox
fml2 opened a new pull request #9606: URL: https://github.com/apache/kafka/pull/9606 Tell that the store used internally is always a timestamped one. This is related to KAFKA-10722. No tests are necessary because only JavaDoc was changed. ### Committer Checklist (exclude

[GitHub] [kafka] mjsax commented on a change in pull request #9572: KAFKA-10500: Thread Cache Resizes

2020-11-17 Thread GitBox
mjsax commented on a change in pull request #9572: URL: https://github.com/apache/kafka/pull/9572#discussion_r525532300 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -806,6 +803,13 @@ private KafkaStreams(final InternalTopologyBuilder int

[GitHub] [kafka] mjsax commented on a change in pull request #9572: KAFKA-10500: Thread Cache Resizes

2020-11-17 Thread GitBox
mjsax commented on a change in pull request #9572: URL: https://github.com/apache/kafka/pull/9572#discussion_r525533593 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -806,6 +803,20 @@ private KafkaStreams(final InternalTopologyBuilder int

[GitHub] [kafka] mjsax commented on a change in pull request #9572: KAFKA-10500: Thread Cache Resizes

2020-11-17 Thread GitBox
mjsax commented on a change in pull request #9572: URL: https://github.com/apache/kafka/pull/9572#discussion_r525534167 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/ThreadCache.java ## @@ -71,6 +72,22 @@ public long flushes() { return n

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9572: KAFKA-10500: Thread Cache Resizes

2020-11-17 Thread GitBox
wcarlson5 commented on a change in pull request #9572: URL: https://github.com/apache/kafka/pull/9572#discussion_r525536944 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -806,6 +803,20 @@ private KafkaStreams(final InternalTopologyBuilder

[GitHub] [kafka] kowshik commented on pull request #9602: MINOR: Use string interpolation in FinalizedFeatureCache

2020-11-17 Thread GitBox
kowshik commented on pull request #9602: URL: https://github.com/apache/kafka/pull/9602#issuecomment-729226900 @dajac thanks for the review :) This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [kafka] mjsax commented on a change in pull request #9572: KAFKA-10500: Thread Cache Resizes

2020-11-17 Thread GitBox
mjsax commented on a change in pull request #9572: URL: https://github.com/apache/kafka/pull/9572#discussion_r525540418 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -806,6 +803,20 @@ private KafkaStreams(final InternalTopologyBuilder int

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9572: KAFKA-10500: Thread Cache Resizes

2020-11-17 Thread GitBox
wcarlson5 commented on a change in pull request #9572: URL: https://github.com/apache/kafka/pull/9572#discussion_r525541523 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/ThreadCache.java ## @@ -71,6 +72,22 @@ public long flushes() { retu

[GitHub] [kafka] fml2 opened a new pull request #9607: [KAFKA-10722] doc: Described the types of the stores used

2020-11-17 Thread GitBox
fml2 opened a new pull request #9607: URL: https://github.com/apache/kafka/pull/9607 This is related to KAFKA-10722 Sometimes it's important to know the correct type of the store used by streams. E.g. when iterating over its items. ### Committer Checklist (excluded from c

[jira] [Commented] (KAFKA-10722) Timestamped store is used even if not desired

2020-11-17 Thread fml2 (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17234030#comment-17234030 ] fml2 commented on KAFKA-10722: -- I've created [https://github.com/apache/kafka/pull/9606] an

[jira] [Created] (KAFKA-10733) Enforce exception thrown for KafkaProducer txn APIs

2020-11-17 Thread Boyang Chen (Jira)
Boyang Chen created KAFKA-10733: --- Summary: Enforce exception thrown for KafkaProducer txn APIs Key: KAFKA-10733 URL: https://issues.apache.org/jira/browse/KAFKA-10733 Project: Kafka Issue Type:

[GitHub] [kafka] guozhangwang commented on a change in pull request #9569: KAFKA-10687: make ProduceRespone only returns INVALID_PRODUCER_EPOCH

2020-11-17 Thread GitBox
guozhangwang commented on a change in pull request #9569: URL: https://github.com/apache/kafka/pull/9569#discussion_r525559599 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/Callback.java ## @@ -40,6 +40,7 @@ * RecordTooLargeExcepti

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9572: KAFKA-10500: Thread Cache Resizes

2020-11-17 Thread GitBox
wcarlson5 commented on a change in pull request #9572: URL: https://github.com/apache/kafka/pull/9572#discussion_r525561178 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -806,6 +803,20 @@ private KafkaStreams(final InternalTopologyBuilder

[GitHub] [kafka] mjsax commented on a change in pull request #9572: KAFKA-10500: Thread Cache Resizes

2020-11-17 Thread GitBox
mjsax commented on a change in pull request #9572: URL: https://github.com/apache/kafka/pull/9572#discussion_r525540418 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -806,6 +803,20 @@ private KafkaStreams(final InternalTopologyBuilder int

[GitHub] [kafka] mjsax commented on a change in pull request #9572: KAFKA-10500: Thread Cache Resizes

2020-11-17 Thread GitBox
mjsax commented on a change in pull request #9572: URL: https://github.com/apache/kafka/pull/9572#discussion_r525562156 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -806,6 +803,20 @@ private KafkaStreams(final InternalTopologyBuilder int

[GitHub] [kafka] mjsax commented on a change in pull request #9572: KAFKA-10500: Thread Cache Resizes

2020-11-17 Thread GitBox
mjsax commented on a change in pull request #9572: URL: https://github.com/apache/kafka/pull/9572#discussion_r525562156 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -806,6 +803,20 @@ private KafkaStreams(final InternalTopologyBuilder int

[GitHub] [kafka] mjsax commented on a change in pull request #9572: KAFKA-10500: Thread Cache Resizes

2020-11-17 Thread GitBox
mjsax commented on a change in pull request #9572: URL: https://github.com/apache/kafka/pull/9572#discussion_r525562156 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -806,6 +803,20 @@ private KafkaStreams(final InternalTopologyBuilder int

[GitHub] [kafka] hachikuji commented on pull request #9401: KAFKA-9628 Replace Produce request/response with automated protocol

2020-11-17 Thread GitBox
hachikuji commented on pull request #9401: URL: https://github.com/apache/kafka/pull/9401#issuecomment-729258346 Here are a couple additional test runs. This was on Ubuntu 20 (ami-00831fc7c1e3ddc60). The machine type was m5a.xlarge with 200GB gp2 EBS storage. One instance was running the b

[GitHub] [kafka] mjsax commented on a change in pull request #9606: [KAFKA-10722] doc: Improve JavaDoc for KGroupedStream.aggregate

2020-11-17 Thread GitBox
mjsax commented on a change in pull request #9606: URL: https://github.com/apache/kafka/pull/9606#discussion_r525580343 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/KGroupedStream.java ## @@ -381,7 +381,8 @@ * {@link StreamsConfig#COMMIT_INTERVAL_

[GitHub] [kafka] mjsax commented on a change in pull request #9607: [KAFKA-10722] doc: Described the types of the stores used

2020-11-17 Thread GitBox
mjsax commented on a change in pull request #9607: URL: https://github.com/apache/kafka/pull/9607#discussion_r525581704 ## File path: docs/streams/developer-guide/dsl-api.html ## @@ -870,6 +870,12 @@ Stateful transformations depend on state for processing inputs and producing

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9572: KAFKA-10500: Thread Cache Resizes

2020-11-17 Thread GitBox
wcarlson5 commented on a change in pull request #9572: URL: https://github.com/apache/kafka/pull/9572#discussion_r525582298 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -806,6 +803,20 @@ private KafkaStreams(final InternalTopologyBuilder

[GitHub] [kafka] hachikuji commented on a change in pull request #9401: KAFKA-9628 Replace Produce request/response with automated protocol

2020-11-17 Thread GitBox
hachikuji commented on a change in pull request #9401: URL: https://github.com/apache/kafka/pull/9401#discussion_r525586697 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java ## @@ -560,13 +562,24 @@ private void handleProduceResponse(C

[GitHub] [kafka] hachikuji commented on a change in pull request #9564: KAFKA-10667: add timeout for forwarding requests

2020-11-17 Thread GitBox
hachikuji commented on a change in pull request #9564: URL: https://github.com/apache/kafka/pull/9564#discussion_r525598620 ## File path: clients/src/main/java/org/apache/kafka/clients/RequestCompletionHandler.java ## @@ -24,4 +24,11 @@ void onComplete(ClientResponse re

[GitHub] [kafka] hachikuji commented on a change in pull request #9539: KAFKA-10634: Adding LeaderId to Voters list in LeaderChangeMessage

2020-11-17 Thread GitBox
hachikuji commented on a change in pull request #9539: URL: https://github.com/apache/kafka/pull/9539#discussion_r525603946 ## File path: raft/src/main/java/org/apache/kafka/raft/QuorumState.java ## @@ -394,7 +394,7 @@ public void transitionToLeader(long epochStartOffset) thro

[jira] [Created] (KAFKA-10734) Speedup the processing of LeaderAndIsr request

2020-11-17 Thread Lucas Wang (Jira)
Lucas Wang created KAFKA-10734: -- Summary: Speedup the processing of LeaderAndIsr request Key: KAFKA-10734 URL: https://issues.apache.org/jira/browse/KAFKA-10734 Project: Kafka Issue Type: Improv

[GitHub] [kafka] ableegoldman commented on pull request #9568: KAFKA-10689: fix windowed FKJ topology and put checks in assignor to avoid infinite loops

2020-11-17 Thread GitBox
ableegoldman commented on pull request #9568: URL: https://github.com/apache/kafka/pull/9568#issuecomment-729306388 All tests pass, but the build overall is broken due to failure of the new `Travis CI - Pull Request` thing. I can't find anything in the results that indicate an actual probl

[GitHub] [kafka] ableegoldman merged pull request #9568: KAFKA-10689: fix windowed FKJ topology and put checks in assignor to avoid infinite loops

2020-11-17 Thread GitBox
ableegoldman merged pull request #9568: URL: https://github.com/apache/kafka/pull/9568 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] ableegoldman commented on pull request #9568: KAFKA-10689: fix windowed FKJ topology and put checks in assignor to avoid infinite loops

2020-11-17 Thread GitBox
ableegoldman commented on pull request #9568: URL: https://github.com/apache/kafka/pull/9568#issuecomment-729307123 Merged to trunk. Will cherrypick back to 2.7 once the ongoing release completes This is an automated message

[GitHub] [kafka] mattwong949 opened a new pull request #9608: MINOR: Enable testLogCleanerStats

2020-11-17 Thread GitBox
mattwong949 opened a new pull request #9608: URL: https://github.com/apache/kafka/pull/9608 The `testLogCleanerStats` test in `LogCleanerTest.scala` was not enabled but it was implemented. This PR adds the @Test annotation, and also gives it a larger map to allow the test to pass as intend

[GitHub] [kafka] hachikuji commented on pull request #9100: Add AlterISR RPC and use it for ISR modifications

2020-11-17 Thread GitBox
hachikuji commented on pull request #9100: URL: https://github.com/apache/kafka/pull/9100#issuecomment-729316632 @jacky1193610322 I missed this comment before. It's a good question. In general, the leader will continue in its current state as long as possible. As you say, as soon as it nee

[GitHub] [kafka] ableegoldman commented on a change in pull request #9487: KAFKA-9331: Add a streams specific uncaught exception handler

2020-11-17 Thread GitBox
ableegoldman commented on a change in pull request #9487: URL: https://github.com/apache/kafka/pull/9487#discussion_r525636554 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -366,6 +377,90 @@ public void setUncaughtExceptionHandler(final T

[GitHub] [kafka] ableegoldman commented on a change in pull request #9487: KAFKA-9331: Add a streams specific uncaught exception handler

2020-11-17 Thread GitBox
ableegoldman commented on a change in pull request #9487: URL: https://github.com/apache/kafka/pull/9487#discussion_r525640088 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -932,56 +1028,62 @@ public synchronized boolean close(final long t

[GitHub] [kafka] hachikuji commented on a change in pull request #9608: MINOR: Enable testLogCleanerStats

2020-11-17 Thread GitBox
hachikuji commented on a change in pull request #9608: URL: https://github.com/apache/kafka/pull/9608#discussion_r525646356 ## File path: core/src/test/scala/unit/kafka/log/LogCleanerTest.scala ## @@ -815,9 +815,10 @@ class LogCleanerTest { (0 until leo.toInt by

[GitHub] [kafka] ableegoldman commented on a change in pull request #9487: KAFKA-9331: Add a streams specific uncaught exception handler

2020-11-17 Thread GitBox
ableegoldman commented on a change in pull request #9487: URL: https://github.com/apache/kafka/pull/9487#discussion_r525650632 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -932,56 +1028,62 @@ public synchronized boolean close(final long t

[GitHub] [kafka] ableegoldman commented on a change in pull request #9487: KAFKA-9331: Add a streams specific uncaught exception handler

2020-11-17 Thread GitBox
ableegoldman commented on a change in pull request #9487: URL: https://github.com/apache/kafka/pull/9487#discussion_r525658639 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStreamThread.java ## @@ -311,6 +314,8 @@ public void run() {

[GitHub] [kafka] ableegoldman commented on a change in pull request #9487: KAFKA-9331: Add a streams specific uncaught exception handler

2020-11-17 Thread GitBox
ableegoldman commented on a change in pull request #9487: URL: https://github.com/apache/kafka/pull/9487#discussion_r525663640 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java ## @@ -559,18 +552,51 @@ void runLoop() {

[jira] [Created] (KAFKA-10735) Kafka producer producing corrupted avro values when confluent cluster is recreated and producer application is not restarted

2020-11-17 Thread Tim Tattersall (Jira)
Tim Tattersall created KAFKA-10735: -- Summary: Kafka producer producing corrupted avro values when confluent cluster is recreated and producer application is not restarted Key: KAFKA-10735 URL: https://issues.apac

  1   2   >