abbccdda commented on a change in pull request #9564:
URL: https://github.com/apache/kafka/pull/9564#discussion_r525507232
##########
File path:
clients/src/main/java/org/apache/kafka/clients/RequestCompletionHandler.java
##########
@@ -24,4 +24,11 @@
void onComplete(ClientResponse response);
+ /**
+ * Fire when the request transmission hits a fatal exception.
+ *
+ * @param exception the thrown exception
+ */
+ default void onFailure(RuntimeException exception) {
Review comment:
We do have a case in `ConsumerNetworkClient` which adds an `onFailure`
callback. To me it makes sense to include it as part of the
RequestCompletionHandler interface.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
