dajac commented on a change in pull request #9573:
URL: https://github.com/apache/kafka/pull/9573#discussion_r519620665
##
File path: core/src/test/scala/unit/kafka/server/IsrExpirationTest.scala
##
@@ -62,14 +64,16 @@ class IsrExpirationTest {
EasyMock.replay(logManager)
chia7712 commented on pull request #9401:
URL: https://github.com/apache/kafka/pull/9401#issuecomment-723875285
> Can we summarize the regression here for a real world workload?
@ijuma I have attached benchmark result to description. I will loop more
benchmark later.
--
dajac commented on pull request #9386:
URL: https://github.com/apache/kafka/pull/9386#issuecomment-723887856
@splett2 Code does not compile:
```
[Error]
/home/jenkins/jenkins-agent/workspace/Kafka_kafka-pr_PR-9386/core/src/main/scala/kafka/network/SocketServer.scala:1456:
value getOr
[
https://issues.apache.org/jira/browse/KAFKA-10688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17228465#comment-17228465
]
Bruno Cadonna commented on KAFKA-10688:
---
Maybe I misunderstood your previous comme
ghmulti commented on pull request #9489:
URL: https://github.com/apache/kafka/pull/9489#issuecomment-723911887
There is a lot of useful information on an INFO level, but as you mentioned
- having that line from several threads with 100ms frequency makes it way too
noisy (especially when co
ghmulti edited a comment on pull request #9489:
URL: https://github.com/apache/kafka/pull/9489#issuecomment-723911887
There is a lot of useful information on an INFO level, but as you mentioned
- having that line from several threads with 100ms frequency makes it way too
noisy (especially
showuon opened a new pull request #9576:
URL: https://github.com/apache/kafka/pull/9576
Strictly parsing the date/time format by setLenient(false). So it won't
allow un-matched date/time format input to avoid the wrong parsing for
microseconds/nanoseconds.
### Committer Checklist (e
Rajini Sivaram created KAFKA-10700:
--
Summary: Support mutual TLS authentication for SASL_SSL listeners
Key: KAFKA-10700
URL: https://issues.apache.org/jira/browse/KAFKA-10700
Project: Kafka
dengziming opened a new pull request #9577:
URL: https://github.com/apache/kafka/pull/9577
This patch implements
[KIP-589](https://cwiki.apache.org/confluence/display/KAFKA/KIP-589+Add+API+to+update+Replica+state+in+Controller),
which introduces an asynchronous API for brokers to notifying
[
https://issues.apache.org/jira/browse/KAFKA-7908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17228514#comment-17228514
]
nandini commented on KAFKA-7908:
This applies to older versions too. Just found this in 0
dengziming commented on pull request #9577:
URL: https://github.com/apache/kafka/pull/9577#issuecomment-723936352
@mumrah @hachikuji @bbejeck Hi, PTAL.
This is an automated message from the Apache Git Service.
To respond to
rajinisivaram commented on pull request #9382:
URL: https://github.com/apache/kafka/pull/9382#issuecomment-723946383
Ran system tests on the latest version, there were 7 failures which look
like flaky tests that also fail on trunk (one TransactionTest and 6 variants of
ConnectDistributedTe
jeqo commented on a change in pull request #9078:
URL: https://github.com/apache/kafka/pull/9078#discussion_r519741816
##
File path:
clients/src/main/java/org/apache/kafka/common/metrics/JmxReporter.java
##
@@ -272,8 +272,16 @@ public MBeanInfo getMBeanInfo() {
fo
[
https://issues.apache.org/jira/browse/KAFKA-10685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17228542#comment-17228542
]
Luke Chen commented on KAFKA-10685:
---
Thanks for the suggestion. It turns out that the
showuon commented on pull request #9576:
URL: https://github.com/apache/kafka/pull/9576#issuecomment-723973014
@mikebin @manijndl7 @mjsax , please help review this PR. Thanks.
This is an automated message from the Apache Git
showuon commented on pull request #9507:
URL: https://github.com/apache/kafka/pull/9507#issuecomment-723974389
@chia7712 @vvcephei , please help review this PR. Thanks.
This is an automated message from the Apache Git Service
showuon commented on pull request #9104:
URL: https://github.com/apache/kafka/pull/9104#issuecomment-723981295
@kkonstantine , please help review this PR. Thanks.
This is an automated message from the Apache Git Service.
To r
rajinisivaram opened a new pull request #9578:
URL: https://github.com/apache/kafka/pull/9578
At the moment, we have one log entry for ACL updates that says:
```
Processing notification(s) to /kafka-acl-changes
```
For other updates like broker configuration updates, we have an a
David Arthur created KAFKA-10701:
Summary: First line of detailed stats from consumer-perf-test.sh
incorrect
Key: KAFKA-10701
URL: https://issues.apache.org/jira/browse/KAFKA-10701
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-10701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Arthur updated KAFKA-10701:
-
Description:
When running the console perf test with {{--show-detailed-stats}}, the first
line
splett2 commented on a change in pull request #9573:
URL: https://github.com/apache/kafka/pull/9573#discussion_r519873954
##
File path: core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala
##
@@ -1506,7 +1508,7 @@ class ReplicaManagerTest {
purgatoryName = "Ele
tombentley commented on pull request #9433:
URL: https://github.com/apache/kafka/pull/9433#issuecomment-724077206
@chia7712 is there anything more you needed on this PR?
This is an automated message from the Apache Git Servic
splett2 commented on a change in pull request #9573:
URL: https://github.com/apache/kafka/pull/9573#discussion_r519894386
##
File path: core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala
##
@@ -1894,10 +1894,10 @@ class ReplicaManagerTest {
// each replica ma
splett2 commented on a change in pull request #9573:
URL: https://github.com/apache/kafka/pull/9573#discussion_r519894386
##
File path: core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala
##
@@ -1894,10 +1894,10 @@ class ReplicaManagerTest {
// each replica ma
dajac commented on a change in pull request #9573:
URL: https://github.com/apache/kafka/pull/9573#discussion_r519922038
##
File path: core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala
##
@@ -1506,7 +1508,7 @@ class ReplicaManagerTest {
purgatoryName = "Elect
stanislavkozlovski commented on pull request #7498:
URL: https://github.com/apache/kafka/pull/7498#issuecomment-724117161
> guess this is a nitpick, but I'd rather not construct an error message
when I might or might not need it (and won't in the common, error-free case.)
@cmccabe w
splett2 commented on a change in pull request #9573:
URL: https://github.com/apache/kafka/pull/9573#discussion_r519894386
##
File path: core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala
##
@@ -1894,10 +1894,10 @@ class ReplicaManagerTest {
// each replica ma
splett2 commented on a change in pull request #9573:
URL: https://github.com/apache/kafka/pull/9573#discussion_r519894386
##
File path: core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala
##
@@ -1894,10 +1894,10 @@ class ReplicaManagerTest {
// each replica ma
omkreddy commented on pull request #9556:
URL: https://github.com/apache/kafka/pull/9556#issuecomment-724131363
Merging to trunk and older branches.
This is an automated message from the Apache Git Service.
To respond to the
hachikuji commented on a change in pull request #9563:
URL: https://github.com/apache/kafka/pull/9563#discussion_r519955199
##
File path:
clients/src/main/java/org/apache/kafka/common/requests/EnvelopeRequest.java
##
@@ -91,4 +91,14 @@ public AbstractResponse getErrorResponse(
omkreddy closed pull request #9556:
URL: https://github.com/apache/kafka/pull/9556
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
hachikuji commented on a change in pull request #9531:
URL: https://github.com/apache/kafka/pull/9531#discussion_r519965008
##
File path: raft/src/main/java/org/apache/kafka/raft/QuorumState.java
##
@@ -21,18 +21,21 @@
import org.slf4j.Logger;
import java.io.IOException;
+i
niteshmor commented on pull request #9556:
URL: https://github.com/apache/kafka/pull/9556#issuecomment-724139651
Thanks @omkreddy
For older releases, feel free to use the commits noted in
https://github.com/apache/kafka/pull/9556#issuecomment-721898016 as a
reference. Git cherry-pickin
hachikuji commented on a change in pull request #9531:
URL: https://github.com/apache/kafka/pull/9531#discussion_r519968145
##
File path: raft/src/main/java/org/apache/kafka/raft/QuorumState.java
##
@@ -21,18 +21,21 @@
import org.slf4j.Logger;
import java.io.IOException;
+i
hachikuji commented on a change in pull request #9531:
URL: https://github.com/apache/kafka/pull/9531#discussion_r519969208
##
File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java
##
@@ -1601,7 +1618,12 @@ private long pollFollower(long currentTimeMs) throws
vamossagar12 commented on a change in pull request #9508:
URL: https://github.com/apache/kafka/pull/9508#discussion_r519969912
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBPrefixIterator.java
##
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Ap
vamossagar12 commented on pull request #9508:
URL: https://github.com/apache/kafka/pull/9508#issuecomment-724142512
> @vamossagar12, Thank you for the PR!
>
> Here my feedback!
@cadonna thanks i made the requeiste changes barring 1.
--
hachikuji commented on a change in pull request #9563:
URL: https://github.com/apache/kafka/pull/9563#discussion_r519971686
##
File path:
generator/src/main/java/org/apache/kafka/message/MessageDataGenerator.java
##
@@ -1579,58 +1566,58 @@ private void generateVariableLengthFi
omkreddy edited a comment on pull request #9556:
URL: https://github.com/apache/kafka/pull/9556#issuecomment-724131363
Merging to trunk and older branches (2.7, 2.6, 2.5, 2.4)
This is an automated message from the Apache Git
hachikuji commented on a change in pull request #9563:
URL: https://github.com/apache/kafka/pull/9563#discussion_r519983517
##
File path:
clients/src/main/java/org/apache/kafka/common/requests/EnvelopeRequest.java
##
@@ -91,4 +91,14 @@ public AbstractResponse getErrorResponse(
[
https://issues.apache.org/jira/browse/KAFKA-10699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Boyang Chen reassigned KAFKA-10699:
---
Assignee: feyman
> Add system test coverage for group coordinator emigration
>
abbccdda opened a new pull request #9579:
URL: https://github.com/apache/kafka/pull/9579
This PR forward the entire FindCoordinator request to the active controller
when the internal topic being queried is not ready to be served yet.
### Committer Checklist (excluded from commit mess
[
https://issues.apache.org/jira/browse/KAFKA-9751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Boyang Chen reassigned KAFKA-9751:
--
Assignee: Boyang Chen
> Internal topic creation should go to controller
>
guozhangwang commented on a change in pull request #9531:
URL: https://github.com/apache/kafka/pull/9531#discussion_r520020029
##
File path: raft/src/main/java/org/apache/kafka/raft/QuorumState.java
##
@@ -21,18 +21,21 @@
import org.slf4j.Logger;
import java.io.IOException;
guozhangwang commented on pull request #9531:
URL: https://github.com/apache/kafka/pull/9531#issuecomment-724186172
LGTM.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
Jason Gustafson created KAFKA-10702:
---
Summary: Slow replication of empty transactions
Key: KAFKA-10702
URL: https://issues.apache.org/jira/browse/KAFKA-10702
Project: Kafka
Issue Type: Bug
C0urante commented on pull request #9549:
URL: https://github.com/apache/kafka/pull/9549#issuecomment-724213528
Thanks for reaching out @tombentley! Happy to take a look.
For reference, maybe you could add a link to
https://cwiki.apache.org/confluence/display/KAFKA/KIP-145+-+Expose+R
ableegoldman commented on a change in pull request #9487:
URL: https://github.com/apache/kafka/pull/9487#discussion_r520077048
##
File path: streams/src/main/resources/common/message/SubscriptionInfoData.json
##
@@ -57,6 +57,11 @@
"name": "uniqueField",
"versions"
C0urante commented on a change in pull request #9549:
URL: https://github.com/apache/kafka/pull/9549#discussion_r520056667
##
File path:
connect/transforms/src/main/java/org/apache/kafka/connect/transforms/HeaderFrom.java
##
@@ -0,0 +1,219 @@
+/*
+ * Licensed to the Apache Sof
wcarlson5 commented on a change in pull request #9487:
URL: https://github.com/apache/kafka/pull/9487#discussion_r520104884
##
File path: streams/src/main/resources/common/message/SubscriptionInfoData.json
##
@@ -57,6 +57,11 @@
"name": "uniqueField",
"versions": "
wcarlson5 commented on a change in pull request #9487:
URL: https://github.com/apache/kafka/pull/9487#discussion_r520104884
##
File path: streams/src/main/resources/common/message/SubscriptionInfoData.json
##
@@ -57,6 +57,11 @@
"name": "uniqueField",
"versions": "
abbccdda opened a new pull request #9580:
URL: https://github.com/apache/kafka/pull/9580
Add metric for forwarding request tracking. Note that the implementation is
slightly diverged from the KIP, where we decide to get rid of the client.id tag
since most admin clients would only have one
hachikuji merged pull request #9531:
URL: https://github.com/apache/kafka/pull/9531
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
[
https://issues.apache.org/jira/browse/KAFKA-10661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson resolved KAFKA-10661.
-
Resolution: Fixed
> Add resigned state to raft state machine to preserve leader/epoch in
mimaison commented on pull request #9545:
URL: https://github.com/apache/kafka/pull/9545#issuecomment-724322506
Groups created on the target cluster by KAFKA-9076 are "simple groups" as
there's no member information.
Not entirely sure why these were explicitly filtered. I can't immediate
mimaison commented on pull request #9224:
URL: https://github.com/apache/kafka/pull/9224#issuecomment-724323408
@ning2008wisc I've not forgotten this PR, I just haven't had time to do
reviews yet :(
This is an automated mes
[
https://issues.apache.org/jira/browse/KAFKA-10688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17228844#comment-17228844
]
Guozhang Wang commented on KAFKA-10688:
---
Normally the repartition topic should nev
wcarlson5 commented on pull request #9581:
URL: https://github.com/apache/kafka/pull/9581#issuecomment-724347812
https://github.com/apache/kafka/pull/9572 need to get this merged first
This is an automated message from the Ap
wcarlson5 opened a new pull request #9581:
URL: https://github.com/apache/kafka/pull/9581
Can add stream threads now
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify docu
Colin McCabe created KAFKA-10703:
Summary: Document that default configs are not supported for TOPIC
entities
Key: KAFKA-10703
URL: https://issues.apache.org/jira/browse/KAFKA-10703
Project: Kafka
scanterog commented on pull request #9545:
URL: https://github.com/apache/kafka/pull/9545#issuecomment-724379519
> Groups created on the target cluster by KAFKA-9076 are "simple groups" as
there's no member information.
> Not entirely sure why these were explicitly filtered. I can't imme
[
https://issues.apache.org/jira/browse/KAFKA-10575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17228890#comment-17228890
]
Richard Yu commented on KAFKA-10575:
[~guozhang] I'm interested in picking this one
junrao commented on a change in pull request #8826:
URL: https://github.com/apache/kafka/pull/8826#discussion_r520225611
##
File path:
clients/src/main/java/org/apache/kafka/common/network/ChannelBuilders.java
##
@@ -159,24 +159,25 @@ private static ChannelBuilder create(Secur
ableegoldman commented on pull request #9489:
URL: https://github.com/apache/kafka/pull/9489#issuecomment-724391259
That's fair. Ok I'll go forward with demoting this and just add a new
INFO-level log that's less frequent, maybe at the max poll interval
---
chia7712 commented on a change in pull request #8826:
URL: https://github.com/apache/kafka/pull/8826#discussion_r520237060
##
File path:
clients/src/main/java/org/apache/kafka/common/network/ChannelBuilders.java
##
@@ -159,24 +159,25 @@ private static ChannelBuilder create(Sec
vamossagar12 commented on pull request #9508:
URL: https://github.com/apache/kafka/pull/9508#issuecomment-724420818
@cadonna , The failing tests here
https://github.com/apache/kafka/pull/9508/checks?check_run_id=1376108664 don't
seem to be related to this PR. Would it be possible to retest
[
https://issues.apache.org/jira/browse/KAFKA-10346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Boyang Chen updated KAFKA-10346:
Description: At the moment, topic creation policy is not enforced on auto
topic creation path for
[
https://issues.apache.org/jira/browse/KAFKA-9751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Boyang Chen updated KAFKA-9751:
---
Summary: Auto topic creation should go to controller (was: Internal topic
creation should go to cont
ableegoldman opened a new pull request #9582:
URL: https://github.com/apache/kafka/pull/9582
Needed to fix this on the side in order to more easily set up some
experiments, so here's the PR.
Allows a user to create multiple KStreams from the same topic, collection of
topics, or patt
abbccdda commented on pull request #9558:
URL: https://github.com/apache/kafka/pull/9558#issuecomment-724447477
@mumrah for a review
This is an automated message from the Apache Git Service.
To respond to the message, please
[
https://issues.apache.org/jira/browse/KAFKA-7908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17228975#comment-17228975
]
nandini commented on KAFKA-7908:
The bug relates to - https://issues.apache.org/jira/brow
chia7712 commented on a change in pull request #8826:
URL: https://github.com/apache/kafka/pull/8826#discussion_r520293926
##
File path:
clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java
##
@@ -105,7 +105,9 @@ public AbstractConfig(ConfigDef definition,
chia7712 commented on a change in pull request #9204:
URL: https://github.com/apache/kafka/pull/9204#discussion_r520297478
##
File path: core/src/main/scala/kafka/tools/DumpLogSegments.scala
##
@@ -257,8 +257,11 @@ object DumpLogSegments {
}
lastOffset
chia7712 commented on pull request #9433:
URL: https://github.com/apache/kafka/pull/9433#issuecomment-724472427
Could you offer test to make sure ```None``` is included.
Personally, the implementations of ```errorCounts``` are almost same. Maybe
it should be implemented
by auto-g
iprithv commented on a change in pull request #9204:
URL: https://github.com/apache/kafka/pull/9204#discussion_r520336051
##
File path: core/src/main/scala/kafka/tools/DumpLogSegments.scala
##
@@ -257,8 +257,11 @@ object DumpLogSegments {
}
lastOffset
[
https://issues.apache.org/jira/browse/KAFKA-10694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17229029#comment-17229029
]
lqjacklee commented on KAFKA-10694:
---
[~jagsancio] Can I take the task?
> Implement z
76 matches
Mail list logo
