hachikuji commented on a change in pull request #9531:
URL: https://github.com/apache/kafka/pull/9531#discussion_r519965008
##########
File path: raft/src/main/java/org/apache/kafka/raft/QuorumState.java
##########
@@ -21,18 +21,21 @@
import org.slf4j.Logger;
import java.io.IOException;
+import java.util.Collections;
import java.util.HashSet;
+import java.util.List;
import java.util.Optional;
import java.util.OptionalInt;
import java.util.Random;
import java.util.Set;
import java.util.stream.Collectors;
/**
- * This class is responsible for managing the current state of this node and
ensuring only
- * valid state transitions.
+ * This class is responsible for managing the current state of this node and
ensuring
+ * only valid state transitions. Below we define the possible state
transitions and
+ * how they are triggered:
*
- * Unattached =>
+ * Unattached|Resigned =>
Review comment:
Hmm.. The quorum size does not change because a leader resigns. If there
are 2N nodes in the cluster, then we always need N + 1 votes, so I don't think
this case is possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
