[GitHub] [kafka] dongjinleekr commented on pull request #9414: KAFKA-10585: Kafka Streams should clean up the state store directory from cleanup

2020-10-22 Thread GitBox
dongjinleekr commented on pull request #9414: URL: https://github.com/apache/kafka/pull/9414#issuecomment-714293384 @vvcephei Here it is; I deleted a outdated condition statement in `EOSUncleanShutdownIntegrationTest`. This

[jira] [Updated] (KAFKA-10233) KafkaConsumer polls in a tight loop if group is not authorized

2020-10-22 Thread Rajini Sivaram (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajini Sivaram updated KAFKA-10233: --- Fix Version/s: (was: 2.7.0) 2.8.0 > KafkaConsumer polls in a tight lo

[GitHub] [kafka] chia7712 commented on a change in pull request #9426: MINOR: Fix flaky shouldRejectNonExistentStoreName

2020-10-22 Thread GitBox
chia7712 commented on a change in pull request #9426: URL: https://github.com/apache/kafka/pull/9426#discussion_r509966875 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/QueryableStateIntegrationTest.java ## @@ -470,6 +475,8 @@ public void shouldRejec

[GitHub] [kafka] chia7712 commented on pull request #9449: MINOR: simplify implementation of ConsumerGroupOperationContext.hasCo…

2020-10-22 Thread GitBox
chia7712 commented on pull request #9449: URL: https://github.com/apache/kafka/pull/9449#issuecomment-714323620 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [kafka] chia7712 merged pull request #9442: MINOR: optimize unrecordedVoters method

2020-10-22 Thread GitBox
chia7712 merged pull request #9442: URL: https://github.com/apache/kafka/pull/9442 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] chia7712 commented on pull request #9442: MINOR: optimize unrecordedVoters method

2020-10-22 Thread GitBox
chia7712 commented on pull request #9442: URL: https://github.com/apache/kafka/pull/9442#issuecomment-714330436 @dengziming Thanks for your patch! This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [kafka] chia7712 merged pull request #8870: MINOR: Fix timestampDelta type in doc

2020-10-22 Thread GitBox
chia7712 merged pull request #8870: URL: https://github.com/apache/kafka/pull/8870 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] chia7712 commented on pull request #9195: KAFKA-10092 Remove unnecessary enum modifier in NioEchoServer

2020-10-22 Thread GitBox
chia7712 commented on pull request #9195: URL: https://github.com/apache/kafka/pull/9195#issuecomment-714341174 @Sasilekha This PR is duplicate to https://github.com/apache/kafka/pull/8794 which was created before your PR (Also, https://issues.apache.org/jira/browse/KAFKA-10092 is assigned

[GitHub] [kafka] chia7712 commented on pull request #9180: MINOR: corrected unit tests in AbstractConfigTest.java- fixed invalid assertions

2020-10-22 Thread GitBox
chia7712 commented on pull request #9180: URL: https://github.com/apache/kafka/pull/9180#issuecomment-714342115 @sanketfajage Could you rebase code to trigger QA again ( I believe those failed tests are unrelated to you PR. ) ---

[GitHub] [kafka] chia7712 merged pull request #9449: MINOR: simplify implementation of ConsumerGroupOperationContext.hasCo…

2020-10-22 Thread GitBox
chia7712 merged pull request #9449: URL: https://github.com/apache/kafka/pull/9449 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[jira] [Created] (KAFKA-10626) Add support for max.in.flight.requests.per.connection behaviour in MockClient

2020-10-22 Thread Rajini Sivaram (Jira)
Rajini Sivaram created KAFKA-10626: -- Summary: Add support for max.in.flight.requests.per.connection behaviour in MockClient Key: KAFKA-10626 URL: https://issues.apache.org/jira/browse/KAFKA-10626 Pr

[GitHub] [kafka] rajinisivaram commented on a change in pull request #9406: KAFKA-10520; Ensure transactional producers poll if leastLoadedNode not available with max.in.flight=1

2020-10-22 Thread GitBox
rajinisivaram commented on a change in pull request #9406: URL: https://github.com/apache/kafka/pull/9406#discussion_r510009333 ## File path: clients/src/test/java/org/apache/kafka/clients/producer/internals/SenderTest.java ## @@ -2667,4 +2760,43 @@ private void assertFutureFa

[GitHub] [kafka] dongjinleekr commented on a change in pull request #9459: MINOR: Add some class javadoc to Admin client

2020-10-22 Thread GitBox
dongjinleekr commented on a change in pull request #9459: URL: https://github.com/apache/kafka/pull/9459#discussion_r510012458 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/Admin.java ## @@ -519,7 +519,6 @@ AlterConfigsResult incrementalAlterConfigs(Map

[GitHub] [kafka] thake commented on pull request #9467: KAFKA-10515: Properly initialize nullable Serdes with default values

2020-10-22 Thread GitBox
thake commented on pull request #9467: URL: https://github.com/apache/kafka/pull/9467#issuecomment-714453353 > Ah, it also looks like a bunch of tests fail due to EasyMock expectations being needed, and I also saw a couple of the null checks failling. @vvcephei Actually I think that

[GitHub] [kafka] chia7712 merged pull request #9459: MINOR: Add some class javadoc to Admin client

2020-10-22 Thread GitBox
chia7712 merged pull request #9459: URL: https://github.com/apache/kafka/pull/9459 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] tombentley commented on pull request #9266: KAFKA-10469: Resolve logger levels hierarchically

2020-10-22 Thread GitBox
tombentley commented on pull request #9266: URL: https://github.com/apache/kafka/pull/9266#issuecomment-714458486 @ijuma [KIP-676](https://cwiki.apache.org/confluence/display/KAFKA/KIP-676%3A+Respect+logging+hierarchy?moved=true) has been approved, so I think we should be able to merge thi

[jira] [Created] (KAFKA-10627) Connect TimestampConverter transform does not support multiple formats for the same field and only allows one field to be transformed at a time

2020-10-22 Thread Joshua Grisham (Jira)
Joshua Grisham created KAFKA-10627: -- Summary: Connect TimestampConverter transform does not support multiple formats for the same field and only allows one field to be transformed at a time Key: KAFKA-10627 URL:

[GitHub] [kafka] thake opened a new pull request #9478: Fixed unit test mocks and incorrect required context serdes.

2020-10-22 Thread GitBox
thake opened a new pull request #9478: URL: https://github.com/apache/kafka/pull/9478 Fixed an incorrect requireNonNull on the context Serdes introduced with #9338 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test

[GitHub] [kafka] thake commented on pull request #9467: KAFKA-10515: Properly initialize nullable Serdes with default values

2020-10-22 Thread GitBox
thake commented on pull request #9467: URL: https://github.com/apache/kafka/pull/9467#issuecomment-714468419 Also fixed this error in #9478 for trunk. Should also be cherry picked to 2.7. Otherwise, every Stream topology without a default serde will fail if it uses foreign key joins.

[GitHub] [kafka] chia7712 commented on a change in pull request #9477: MINOR: TopologyTestDriver should not require dummy parameters

2020-10-22 Thread GitBox
chia7712 commented on a change in pull request #9477: URL: https://github.com/apache/kafka/pull/9477#discussion_r510126004 ## File path: streams/test-utils/src/main/java/org/apache/kafka/streams/TopologyTestDriver.java ## @@ -297,7 +297,15 @@ public TopologyTestDriver(final To

[GitHub] [kafka] chia7712 commented on a change in pull request #9477: MINOR: TopologyTestDriver should not require dummy parameters

2020-10-22 Thread GitBox
chia7712 commented on a change in pull request #9477: URL: https://github.com/apache/kafka/pull/9477#discussion_r510131798 ## File path: streams/test-utils/src/main/java/org/apache/kafka/streams/TopologyTestDriver.java ## @@ -297,7 +297,15 @@ public TopologyTestDriver(final To

[GitHub] [kafka] vvcephei merged pull request #9477: MINOR: TopologyTestDriver should not require dummy parameters

2020-10-22 Thread GitBox
vvcephei merged pull request #9477: URL: https://github.com/apache/kafka/pull/9477 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] vvcephei commented on pull request #9477: MINOR: TopologyTestDriver should not require dummy parameters

2020-10-22 Thread GitBox
vvcephei commented on pull request #9477: URL: https://github.com/apache/kafka/pull/9477#issuecomment-714490489 Oh, sorry, @chia7712 ! I was looking at a cached copy of the page when I merged. Your comments only loaded afterward. The answer to your question is that I'm planning to ma

[GitHub] [kafka] vvcephei commented on a change in pull request #9477: MINOR: TopologyTestDriver should not require dummy parameters

2020-10-22 Thread GitBox
vvcephei commented on a change in pull request #9477: URL: https://github.com/apache/kafka/pull/9477#discussion_r510157496 ## File path: streams/test-utils/src/main/java/org/apache/kafka/streams/TopologyTestDriver.java ## @@ -297,7 +297,15 @@ public TopologyTestDriver(final To

[GitHub] [kafka] vvcephei commented on a change in pull request #9477: MINOR: TopologyTestDriver should not require dummy parameters

2020-10-22 Thread GitBox
vvcephei commented on a change in pull request #9477: URL: https://github.com/apache/kafka/pull/9477#discussion_r510157857 ## File path: streams/test-utils/src/main/java/org/apache/kafka/streams/TopologyTestDriver.java ## @@ -297,7 +297,15 @@ public TopologyTestDriver(final To

[GitHub] [kafka] chia7712 commented on pull request #9477: MINOR: TopologyTestDriver should not require dummy parameters

2020-10-22 Thread GitBox
chia7712 commented on pull request #9477: URL: https://github.com/apache/kafka/pull/9477#issuecomment-714491362 @vvcephei Don't worry. The patch LGTM 👍 This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] vvcephei commented on pull request #9477: MINOR: TopologyTestDriver should not require dummy parameters

2020-10-22 Thread GitBox
vvcephei commented on pull request #9477: URL: https://github.com/apache/kafka/pull/9477#issuecomment-714500679 Thanks @chia7712 . Just cherry-picked to 2.7 @bbejeck This is an automated message from the Apache Git Se

[jira] [Created] (KAFKA-10628) Follow-up: Remove all unnecessary dummy TopologyTestDriver configs

2020-10-22 Thread John Roesler (Jira)
John Roesler created KAFKA-10628: Summary: Follow-up: Remove all unnecessary dummy TopologyTestDriver configs Key: KAFKA-10628 URL: https://issues.apache.org/jira/browse/KAFKA-10628 Project: Kafka

[jira] [Updated] (KAFKA-10628) Follow-up: Remove all unnecessary dummy TopologyTestDriver configs

2020-10-22 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-10628: - Component/s: streams-test-utils > Follow-up: Remove all unnecessary dummy TopologyTestDriver con

[jira] [Updated] (KAFKA-10628) Follow-up: Remove all unnecessary dummy TopologyTestDriver configs

2020-10-22 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-10628: - Component/s: streams > Follow-up: Remove all unnecessary dummy TopologyTestDriver configs >

[jira] [Updated] (KAFKA-10628) Follow-up: Remove all unnecessary dummy TopologyTestDriver configs

2020-10-22 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-10628: - Labels: newbie (was: ) > Follow-up: Remove all unnecessary dummy TopologyTestDriver configs > -

[jira] [Created] (KAFKA-10629) TopologyTestDriver should not require a Properties arg

2020-10-22 Thread John Roesler (Jira)
John Roesler created KAFKA-10629: Summary: TopologyTestDriver should not require a Properties arg Key: KAFKA-10629 URL: https://issues.apache.org/jira/browse/KAFKA-10629 Project: Kafka Issue

[jira] [Created] (KAFKA-10630) State Directory config could be improved

2020-10-22 Thread John Roesler (Jira)
John Roesler created KAFKA-10630: Summary: State Directory config could be improved Key: KAFKA-10630 URL: https://issues.apache.org/jira/browse/KAFKA-10630 Project: Kafka Issue Type: Task

[GitHub] [kafka] vvcephei commented on pull request #9477: MINOR: TopologyTestDriver should not require dummy parameters

2020-10-22 Thread GitBox
vvcephei commented on pull request #9477: URL: https://github.com/apache/kafka/pull/9477#issuecomment-714550389 Ok, here are the follow-up tickets I filed: * https://issues.apache.org/jira/browse/KAFKA-10628 * https://issues.apache.org/jira/browse/KAFKA-10629 * https://issues.apache

[GitHub] [kafka] vvcephei commented on pull request #9270: KAFKA-10284: Group membership update due to static member rejoin should be persisted

2020-10-22 Thread GitBox
vvcephei commented on pull request #9270: URL: https://github.com/apache/kafka/pull/9270#issuecomment-714551566 The test failure was unrelated: Build / JDK 15 / org.apache.kafka.streams.integration.EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta[true]

[GitHub] [kafka] vvcephei merged pull request #9270: KAFKA-10284: Group membership update due to static member rejoin should be persisted

2020-10-22 Thread GitBox
vvcephei merged pull request #9270: URL: https://github.com/apache/kafka/pull/9270 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[jira] [Updated] (KAFKA-10284) Group membership update due to static member rejoin should be persisted

2020-10-22 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-10284: - Fix Version/s: 2.7.0 > Group membership update due to static member rejoin should be persisted >

[GitHub] [kafka] vvcephei commented on pull request #9270: KAFKA-10284: Group membership update due to static member rejoin should be persisted

2020-10-22 Thread GitBox
vvcephei commented on pull request #9270: URL: https://github.com/apache/kafka/pull/9270#issuecomment-714559804 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [kafka] vvcephei commented on pull request #9478: Fixed unit test mocks and incorrect required context serdes.

2020-10-22 Thread GitBox
vvcephei commented on pull request #9478: URL: https://github.com/apache/kafka/pull/9478#issuecomment-714562224 Thanks for this, @thake! I'm wondering if this is the right direction to go here. In a real Streams application, as well as in MockProcessorContext and TopologyTestDriver,

[GitHub] [kafka] vvcephei commented on pull request #9467: KAFKA-10515: Properly initialize nullable Serdes with default values

2020-10-22 Thread GitBox
vvcephei commented on pull request #9467: URL: https://github.com/apache/kafka/pull/9467#issuecomment-714564666 Ahh, I already commented on https://github.com/apache/kafka/pull/9478, but I think now I see the motivation for that PR. If it was indeed just because there are internal te

[GitHub] [kafka] vvcephei commented on pull request #9478: Fixed unit test mocks and incorrect required context serdes.

2020-10-22 Thread GitBox
vvcephei commented on pull request #9478: URL: https://github.com/apache/kafka/pull/9478#issuecomment-714565433 Sorry, this is getting complicated. I've just realized that this PR is specifically addressing some internal test failures that came up in the 2.6 port: https://github.com/apache

[jira] [Resolved] (KAFKA-10284) Group membership update due to static member rejoin should be persisted

2020-10-22 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler resolved KAFKA-10284. -- Resolution: Fixed > Group membership update due to static member rejoin should be persisted >

[GitHub] [kafka] vvcephei commented on pull request #9471: MINOR: Add Jenkinsfile to 2.6

2020-10-22 Thread GitBox
vvcephei commented on pull request #9471: URL: https://github.com/apache/kafka/pull/9471#issuecomment-714569139 The tests for 8 and 14 passed, but 11 timed out. Weirdly, the build log (https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-9471/1/console) actually shows that the tests

[jira] [Commented] (KAFKA-10201) Update codebase to use more inclusive terms

2020-10-22 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219093#comment-17219093 ] Bill Bejeck commented on KAFKA-10201: - [~xvrl] , Since we've hit code freeze on 10/2

[jira] [Updated] (KAFKA-10201) Update codebase to use more inclusive terms

2020-10-22 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bill Bejeck updated KAFKA-10201: Fix Version/s: (was: 2.7.0) 2.8.0 > Update codebase to use more inclusive t

[GitHub] [kafka] vvcephei commented on pull request #9270: KAFKA-10284: Group membership update due to static member rejoin should be persisted

2020-10-22 Thread GitBox
vvcephei commented on pull request #9270: URL: https://github.com/apache/kafka/pull/9270#issuecomment-714574329 Cherry-picked to 2.6 (cc @mimaison ) This is an automated message from the Apache Git Service. To respond to the

[jira] [Updated] (KAFKA-10284) Group membership update due to static member rejoin should be persisted

2020-10-22 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-10284: - Fix Version/s: 2.6.1 > Group membership update due to static member rejoin should be persisted >

[jira] [Commented] (KAFKA-7575) 'Error while writing to checkpoint file' Issue

2020-10-22 Thread Ivan Gonzalez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219108#comment-17219108 ] Ivan Gonzalez commented on KAFKA-7575: -- Hi, We are running a cluster of 3 Kafka serv

[jira] [Updated] (KAFKA-10554) Perform follower truncation based on epoch offsets returned in Fetch response

2020-10-22 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bill Bejeck updated KAFKA-10554: Fix Version/s: (was: 2.7.0) 2.8.0 > Perform follower truncation based on ep

[jira] [Commented] (KAFKA-10554) Perform follower truncation based on epoch offsets returned in Fetch response

2020-10-22 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219111#comment-17219111 ] Bill Bejeck commented on KAFKA-10554: - Since this is not a blocker, and we've hit co

[GitHub] [kafka] cadonna opened a new pull request #9479: Handle ProducerFencedException on offset commit

2020-10-22 Thread GitBox
cadonna opened a new pull request #9479: URL: https://github.com/apache/kafka/pull/9479 The transaction manager does currently not handle producer fenced errors returned from a offset commit request. This PR adds the handling of the producer fenced errors. ### Committer Ch

[jira] [Commented] (KAFKA-10406) Table data doesn't wrap around in fixed-width columns and gets hidden

2020-10-22 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219137#comment-17219137 ] Mickael Maison commented on KAFKA-10406: [~vvcephei] I see you merged https://gi

[GitHub] [kafka] joshuagrisham commented on pull request #9470: Add recursive support to Connect Cast and ReplaceField transforms, and support for casting complex types to either a native or JSON stri

2020-10-22 Thread GitBox
joshuagrisham commented on pull request #9470: URL: https://github.com/apache/kafka/pull/9470#issuecomment-714608520 I saw that all of the checks have failed, but when I look in the log they are all related only to `checkstyle`.. if I get some time tomorrow I will try to address all of the

[GitHub] [kafka] nizhikov opened a new pull request #9480: [WIP] KAFKA-10592: Fix vagrant for a system tests with python3

2020-10-22 Thread GitBox
nizhikov opened a new pull request #9480: URL: https://github.com/apache/kafka/pull/9480 Fix vagrant for a system tests with a python3. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status

[GitHub] [kafka] vvcephei commented on pull request #9474: MINOR: Add Jenkinsfile to 2.2

2020-10-22 Thread GitBox
vvcephei commented on pull request #9474: URL: https://github.com/apache/kafka/pull/9474#issuecomment-714624277 Thanks for the reviews! This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [kafka] vvcephei commented on pull request #9475: MINOR: Add Jenkinsfile to 2.1

2020-10-22 Thread GitBox
vvcephei commented on pull request #9475: URL: https://github.com/apache/kafka/pull/9475#issuecomment-714623937 Thanks for the reviews, all! This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] vvcephei merged pull request #9474: MINOR: Add Jenkinsfile to 2.2

2020-10-22 Thread GitBox
vvcephei merged pull request #9474: URL: https://github.com/apache/kafka/pull/9474 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] vvcephei merged pull request #9475: MINOR: Add Jenkinsfile to 2.1

2020-10-22 Thread GitBox
vvcephei merged pull request #9475: URL: https://github.com/apache/kafka/pull/9475 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] vvcephei merged pull request #9472: MINOR: Add Jenkinsfile to 2.3

2020-10-22 Thread GitBox
vvcephei merged pull request #9472: URL: https://github.com/apache/kafka/pull/9472 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] vvcephei commented on pull request #9472: MINOR: Add Jenkinsfile to 2.3

2020-10-22 Thread GitBox
vvcephei commented on pull request #9472: URL: https://github.com/apache/kafka/pull/9472#issuecomment-714624598 Thanks for the reviews! This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [kafka] apurvam commented on pull request #9479: Handle ProducerFencedException on offset commit

2020-10-22 Thread GitBox
apurvam commented on pull request #9479: URL: https://github.com/apache/kafka/pull/9479#issuecomment-714628995 I can't believe this bug has been lurking for so long. This is an automated message from the Apache Git Service.

[GitHub] [kafka] thake closed pull request #9478: Fixed unit test mocks and incorrect required context serdes.

2020-10-22 Thread GitBox
thake closed pull request #9478: URL: https://github.com/apache/kafka/pull/9478 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] thake commented on pull request #9478: Fixed unit test mocks and incorrect required context serdes.

2020-10-22 Thread GitBox
thake commented on pull request #9478: URL: https://github.com/apache/kafka/pull/9478#issuecomment-714630476 You were right. Somehow I thought that the tests were right and that keySerde and valueSerde are nullable. It would really help to have a null safe API description using annotations

[GitHub] [kafka] thake commented on pull request #9467: KAFKA-10515: Properly initialize nullable Serdes with default values

2020-10-22 Thread GitBox
thake commented on pull request #9467: URL: https://github.com/apache/kafka/pull/9467#issuecomment-714632784 @vvcephei Sorry for the confusion, creating a new commit now. This is an automated message from the Apache Git Servi

[GitHub] [kafka] soarez commented on pull request #9000: KAFKA-10036 Improve handling and documentation of Suppliers

2020-10-22 Thread GitBox
soarez commented on pull request #9000: URL: https://github.com/apache/kafka/pull/9000#issuecomment-714636553 @mjsax rebased and fixed an error. Can we try running the tests again? This is an automated message from the Apache

[jira] [Created] (KAFKA-10631) ProducerFencedException is not Handled on Offest Commit

2020-10-22 Thread Bruno Cadonna (Jira)
Bruno Cadonna created KAFKA-10631: - Summary: ProducerFencedException is not Handled on Offest Commit Key: KAFKA-10631 URL: https://issues.apache.org/jira/browse/KAFKA-10631 Project: Kafka Iss

[jira] [Updated] (KAFKA-10631) ProducerFencedException is not Handled on Offest Commit

2020-10-22 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-10631: -- Description: The transaction manager does currently not handle producer fenced errors returne

[GitHub] [kafka] thake commented on pull request #9467: KAFKA-10515: Properly initialize nullable Serdes with default values

2020-10-22 Thread GitBox
thake commented on pull request #9467: URL: https://github.com/apache/kafka/pull/9467#issuecomment-714640590 Ready for review This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] jsancio commented on a change in pull request #9476: MINOR: Refactor RaftClientTest to be used by other tests

2020-10-22 Thread GitBox
jsancio commented on a change in pull request #9476: URL: https://github.com/apache/kafka/pull/9476#discussion_r510331249 ## File path: raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientTest.java ## @@ -1536,67 +1522,70 @@ public void testObserverLeaderRediscoveryAfterRe

[jira] [Updated] (KAFKA-9929) Support reverse iterator on WindowStore

2020-10-22 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-9929: --- Fix Version/s: 2.7.0 > Support reverse iterator on WindowStore >

[jira] [Updated] (KAFKA-10631) ProducerFencedException is not Handled on Offest Commit

2020-10-22 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bill Bejeck updated KAFKA-10631: Fix Version/s: 2.7.0 > ProducerFencedException is not Handled on Offest Commit > -

[jira] [Assigned] (KAFKA-10631) ProducerFencedException is not Handled on Offest Commit

2020-10-22 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bill Bejeck reassigned KAFKA-10631: --- Assignee: Bruno Cadonna > ProducerFencedException is not Handled on Offest Commit > ---

[GitHub] [kafka] vvcephei commented on pull request #9270: KAFKA-10284: Group membership update due to static member rejoin should be persisted

2020-10-22 Thread GitBox
vvcephei commented on pull request #9270: URL: https://github.com/apache/kafka/pull/9270#issuecomment-714669017 Cherry-picked to 2.5 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] vvcephei opened a new pull request #9481: KAFKA-10284: Disable static membership test in 2.4

2020-10-22 Thread GitBox
vvcephei opened a new pull request #9481: URL: https://github.com/apache/kafka/pull/9481 This test was fixed in https://github.com/apache/kafka/pull/9270 for 2.5+, but the code in 2.4 is too different to have a clean backport. Rather than risk introducing a worse bug in 2.4, and also b

[GitHub] [kafka] vvcephei commented on pull request #9481: KAFKA-10284: Disable static membership test in 2.4

2020-10-22 Thread GitBox
vvcephei commented on pull request #9481: URL: https://github.com/apache/kafka/pull/9481#issuecomment-714670340 Hey @abbccdda , @feyman2016 , what do you think about this, as opposed to spending more time doing a backport for 2.4? --

[GitHub] [kafka] vvcephei commented on pull request #9471: MINOR: Add Jenkinsfile to 2.6

2020-10-22 Thread GitBox
vvcephei commented on pull request #9471: URL: https://github.com/apache/kafka/pull/9471#issuecomment-714674113 On second thought, it looks like there's legitimately a test that hangs on 2.6 in java 11. I was looking before at the whole log, which I didn't realize shows all the buil

[jira] [Created] (KAFKA-10632) Raft client should push all committed data to listeners

2020-10-22 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-10632: --- Summary: Raft client should push all committed data to listeners Key: KAFKA-10632 URL: https://issues.apache.org/jira/browse/KAFKA-10632 Project: Kafka

[jira] [Resolved] (KAFKA-9999) Internal topic creation failure should be non-fatal and trigger explicit rebalance

2020-10-22 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Chen resolved KAFKA-. Resolution: Won't Fix > Internal topic creation failure should be non-fatal and trigger explicit >

[GitHub] [kafka] hachikuji opened a new pull request #9482: KAFKA-10632; Raft client should push all committed data to state machines

2020-10-22 Thread GitBox
hachikuji opened a new pull request #9482: URL: https://github.com/apache/kafka/pull/9482 In #9418, we add a listener to the `RaftClient` interface. In that patch, we used it only to send commit notifications for writes from the leader. In this PR, we extend the `handleCommit` API to accep

[GitHub] [kafka] jolshan commented on pull request #9471: MINOR: Add Jenkinsfile to 2.6

2020-10-22 Thread GitBox
jolshan commented on pull request #9471: URL: https://github.com/apache/kafka/pull/9471#issuecomment-714684198 @vvcephei Yeah. I was worried that might be happening. Good to check This is an automated message from the Apa

[GitHub] [kafka] mjsax commented on pull request #9000: KAFKA-10036 Improve handling and documentation of Suppliers

2020-10-22 Thread GitBox
mjsax commented on pull request #9000: URL: https://github.com/apache/kafka/pull/9000#issuecomment-714688801 The build did run, but failed with a compile error: Maybe something wrong with the rebase you did? ``` /home/jenkins/jenkins-agent/workspace/Kafka_kafka-pr_PR-9000@2/streams/s

[jira] [Commented] (KAFKA-10592) system tests not running after python3 merge

2020-10-22 Thread Nikolay Izhikov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219284#comment-17219284 ] Nikolay Izhikov commented on KAFKA-10592: - Hello [~rndgstn], [~omkreddy] I fixe

[GitHub] [kafka] hachikuji commented on a change in pull request #9476: MINOR: Refactor RaftClientTest to be used by other tests

2020-10-22 Thread GitBox
hachikuji commented on a change in pull request #9476: URL: https://github.com/apache/kafka/pull/9476#discussion_r510387310 ## File path: raft/src/test/java/org/apache/kafka/raft/RaftClientTestContext.java ## @@ -0,0 +1,648 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] hachikuji commented on a change in pull request #9476: MINOR: Refactor RaftClientTest to be used by other tests

2020-10-22 Thread GitBox
hachikuji commented on a change in pull request #9476: URL: https://github.com/apache/kafka/pull/9476#discussion_r510387310 ## File path: raft/src/test/java/org/apache/kafka/raft/RaftClientTestContext.java ## @@ -0,0 +1,648 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] vvcephei commented on pull request #9479: KAFKA-10631: Handle ProducerFencedException on offset commit

2020-10-22 Thread GitBox
vvcephei commented on pull request #9479: URL: https://github.com/apache/kafka/pull/9479#issuecomment-714708637 LGTM! Thanks, @cadonna . This is an automated message from the Apache Git Service. To respond to the message, ple

[jira] [Created] (KAFKA-10633) Constant probing rebalances in Streams 2.6

2020-10-22 Thread Bradley Peterson (Jira)
Bradley Peterson created KAFKA-10633: Summary: Constant probing rebalances in Streams 2.6 Key: KAFKA-10633 URL: https://issues.apache.org/jira/browse/KAFKA-10633 Project: Kafka Issue Type

[GitHub] [kafka] vvcephei merged pull request #9479: KAFKA-10631: Handle ProducerFencedException on offset commit

2020-10-22 Thread GitBox
vvcephei merged pull request #9479: URL: https://github.com/apache/kafka/pull/9479 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] vvcephei commented on pull request #9479: KAFKA-10631: Handle ProducerFencedException on offset commit

2020-10-22 Thread GitBox
vvcephei commented on pull request #9479: URL: https://github.com/apache/kafka/pull/9479#issuecomment-714715589 Cherry-picked to 2.7 (cc @bbejeck ) This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [kafka] jherico commented on a change in pull request #8204: KAFKA-9633: Ensure ConfigProviders are closed

2020-10-22 Thread GitBox
jherico commented on a change in pull request #8204: URL: https://github.com/apache/kafka/pull/8204#discussion_r510410362 ## File path: clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java ## @@ -483,6 +483,7 @@ public void logUnused() { re

[GitHub] [kafka] jsancio commented on a change in pull request #9482: KAFKA-10632; Raft client should push all committed data to state machines

2020-10-22 Thread GitBox
jsancio commented on a change in pull request #9482: URL: https://github.com/apache/kafka/pull/9482#discussion_r510385486 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -206,30 +234,77 @@ private void updateLeaderEndOffsetAndTimestamp(

[jira] [Commented] (KAFKA-10633) Constant probing rebalances in Streams 2.6

2020-10-22 Thread Bradley Peterson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219307#comment-17219307 ] Bradley Peterson commented on KAFKA-10633: -- /cc [~vvcephei] > Constant probing

[jira] [Created] (KAFKA-10634) LeaderChangeMessage should include the leader as one of the voters

2020-10-22 Thread Jose Armando Garcia Sancio (Jira)
Jose Armando Garcia Sancio created KAFKA-10634: -- Summary: LeaderChangeMessage should include the leader as one of the voters Key: KAFKA-10634 URL: https://issues.apache.org/jira/browse/KAFKA-10634

[GitHub] [kafka] jsancio commented on a change in pull request #9476: MINOR: Refactor RaftClientTest to be used by other tests

2020-10-22 Thread GitBox
jsancio commented on a change in pull request #9476: URL: https://github.com/apache/kafka/pull/9476#discussion_r510421964 ## File path: raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientTest.java ## @@ -90,470 +76,480 @@ import static org.junit.jupiter.api.Assertions.ass

[GitHub] [kafka] ijuma commented on pull request #9469: MINOR: replace FetchRequest.TopicAndPartitionData by Map.Entry

2020-10-22 Thread GitBox
ijuma commented on pull request #9469: URL: https://github.com/apache/kafka/pull/9469#issuecomment-714728901 Thanks for the PR. Is this an improvement? It seems to make the code harder to read. This is an automated message f

[GitHub] [kafka] hachikuji commented on a change in pull request #9482: KAFKA-10632; Raft client should push all committed data to state machines

2020-10-22 Thread GitBox
hachikuji commented on a change in pull request #9482: URL: https://github.com/apache/kafka/pull/9482#discussion_r510426714 ## File path: raft/src/main/java/org/apache/kafka/raft/RaftClient.java ## @@ -16,57 +16,75 @@ */ package org.apache.kafka.raft; -import org.apache.ka

[GitHub] [kafka] hachikuji commented on a change in pull request #9482: KAFKA-10632; Raft client should push all committed data to state machines

2020-10-22 Thread GitBox
hachikuji commented on a change in pull request #9482: URL: https://github.com/apache/kafka/pull/9482#discussion_r510432303 ## File path: raft/src/main/java/org/apache/kafka/raft/RaftClient.java ## @@ -16,57 +16,75 @@ */ package org.apache.kafka.raft; -import org.apache.ka

[GitHub] [kafka] hachikuji commented on a change in pull request #9482: KAFKA-10632; Raft client should push all committed data to state machines

2020-10-22 Thread GitBox
hachikuji commented on a change in pull request #9482: URL: https://github.com/apache/kafka/pull/9482#discussion_r510433916 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -1757,35 +1809,86 @@ public void complete() { } } -p

[GitHub] [kafka] hachikuji commented on a change in pull request #9482: KAFKA-10632; Raft client should push all committed data to state machines

2020-10-22 Thread GitBox
hachikuji commented on a change in pull request #9482: URL: https://github.com/apache/kafka/pull/9482#discussion_r510437477 ## File path: raft/src/main/java/org/apache/kafka/raft/QuorumState.java ## @@ -369,6 +379,17 @@ public void transitionToLeader(long epochStartOffset) thr

[GitHub] [kafka] hachikuji commented on a change in pull request #9482: KAFKA-10632; Raft client should push all committed data to state machines

2020-10-22 Thread GitBox
hachikuji commented on a change in pull request #9482: URL: https://github.com/apache/kafka/pull/9482#discussion_r510438318 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -206,30 +234,77 @@ private void updateLeaderEndOffsetAndTimestamp(

[GitHub] [kafka] jsancio commented on a change in pull request #9476: MINOR: Refactor RaftClientTest to be used by other tests

2020-10-22 Thread GitBox
jsancio commented on a change in pull request #9476: URL: https://github.com/apache/kafka/pull/9476#discussion_r510448694 ## File path: raft/src/test/java/org/apache/kafka/raft/RaftClientTestContext.java ## @@ -0,0 +1,648 @@ +/* + * Licensed to the Apache Software Foundation (A

  1   2   >