vvcephei commented on pull request #9467: URL: https://github.com/apache/kafka/pull/9467#issuecomment-714564666
Ahh, I already commented on https://github.com/apache/kafka/pull/9478, but I think now I see the motivation for that PR. If it was indeed just because there are internal tests that need new expectations now, we should just add the expectations instead of twisting the "main" code into handling an unexpected condition. By the way, I'm sure it's not obvious, but the fundamental reason for my taking this position is that in production code, the context serdes can never be null. There is a "default default" of ByteArraySerde even if you don't configure a "deafult" serde at all. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
