[GitHub] [kafka] rgo commented on pull request #9387: KAFKA-4759: Acl authorizer subnet support

2020-10-09 Thread GitBox
rgo commented on pull request #9387: URL: https://github.com/apache/kafka/pull/9387#issuecomment-706018710 Hi @ijuma @hachikuji @guozhangwang, could you take a look to this PR? Thanks This is an automated message from

[jira] [Created] (KAFKA-10591) kafka_2.13-2.6.0 vulnerabilities

2020-10-09 Thread Manvindar (Jira)
Manvindar created KAFKA-10591: - Summary: kafka_2.13-2.6.0 vulnerabilities Key: KAFKA-10591 URL: https://issues.apache.org/jira/browse/KAFKA-10591 Project: Kafka Issue Type: Bug Affects Versio

[jira] [Updated] (KAFKA-10591) kafka_2.13-2.6.0 vulnerabilities

2020-10-09 Thread Manvindar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manvindar updated KAFKA-10591: -- Attachment: (was: image (13).png) > kafka_2.13-2.6.0 vulnerabilities > ---

[jira] [Updated] (KAFKA-10501) Log Cleaner never clean up some __consumer_offsets partitions

2020-10-09 Thread Mykhailo Baluta (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mykhailo Baluta updated KAFKA-10501: Description: Some __consumer_offsets partitions contain "broken" messages in the second lo

[jira] [Commented] (KAFKA-9144) Early expiration of producer state can cause coordinator epoch to regress

2020-10-09 Thread Mykhailo Baluta (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210714#comment-17210714 ] Mykhailo Baluta commented on KAFKA-9144: We faced the same behavior on version 2.

[GitHub] [kafka] mimaison commented on a change in pull request #9313: [mm2] Fix consumer/producer properties override

2020-10-09 Thread GitBox
mimaison commented on a change in pull request #9313: URL: https://github.com/apache/kafka/pull/9313#discussion_r502264321 ## File path: connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorMakerConfigTest.java ## @@ -52,10 +52,10 @@ public void testClusterConfig

[jira] [Commented] (KAFKA-10501) Log Cleaner never clean up some __consumer_offsets partitions

2020-10-09 Thread Mykhailo Baluta (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210716#comment-17210716 ] Mykhailo Baluta commented on KAFKA-10501: - Similar behavior with producer epoch

[jira] [Commented] (KAFKA-9628) Replace Produce request/response with automated protocol

2020-10-09 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210726#comment-17210726 ] Mickael Maison commented on KAFKA-9628: --- A single PR is probably better as this is

[jira] [Commented] (KAFKA-9628) Replace Produce request/response with automated protocol

2020-10-09 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210731#comment-17210731 ] Chia-Ping Tsai commented on KAFKA-9628: --- {quote} A single PR is probably better as

[jira] [Resolved] (KAFKA-10591) kafka_2.13-2.6.0 vulnerabilities

2020-10-09 Thread Dongjin Lee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dongjin Lee resolved KAFKA-10591. - Resolution: Duplicate See: [KAFKA-9366|http://https://issues.apache.org/jira/browse/KAFKA-9366]

[GitHub] [kafka] dongjinleekr commented on pull request #9276: KAFKA-10473: Add docs on partition size-on-disk, and other log-related metrics

2020-10-09 Thread GitBox
dongjinleekr commented on pull request #9276: URL: https://github.com/apache/kafka/pull/9276#issuecomment-706104273 @wushujames Could you make some updates? I think it would be good for this PR to be included in the 2.7.0 release. --

[GitHub] [kafka] dongjinleekr commented on pull request #7891: MINOR: Group KafkaController, ReplicaManager metrics in documentation

2020-10-09 Thread GitBox
dongjinleekr commented on pull request #7891: URL: https://github.com/apache/kafka/pull/7891#issuecomment-706104974 Rebased onto the latest trunk. cc/ @hachikuji This is an automated message from the Apache Git Service. To re

[GitHub] [kafka] dongjinleekr commented on pull request #8150: KAFKA-9587: Producer configs are omitted in the documentation

2020-10-09 Thread GitBox
dongjinleekr commented on pull request #8150: URL: https://github.com/apache/kafka/pull/8150#issuecomment-706105728 Rebased onto the latest trunk. cc/ @kkonstantine @bbejeck This is an automated message from the Apache Git Se

[GitHub] [kafka] scanterog commented on a change in pull request #9313: [mm2] Fix consumer/producer properties override

2020-10-09 Thread GitBox
scanterog commented on a change in pull request #9313: URL: https://github.com/apache/kafka/pull/9313#discussion_r502351930 ## File path: connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorMakerConfigTest.java ## @@ -52,10 +52,10 @@ public void testClusterConfi

[GitHub] [kafka] chia7712 commented on pull request #9374: MINOR: Fix NPE in KafkaAdminClient.describeUserScramCredentials

2020-10-09 Thread GitBox
chia7712 commented on pull request #9374: URL: https://github.com/apache/kafka/pull/9374#issuecomment-705340299 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [kafka] rondagostino commented on pull request #9378: MINOR: ACLs for secured cluster system tests

2020-10-09 Thread GitBox
rondagostino commented on pull request #9378: URL: https://github.com/apache/kafka/pull/9378#issuecomment-705552615 Rebased onto trunk despite lack of conflicts due to Python 3 for system tests being merged. This is an autom

[GitHub] [kafka] mimaison commented on pull request #9313: [mm2] Fix consumer/producer properties override

2020-10-09 Thread GitBox
mimaison commented on pull request #9313: URL: https://github.com/apache/kafka/pull/9313#issuecomment-705563795 @scanterog `testClusterConfigProperties()` seems to be failing now. Can you fix it before I take a look at the PR? ``` org.apache.kafka.connect.mirror.MirrorMakerCon

[GitHub] [kafka] apovzner commented on a change in pull request #9386: KAFKA-10024: Add dynamic configuration and enforce quota for per-IP connection rate limits

2020-10-09 Thread GitBox
apovzner commented on a change in pull request #9386: URL: https://github.com/apache/kafka/pull/9386#discussion_r502084924 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -1203,14 +1262,27 @@ class ConnectionQuotas(config: KafkaConfig, time: Time, metr

[GitHub] [kafka] chia7712 commented on pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

2020-10-09 Thread GitBox
chia7712 commented on pull request #9001: URL: https://github.com/apache/kafka/pull/9001#issuecomment-705378300 @kowshik sorry for bringing trivial comments after this is merged. I just noticed those nits in testing new APIs in 2.7.0. --

[GitHub] [kafka] vvcephei merged pull request #9139: KAFKA-9929: Support backward iterator on SessionStore

2020-10-09 Thread GitBox
vvcephei merged pull request #9139: URL: https://github.com/apache/kafka/pull/9139 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] xvrl commented on a change in pull request #9367: KAFKA-10570 Rename JMXReporter configs for KIP-629

2020-10-09 Thread GitBox
xvrl commented on a change in pull request #9367: URL: https://github.com/apache/kafka/pull/9367#discussion_r502167123 ## File path: clients/src/main/java/org/apache/kafka/common/utils/ConfigUtils.java ## @@ -0,0 +1,92 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] cmccabe commented on pull request #9390: MINOR: Implement ApiError#equals and hashCode

2020-10-09 Thread GitBox
cmccabe commented on pull request #9390: URL: https://github.com/apache/kafka/pull/9390#issuecomment-705826094 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [kafka] gardnervickers commented on pull request #7929: KAFKA-9393: DeleteRecords may cause extreme lock contention for large partition directories

2020-10-09 Thread GitBox
gardnervickers commented on pull request #7929: URL: https://github.com/apache/kafka/pull/7929#issuecomment-705786361 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] efeg commented on pull request #9397: KAFKA-10583: Add documentation on the thread-safety of KafkaAdminClient.

2020-10-09 Thread GitBox
efeg commented on pull request #9397: URL: https://github.com/apache/kafka/pull/9397#issuecomment-705765230 @cmccabe Do you think you might be able to take a look at this PR? This is an automated message from the Apache Git S

[GitHub] [kafka] junrao removed a comment on pull request #9393: KAFKA-10028: Minor fixes to describeFeatures and updateFeatures apis

2020-10-09 Thread GitBox
junrao removed a comment on pull request #9393: URL: https://github.com/apache/kafka/pull/9393#issuecomment-705702092 In this PR, I have addressed the review comments from @chia7712 in #9001 which were provided after #9001 was merged. The changes are made mainly to KafkaAdminClient:

[GitHub] [kafka] rgo commented on pull request #9387: KAFKA-4759: Acl authorizer subnet support

2020-10-09 Thread GitBox
rgo commented on pull request #9387: URL: https://github.com/apache/kafka/pull/9387#issuecomment-705369057 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [kafka] gwenshap commented on a change in pull request #9367: KAFKA-10570 Rename JMXReporter configs for KIP-629

2020-10-09 Thread GitBox
gwenshap commented on a change in pull request #9367: URL: https://github.com/apache/kafka/pull/9367#discussion_r502082826 ## File path: clients/src/main/java/org/apache/kafka/common/utils/ConfigUtils.java ## @@ -0,0 +1,92 @@ +/* + * Licensed to the Apache Software Foundation (

[GitHub] [kafka] lct45 commented on pull request #9383: KAFKA-10455: Ensure that probing rebalances always occur

2020-10-09 Thread GitBox
lct45 commented on pull request #9383: URL: https://github.com/apache/kafka/pull/9383#issuecomment-705688523 System tests: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4204/ This is an automated message

[GitHub] [kafka] gardnervickers commented on a change in pull request #7929: KAFKA-9393: DeleteRecords may cause extreme lock contention for large partition directories

2020-10-09 Thread GitBox
gardnervickers commented on a change in pull request #7929: URL: https://github.com/apache/kafka/pull/7929#discussion_r501942512 ## File path: core/src/main/scala/kafka/log/ProducerStateManager.scala ## @@ -653,36 +697,44 @@ class ProducerStateManager(val topicPartition: Topic

[GitHub] [kafka] junrao commented on a change in pull request #7929: KAFKA-9393: DeleteRecords may cause extreme lock contention for large partition directories

2020-10-09 Thread GitBox
junrao commented on a change in pull request #7929: URL: https://github.com/apache/kafka/pull/7929#discussion_r501325705 ## File path: core/src/main/scala/kafka/log/ProducerStateManager.scala ## @@ -496,6 +491,53 @@ class ProducerStateManager(val topicPartition: TopicPartition

[GitHub] [kafka] shadikajevand commented on pull request #9359: kafka-10273 Connect Converters should produce actionable error messages

2020-10-09 Thread GitBox
shadikajevand commented on pull request #9359: URL: https://github.com/apache/kafka/pull/9359#issuecomment-705566435 Hi @rhauch I am working on convertKey(...) and convertValue(...) methods for WorkerSourceTask. I'm throwing a DataException in these two methods when an exception occures. I

[GitHub] [kafka] guozhangwang commented on pull request #9020: KAFKA-10271 Performance regression while fetching a key from a single partition

2020-10-09 Thread GitBox
guozhangwang commented on pull request #9020: URL: https://github.com/apache/kafka/pull/9020#issuecomment-705707869 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [kafka] guozhangwang commented on a change in pull request #9396: KAFKA-10437: Implement new PAPI support for test-utils

2020-10-09 Thread GitBox
guozhangwang commented on a change in pull request #9396: URL: https://github.com/apache/kafka/pull/9396#discussion_r502067124 ## File path: streams/test-utils/src/main/java/org/apache/kafka/streams/processor/api/MockProcessorContext.java ## @@ -0,0 +1,494 @@ +/* + * Licensed

[GitHub] [kafka] mimaison commented on pull request #9271: MINOR: correct package of LinuxIoMetricsCollector

2020-10-09 Thread GitBox
mimaison commented on pull request #9271: URL: https://github.com/apache/kafka/pull/9271#issuecomment-705628291 Test failures are not related and passed locally, merging This is an automated message from the Apache Git Servic

[GitHub] [kafka] xvrl commented on pull request #9367: KAFKA-10570 Rename JMXReporter configs for KIP-629

2020-10-09 Thread GitBox
xvrl commented on pull request #9367: URL: https://github.com/apache/kafka/pull/9367#issuecomment-705863610 jdk8 test failures appear unrelated This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [kafka] kowshik commented on pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

2020-10-09 Thread GitBox
kowshik commented on pull request #9001: URL: https://github.com/apache/kafka/pull/9001#issuecomment-705419934 @chia7712 No worries, thanks for the suggestions! I have opened a separate PR addressing your comments. Would you be able to please review it? https://github.com/apache/kafka/pull

[GitHub] [kafka] guozhangwang commented on pull request #9352: KAFKA-10533; KafkaRaftClient should flush log after appends

2020-10-09 Thread GitBox
guozhangwang commented on pull request #9352: URL: https://github.com/apache/kafka/pull/9352#issuecomment-705954882 test this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] acmck closed pull request #9394: Fully automate dev setup with Gitpod

2020-10-09 Thread GitBox
acmck closed pull request #9394: URL: https://github.com/apache/kafka/pull/9394 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] chia7712 commented on pull request #9400: MINOR rename kafka.utils.Whitelist to IncludeList

2020-10-09 Thread GitBox
chia7712 commented on pull request #9400: URL: https://github.com/apache/kafka/pull/9400#issuecomment-705984805 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [kafka] splett2 commented on a change in pull request #9386: KAFKA-10024: Add dynamic configuration and enforce quota for per-IP connection rate limits

2020-10-09 Thread GitBox
splett2 commented on a change in pull request #9386: URL: https://github.com/apache/kafka/pull/9386#discussion_r502091435 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -1203,14 +1262,27 @@ class ConnectionQuotas(config: KafkaConfig, time: Time, metri

[jira] [Commented] (KAFKA-10555) Improve client state machine

2020-10-09 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210968#comment-17210968 ] Bruno Cadonna commented on KAFKA-10555: --- [~ableegoldman] Thank you for your detail

[GitHub] [kafka] junrao merged pull request #9393: KAFKA-10028: Minor fixes to describeFeatures and updateFeatures apis

2020-10-09 Thread GitBox
junrao merged pull request #9393: URL: https://github.com/apache/kafka/pull/9393 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] vvcephei commented on pull request #9139: KAFKA-9929: Support backward iterator on SessionStore

2020-10-09 Thread GitBox
vvcephei commented on pull request #9139: URL: https://github.com/apache/kafka/pull/9139#issuecomment-705319349 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [kafka] chia7712 commented on pull request #9393: KAFKA-10028: Minor fixes to describeFeatures and updateFeatures apis

2020-10-09 Thread GitBox
chia7712 commented on pull request #9393: URL: https://github.com/apache/kafka/pull/9393#issuecomment-705449262 I can't merge it since I'm not a Kafka committer 😅 @junrao Could you please take a look? This is an autom

[GitHub] [kafka] ableegoldman commented on a change in pull request #9273: KAFKA-9331: changes for Streams uncaught exception handler

2020-10-09 Thread GitBox
ableegoldman commented on a change in pull request #9273: URL: https://github.com/apache/kafka/pull/9273#discussion_r501868835 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -364,6 +370,73 @@ public void setUncaughtExceptionHandler(final T

[GitHub] [kafka] mumrah merged pull request #9307: MINOR: Backported changes to ClientUtils.resolve tests to 2.4

2020-10-09 Thread GitBox
mumrah merged pull request #9307: URL: https://github.com/apache/kafka/pull/9307 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] xvrl commented on pull request #9400: MINOR rename kafka.utils.Whitelist to IncludeList

2020-10-09 Thread GitBox
xvrl commented on pull request #9400: URL: https://github.com/apache/kafka/pull/9400#issuecomment-705987912 @chia7712 this was already discussed as part of KIP-629. The term "include" was chosen to align with existing configs we already had. Please see the [KIP](https://cwiki.apache.org/co

[GitHub] [kafka] lct45 commented on a change in pull request #9383: KAFKA-10455: Ensure that probing rebalances always occur

2020-10-09 Thread GitBox
lct45 commented on a change in pull request #9383: URL: https://github.com/apache/kafka/pull/9383#discussion_r501956905 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignorTest.java ## @@ -483,7 +485,7 @@ public void testEag

[GitHub] [kafka] cadonna commented on a change in pull request #9273: KAFKA-9331: changes for Streams uncaught exception handler

2020-10-09 Thread GitBox
cadonna commented on a change in pull request #9273: URL: https://github.com/apache/kafka/pull/9273#discussion_r501793433 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -364,6 +370,73 @@ public void setUncaughtExceptionHandler(final Thread

[GitHub] [kafka] mimaison merged pull request #9296: MINOR: remove unused scala files from core module

2020-10-09 Thread GitBox
mimaison merged pull request #9296: URL: https://github.com/apache/kafka/pull/9296 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] ableegoldman commented on a change in pull request #9383: KAFKA-10455: Ensure that probing rebalances always occur

2020-10-09 Thread GitBox
ableegoldman commented on a change in pull request #9383: URL: https://github.com/apache/kafka/pull/9383#discussion_r501875691 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/HighAvailabilityTaskAssignorIntegrationTest.java ## @@ -286,7 +286,8 @@ priva

[GitHub] [kafka] gwenshap closed pull request #9398: MINOR update comments and docs to be gender-neutral

2020-10-09 Thread GitBox
gwenshap closed pull request #9398: URL: https://github.com/apache/kafka/pull/9398 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] mimaison commented on a change in pull request #9313: [mm2] Fix consumer/producer properties override

2020-10-09 Thread GitBox
mimaison commented on a change in pull request #9313: URL: https://github.com/apache/kafka/pull/9313#discussion_r502264321 ## File path: connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorMakerConfigTest.java ## @@ -52,10 +52,10 @@ public void testClusterConfig

[GitHub] [kafka] junrao commented on pull request #9393: KAFKA-10028: Minor fixes to describeFeatures and updateFeatures apis

2020-10-09 Thread GitBox
junrao commented on pull request #9393: URL: https://github.com/apache/kafka/pull/9393#issuecomment-705702092 In this PR, I have addressed the review comments from @chia7712 in #9001 which were provided after #9001 was merged. The changes are made mainly to KafkaAdminClient: Improve

[GitHub] [kafka] dongjinleekr commented on pull request #8150: KAFKA-9587: Producer configs are omitted in the documentation

2020-10-09 Thread GitBox
dongjinleekr commented on pull request #8150: URL: https://github.com/apache/kafka/pull/8150#issuecomment-706105728 Rebased onto the latest trunk. cc/ @kkonstantine @bbejeck This is an automated message from the Apache Git Se

[GitHub] [kafka] mjsax merged pull request #9380: KAFKA-7334: Suggest changing config for state.dir in case of FileNotF…

2020-10-09 Thread GitBox
mjsax merged pull request #9380: URL: https://github.com/apache/kafka/pull/9380 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] C0urante commented on pull request #9375: KAFKA-10574: Fix infinite loop in Values::parseString

2020-10-09 Thread GitBox
C0urante commented on pull request #9375: URL: https://github.com/apache/kafka/pull/9375#issuecomment-705596382 Hi @rhauch @kkonstantine, this PR has been approved, all merge conflicts have been resolved, and every build is green. Would it be possible to merge sometime soon so that it can

[GitHub] [kafka] mjsax commented on pull request #9380: KAFKA-7334: Suggest changing config for state.dir in case of FileNotF…

2020-10-09 Thread GitBox
mjsax commented on pull request #9380: URL: https://github.com/apache/kafka/pull/9380#issuecomment-705772843 Thanks for the PR @voffcheg109! Merged to `trunk` and cherry-picked to `2.7` branch. This is an automated mes

[GitHub] [kafka] gwenshap closed pull request #9366: KAFKA-10571 Replace blackout with backoff for KIP-629

2020-10-09 Thread GitBox
gwenshap closed pull request #9366: URL: https://github.com/apache/kafka/pull/9366 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] mimaison merged pull request #9271: MINOR: correct package of LinuxIoMetricsCollector

2020-10-09 Thread GitBox
mimaison merged pull request #9271: URL: https://github.com/apache/kafka/pull/9271 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] kowshik commented on pull request #9393: KAFKA-10028: Minor fixes to describeFeatures and updateFeatures apis

2020-10-09 Thread GitBox
kowshik commented on pull request #9393: URL: https://github.com/apache/kafka/pull/9393#issuecomment-705444078 @chia7712 thanks for the review! would you be able to please help merge this PR into trunk when CI passes? This i

[GitHub] [kafka] guozhangwang merged pull request #9020: KAFKA-10271 Performance regression while fetching a key from a single partition

2020-10-09 Thread GitBox
guozhangwang merged pull request #9020: URL: https://github.com/apache/kafka/pull/9020 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] chia7712 commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

2020-10-09 Thread GitBox
chia7712 commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r501489060 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -4335,6 +4343,150 @@ void handleFailure(Throwable throwable

[GitHub] [kafka] dongjinleekr commented on pull request #9276: KAFKA-10473: Add docs on partition size-on-disk, and other log-related metrics

2020-10-09 Thread GitBox
dongjinleekr commented on pull request #9276: URL: https://github.com/apache/kafka/pull/9276#issuecomment-706104273 @wushujames Could you make some updates? I think it would be good for this PR to be included in the 2.7.0 release. --

[GitHub] [kafka] vvcephei commented on a change in pull request #9396: KAFKA-10437: Implement new PAPI support for test-utils

2020-10-09 Thread GitBox
vvcephei commented on a change in pull request #9396: URL: https://github.com/apache/kafka/pull/9396#discussion_r501891955 ## File path: checkstyle/suppressions.xml ## @@ -194,13 +194,13 @@ files=".*[/\\]streams[/\\].*test[/\\].*.java"/> + f

[GitHub] [kafka] junrao commented on pull request #7929: KAFKA-9393: DeleteRecords may cause extreme lock contention for large partition directories

2020-10-09 Thread GitBox
junrao commented on pull request #7929: URL: https://github.com/apache/kafka/pull/7929#issuecomment-705727027 Also, it seems that Log.takeProducerSnapshot() no longer used? This is an automated message from the Apache Git Ser

[GitHub] [kafka] dima5rr removed a comment on pull request #9020: KAFKA-10271 Performance regression while fetching a key from a single partition

2020-10-09 Thread GitBox
dima5rr removed a comment on pull request #9020: URL: https://github.com/apache/kafka/pull/9020#issuecomment-705675283 test this please This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [kafka] huxihx commented on pull request #9399: KAFKA-10584:IndexSearchType should use sealed trait instead of Enumeration

2020-10-09 Thread GitBox
huxihx commented on pull request #9399: URL: https://github.com/apache/kafka/pull/9399#issuecomment-705990045 @junrao Please review this minor change. This is an automated message from the Apache Git Service. To respond to th

[GitHub] [kafka] tombentley commented on pull request #9365: KAFKA-10566: Fix erroneous config usage warnings

2020-10-09 Thread GitBox
tombentley commented on pull request #9365: URL: https://github.com/apache/kafka/pull/9365#issuecomment-705503807 @rajinisivaram @omkreddy did you have any thoughts about this? What I've done here isn't exactly pretty, but it was the simplest thing I could think of which would remove the e

[GitHub] [kafka] dongjinleekr commented on pull request #7891: MINOR: Group KafkaController, ReplicaManager metrics in documentation

2020-10-09 Thread GitBox
dongjinleekr commented on pull request #7891: URL: https://github.com/apache/kafka/pull/7891#issuecomment-706104974 Rebased onto the latest trunk. cc/ @hachikuji This is an automated message from the Apache Git Service. To re

[GitHub] [kafka] voffcheg109 commented on pull request #9380: KAFKA-7334: Suggest changing config for state.dir in case of FileNotF…

2020-10-09 Thread GitBox
voffcheg109 commented on pull request #9380: URL: https://github.com/apache/kafka/pull/9380#issuecomment-705464097 @mjsax, I've fixed by your comments. This is an automated message from the Apache Git Service. To respond to t

[GitHub] [kafka] xvrl commented on pull request #9366: KAFKA-10571 Replace blackout with backoff for KIP-629

2020-10-09 Thread GitBox
xvrl commented on pull request #9366: URL: https://github.com/apache/kafka/pull/9366#issuecomment-705676711 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [kafka] dajac commented on a change in pull request #9391: MINOR: fix potential NPT in PartitionData.equals

2020-10-09 Thread GitBox
dajac commented on a change in pull request #9391: URL: https://github.com/apache/kafka/pull/9391#discussion_r501505455 ## File path: clients/src/test/java/org/apache/kafka/common/requests/OffsetFetchResponseTest.java ## @@ -159,14 +159,14 @@ public void testShouldThrottle() {

[GitHub] [kafka] scanterog commented on a change in pull request #9313: [mm2] Fix consumer/producer properties override

2020-10-09 Thread GitBox
scanterog commented on a change in pull request #9313: URL: https://github.com/apache/kafka/pull/9313#discussion_r502351930 ## File path: connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorMakerConfigTest.java ## @@ -52,10 +52,10 @@ public void testClusterConfi

[GitHub] [kafka] chia7712 commented on pull request #9318: KAFKA-10497 Convert group coordinator metadata schemas to use generat…

2020-10-09 Thread GitBox
chia7712 commented on pull request #9318: URL: https://github.com/apache/kafka/pull/9318#issuecomment-705979334 @hachikuji @dajac Could you take a look? This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] dima5rr commented on pull request #9020: KAFKA-10271 Performance regression while fetching a key from a single partition

2020-10-09 Thread GitBox
dima5rr commented on pull request #9020: URL: https://github.com/apache/kafka/pull/9020#issuecomment-705675283 test this please This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [kafka] rondagostino commented on pull request #9374: MINOR: Fix NPE in KafkaAdminClient.describeUserScramCredentials

2020-10-09 Thread GitBox
rondagostino commented on pull request #9374: URL: https://github.com/apache/kafka/pull/9374#issuecomment-705531979 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [kafka] ableegoldman commented on pull request #9380: KAFKA-7334: Suggest changing config for state.dir in case of FileNotF…

2020-10-09 Thread GitBox
ableegoldman commented on pull request #9380: URL: https://github.com/apache/kafka/pull/9380#issuecomment-705689770 Tests passed, should be good to merge @mjsax . Btw the 2.7 branch was just cut so this should be cherrypicked back to 2.7. --

[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

2020-10-09 Thread GitBox
kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r501575432 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -4335,6 +4343,150 @@ void handleFailure(Throwable throwable)

[GitHub] [kafka] chia7712 commented on a change in pull request #9391: MINOR: fix potential NPT in PartitionData.equals

2020-10-09 Thread GitBox
chia7712 commented on a change in pull request #9391: URL: https://github.com/apache/kafka/pull/9391#discussion_r501507673 ## File path: clients/src/test/java/org/apache/kafka/common/requests/OffsetFetchResponseTest.java ## @@ -159,14 +159,14 @@ public void testShouldThrottle(

[GitHub] [kafka] gardnervickers edited a comment on pull request #7929: KAFKA-9393: DeleteRecords may cause extreme lock contention for large partition directories

2020-10-09 Thread GitBox
gardnervickers edited a comment on pull request #7929: URL: https://github.com/apache/kafka/pull/7929#issuecomment-706183953 It appears the build is running into https://github.com/apache/kafka/pull/9328. Other than that I'm seeing two test failures in `kafka.api.MetricsTest.testMet

[GitHub] [kafka] rajinisivaram opened a new pull request #9406: KAFKA-10520; Ensure transactional producers poll if leastLoadedNode not available with max.in.flight=1

2020-10-09 Thread GitBox
rajinisivaram opened a new pull request #9406: URL: https://github.com/apache/kafka/pull/9406 We currently stop polling in `Sender` in a transactional producer if there is only one broker in the bootstrap server list and `max.in.flight.requests.per.connection=1` and Metadata response is pe

[GitHub] [kafka] tombentley commented on pull request #9397: KAFKA-10583: Add documentation on the thread-safety of KafkaAdminClient.

2020-10-09 Thread GitBox
tombentley commented on pull request #9397: URL: https://github.com/apache/kafka/pull/9397#issuecomment-706196779 @efeg the javadoc for `KafkaAdminClient` says "Users should not refer to this class directly", so just adding the thread-safety note to `KafkaAdminClient` probably isn't so hel

[GitHub] [kafka] rajinisivaram commented on pull request #9378: MINOR: ACLs for secured cluster system tests

2020-10-09 Thread GitBox
rajinisivaram commented on pull request #9378: URL: https://github.com/apache/kafka/pull/9378#issuecomment-706216748 @rondagostino Thanks for the PR updates and test runs. Merging to trunk. This is an automated message from t

[GitHub] [kafka] rajinisivaram merged pull request #9378: MINOR: ACLs for secured cluster system tests

2020-10-09 Thread GitBox
rajinisivaram merged pull request #9378: URL: https://github.com/apache/kafka/pull/9378 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] rondagostino commented on pull request #9378: MINOR: ACLs for secured cluster system tests

2020-10-09 Thread GitBox
rondagostino commented on pull request #9378: URL: https://github.com/apache/kafka/pull/9378#issuecomment-706242425 Test runs as follows: Status of trunk 2 days ago: http://confluent-kafka-system-test-results.s3-us-west-2.amazonaws.com/2020-10-07--001.1602079305--apache--trunk

[GitHub] [kafka] bmaggi opened a new pull request #9407: MINOR: Merge log error to avoid double error

2020-10-09 Thread GitBox
bmaggi opened a new pull request #9407: URL: https://github.com/apache/kafka/pull/9407 When using an error tracking system, 2 errors means 2 different alerts. It's best to group the logs and have one error with all information. For example when using with [Sentry](https://sentry.io

[GitHub] [kafka] xvrl commented on pull request #9400: MINOR rename kafka.utils.Whitelist to IncludeList

2020-10-09 Thread GitBox
xvrl commented on pull request #9400: URL: https://github.com/apache/kafka/pull/9400#issuecomment-706266330 jdk11 failures seem unrelated This is an automated message from the Apache Git Service. To respond to the message, pl

[jira] [Created] (KAFKA-10592) system tests not running after python3 merge

2020-10-09 Thread Ron Dagostino (Jira)
Ron Dagostino created KAFKA-10592: - Summary: system tests not running after python3 merge Key: KAFKA-10592 URL: https://issues.apache.org/jira/browse/KAFKA-10592 Project: Kafka Issue Type: Ta

[jira] [Commented] (KAFKA-10592) system tests not running after python3 merge

2020-10-09 Thread Ron Dagostino (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17211135#comment-17211135 ] Ron Dagostino commented on KAFKA-10592: --- One additional piece of information that

[jira] [Created] (KAFKA-10593) Kafka Hazelcast Process down

2020-10-09 Thread Cihan YILDIZ (Jira)
Cihan YILDIZ created KAFKA-10593: Summary: Kafka Hazelcast Process down Key: KAFKA-10593 URL: https://issues.apache.org/jira/browse/KAFKA-10593 Project: Kafka Issue Type: Bug Repo

[jira] [Commented] (KAFKA-10559) Don't shutdown the entire app upon TimeoutException during internal topic validation

2020-10-09 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17211158#comment-17211158 ] Bill Bejeck commented on KAFKA-10559: - [~sagarrao] can you close the above PR and op

[GitHub] [kafka] bbejeck commented on pull request #9338: Fixed KAFKA-10515: Serdes used within metered state stores will now be initialized with the default serdes if not already set.

2020-10-09 Thread GitBox
bbejeck commented on pull request #9338: URL: https://github.com/apache/kafka/pull/9338#issuecomment-706287686 @thake can you rebase this PR then ping us here so we can review it? Thanks! This is an automated message f

[GitHub] [kafka] vvcephei commented on pull request #9338: Fixed KAFKA-10515: Serdes used within metered state stores will now be initialized with the default serdes if not already set.

2020-10-09 Thread GitBox
vvcephei commented on pull request #9338: URL: https://github.com/apache/kafka/pull/9338#issuecomment-706290399 Hi @thake , I'm really sorry, I missed your earlier ping. I'll review it. As Bill said, it will need to be rebased (or you can merge trunk in) to resolve those merge confli

[jira] [Updated] (KAFKA-10515) NPE: Foreign key join serde may not be initialized with default serde if application is distributed

2020-10-09 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-10515: - Priority: Critical (was: Blocker) > NPE: Foreign key join serde may not be initialized with def

[jira] [Commented] (KAFKA-10378) issue when create producer using java

2020-10-09 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17211169#comment-17211169 ] Bill Bejeck commented on KAFKA-10378: - [~ijuma] [~cmccabe]    what's the status of

[jira] [Commented] (KAFKA-10515) NPE: Foreign key join serde may not be initialized with default serde if application is distributed

2020-10-09 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17211170#comment-17211170 ] John Roesler commented on KAFKA-10515: -- Thanks for the patch [~thorsten.hake] ! I'l

[jira] [Updated] (KAFKA-10417) suppress() with cogroup() throws ClassCastException

2020-10-09 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bill Bejeck updated KAFKA-10417: Priority: Critical (was: Blocker) > suppress() with cogroup() throws ClassCastException > ---

[jira] [Updated] (KAFKA-10417) suppress() with cogroup() throws ClassCastException

2020-10-09 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bill Bejeck updated KAFKA-10417: Fix Version/s: (was: 2.7.0) 2.8.0 2.7.1 > suppress() wit

[jira] [Commented] (KAFKA-10417) suppress() with cogroup() throws ClassCastException

2020-10-09 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17211210#comment-17211210 ] Bill Bejeck commented on KAFKA-10417: - I'm marking this as critical vs. blocker as I

  1   2   3   4   >