tombentley commented on pull request #9365: URL: https://github.com/apache/kafka/pull/9365#issuecomment-705503807
@rajinisivaram @omkreddy did you have any thoughts about this? What I've done here isn't exactly pretty, but it was the simplest thing I could think of which would remove the erroneous warnings. As an aside: I spent quite some time looking at how the `AbstractConfig` tracks usage in order to log about unknown config. TBH it's a pattern which, as here, doesn't always work well, because what's passed to `Configrable` is a `Map` so it's easy for people to forget that they need to track usage if they need to configure a plugin with something other than `AbstractConfig.values()`. In some ways it would be better to be able to validate config parameters at the point of creating the `AbstractConfig`, but that would require lots of public API change to be able to build the overall `ConfigDef` (including all the plugins defined in the "root config"). As well as addressing the logging of unknown configs in a less flaky way, that would open the door for `describeConfigs` to be able to describe configs for plugins as well as the broker, for example. But it would be a lot of work if those were the only benefits. Thoughts? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
