chia7712 commented on a change in pull request #9001:
URL: https://github.com/apache/kafka/pull/9001#discussion_r501418496
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java
##
@@ -4335,6 +4343,150 @@ void handleFailure(Throwable throwable
chia7712 commented on pull request #9001:
URL: https://github.com/apache/kafka/pull/9001#issuecomment-705378300
@kowshik sorry for bringing trivial comments after this is merged. I just
noticed those nits in testing new APIs in 2.7.0.
--
dajac commented on a change in pull request #9391:
URL: https://github.com/apache/kafka/pull/9391#discussion_r501505455
##
File path:
clients/src/test/java/org/apache/kafka/common/requests/OffsetFetchResponseTest.java
##
@@ -159,14 +159,14 @@ public void testShouldThrottle() {
Rohan Desai created KAFKA-10585:
---
Summary: Kafka Streams should clean up the state store directory
from cleanup
Key: KAFKA-10585
URL: https://issues.apache.org/jira/browse/KAFKA-10585
Project: Kafka
chia7712 commented on a change in pull request #9391:
URL: https://github.com/apache/kafka/pull/9391#discussion_r501507673
##
File path:
clients/src/test/java/org/apache/kafka/common/requests/OffsetFetchResponseTest.java
##
@@ -159,14 +159,14 @@ public void testShouldThrottle(
kowshik opened a new pull request #9393:
URL: https://github.com/apache/kafka/pull/9393
In this PR, I have addressed the review comments from @chia7712 in
https://github.com/apache/kafka/pull/9001 which were provided after
https://github.com/apache/kafka/pull/9001 was merged. The changes a
kowshik commented on pull request #9001:
URL: https://github.com/apache/kafka/pull/9001#issuecomment-705419934
@chia7712 No worries, thanks for the suggestions! I have opened a separate
PR addressing your comments. Would you be able to please review it?
https://github.com/apache/kafka/pull
kowshik commented on pull request #9393:
URL: https://github.com/apache/kafka/pull/9393#issuecomment-705444078
@chia7712 thanks for the review! would you be able to please help merge this
PR into trunk when CI passes?
This i
kowshik commented on a change in pull request #9001:
URL: https://github.com/apache/kafka/pull/9001#discussion_r501575432
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java
##
@@ -4335,6 +4343,150 @@ void handleFailure(Throwable throwable)
chia7712 commented on pull request #9393:
URL: https://github.com/apache/kafka/pull/9393#issuecomment-705449262
I can't merge it since I'm not a Kafka committer đ
@junrao Could you please take a look?
This is an autom
voffcheg109 commented on pull request #9380:
URL: https://github.com/apache/kafka/pull/9380#issuecomment-705464097
@mjsax, I've fixed by your comments.
This is an automated message from the Apache Git Service.
To respond to t
tombentley commented on pull request #9365:
URL: https://github.com/apache/kafka/pull/9365#issuecomment-705503807
@rajinisivaram @omkreddy did you have any thoughts about this? What I've
done here isn't exactly pretty, but it was the simplest thing I could think of
which would remove the e
rondagostino commented on pull request #9374:
URL: https://github.com/apache/kafka/pull/9374#issuecomment-705531979
This feature is just being released in 2.7 and will itself be mentioned in
the release notes, so a separate ticket for this issue seems unnecessary to me.
--
mumrah merged pull request #9307:
URL: https://github.com/apache/kafka/pull/9307
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
chia7712 commented on pull request #9374:
URL: https://github.com/apache/kafka/pull/9374#issuecomment-705551760
> This feature is just being released in 2.7 and will itself be mentioned in
the release notes, so a separate ticket for this issue seems unnecessary to me.
I just worry th
rondagostino commented on pull request #9378:
URL: https://github.com/apache/kafka/pull/9378#issuecomment-705552615
Rebased onto trunk despite lack of conflicts due to Python 3 for system
tests being merged.
This is an autom
vvcephei commented on pull request #9139:
URL: https://github.com/apache/kafka/pull/9139#issuecomment-705556429
Ok, it's merged. I'm waiting on permission from Bill before cherry-picking
to 2.7
This is an automated message f
vvcephei merged pull request #9139:
URL: https://github.com/apache/kafka/pull/9139
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
mimaison commented on pull request #9313:
URL: https://github.com/apache/kafka/pull/9313#issuecomment-705563795
@scanterog
`testClusterConfigProperties()` seems to be failing now. Can you fix it
before I take a look at the PR?
```
org.apache.kafka.connect.mirror.MirrorMakerCon
vvcephei commented on pull request #9139:
URL: https://github.com/apache/kafka/pull/9139#issuecomment-705564790
cherry-picked to 2.7. Thanks @jeqo !
This is an automated message from the Apache Git Service.
To respond to the
shadikajevand commented on pull request #9359:
URL: https://github.com/apache/kafka/pull/9359#issuecomment-705566435
Hi @rhauch I am working on convertKey(...) and convertValue(...) methods for
WorkerSourceTask. I'm throwing a DataException in these two methods when an
exception occures. I
C0urante commented on pull request #9375:
URL: https://github.com/apache/kafka/pull/9375#issuecomment-705596382
Hi @rhauch @kkonstantine, this PR has been approved, all merge conflicts
have been resolved, and every build is green. Would it be possible to merge
sometime soon so that it can
mimaison merged pull request #9296:
URL: https://github.com/apache/kafka/pull/9296
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
Daniel Urban created KAFKA-10586:
Summary: MirrorMaker 2.0 REST support
Key: KAFKA-10586
URL: https://issues.apache.org/jira/browse/KAFKA-10586
Project: Kafka
Issue Type: Improvement
[
https://issues.apache.org/jira/browse/KAFKA-10585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210251#comment-17210251
]
Dongjin Lee commented on KAFKA-10585:
-
I inspected this issue a little bit. You mean
acmck opened a new pull request #9394:
URL: https://github.com/apache/kafka/pull/9394
This commit implements a fully-automated development setup using Gitpod.io,
an
online IDE for GitLab, GitHub, and Bitbucket that enables
Dev-Environments-As-Code.
This makes it easy for anyone to ge
acmck closed pull request #9394:
URL: https://github.com/apache/kafka/pull/9394
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
mimaison commented on pull request #9271:
URL: https://github.com/apache/kafka/pull/9271#issuecomment-705628291
Test failures are not related and passed locally, merging
This is an automated message from the Apache Git Servic
mimaison merged pull request #9271:
URL: https://github.com/apache/kafka/pull/9271
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
cadonna commented on a change in pull request #9273:
URL: https://github.com/apache/kafka/pull/9273#discussion_r501793433
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -364,6 +370,73 @@ public void setUncaughtExceptionHandler(final
Thread
cadonna commented on a change in pull request #9273:
URL: https://github.com/apache/kafka/pull/9273#discussion_r501802252
##
File path: streams/src/test/java/org/apache/kafka/streams/KafkaStreamsTest.java
##
@@ -617,7 +619,19 @@ public void
shouldThrowExceptionSettingUncaughtE
[
https://issues.apache.org/jira/browse/KAFKA-10585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210308#comment-17210308
]
Rohan Desai commented on KAFKA-10585:
-
Yes, this is a good summary.
> Kafka Streams
dima5rr commented on pull request #9020:
URL: https://github.com/apache/kafka/pull/9020#issuecomment-705675283
test this please
This is an automated message from the Apache Git Service.
To respond to the message, please log o
dima5rr removed a comment on pull request #9020:
URL: https://github.com/apache/kafka/pull/9020#issuecomment-705675283
test this please
This is an automated message from the Apache Git Service.
To respond to the message, plea
xvrl commented on pull request #9366:
URL: https://github.com/apache/kafka/pull/9366#issuecomment-705676790
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please log on
xvrl commented on pull request #9366:
URL: https://github.com/apache/kafka/pull/9366#issuecomment-705676711
CI seems broken, can we trigger tests again for this?
This is an automated message from the Apache Git Service.
To re
[
https://issues.apache.org/jira/browse/KAFKA-9679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sheikh Araf updated KAFKA-9679:
---
Attachment: image.png
> Mock consumer should behave consistent with actual consumer
> ---
[
https://issues.apache.org/jira/browse/KAFKA-9679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sheikh Araf updated KAFKA-9679:
---
Attachment: (was: image.png)
> Mock consumer should behave consistent with actual consumer
>
Xavier Léauté created KAFKA-10587:
-
Summary: Rename kafka-mirror-maker CLI command line arguments for
KIP-629
Key: KAFKA-10587
URL: https://issues.apache.org/jira/browse/KAFKA-10587
Project: Kafka
Xavier Léauté created KAFKA-10588:
-
Summary: Rename kafka-console-consumer CLI command line arguments
for KIP-629
Key: KAFKA-10588
URL: https://issues.apache.org/jira/browse/KAFKA-10588
Project: Kafka
Xavier Léauté created KAFKA-10589:
-
Summary: Rename kafka-replica-verification CLI command line
arguments for KIP-629
Key: KAFKA-10589
URL: https://issues.apache.org/jira/browse/KAFKA-10589
Project: K
lct45 commented on pull request #9383:
URL: https://github.com/apache/kafka/pull/9383#issuecomment-705688523
System tests:
https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4204/
This is an automated message
ableegoldman commented on pull request #9380:
URL: https://github.com/apache/kafka/pull/9380#issuecomment-705689770
Tests passed, should be good to merge @mjsax . Btw the 2.7 branch was just
cut so this should be cherrypicked back to 2.7.
--
junrao commented on a change in pull request #7929:
URL: https://github.com/apache/kafka/pull/7929#discussion_r501325705
##
File path: core/src/main/scala/kafka/log/ProducerStateManager.scala
##
@@ -496,6 +491,53 @@ class ProducerStateManager(val topicPartition:
TopicPartition
ableegoldman commented on a change in pull request #9273:
URL: https://github.com/apache/kafka/pull/9273#discussion_r501868835
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -364,6 +370,73 @@ public void setUncaughtExceptionHandler(final
T
ableegoldman commented on a change in pull request #9273:
URL: https://github.com/apache/kafka/pull/9273#discussion_r501873791
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -364,6 +370,73 @@ public void setUncaughtExceptionHandler(final
T
ivanyu opened a new pull request #9395:
URL: https://github.com/apache/kafka/pull/9395
This commit adds a new replication policy for MirrorMaker 2,
`LegacyReplicationPolicy`. This policy imitates MirrorMaker 1 behavior of not
renaming replicated topics. The exception is made for `heartbeat
ableegoldman commented on a change in pull request #9383:
URL: https://github.com/apache/kafka/pull/9383#discussion_r501875691
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/HighAvailabilityTaskAssignorIntegrationTest.java
##
@@ -286,7 +286,8 @@ priva
junrao commented on pull request #9393:
URL: https://github.com/apache/kafka/pull/9393#issuecomment-705702092
In this PR, I have addressed the review comments from @chia7712 in #9001
which were provided after #9001 was merged. The changes are made mainly to
KafkaAdminClient:
Improve
junrao removed a comment on pull request #9393:
URL: https://github.com/apache/kafka/pull/9393#issuecomment-705702092
In this PR, I have addressed the review comments from @chia7712 in #9001
which were provided after #9001 was merged. The changes are made mainly to
KafkaAdminClient:
ableegoldman commented on a change in pull request #9383:
URL: https://github.com/apache/kafka/pull/9383#discussion_r501876646
##
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/SubscriptionInfoTest.java
##
@@ -59,6 +60,7 @@
);
junrao merged pull request #9393:
URL: https://github.com/apache/kafka/pull/9393
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
guozhangwang commented on pull request #9020:
URL: https://github.com/apache/kafka/pull/9020#issuecomment-705707869
Test passed, merged to trunk.
Thanks @dima5rr for your great contribution!
This is an automated messag
guozhangwang merged pull request #9020:
URL: https://github.com/apache/kafka/pull/9020
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
vvcephei opened a new pull request #9396:
URL: https://github.com/apache/kafka/pull/9396
Implements KIP-478 for the test-utils module:
* adds mocks of the new ProcessorContext and StateStoreContext
* adds tests that all stores and store builders are usable with the new mock
* adds t
guozhangwang commented on pull request #9020:
URL: https://github.com/apache/kafka/pull/9020#issuecomment-705723421
Cherry-picked to 2.6 as well.
This is an automated message from the Apache Git Service.
To respond to the mes
[
https://issues.apache.org/jira/browse/KAFKA-10271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang resolved KAFKA-10271.
---
Fix Version/s: (was: 2.5.2)
2.7.0
Resolution: Fixed
> Performa
junrao commented on pull request #7929:
URL: https://github.com/apache/kafka/pull/7929#issuecomment-705727027
Also, it seems that Log.takeProducerSnapshot() no longer used?
This is an automated message from the Apache Git Ser
vvcephei commented on a change in pull request #9396:
URL: https://github.com/apache/kafka/pull/9396#discussion_r501891955
##
File path: checkstyle/suppressions.xml
##
@@ -194,13 +194,13 @@
files=".*[/\\]streams[/\\].*test[/\\].*.java"/>
+
f
[
https://issues.apache.org/jira/browse/KAFKA-10585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang updated KAFKA-10585:
--
Labels: newbie++ (was: )
> Kafka Streams should clean up the state store directory from clean
[
https://issues.apache.org/jira/browse/KAFKA-10585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-10585:
Issue Type: Improvement (was: Bug)
> Kafka Streams should clean up the state store direct
[
https://issues.apache.org/jira/browse/KAFKA-10585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-10585:
Priority: Minor (was: Major)
> Kafka Streams should clean up the state store directory fr
[
https://issues.apache.org/jira/browse/KAFKA-10585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210386#comment-17210386
]
Matthias J. Sax commented on KAFKA-10585:
-
[~dongjin] â please assign the ticket
gardnervickers commented on a change in pull request #7929:
URL: https://github.com/apache/kafka/pull/7929#discussion_r501942512
##
File path: core/src/main/scala/kafka/log/ProducerStateManager.scala
##
@@ -653,36 +697,44 @@ class ProducerStateManager(val topicPartition:
Topic
gardnervickers commented on a change in pull request #7929:
URL: https://github.com/apache/kafka/pull/7929#discussion_r501944185
##
File path: core/src/main/scala/kafka/log/ProducerStateManager.scala
##
@@ -496,6 +491,53 @@ class ProducerStateManager(val topicPartition:
TopicP
efeg opened a new pull request #9397:
URL: https://github.com/apache/kafka/pull/9397
Other than a Stack Overflow comment (see
https://stackoverflow.com/a/61738065) by Colin Patrick McCabe (@cmccabe ) and a
proposed design note on KIP-117 wiki, there is no source that verifies the
thread-s
efeg commented on pull request #9397:
URL: https://github.com/apache/kafka/pull/9397#issuecomment-705765230
@cmccabe Do you think you might be able to take a look at this PR?
This is an automated message from the Apache Git S
lct45 commented on a change in pull request #9383:
URL: https://github.com/apache/kafka/pull/9383#discussion_r501956905
##
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignorTest.java
##
@@ -483,7 +485,7 @@ public void testEag
gardnervickers commented on a change in pull request #7929:
URL: https://github.com/apache/kafka/pull/7929#discussion_r501957800
##
File path: core/src/test/scala/unit/kafka/log/LogTest.scala
##
@@ -1226,6 +1225,104 @@ class LogTest {
assertEquals(retainedLastSeqOpt, reloa
mjsax merged pull request #9380:
URL: https://github.com/apache/kafka/pull/9380
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
mjsax commented on pull request #9380:
URL: https://github.com/apache/kafka/pull/9380#issuecomment-705772843
Thanks for the PR @voffcheg109!
Merged to `trunk` and cherry-picked to `2.7` branch.
This is an automated mes
[
https://issues.apache.org/jira/browse/KAFKA-7334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax reassigned KAFKA-7334:
--
Assignee: Vladimir
> Suggest changing config for state.dir in case of FileNotFoundExce
[
https://issues.apache.org/jira/browse/KAFKA-7334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210410#comment-17210410
]
Matthias J. Sax commented on KAFKA-7334:
[~vladimir_shadrin]Â I added you to the l
gardnervickers commented on a change in pull request #7929:
URL: https://github.com/apache/kafka/pull/7929#discussion_r501968249
##
File path: core/src/test/scala/unit/kafka/log/ProducerStateManagerTest.scala
##
@@ -834,6 +834,40 @@ class ProducerStateManagerTest {
assertE
gardnervickers commented on a change in pull request #7929:
URL: https://github.com/apache/kafka/pull/7929#discussion_r501970716
##
File path: core/src/test/scala/unit/kafka/log/ProducerStateManagerTest.scala
##
@@ -834,6 +834,40 @@ class ProducerStateManagerTest {
assertE
gardnervickers commented on pull request #7929:
URL: https://github.com/apache/kafka/pull/7929#issuecomment-705786361
@junrao I think that `Log.takeProducerSnapshot` is being used for testing in
a few places in `LogTest`, though my IDE does not pick that up for some reason.
-
gardnervickers commented on a change in pull request #7929:
URL: https://github.com/apache/kafka/pull/7929#discussion_r501979388
##
File path: core/src/test/scala/unit/kafka/log/LogTest.scala
##
@@ -1226,6 +1225,104 @@ class LogTest {
assertEquals(retainedLastSeqOpt, reloa
[
https://issues.apache.org/jira/browse/KAFKA-9628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mickael Maison reassigned KAFKA-9628:
-
Assignee: Chia-Ping Tsai (was: Mickael Maison)
> Replace Produce request/response with
[
https://issues.apache.org/jira/browse/KAFKA-9628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210441#comment-17210441
]
Mickael Maison commented on KAFKA-9628:
---
[~chia7712] I've reassigned it to you, go
cmccabe commented on pull request #9390:
URL: https://github.com/apache/kafka/pull/9390#issuecomment-705826094
ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
cmccabe commented on pull request #9390:
URL: https://github.com/apache/kafka/pull/9390#issuecomment-705828611
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please log
[
https://issues.apache.org/jira/browse/KAFKA-7447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210470#comment-17210470
]
James Cheng commented on KAFKA-7447:
Hi. The consensus seems to be that this was fixe
junrao commented on a change in pull request #7929:
URL: https://github.com/apache/kafka/pull/7929#discussion_r502023899
##
File path: core/src/test/scala/unit/kafka/log/LogTest.scala
##
@@ -782,7 +782,7 @@ class LogTest {
}
// Retain snapshots for the last 2 segmen
[
https://issues.apache.org/jira/browse/KAFKA-7447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210472#comment-17210472
]
Lauren McDonald commented on KAFKA-7447:
We are on version 2.3.* and saw this iss
ableegoldman commented on a change in pull request #9383:
URL: https://github.com/apache/kafka/pull/9383#discussion_r502052730
##
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignorTest.java
##
@@ -483,7 +485,7 @@ public void
xvrl commented on pull request #9367:
URL: https://github.com/apache/kafka/pull/9367#issuecomment-705863610
jdk8 test failures appear unrelated
This is an automated message from the Apache Git Service.
To respond to the messa
gwenshap closed pull request #9366:
URL: https://github.com/apache/kafka/pull/9366
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
xvrl opened a new pull request #9398:
URL: https://github.com/apache/kafka/pull/9398
cc @gwenshap
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
guozhangwang commented on a change in pull request #9396:
URL: https://github.com/apache/kafka/pull/9396#discussion_r502067124
##
File path:
streams/test-utils/src/main/java/org/apache/kafka/streams/processor/api/MockProcessorContext.java
##
@@ -0,0 +1,494 @@
+/*
+ * Licensed
gardnervickers commented on a change in pull request #7929:
URL: https://github.com/apache/kafka/pull/7929#discussion_r502078584
##
File path: core/src/test/scala/unit/kafka/log/LogTest.scala
##
@@ -782,7 +782,7 @@ class LogTest {
}
// Retain snapshots for the last
gwenshap commented on a change in pull request #9367:
URL: https://github.com/apache/kafka/pull/9367#discussion_r502082826
##
File path: clients/src/main/java/org/apache/kafka/common/utils/ConfigUtils.java
##
@@ -0,0 +1,92 @@
+/*
+ * Licensed to the Apache Software Foundation (
gwenshap commented on a change in pull request #9367:
URL: https://github.com/apache/kafka/pull/9367#discussion_r502083707
##
File path: clients/src/main/java/org/apache/kafka/common/utils/ConfigUtils.java
##
@@ -0,0 +1,92 @@
+/*
+ * Licensed to the Apache Software Foundation (
apovzner commented on a change in pull request #9386:
URL: https://github.com/apache/kafka/pull/9386#discussion_r502084924
##
File path: core/src/main/scala/kafka/network/SocketServer.scala
##
@@ -1203,14 +1262,27 @@ class ConnectionQuotas(config: KafkaConfig, time: Time,
metr
apovzner commented on a change in pull request #9386:
URL: https://github.com/apache/kafka/pull/9386#discussion_r502086777
##
File path: core/src/main/scala/kafka/network/SocketServer.scala
##
@@ -1242,7 +1314,56 @@ class ConnectionQuotas(config: KafkaConfig, time: Time,
metri
gwenshap closed pull request #9398:
URL: https://github.com/apache/kafka/pull/9398
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
apovzner commented on a change in pull request #9386:
URL: https://github.com/apache/kafka/pull/9386#discussion_r502091323
##
File path: core/src/test/scala/unit/kafka/network/ConnectionQuotasTest.scala
##
@@ -409,6 +409,67 @@ class ConnectionQuotasTest {
verifyConnectionC
splett2 commented on a change in pull request #9386:
URL: https://github.com/apache/kafka/pull/9386#discussion_r502091435
##
File path: core/src/main/scala/kafka/network/SocketServer.scala
##
@@ -1203,14 +1262,27 @@ class ConnectionQuotas(config: KafkaConfig, time: Time,
metri
apovzner commented on a change in pull request #9386:
URL: https://github.com/apache/kafka/pull/9386#discussion_r502092158
##
File path: core/src/main/scala/kafka/network/SocketServer.scala
##
@@ -1203,14 +1262,27 @@ class ConnectionQuotas(config: KafkaConfig, time: Time,
metr
splett2 commented on a change in pull request #9386:
URL: https://github.com/apache/kafka/pull/9386#discussion_r502092508
##
File path: core/src/main/scala/kafka/network/SocketServer.scala
##
@@ -1242,7 +1314,56 @@ class ConnectionQuotas(config: KafkaConfig, time: Time,
metric
[
https://issues.apache.org/jira/browse/KAFKA-10584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
huxihx reassigned KAFKA-10584:
--
Assignee: huxihx
> IndexSearchType should use sealed trait instead of Enumeration
> -
1 - 100 of 122 matches
Mail list logo
