[GitHub] [kafka] gardnervickers commented on a change in pull request #7929: KAFKA-9393: DeleteRecords may cause extreme lock contention for large partition directories

[GitBox]

gardnervickers commented on a change in pull request #7929:
URL: https://github.com/apache/kafka/pull/7929#discussion_r502078584



##########
File path: core/src/test/scala/unit/kafka/log/LogTest.scala
##########
@@ -782,7 +782,7 @@ class LogTest {
     }
 
     // Retain snapshots for the last 2 segments
-    ProducerStateManager.deleteSnapshotsBefore(logDir, 
segmentOffsets(segmentOffsets.size - 2))
+    ProducerStateManager.listSnapshotFiles(logDir).filter(_.offset < 
segmentOffsets(segmentOffsets.size - 2)).foreach(_.deleteIfExists())

Review comment:
       Yes, it should work if we switch these back to using 
deleteSnapshotsBefore. Thanks!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org