cnZach commented on a change in pull request #9236:
URL: https://github.com/apache/kafka/pull/9236#discussion_r489215673
##
File path:
clients/src/main/java/org/apache/kafka/common/security/kerberos/KerberosLogin.java
##
@@ -213,6 +213,7 @@ public LoginContext login() throws L
AD created KAFKA-10489:
--
Summary: Committed consumer offsets not sent to consumer on
rebalance
Key: KAFKA-10489
URL: https://issues.apache.org/jira/browse/KAFKA-10489
Project: Kafka
Issue Type: Bug
[
https://issues.apache.org/jira/browse/KAFKA-9016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17196927#comment-17196927
]
Srikantha G K commented on KAFKA-9016:
--
I am new to Kafka,I am working in Windows en
dongjinleekr commented on pull request #7898:
URL: https://github.com/apache/kafka/pull/7898#issuecomment-693414587
@hachikuji @chia7712 @abbccdda @omkreddy @tombentley Could you have a look?
:pray:
This is an automated mess
showuon commented on pull request #9241:
URL: https://github.com/apache/kafka/pull/9241#issuecomment-693429851
@guozhangwang , could you help review this small PR? Thanks.
This is an automated message from the Apache Git Ser
chia7712 commented on a change in pull request #9262:
URL: https://github.com/apache/kafka/pull/9262#discussion_r489476268
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java
##
@@ -306,40 +306,55 @@ public synchronized void cle
DOJI45 commented on pull request #9247:
URL: https://github.com/apache/kafka/pull/9247#issuecomment-693451000
> > @DOJI45 Thanks for the PR! Could you also add a unit test to complete
the coverage? You can find some examples in StreamTaskTest or
ProcessorStateManagerTest
>
> Seems t
ijuma commented on pull request #7898:
URL: https://github.com/apache/kafka/pull/7898#issuecomment-693453914
@dongjinleekr Has the KIP been approved?
This is an automated message from the Apache Git Service.
To respond to the
[
https://issues.apache.org/jira/browse/KAFKA-10481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-10481:
Component/s: system tests
> Consider Improving the Success Criteria of Streams' System Tes
vamossagar12 opened a new pull request #9292:
URL: https://github.com/apache/kafka/pull/9292
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of test
vamossagar12 commented on pull request #6669:
URL: https://github.com/apache/kafka/pull/6669#issuecomment-693465372
@stanislavkozlovski , unfortunately the older branch of mine got corrupted.
I have created a new PR here: https://github.com/apache/kafka/pull/9292
-
manijndl7 commented on a change in pull request #9255:
URL: https://github.com/apache/kafka/pull/9255#discussion_r489515189
##
File path: core/src/main/scala/kafka/admin/ConsumerGroupCommand.scala
##
@@ -823,7 +809,7 @@ object ConsumerGroupCommand extends Logging {
c
manijndl7 commented on a change in pull request #9255:
URL: https://github.com/apache/kafka/pull/9255#discussion_r489515189
##
File path: core/src/main/scala/kafka/admin/ConsumerGroupCommand.scala
##
@@ -823,7 +809,7 @@ object ConsumerGroupCommand extends Logging {
c
manijndl7 commented on a change in pull request #9255:
URL: https://github.com/apache/kafka/pull/9255#discussion_r489515785
##
File path: clients/src/test/java/org/apache/kafka/common/utils/UtilsTest.java
##
@@ -784,4 +787,39 @@ public void testCloseAllQuietly() {
asse
manijndl7 commented on a change in pull request #9255:
URL: https://github.com/apache/kafka/pull/9255#discussion_r489518181
##
File path: clients/src/main/java/org/apache/kafka/common/utils/Utils.java
##
@@ -1271,4 +1274,34 @@ private static byte checkRange(final byte i) {
manijndl7 commented on a change in pull request #9255:
URL: https://github.com/apache/kafka/pull/9255#discussion_r489531741
##
File path: clients/src/main/java/org/apache/kafka/common/utils/Utils.java
##
@@ -1271,4 +1274,34 @@ private static byte checkRange(final byte i) {
manijndl7 commented on a change in pull request #9255:
URL: https://github.com/apache/kafka/pull/9255#discussion_r489515189
##
File path: core/src/main/scala/kafka/admin/ConsumerGroupCommand.scala
##
@@ -823,7 +809,7 @@ object ConsumerGroupCommand extends Logging {
c
manijndl7 commented on a change in pull request #9255:
URL: https://github.com/apache/kafka/pull/9255#discussion_r489518181
##
File path: clients/src/main/java/org/apache/kafka/common/utils/Utils.java
##
@@ -1271,4 +1274,34 @@ private static byte checkRange(final byte i) {
manijndl7 commented on a change in pull request #9255:
URL: https://github.com/apache/kafka/pull/9255#discussion_r489515785
##
File path: clients/src/test/java/org/apache/kafka/common/utils/UtilsTest.java
##
@@ -784,4 +787,39 @@ public void testCloseAllQuietly() {
asse
manijndl7 commented on a change in pull request #9255:
URL: https://github.com/apache/kafka/pull/9255#discussion_r489534622
##
File path: clients/src/main/java/org/apache/kafka/common/utils/Utils.java
##
@@ -1271,4 +1274,34 @@ private static byte checkRange(final byte i) {
manijndl7 commented on a change in pull request #9255:
URL: https://github.com/apache/kafka/pull/9255#discussion_r489531741
##
File path: clients/src/main/java/org/apache/kafka/common/utils/Utils.java
##
@@ -1271,4 +1274,34 @@ private static byte checkRange(final byte i) {
big-andy-coates commented on a change in pull request #9156:
URL: https://github.com/apache/kafka/pull/9156#discussion_r489538195
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableImpl.java
##
@@ -182,6 +182,8 @@ public String queryableStoreN
lbradstreet closed pull request #9187:
URL: https://github.com/apache/kafka/pull/9187
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
big-andy-coates commented on a change in pull request #9156:
URL: https://github.com/apache/kafka/pull/9156#discussion_r489539904
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableKTableAbstractJoin.java
##
@@ -39,9 +39,15 @@
}
@O
big-andy-coates commented on a change in pull request #9156:
URL: https://github.com/apache/kafka/pull/9156#discussion_r487060078
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableKTableAbstractJoin.java
##
@@ -39,9 +39,15 @@
}
@O
big-andy-coates commented on a change in pull request #9156:
URL: https://github.com/apache/kafka/pull/9156#discussion_r489542022
##
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KTableImplTest.java
##
@@ -304,6 +363,30 @@ public void testStateSto
big-andy-coates commented on a change in pull request #9156:
URL: https://github.com/apache/kafka/pull/9156#discussion_r489543472
##
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KTableImplTest.java
##
@@ -304,6 +363,30 @@ public void testStateSto
big-andy-coates commented on a change in pull request #9156:
URL: https://github.com/apache/kafka/pull/9156#discussion_r489544014
##
File path:
streams/streams-scala/src/test/scala/org/apache/kafka/streams/scala/kstream/KTableTest.scala
##
@@ -39,29 +39,27 @@ class KTableTest
hachikuji merged pull request #9290:
URL: https://github.com/apache/kafka/pull/9290
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
[
https://issues.apache.org/jira/browse/KAFKA-10487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson resolved KAFKA-10487.
-
Resolution: Fixed
> Fix edge case in Raft truncation protocol
>
ableegoldman commented on a change in pull request #9060:
URL: https://github.com/apache/kafka/pull/9060#discussion_r489580109
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java
##
@@ -45,33 +49,38 @@
"Please rep
ableegoldman commented on a change in pull request #9060:
URL: https://github.com/apache/kafka/pull/9060#discussion_r489580572
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java
##
@@ -45,33 +49,38 @@
"Please rep
kkonstantine commented on pull request #9227:
URL: https://github.com/apache/kafka/pull/9227#issuecomment-693533434
ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log on
kkonstantine commented on pull request #9227:
URL: https://github.com/apache/kafka/pull/9227#issuecomment-693534496
Closing temporarily to attempt to trigger a jenkins build.
This is an automated message from the Apache Git
kkonstantine closed pull request #9227:
URL: https://github.com/apache/kafka/pull/9227
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
big-andy-coates commented on a change in pull request #9156:
URL: https://github.com/apache/kafka/pull/9156#discussion_r489588705
##
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KTableImplTest.java
##
@@ -304,6 +363,30 @@ public void testStateSto
dongjinleekr commented on pull request #7898:
URL: https://github.com/apache/kafka/pull/7898#issuecomment-693552944
@ijuma Of course not. But I hoped to reboot the discussion. (Thanks for the
kind reponse! :+1:)
This is an a
ijuma commented on a change in pull request #9275:
URL: https://github.com/apache/kafka/pull/9275#discussion_r489612109
##
File path: core/src/main/scala/kafka/api/ApiVersion.scala
##
@@ -100,7 +100,9 @@ object ApiVersion {
// Introduced StopReplicaRequest V3 containing th
wcarlson5 commented on a change in pull request #9273:
URL: https://github.com/apache/kafka/pull/9273#discussion_r489619608
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
##
@@ -570,6 +581,21 @@ void runLoop() {
}
hachikuji commented on a change in pull request #9100:
URL: https://github.com/apache/kafka/pull/9100#discussion_r489569400
##
File path: clients/src/main/resources/common/message/AlterIsrRequest.json
##
@@ -0,0 +1,44 @@
+// Licensed to the Apache Software Foundation (ASF) unde
Noa Resare created KAFKA-10490:
--
Summary: Make constructors public for Admin API value objects
Key: KAFKA-10490
URL: https://issues.apache.org/jira/browse/KAFKA-10490
Project: Kafka
Issue Type:
vvcephei opened a new pull request #9293:
URL: https://github.com/apache/kafka/pull/9293
Just a quick POC of how we can optionally bypass the caching layer in IQ.
Some queries that are common in IQ but rare in the PAPI perform really poorly
with the caching layer involved. We should have a
vvcephei commented on a change in pull request #9293:
URL: https://github.com/apache/kafka/pull/9293#discussion_r489632127
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java
##
@@ -46,43 +46,90 @@
* @param
* @param
*/
mjsax commented on a change in pull request #9060:
URL: https://github.com/apache/kafka/pull/9060#discussion_r489646059
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java
##
@@ -45,33 +49,38 @@
"Please report at
mumrah commented on a change in pull request #9100:
URL: https://github.com/apache/kafka/pull/9100#discussion_r489703810
##
File path: core/src/main/scala/kafka/cluster/Partition.scala
##
@@ -1210,6 +1317,37 @@ class Partition(val topicPartition: TopicPartition,
}
}
+
mumrah commented on a change in pull request #9100:
URL: https://github.com/apache/kafka/pull/9100#discussion_r489720971
##
File path: config/log4j.properties
##
@@ -76,8 +76,8 @@ log4j.additivity.kafka.request.logger=false
log4j.logger.kafka.network.RequestChannel$=WARN, requ
mumrah commented on a change in pull request #9100:
URL: https://github.com/apache/kafka/pull/9100#discussion_r489721316
##
File path: core/src/main/scala/kafka/cluster/Partition.scala
##
@@ -617,9 +665,9 @@ class Partition(val topicPartition: TopicPartition,
// since
mumrah commented on a change in pull request #9100:
URL: https://github.com/apache/kafka/pull/9100#discussion_r489730265
##
File path: core/src/main/scala/kafka/server/AlterIsrManager.scala
##
@@ -0,0 +1,173 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
mumrah commented on a change in pull request #9100:
URL: https://github.com/apache/kafka/pull/9100#discussion_r489740479
##
File path: core/src/main/scala/kafka/server/AlterIsrManager.scala
##
@@ -0,0 +1,173 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
mumrah commented on a change in pull request #9100:
URL: https://github.com/apache/kafka/pull/9100#discussion_r489744561
##
File path: core/src/main/scala/kafka/server/AlterIsrManager.scala
##
@@ -0,0 +1,173 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
mumrah commented on a change in pull request #9100:
URL: https://github.com/apache/kafka/pull/9100#discussion_r489745539
##
File path: core/src/main/scala/kafka/server/AlterIsrManager.scala
##
@@ -0,0 +1,173 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
mumrah commented on a change in pull request #9100:
URL: https://github.com/apache/kafka/pull/9100#discussion_r489747101
##
File path: core/src/main/scala/kafka/server/AlterIsrManager.scala
##
@@ -0,0 +1,173 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
David Arthur created KAFKA-10491:
Summary: Check authorizations before other criteria in KafkaApis
Key: KAFKA-10491
URL: https://issues.apache.org/jira/browse/KAFKA-10491
Project: Kafka
Issue
mumrah commented on a change in pull request #9100:
URL: https://github.com/apache/kafka/pull/9100#discussion_r489753946
##
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##
@@ -3045,6 +3045,24 @@ class KafkaApis(val requestChannel: RequestChannel,
}
}
+
mumrah commented on a change in pull request #9100:
URL: https://github.com/apache/kafka/pull/9100#discussion_r489756083
##
File path: core/src/main/scala/kafka/server/ReplicaManager.scala
##
@@ -1317,7 +1326,9 @@ class ReplicaManager(val config: KafkaConfig,
parti
jolshan opened a new pull request #9294:
URL: https://github.com/apache/kafka/pull/9294
ClusterConnectStatesTest and ClientUtilsTest were failing because they
expected kafka.apache.org to resolve to 2 IP addresses. This updates the tests
so they reflect that DNS resolves to 3 addresses.
[
https://issues.apache.org/jira/browse/KAFKA-10476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
AbdulRahman Mahmoud updated KAFKA-10476:
Attachment: (was: Error.txt)
> Error when calling (kafka-configs.sh --add-conf
[
https://issues.apache.org/jira/browse/KAFKA-10476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
AbdulRahman Mahmoud updated KAFKA-10476:
Description:
was:
For now We created a Cluster on AWS with MSK service, we
[
https://issues.apache.org/jira/browse/KAFKA-10476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
AbdulRahman Mahmoud updated KAFKA-10476:
Attachment: (was: Script.txt)
> Error when calling (kafka-configs.sh --add-con
[
https://issues.apache.org/jira/browse/KAFKA-10476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
AbdulRahman Mahmoud updated KAFKA-10476:
Summary: ignore it (was: Error when calling (kafka-configs.sh
--add-config): org.
[
https://issues.apache.org/jira/browse/KAFKA-10476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
AbdulRahman Mahmoud closed KAFKA-10476.
---
> ignore it
> -
>
> Key: KAFKA-10476
> URL: http
[
https://issues.apache.org/jira/browse/KAFKA-10476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
AbdulRahman Mahmoud resolved KAFKA-10476.
-
Resolution: Invalid
> ignore it
> -
>
> Key: KAFKA-10476
ableegoldman opened a new pull request #9295:
URL: https://github.com/apache/kafka/pull/9295
Some minor logging adjustments to standardize the grammar of rebalance
related messages and make it easy to query the logs for quick debugging results
-
ableegoldman commented on pull request #9295:
URL: https://github.com/apache/kafka/pull/9295#issuecomment-693727341
@guozhangwang
This is an automated message from the Apache Git Service.
To respond to the message, please lo
jolshan commented on pull request #9294:
URL: https://github.com/apache/kafka/pull/9294#issuecomment-693727406
@abbccdda I agree that they are fragile. Could you give a little more detail
about checking the patterns? I'm not sure if I follow.
--
Jason Gustafson created KAFKA-10492:
---
Summary: Core Raft implementation
Key: KAFKA-10492
URL: https://issues.apache.org/jira/browse/KAFKA-10492
Project: Kafka
Issue Type: Sub-task
kkonstantine commented on a change in pull request #9104:
URL: https://github.com/apache/kafka/pull/9104#discussion_r489834773
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ConnectorConfig.java
##
@@ -89,11 +89,16 @@
public static final Stri
abbccdda commented on pull request #9103:
URL: https://github.com/apache/kafka/pull/9103#issuecomment-693757638
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please lo
abbccdda commented on a change in pull request #9103:
URL: https://github.com/apache/kafka/pull/9103#discussion_r489875283
##
File path: core/src/main/scala/kafka/server/KafkaConfig.scala
##
@@ -1542,6 +1542,9 @@ class KafkaConfig(val props: java.util.Map[_, _], doLog:
Boolean
chia7712 opened a new pull request #9296:
URL: https://github.com/apache/kafka/pull/9296
```NoEpochForPartitionException``` and ```ClientIdAndTopic``` are not used
anymore.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Veri
chia7712 commented on a change in pull request #9292:
URL: https://github.com/apache/kafka/pull/9292#discussion_r489931752
##
File path:
core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala
##
@@ -670,12 +675,16 @@ class GroupMetadataManager(brokerId: Int,
vamossagar12 commented on a change in pull request #9292:
URL: https://github.com/apache/kafka/pull/9292#discussion_r489956487
##
File path:
core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala
##
@@ -670,12 +675,16 @@ class GroupMetadataManager(brokerId: Int
[
https://issues.apache.org/jira/browse/KAFKA-10485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17197368#comment-17197368
]
Chia-Ping Tsai commented on KAFKA-10485:
REQUEST_TIMED_OUT is viewed as fatal er
[
https://issues.apache.org/jira/browse/KAFKA-10490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tom Bentley updated KAFKA-10490:
Labels: needs-kip (was: )
> Make constructors public for Admin API value objects
> --
[
https://issues.apache.org/jira/browse/KAFKA-6791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17197411#comment-17197411
]
Jeff Widman commented on KAFKA-6791:
Should this be closed as "wontfix"?
The associ
tombentley commented on pull request #9266:
URL: https://github.com/apache/kafka/pull/9266#issuecomment-693952069
@ijuma @hachikuji @guozhangwang @mjsax @mimaison please could one of you
could take a look?
This is an automa
tombentley commented on pull request #9252:
URL: https://github.com/apache/kafka/pull/9252#issuecomment-693953116
@abbccdda or perhaps @cmccabe or @dajac any chance one of you could take a
look?
This is an automated message
tombentley commented on pull request #8878:
URL: https://github.com/apache/kafka/pull/8878#issuecomment-693954974
@mimaison @omkreddy could one of you do the build again?
This is an automated message from the Apache Git Serv
Pedro Gontijo created KAFKA-10493:
-
Summary: Ktable out-of-order updates are not being ignored
Key: KAFKA-10493
URL: https://issues.apache.org/jira/browse/KAFKA-10493
Project: Kafka
Issue Typ
79 matches
Mail list logo
