big-andy-coates commented on a change in pull request #9156:
URL: https://github.com/apache/kafka/pull/9156#discussion_r489588705
##########
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KTableImplTest.java
##########
@@ -304,6 +363,30 @@ public void testStateStore() {
}
}
+ @Test
+ public void testSendingOldValuesNotSetIfNotMaterialized() {
+ final StreamsBuilder builder = new StreamsBuilder();
+
+ final KTableImpl<String, String, String> table =
+ (KTableImpl<String, String, String>) builder.table("topic1",
consumed);
+
+ table.enableSendingOldValues(true);
+
+ assertThat(table.sendingOldValueEnabled(), is(false));
+ }
+
+ @Test
+ public void testSendingOldValuesSetIfMaterializedForced() {
+ final StreamsBuilder builder = new StreamsBuilder();
+
+ final KTableImpl<String, String, String> table =
+ (KTableImpl<String, String, String>) builder.table("topic1",
consumed);
Review comment:
Rename test to make it clear its force materialized due to sending old
values,
`shouldSetSendingOldValuesIfMaterializationForcedInternally`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
