[GitHub] [kafka] dielhennr edited a comment on pull request #9101: KAFKA-10325: KIP-649 implementation

2020-08-30 Thread GitBox
dielhennr edited a comment on pull request #9101: URL: https://github.com/apache/kafka/pull/9101#issuecomment-683076305 Hey @jsancio , I added some work in progress to this branch including new APIs for this feature. Fitting user and client-id into the `DescribeConfigs` API was awkw

[GitHub] [kafka] dielhennr edited a comment on pull request #9101: KAFKA-10325: KIP-649 implementation

2020-08-30 Thread GitBox
dielhennr edited a comment on pull request #9101: URL: https://github.com/apache/kafka/pull/9101#issuecomment-683076305 Hey @jsancio , I added some work in progress to this branch including new APIs for this feature. Fitting user and client-id into the `DescribeConfigs` API was awkw

[GitHub] [kafka] dielhennr edited a comment on pull request #9101: KAFKA-10325: KIP-649 implementation

2020-08-30 Thread GitBox
dielhennr edited a comment on pull request #9101: URL: https://github.com/apache/kafka/pull/9101#issuecomment-683076305 Hey @jsancio , I added some work in progress to this branch including new APIs for this feature. Fitting user and client-id into the `DescribeConfigs` API was awkw

[GitHub] [kafka] chia7712 commented on a change in pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

2020-08-30 Thread GitBox
chia7712 commented on a change in pull request #8657: URL: https://github.com/apache/kafka/pull/8657#discussion_r479737358 ## File path: core/src/main/scala/kafka/server/ActionQueue.scala ## @@ -0,0 +1,46 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one o

[jira] [Assigned] (KAFKA-10433) Reuse the ByteBuffer in validating compressed records

2020-08-30 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-10433: -- Assignee: Ismael Juma (was: Chia-Ping Tsai) > Reuse the ByteBuffer in validating com

[GitHub] [kafka] chia7712 closed pull request #9220: KAFKA-10433 Reuse the ByteBuffer in validating compressed records

2020-08-30 Thread GitBox
chia7712 closed pull request #9220: URL: https://github.com/apache/kafka/pull/9220 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] chia7712 commented on pull request #9220: KAFKA-10433 Reuse the ByteBuffer in validating compressed records

2020-08-30 Thread GitBox
chia7712 commented on pull request #9220: URL: https://github.com/apache/kafka/pull/9220#issuecomment-683400353 close as there is a better approach (#9229) This is an automated message from the Apache Git Service. To respond

[GitHub] [kafka] chia7712 commented on pull request #9229: MINOR: Reduce allocations in requests via buffer caching

2020-08-30 Thread GitBox
chia7712 commented on pull request #9229: URL: https://github.com/apache/kafka/pull/9229#issuecomment-683400436 @ijuma I have closed #9220 and assign https://issues.apache.org/jira/browse/KAFKA-10433 to you. This is an autom

[GitHub] [kafka] chia7712 commented on pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

2020-08-30 Thread GitBox
chia7712 commented on pull request #8657: URL: https://github.com/apache/kafka/pull/8657#issuecomment-683400677 > Could you do some perf tests so that we know the performance of fetch requests doesn't change noticeably? @junrao Are there any suggested official benchmark tools?

[GitHub] [kafka] chia7712 commented on a change in pull request #9223: KAFKA-10438 Lazy initialization of record header to reduce memory usa…

2020-08-30 Thread GitBox
chia7712 commented on a change in pull request #9223: URL: https://github.com/apache/kafka/pull/9223#discussion_r479750019 ## File path: clients/src/test/java/org/apache/kafka/common/record/DefaultRecordTest.java ## @@ -270,7 +270,7 @@ public void testInvalidNumHeadersPartial(

[GitHub] [kafka] soarez edited a comment on pull request #9064: KAFKA-10205: Documentation and handling of non deterministic Topologies

2020-08-30 Thread GitBox
soarez edited a comment on pull request #9064: URL: https://github.com/apache/kafka/pull/9064#issuecomment-683421515 @mjsax rebased and fixed the error, now `./gradlew :streams:unitTest` seems to run without errors over here. --

[GitHub] [kafka] soarez commented on pull request #9064: KAFKA-10205: Documentation and handling of non deterministic Topologies

2020-08-30 Thread GitBox
soarez commented on pull request #9064: URL: https://github.com/apache/kafka/pull/9064#issuecomment-683421515 @mjsax rebased and fix the error, now `./gradlew :streams:unitTest` seems to run without errors over here. This i

[GitHub] [kafka] chia7712 commented on pull request #9223: KAFKA-10438 Lazy initialization of record header to reduce memory usa…

2020-08-30 Thread GitBox
chia7712 commented on pull request #9223: URL: https://github.com/apache/kafka/pull/9223#issuecomment-683425417 > Any thoughts on test for this? The JMH is attached. This is an automated message from the Apache Git Ser

[GitHub] [kafka] aakashgupta96 commented on pull request #5068: KAFKA-6886 Externalize secrets from Connect configs

2020-08-30 Thread GitBox
aakashgupta96 commented on pull request #5068: URL: https://github.com/apache/kafka/pull/5068#issuecomment-683433765 Hi @rayokota Was this feature merged? I was also planning to submit a KIP around same then I saw your proposal. Can you please update whether it is merged or are you

[GitHub] [kafka] chia7712 commented on pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

2020-08-30 Thread GitBox
chia7712 commented on pull request #8657: URL: https://github.com/apache/kafka/pull/8657#issuecomment-683434648 > Could you do some perf tests so that we know the performance of fetch requests doesn't change noticeably? the result of ```Benchmark.test_producer_and_consumer``` is atta

[jira] [Updated] (KAFKA-10446) add "lz4" and "zstd" to compression type of benchmark_test.py

2020-08-30 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-10446: --- Labels: benchmark benchmarks (was: ) > add "lz4" and "zstd" to compression type of benchmar

[jira] [Created] (KAFKA-10446) add "lz4" and "zstd" to compression type of benchmark_test.py

2020-08-30 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-10446: -- Summary: add "lz4" and "zstd" to compression type of benchmark_test.py Key: KAFKA-10446 URL: https://issues.apache.org/jira/browse/KAFKA-10446 Project: Kafka

[GitHub] [kafka] chia7712 opened a new pull request #9230: KAFKA-10446 add lz4 and zstd to compression type of benchmark_test.py

2020-08-30 Thread GitBox
chia7712 opened a new pull request #9230: URL: https://github.com/apache/kafka/pull/9230 issue: https://issues.apache.org/jira/browse/KAFKA-10446 Both "lz4" and "zstd" are popular and important compressions supported by kafka. They are worth being benchmark. ### Committer Chec

[GitHub] [kafka] rayokota commented on pull request #5068: KAFKA-6886 Externalize secrets from Connect configs

2020-08-30 Thread GitBox
rayokota commented on pull request #5068: URL: https://github.com/apache/kafka/pull/5068#issuecomment-683443295 @aakashgupta96 yes it was merged This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [kafka] omkreddy commented on pull request #9062: KAFKA-8098: fix the flaky test by disabling the auto commit to avoid member rejoining

2020-08-30 Thread GitBox
omkreddy commented on pull request #9062: URL: https://github.com/apache/kafka/pull/9062#issuecomment-683453793 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] junrao commented on a change in pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

2020-08-30 Thread GitBox
junrao commented on a change in pull request #8657: URL: https://github.com/apache/kafka/pull/8657#discussion_r479802860 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -85,6 +92,9 @@ object LogAppendInfo { * @param validBytes The number of valid bytes * @param

[jira] [Commented] (KAFKA-10417) suppress() with cogroup() throws ClassCastException

2020-08-30 Thread Rens Groothuijsen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187322#comment-17187322 ] Rens Groothuijsen commented on KAFKA-10417: --- A cogrouped stream creates a KTab

[jira] [Updated] (KAFKA-10447) Migrate tools module to JUnit 5

2020-08-30 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-10447: Summary: Migrate tools module to JUnit 5 (was: Migrate tools module from JUnit 4 to JUnit 5) > M

[jira] [Created] (KAFKA-10447) Migrate tools module from JUnit 4 to JUnit 5

2020-08-30 Thread Ismael Juma (Jira)
Ismael Juma created KAFKA-10447: --- Summary: Migrate tools module from JUnit 4 to JUnit 5 Key: KAFKA-10447 URL: https://issues.apache.org/jira/browse/KAFKA-10447 Project: Kafka Issue Type: Sub-ta

[GitHub] [kafka] ijuma opened a new pull request #9231: KAFKA-10447: Migrate tools module to JUnit 5

2020-08-30 Thread GitBox
ijuma opened a new pull request #9231: URL: https://github.com/apache/kafka/pull/9231 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade n

[GitHub] [kafka] ijuma commented on a change in pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

2020-08-30 Thread GitBox
ijuma commented on a change in pull request #8657: URL: https://github.com/apache/kafka/pull/8657#discussion_r479829275 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -68,6 +68,13 @@ object LogAppendInfo { offsetsMonotonic = false, -1L, recordErrors, errorMe

[GitHub] [kafka] soarez commented on a change in pull request #9000: KAFKA-10036 Improve handling and documentation of Suppliers

2020-08-30 Thread GitBox
soarez commented on a change in pull request #9000: URL: https://github.com/apache/kafka/pull/9000#discussion_r479832011 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamUtil.java ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] soarez commented on pull request #9000: KAFKA-10036 Improve handling and documentation of Suppliers

2020-08-30 Thread GitBox
soarez commented on pull request #9000: URL: https://github.com/apache/kafka/pull/9000#issuecomment-683488002 Squashed and rebased as there were conflicts. Please take another look @mjsax . This is an automated message from

[jira] [Created] (KAFKA-10448) Preserve Source Partition in Kafka Streams from context

2020-08-30 Thread satya (Jira)
satya created KAFKA-10448: - Summary: Preserve Source Partition in Kafka Streams from context Key: KAFKA-10448 URL: https://issues.apache.org/jira/browse/KAFKA-10448 Project: Kafka Issue Type: Improve

[jira] [Created] (KAFKA-10449) Connect-distributed sample configuration file does not have instructions for listeners

2020-08-30 Thread tinawenqiao (Jira)
tinawenqiao created KAFKA-10449: --- Summary: Connect-distributed sample configuration file does not have instructions for listeners Key: KAFKA-10449 URL: https://issues.apache.org/jira/browse/KAFKA-10449

[jira] [Updated] (KAFKA-10448) Preserve Source Partition in Kafka Streams from context

2020-08-30 Thread satya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] satya updated KAFKA-10448: -- Description: Currently Kafka streams Sink Nodes use default partitioner or has the provision of using a custom

[GitHub] [kafka] LMnet commented on a change in pull request #8955: KAFKA-10020: Create a new version of a scala Serdes without name clash (KIP-616)

2020-08-30 Thread GitBox
LMnet commented on a change in pull request #8955: URL: https://github.com/apache/kafka/pull/8955#discussion_r479877121 ## File path: streams/streams-scala/src/main/scala/org/apache/kafka/streams/scala/serialization/Serdes.scala ## @@ -0,0 +1,93 @@ +/* + * Copyright (C) 2018 L

[jira] [Commented] (KAFKA-10134) High CPU issue during rebalance in Kafka consumer after upgrading to 2.5

2020-08-30 Thread Jerry Wei (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187480#comment-17187480 ] Jerry Wei commented on KAFKA-10134: --- [~guozhang] I've tested against PR #8834, it work