junrao commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r479802860
##########
File path: core/src/main/scala/kafka/log/Log.scala
##########
@@ -85,6 +92,9 @@ object LogAppendInfo {
* @param validBytes The number of valid bytes
* @param offsetsMonotonic Are the offsets in this message set monotonically
increasing
* @param lastOffsetOfFirstBatch The last offset of the first batch
+ * @param leaderHWChange Incremental if the high watermark need to be
increased after appending record.
Review comment:
need => needs
##########
File path: core/src/main/scala/kafka/log/Log.scala
##########
@@ -68,6 +68,13 @@ object LogAppendInfo {
offsetsMonotonic = false, -1L, recordErrors, errorMessage)
}
+sealed trait LeaderHWChange
+object LeaderHWChange {
+ case object Incremental extends LeaderHWChange
Review comment:
Probably Increased is clearer than Incremental.
##########
File path: core/src/main/scala/kafka/log/Log.scala
##########
@@ -85,6 +92,9 @@ object LogAppendInfo {
* @param validBytes The number of valid bytes
* @param offsetsMonotonic Are the offsets in this message set monotonically
increasing
* @param lastOffsetOfFirstBatch The last offset of the first batch
+ * @param leaderHWChange Incremental if the high watermark need to be
increased after appending record.
+ * Same if high watermark is not changed. None is the
default value and it means append is failed
Review comment:
is failed => failed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
