[GitHub] [kafka] showuon commented on a change in pull request #9121: KAFKA-10351: add tests for IOExceptions for GlobalStateManagerImpl/OffsetCheckpoint

showuon commented on a change in pull request #9121: URL: https://github.com/apache/kafka/pull/9121#discussion_r475393747 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImplTest.java ## @@ -180,6 +183,27 @@ public void should

[GitHub] [kafka] showuon commented on a change in pull request #9121: KAFKA-10351: add tests for IOExceptions for GlobalStateManagerImpl/OffsetCheckpoint

showuon commented on a change in pull request #9121: URL: https://github.com/apache/kafka/pull/9121#discussion_r475393747 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImplTest.java ## @@ -180,6 +183,27 @@ public void should

[GitHub] [kafka] showuon commented on pull request #9121: KAFKA-10351: add tests for IOExceptions for GlobalStateManagerImpl/OffsetCheckpoint

showuon commented on pull request #9121: URL: https://github.com/apache/kafka/pull/9121#issuecomment-678959902 @mjsax , I've updated in this commit: https://github.com/apache/kafka/pull/9121/commits/b248ccc4f35ce6bb7ef865c65392710c1558ca20. Thanks. ---

[GitHub] [kafka] showuon edited a comment on pull request #9121: KAFKA-10351: add tests for IOExceptions for GlobalStateManagerImpl/OffsetCheckpoint

showuon edited a comment on pull request #9121: URL: https://github.com/apache/kafka/pull/9121#issuecomment-678959902 @mjsax , I've updated in this commit: https://github.com/apache/kafka/pull/9121/commits/12d3826a87a5b21033e2f81c6a486353e79d8591. Thanks.

[GitHub] [kafka] showuon commented on a change in pull request #9121: KAFKA-10351: add tests for IOExceptions for GlobalStateManagerImpl/OffsetCheckpoint

showuon commented on a change in pull request #9121: URL: https://github.com/apache/kafka/pull/9121#discussion_r475393747 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImplTest.java ## @@ -180,6 +183,27 @@ public void should

[GitHub] [kafka] showuon commented on a change in pull request #9121: KAFKA-10351: add tests for IOExceptions for GlobalStateManagerImpl/OffsetCheckpoint

showuon commented on a change in pull request #9121: URL: https://github.com/apache/kafka/pull/9121#discussion_r475393747 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImplTest.java ## @@ -180,6 +183,27 @@ public void should

[jira] [Commented] (KAFKA-10425) Documentation switches to a random page on clicking the left navigation bar hide/expand button

[ https://issues.apache.org/jira/browse/KAFKA-10425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17183034#comment-17183034 ] Luke Chen commented on KAFKA-10425: --- I'm having the same issue, too.   > Documentati

[jira] [Updated] (KAFKA-10402) Upgrade python version in system tests

[ https://issues.apache.org/jira/browse/KAFKA-10402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nikolay Izhikov updated KAFKA-10402: Attachment: report.txt > Upgrade python version in system tests >

[jira] [Commented] (KAFKA-10402) Upgrade python version in system tests

[ https://issues.apache.org/jira/browse/KAFKA-10402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17183036#comment-17183036 ] Nikolay Izhikov commented on KAFKA-10402: - Tests results: {noformat} ==

[jira] [Comment Edited] (KAFKA-10402) Upgrade python version in system tests

[ https://issues.apache.org/jira/browse/KAFKA-10402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17183036#comment-17183036 ] Nikolay Izhikov edited comment on KAFKA-10402 at 8/24/20, 8:05 AM: ---

[jira] [Commented] (KAFKA-10402) Upgrade python version in system tests

[ https://issues.apache.org/jira/browse/KAFKA-10402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17183038#comment-17183038 ] Nikolay Izhikov commented on KAFKA-10402: - Fails: {noformat} ---

[jira] [Created] (KAFKA-10426) Deadlock in KafkaConfigBackingStore

Goltseva Taisiia created KAFKA-10426: Summary: Deadlock in KafkaConfigBackingStore Key: KAFKA-10426 URL: https://issues.apache.org/jira/browse/KAFKA-10426 Project: Kafka Issue Type: Bug

[jira] [Commented] (KAFKA-10362) When resuming Streams active task with EOS, the checkpoint file should be deleted

[ https://issues.apache.org/jira/browse/KAFKA-10362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17183075#comment-17183075 ] highluck commented on KAFKA-10362: -- [~ipasynkov] Are you working on it? If not, can I

[jira] [Commented] (KAFKA-10362) When resuming Streams active task with EOS, the checkpoint file should be deleted

[ https://issues.apache.org/jira/browse/KAFKA-10362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17183104#comment-17183104 ] Ilia Pasynkov commented on KAFKA-10362: --- [~high.lee] Hello, yes I'm working on thi

[jira] [Resolved] (KAFKA-10414) Upgrade api-util dependency - CVE-2018-1337

[ https://issues.apache.org/jira/browse/KAFKA-10414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Urban resolved KAFKA-10414. -- Resolution: Not A Problem api-util is only a test dependency, not an issue. > Upgrade api-uti

[jira] [Commented] (KAFKA-10133) Cannot compress messages in destination cluster with MM2

[ https://issues.apache.org/jira/browse/KAFKA-10133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17183300#comment-17183300 ] Steve Jacobs commented on KAFKA-10133: -- That is how I was confirming compression as

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r475627290 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -141,7 +142,8 @@ object Partition extends KafkaMetricsGroup { stateStore = zkIsr

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r475629593 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -635,7 +666,7 @@ class Partition(val topicPartition: TopicPartition, // chec

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r475630695 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -806,8 +840,9 @@ class Partition(val topicPartition: TopicPartition, // avoid un

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r475625111 ## File path: clients/src/main/java/org/apache/kafka/common/protocol/Errors.java ## @@ -325,7 +326,8 @@ UNSTABLE_OFFSET_COMMIT(88, "There are unstable o

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r475632719 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -1257,4 +1364,4 @@ class Partition(val topicPartition: TopicPartition, } part

[GitHub] [kafka] xakassi opened a new pull request #9211: KAFKA-10426: Deadlock on session key update.

xakassi opened a new pull request #9211: URL: https://github.com/apache/kafka/pull/9211 DistributedHerder goes to updateConfigsWithIncrementalCooperative() synchronized method and called configBackingStore.snapshot() which take a lock on internal object in KafkaConfigBackingStore class.

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r475626573 ## File path: config/log4j.properties ## @@ -61,8 +61,8 @@ log4j.appender.authorizerAppender.layout.ConversionPattern=[%d] %p %m (%c)%n log4j.logger.org.ap

[jira] [Commented] (KAFKA-8733) Offline partitions occur when leader's disk is slow in reads while responding to follower fetch requests.

[ https://issues.apache.org/jira/browse/KAFKA-8733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17183304#comment-17183304 ] Flavien Raynaud commented on KAFKA-8733: Has there been any update regarding this

[jira] [Assigned] (KAFKA-10426) Deadlock in KafkaConfigBackingStore

[ https://issues.apache.org/jira/browse/KAFKA-10426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Goltseva Taisiia reassigned KAFKA-10426: Assignee: Goltseva Taisiia > Deadlock in KafkaConfigBackingStore > --

[jira] [Commented] (KAFKA-7740) Kafka Admin Client should be able to manage user/client configurations for users and clients

[ https://issues.apache.org/jira/browse/KAFKA-7740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17183338#comment-17183338 ] Brian Byrne commented on KAFKA-7740: Hello - resolve is still planned for a future re

[GitHub] [kafka] cmccabe commented on pull request #9194: KAFKA-10384: Separate converters from generated messages

cmccabe commented on pull request #9194: URL: https://github.com/apache/kafka/pull/9194#issuecomment-679187796 > Ok, just to make sure I understand [...] Now for a given schema, we will generate SomeMessageData as well as SomeMessageJsonConverter Right, you got it.

[GitHub] [kafka] cmccabe commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

cmccabe commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r475695750 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/DescribeUserScramCredentialsResult.java ## @@ -0,0 +1,139 @@ +/* + * Licensed to the Apa

[GitHub] [kafka] cmccabe commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

cmccabe commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r475696554 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/DescribeUserScramCredentialsResult.java ## @@ -0,0 +1,139 @@ +/* + * Licensed to the Apa

[GitHub] [kafka] cmccabe commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

cmccabe commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r475698813 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/DescribeUserScramCredentialsResult.java ## @@ -0,0 +1,139 @@ +/* + * Licensed to the Apa

[GitHub] [kafka] cmccabe commented on pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

cmccabe commented on pull request #9032: URL: https://github.com/apache/kafka/pull/9032#issuecomment-679199653 @rajinisivaram : I'd like to understand your suggestion to forbid authenticating via delegation token here. It doesn't seem consistent with how we handle delegation tokens in gen

[GitHub] [kafka] cmccabe commented on a change in pull request #9103: Add redirection for (Incremental)AlterConfig, AlterClientQuota and CreateTopics

cmccabe commented on a change in pull request #9103: URL: https://github.com/apache/kafka/pull/9103#discussion_r475710400 ## File path: clients/src/main/java/org/apache/kafka/common/errors/BrokerAuthorizationFailureException.java ## @@ -0,0 +1,27 @@ +/* + * Licensed to the Apa

[GitHub] [kafka] cmccabe commented on a change in pull request #9103: Add redirection for (Incremental)AlterConfig, AlterClientQuota and CreateTopics

cmccabe commented on a change in pull request #9103: URL: https://github.com/apache/kafka/pull/9103#discussion_r475712573 ## File path: clients/src/main/java/org/apache/kafka/common/protocol/Errors.java ## @@ -325,7 +326,9 @@ UNSTABLE_OFFSET_COMMIT(88, "There are unstable

[GitHub] [kafka] cmccabe commented on a change in pull request #9103: Add redirection for (Incremental)AlterConfig, AlterClientQuota and CreateTopics

cmccabe commented on a change in pull request #9103: URL: https://github.com/apache/kafka/pull/9103#discussion_r475714230 ## File path: clients/src/main/java/org/apache/kafka/common/requests/AlterConfigsRequest.java ## @@ -87,6 +87,16 @@ public Builder(Map configs, boolean va

[jira] [Commented] (KAFKA-10133) Cannot compress messages in destination cluster with MM2

[ https://issues.apache.org/jira/browse/KAFKA-10133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17183401#comment-17183401 ] Ning Zhang commented on KAFKA-10133: Great. Then I will probably make a pr to clarif

[GitHub] [kafka] cmccabe commented on a change in pull request #9103: Add redirection for (Incremental)AlterConfig, AlterClientQuota and CreateTopics

cmccabe commented on a change in pull request #9103: URL: https://github.com/apache/kafka/pull/9103#discussion_r475725389 ## File path: core/src/main/scala/kafka/server/KafkaServer.scala ## @@ -316,7 +316,10 @@ class KafkaServer(val config: KafkaConfig, time: Time = Time.SYSTE

[jira] [Updated] (KAFKA-10426) Deadlock in KafkaConfigBackingStore

[ https://issues.apache.org/jira/browse/KAFKA-10426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Goltseva Taisiia updated KAFKA-10426: - Reviewer: Konstantine Karantasis (was: Chris Egerton) > Deadlock in KafkaConfigBackingS

[jira] [Updated] (KAFKA-10426) Deadlock in KafkaConfigBackingStore

[ https://issues.apache.org/jira/browse/KAFKA-10426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Goltseva Taisiia updated KAFKA-10426: - Reviewer: Chris Egerton (was: Konstantine Karantasis) > Deadlock in KafkaConfigBackingS

[GitHub] [kafka] chia7712 opened a new pull request #9212: MINOR: don't keep reference of receive buffer when the value of head …

chia7712 opened a new pull request #9212: URL: https://github.com/apache/kafka/pull/9212 Users, who try to avoid null variable, can replace null by empty array to build header to be a kind of "flag". The ```RecordHeader#value()``` may be never called (as users only want to check existence

[GitHub] [kafka] rondagostino commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

rondagostino commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r475750058 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/DescribeUserScramCredentialsResult.java ## @@ -0,0 +1,139 @@ +/* + * Licensed to th

[GitHub] [kafka] lbradstreet opened a new pull request #9213: MINOR: add epoch lineage checks to system tests

lbradstreet opened a new pull request #9213: URL: https://github.com/apache/kafka/pull/9213 This adds assertions to check that leader epoch lineages match between replicas. These have been added to system tests that involve broker restarts and that wait for replicas to rejoin the ISR b

[jira] [Commented] (KAFKA-10133) Cannot compress messages in destination cluster with MM2

[ https://issues.apache.org/jira/browse/KAFKA-10133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17183445#comment-17183445 ] Steve Jacobs commented on KAFKA-10133: -- That would be incredibly helpful. Just an e

[GitHub] [kafka] rondagostino commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

rondagostino commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r475756645 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/DescribeUserScramCredentialsResult.java ## @@ -0,0 +1,139 @@ +/* + * Licensed to th

[jira] [Assigned] (KAFKA-10133) Cannot compress messages in destination cluster with MM2

[ https://issues.apache.org/jira/browse/KAFKA-10133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ning Zhang reassigned KAFKA-10133: -- Assignee: Ning Zhang > Cannot compress messages in destination cluster with MM2 > ---

[jira] [Reopened] (KAFKA-10133) Cannot compress messages in destination cluster with MM2

[ https://issues.apache.org/jira/browse/KAFKA-10133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ning Zhang reopened KAFKA-10133: There is no bug in the code, but need some efforts on doc to clarify on where some frequently used co

[GitHub] [kafka] rajinisivaram commented on pull request #9200: MINOR: mirror integration tests should not call System.exit

rajinisivaram commented on pull request #9200: URL: https://github.com/apache/kafka/pull/9200#issuecomment-679249066 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [kafka] junrao commented on pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

junrao commented on pull request #8657: URL: https://github.com/apache/kafka/pull/8657#issuecomment-679256967 @chia7712 : Sorry for the late response. I just realized there seems to be another issue in addition to the above one that I mentioned. The second issue is that we hold a group loc

[GitHub] [kafka] rondagostino commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

rondagostino commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r475771230 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/DescribeUserScramCredentialsResult.java ## @@ -0,0 +1,139 @@ +/* + * Licensed to th

[GitHub] [kafka] rondagostino commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

rondagostino commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r475771230 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/DescribeUserScramCredentialsResult.java ## @@ -0,0 +1,139 @@ +/* + * Licensed to th

[GitHub] [kafka] bbejeck commented on pull request #9099: KAFKA-6733: Printing additional ConsumerRecord fields in DefaultMessageFormatter

bbejeck commented on pull request #9099: URL: https://github.com/apache/kafka/pull/9099#issuecomment-679258872 > I should just delete the test for DefaultMessageFormatter in ConsoleConsumerTest.scala. @badaiaqrandista I'm not sure. My vote would be to keep the test but move i

[jira] [Created] (KAFKA-10427) Implement FetchSnapshot RPC

Jose Armando Garcia Sancio created KAFKA-10427: -- Summary: Implement FetchSnapshot RPC Key: KAFKA-10427 URL: https://issues.apache.org/jira/browse/KAFKA-10427 Project: Kafka Issue

[jira] [Updated] (KAFKA-10417) suppress() with cogroup() throws ClassCastException

[ https://issues.apache.org/jira/browse/KAFKA-10417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-10417: - Fix Version/s: 3.0.0 2.8.0 > suppress() with cogroup() throws ClassCastExcept

[jira] [Updated] (KAFKA-10409) Refactor Kafka Streams RocksDb iterators

[ https://issues.apache.org/jira/browse/KAFKA-10409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-10409: - Labels: newbie (was: ) > Refactor Kafka Streams RocksDb iterators > --

[GitHub] [kafka] ableegoldman commented on a change in pull request #9186: KAFKA-10277: Allow null keys with non-null mappedKey in KStreamKGlobalTable join

ableegoldman commented on a change in pull request #9186: URL: https://github.com/apache/kafka/pull/9186#discussion_r475791126 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKTableJoinProcessor.java ## @@ -58,29 +60,46 @@ public void init

[GitHub] [kafka] ableegoldman commented on a change in pull request #9186: KAFKA-10277: Allow null keys with non-null mappedKey in KStreamKGlobalTable join

ableegoldman commented on a change in pull request #9186: URL: https://github.com/apache/kafka/pull/9186#discussion_r475792745 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKTableJoinProcessor.java ## @@ -58,29 +60,46 @@ public void init

[GitHub] [kafka] guozhangwang commented on a change in pull request #9156: KAFKA-10077: Filter downstream of state-store results in spurious tombstones

guozhangwang commented on a change in pull request #9156: URL: https://github.com/apache/kafka/pull/9156#discussion_r475792671 ## File path: streams/src/test/java/org/apache/kafka/streams/StreamsBuilderTest.java ## @@ -123,7 +123,7 @@ public void shouldAllowJoinMaterializedFil

[jira] [Commented] (KAFKA-7740) Kafka Admin Client should be able to manage user/client configurations for users and clients

[ https://issues.apache.org/jira/browse/KAFKA-7740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17183512#comment-17183512 ] Travis Bischel commented on KAFKA-7740: --- Oh cool, that's great. I thought that aspe

[GitHub] [kafka] ableegoldman commented on a change in pull request #9186: KAFKA-10277: Allow null keys with non-null mappedKey in KStreamKGlobalTable join

ableegoldman commented on a change in pull request #9186: URL: https://github.com/apache/kafka/pull/9186#discussion_r475800482 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKTableJoinProcessor.java ## @@ -58,29 +60,46 @@ public void init

[GitHub] [kafka] hachikuji merged pull request #9112: KAFKA-10312 Fix error code returned by getPartitionMetadata

hachikuji merged pull request #9112: URL: https://github.com/apache/kafka/pull/9112 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] vvcephei opened a new pull request #9214: [DO NOT MERGE] POC: unify all jvm cache pools

vvcephei opened a new pull request #9214: URL: https://github.com/apache/kafka/pull/9214 Currently, users of Suppress in strict mode must either not configure a memory bound or consider a per-operator, per-partition bound. The former would result in the application crashing ungracefully if

[GitHub] [kafka] mjsax commented on pull request #9174: KAFKA-10395: relax output topic check in TTD to work with dynamic routing

mjsax commented on pull request #9174: URL: https://github.com/apache/kafka/pull/9174#issuecomment-679347362 Might it be worth to cherry-pick to `2.6` ? This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] ableegoldman commented on pull request #9174: KAFKA-10395: relax output topic check in TTD to work with dynamic routing

ableegoldman commented on pull request #9174: URL: https://github.com/apache/kafka/pull/9174#issuecomment-679373369 @mjsax Be my guest 🙂 This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [kafka] ning2008wisc opened a new pull request #9215: KAFKA-10133: MM2 readme update on config

ning2008wisc opened a new pull request #9215: URL: https://github.com/apache/kafka/pull/9215 Per https://issues.apache.org/jira/browse/KAFKA-10133, MM2 users sometimes confuse on specifying or overriding the default configurations at different levels: connector, MM2, producer/consumers. It

[jira] [Updated] (KAFKA-10133) Cannot compress messages in destination cluster with MM2

[ https://issues.apache.org/jira/browse/KAFKA-10133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ning Zhang updated KAFKA-10133: --- Fix Version/s: 2.7.0 > Cannot compress messages in destination cluster with MM2 > --

[GitHub] [kafka] ableegoldman commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

ableegoldman commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r475919413 ## File path: streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregateTest.java ## @@ -0,0 +1,690 @@ +/* + * Lic

[GitHub] [kafka] ableegoldman commented on pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

ableegoldman commented on pull request #9039: URL: https://github.com/apache/kafka/pull/9039#issuecomment-679394512 test this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] badaiaqrandista commented on pull request #9099: KAFKA-6733: Printing additional ConsumerRecord fields in DefaultMessageFormatter

badaiaqrandista commented on pull request #9099: URL: https://github.com/apache/kafka/pull/9099#issuecomment-679398619 @bbejeck It failed because it print the partition number as a single integer after the value. I moved the partition to be before the key (if printed) and value, an

[GitHub] [kafka] ableegoldman commented on pull request #9094: KAFKA-10054: KIP-613, add TRACE-level e2e latency metrics

ableegoldman commented on pull request #9094: URL: https://github.com/apache/kafka/pull/9094#issuecomment-679399444 @guozhangwang can we finally merge this? 🙂 This is an automated message from the Apache Git Service. To resp

[jira] [Commented] (KAFKA-10357) Handle accidental deletion of repartition-topics as exceptional failure

[ https://issues.apache.org/jira/browse/KAFKA-10357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17183626#comment-17183626 ] Guozhang Wang commented on KAFKA-10357: --- Theoretically, I think today there's no p

[jira] [Commented] (KAFKA-10357) Handle accidental deletion of repartition-topics as exceptional failure

[ https://issues.apache.org/jira/browse/KAFKA-10357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17183630#comment-17183630 ] Sophie Blee-Goldman commented on KAFKA-10357: - Cool. I agree, KAFKA-3370 wou

[GitHub] [kafka] guozhangwang commented on pull request #9094: KAFKA-10054: KIP-613, add TRACE-level e2e latency metrics

guozhangwang commented on pull request #9094: URL: https://github.com/apache/kafka/pull/9094#issuecomment-679408267 LGTM. This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[jira] [Created] (KAFKA-10428) Mirror Maker connect applies base64 encoding to string headers

Jennifer Thompson created KAFKA-10428: - Summary: Mirror Maker connect applies base64 encoding to string headers Key: KAFKA-10428 URL: https://issues.apache.org/jira/browse/KAFKA-10428 Project: Kaf

[GitHub] [kafka] guozhangwang commented on pull request #8834: MINOR: Do not disable heartbeat during Rebalance

guozhangwang commented on pull request #8834: URL: https://github.com/apache/kafka/pull/8834#issuecomment-679419336 @ableegoldman I'm re-targeting this against https://issues.apache.org/jira/browse/KAFKA-10134 now as I found the root cause of that ticket is actually because we do not send

[GitHub] [kafka] ning2008wisc commented on pull request #9215: KAFKA-10133: MM2 readme update on config

ning2008wisc commented on pull request #9215: URL: https://github.com/apache/kafka/pull/9215#issuecomment-679420821 Hi @ryannedolan @mimaison just in case I could borrow few minutes from you to take a quick review. Thanks T

[GitHub] [kafka] jthompson6 opened a new pull request #9216: KAFKA-10428: Fix schema for header conversion in MirrorSourceTask.

jthompson6 opened a new pull request #9216: URL: https://github.com/apache/kafka/pull/9216 The addBytes method adds the header using Schema.BYTES, which results in base64 encoding when the record is stored. SimpleHeaderConverter#toConnectHeader implements schema inference which we can us

[GitHub] [kafka] ableegoldman commented on a change in pull request #9157: Update for KIP-450 to handle early records

ableegoldman commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r475985073 ## File path: streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregateTest.java ## @@ -328,6 +328,68 @@ public v

[GitHub] [kafka] jeqo commented on a change in pull request #9138: KAFKA-9929: Support backward iterator on WindowStore

jeqo commented on a change in pull request #9138: URL: https://github.com/apache/kafka/pull/9138#discussion_r475910689 ## File path: streams/src/main/java/org/apache/kafka/streams/state/WindowStore.java ## @@ -119,15 +118,16 @@ * * This iterator must be closed afte

[GitHub] [kafka] ableegoldman commented on a change in pull request #9138: KAFKA-9929: Support backward iterator on WindowStore

ableegoldman commented on a change in pull request #9138: URL: https://github.com/apache/kafka/pull/9138#discussion_r475999351 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/InMemoryWindowStore.java ## @@ -419,13 +504,13 @@ Long minTime() {

[GitHub] [kafka] ableegoldman commented on a change in pull request #9138: KAFKA-9929: Support backward iterator on WindowStore

ableegoldman commented on a change in pull request #9138: URL: https://github.com/apache/kafka/pull/9138#discussion_r476001166 ## File path: streams/src/main/java/org/apache/kafka/streams/state/WindowStore.java ## @@ -119,15 +118,16 @@ * * This iterator must be clo

[GitHub] [kafka] ableegoldman commented on a change in pull request #9138: KAFKA-9929: Support backward iterator on WindowStore

ableegoldman commented on a change in pull request #9138: URL: https://github.com/apache/kafka/pull/9138#discussion_r476003479 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/InMemoryWindowStore.java ## @@ -163,7 +164,17 @@ public void put(final By

[GitHub] [kafka] guozhangwang merged pull request #9094: KAFKA-10054: KIP-613, add TRACE-level e2e latency metrics

guozhangwang merged pull request #9094: URL: https://github.com/apache/kafka/pull/9094 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (KAFKA-10134) High CPU issue during rebalance in Kafka consumer after upgrading to 2.5

[ https://issues.apache.org/jira/browse/KAFKA-10134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17183654#comment-17183654 ] Guozhang Wang commented on KAFKA-10134: --- [~zhowei] Thanks for the new log files, i

[GitHub] [kafka] huxihx commented on pull request #8984: KAFKA-10227: Enforce cleanup policy to only contain compact or delete once

huxihx commented on pull request #8984: URL: https://github.com/apache/kafka/pull/8984#issuecomment-679438909 @abbccdda Hi, do you have any time to review this patch? It's been quite a long time since no one had a look at it :( -

[GitHub] [kafka] mjsax commented on a change in pull request #9217: MINOR: fix JavaDoc

mjsax commented on a change in pull request #9217: URL: https://github.com/apache/kafka/pull/9217#discussion_r476025687 ## File path: streams/src/main/java/org/apache/kafka/streams/errors/StreamsNotStartedException.java ## @@ -17,11 +17,12 @@ package org.apache.kafka.streams.

[GitHub] [kafka] mjsax opened a new pull request #9217: MINOR: fix JavaDoc

mjsax opened a new pull request #9217: URL: https://github.com/apache/kafka/pull/9217 Call for review @vvcephei This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] mjsax commented on a change in pull request #9217: MINOR: fix JavaDoc

mjsax commented on a change in pull request #9217: URL: https://github.com/apache/kafka/pull/9217#discussion_r476026230 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/api/ProcessorContext.java ## @@ -106,7 +105,7 @@ void register(final StateStore store,

[GitHub] [kafka] guozhangwang commented on pull request #9038: KAFKA-10134: Check heartbeat timeout for poll fetches [DO NOT MERGE]

guozhangwang commented on pull request #9038: URL: https://github.com/apache/kafka/pull/9038#issuecomment-679463606 Closing as it will be subsumed by https://github.com/apache/kafka/pull/8834 This is an automated message from

[GitHub] [kafka] guozhangwang closed pull request #9038: KAFKA-10134: Check heartbeat timeout for poll fetches [DO NOT MERGE]

guozhangwang closed pull request #9038: URL: https://github.com/apache/kafka/pull/9038 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] huxihx opened a new pull request #9218: MINOR: Fix shouldNotResetEpochHistoryHeadIfUndefinedPassed

huxihx opened a new pull request #9218: URL: https://github.com/apache/kafka/pull/9218 In LeaderEpochFileCacheTest.scala, code is identical for `shouldNotResetEpochHistoryHeadIfUndefinedPassed` and `shouldNotResetEpochHistoryTailIfUndefinedPassed`. Seems `truncateFromStart` should be invo

[GitHub] [kafka] LMnet commented on a change in pull request #8955: KAFKA-10020: Create a new version of a scala Serdes without name clash (KIP-616)

LMnet commented on a change in pull request #8955: URL: https://github.com/apache/kafka/pull/8955#discussion_r476102121 ## File path: streams/streams-scala/src/main/scala/org/apache/kafka/streams/scala/Serdes.scala ## @@ -24,6 +24,7 @@ import java.util import org.apache.kafka

[GitHub] [kafka] LMnet commented on pull request #8955: KAFKA-10020: Create a new version of a scala Serdes without name clash (KIP-616)

LMnet commented on pull request #8955: URL: https://github.com/apache/kafka/pull/8955#issuecomment-679502482 @vvcephei I completely forgot about tests, thanks for reminding me! I changed all usages of the old `org.apache.kafka.streams.scala.Serdes` to the new `org.apache.kafka.streams.scal

[jira] [Assigned] (KAFKA-10424) MirrorMaker 2.0 does not replicates topic's "clean.policy"

[ https://issues.apache.org/jira/browse/KAFKA-10424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ning Zhang reassigned KAFKA-10424: -- Assignee: Ning Zhang > MirrorMaker 2.0 does not replicates topic's "clean.policy" > -

[jira] [Created] (KAFKA-10429) Group Coordinator is unavailable leads to missing events

Navinder Brar created KAFKA-10429: - Summary: Group Coordinator is unavailable leads to missing events Key: KAFKA-10429 URL: https://issues.apache.org/jira/browse/KAFKA-10429 Project: Kafka Is

[GitHub] [kafka] ryannedolan commented on a change in pull request #9215: KAFKA-10133: MM2 readme update on config

ryannedolan commented on a change in pull request #9215: URL: https://github.com/apache/kafka/pull/9215#discussion_r476170655 ## File path: connect/mirror/README.md ## @@ -141,7 +141,38 @@ nearby clusters. N.B. that the `--clusters` parameter is not technically required here.

[jira] [Updated] (KAFKA-10429) Group Coordinator unavailability leads to missing events

[ https://issues.apache.org/jira/browse/KAFKA-10429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Navinder Brar updated KAFKA-10429: -- Summary: Group Coordinator unavailability leads to missing events (was: Group Coordinator is

[GitHub] [kafka] chia7712 commented on pull request #9162: MINOR: refactor Log to get rid of "return" in nested anonymous function

chia7712 commented on pull request #9162: URL: https://github.com/apache/kafka/pull/9162#issuecomment-679805254 retest this please This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [kafka] chia7712 commented on pull request #9182: KAFKA-10403 Replace scala collection by java collection in generating…

chia7712 commented on pull request #9182: URL: https://github.com/apache/kafka/pull/9182#issuecomment-679805021 retest this please This is an automated message from the Apache Git Service. To respond to the message, please lo

[jira] [Commented] (KAFKA-10426) Deadlock in KafkaConfigBackingStore

[ https://issues.apache.org/jira/browse/KAFKA-10426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17183758#comment-17183758 ] Goltseva Taisiia commented on KAFKA-10426: -- Hi, [~ChrisEgerton] ! Could you, p

[jira] [Comment Edited] (KAFKA-10426) Deadlock in KafkaConfigBackingStore

[ https://issues.apache.org/jira/browse/KAFKA-10426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17183758#comment-17183758 ] Goltseva Taisiia edited comment on KAFKA-10426 at 8/25/20, 6:47 AM: --