LMnet commented on pull request #8955:
URL: https://github.com/apache/kafka/pull/8955#issuecomment-679502482


   @vvcephei I completely forgot about tests, thanks for reminding me! I 
changed all usages of the old `org.apache.kafka.streams.scala.Serdes` to the 
new `org.apache.kafka.streams.scala.serialization.Serdes` in tests. I think it 
should be enough in terms of test coverage.
   
   Also, I fixed `KGroupedStream`, `SessionWindowedKStream`, 
`TimeWindowedKStream`, and docs: they used the old `Serdes` object.
   
   I was not sure about commits policy in Kafka so I added all these changes in 
the separate commit. I can squash it later if needed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to