[jira] [Created] (KAFKA-10424) MirrorMaker 2.0 does not replicates topic's "clean.policy"

2020-08-21 Thread Mikhail Grinfeld (Jira)
Mikhail Grinfeld created KAFKA-10424: Summary: MirrorMaker 2.0 does not replicates topic's "clean.policy" Key: KAFKA-10424 URL: https://issues.apache.org/jira/browse/KAFKA-10424 Project: Kafka

[jira] [Commented] (KAFKA-10422) Provide a `timesForOffsets` operation in kafka consumer

2020-08-21 Thread Guillaume Bort (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17181691#comment-17181691 ] Guillaume Bort commented on KAFKA-10422: Thanks for you answer. What is the righ

[GitHub] [kafka] tombentley commented on pull request #9136: KAFKA-10211: Add DirectoryConfigProvider

2020-08-21 Thread GitBox
tombentley commented on pull request #9136: URL: https://github.com/apache/kafka/pull/9136#issuecomment-678105023 @mimaison fixed. This is an automated message from the Apache Git Service. To respond to the message, please lo

[jira] [Commented] (KAFKA-10421) Kafka Producer deadlocked on get() call

2020-08-21 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17181723#comment-17181723 ] Ismael Juma commented on KAFKA-10421: - Would you be able to test a newer version, 2.

[jira] [Commented] (KAFKA-10422) Provide a `timesForOffsets` operation in kafka consumer

2020-08-21 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17181726#comment-17181726 ] Mickael Maison commented on KAFKA-10422: You can request the permission to creat

[GitHub] [kafka] mimaison commented on pull request #9136: KAFKA-10211: Add DirectoryConfigProvider

2020-08-21 Thread GitBox
mimaison commented on pull request #9136: URL: https://github.com/apache/kafka/pull/9136#issuecomment-678131966 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] mimaison commented on pull request #9136: KAFKA-10211: Add DirectoryConfigProvider

2020-08-21 Thread GitBox
mimaison commented on pull request #9136: URL: https://github.com/apache/kafka/pull/9136#issuecomment-678132390 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] mimaison commented on pull request #9136: KAFKA-10211: Add DirectoryConfigProvider

2020-08-21 Thread GitBox
mimaison commented on pull request #9136: URL: https://github.com/apache/kafka/pull/9136#issuecomment-678140872 retest this please This is an automated message from the Apache Git Service. To respond to the message, please lo

[jira] [Commented] (KAFKA-10378) issue when create producer using java

2020-08-21 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17181814#comment-17181814 ] Ismael Juma commented on KAFKA-10378: - [~cmccabe] can you please post links to your

[GitHub] [kafka] cadonna commented on pull request #9177: KAFKA-9924: Add RocksDB metric num-entries-active-mem-table

2020-08-21 Thread GitBox
cadonna commented on pull request #9177: URL: https://github.com/apache/kafka/pull/9177#issuecomment-678269275 test this please This is an automated message from the Apache Git Service. To respond to the message, please log o

[jira] [Commented] (KAFKA-9747) No tasks created for a connector

2020-08-21 Thread Yaroslav Derman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17181869#comment-17181869 ] Yaroslav Derman commented on KAFKA-9747: Have the same problem for Debezium (Mysq

[jira] [Comment Edited] (KAFKA-9747) No tasks created for a connector

2020-08-21 Thread Yaroslav Derman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17181869#comment-17181869 ] Yaroslav Derman edited comment on KAFKA-9747 at 8/21/20, 2:02 PM: -

[GitHub] [kafka] mumrah merged pull request #7222: KAFKA-8806 Reduce calls to validateOffsetsIfNeeded

2020-08-21 Thread GitBox
mumrah merged pull request #7222: URL: https://github.com/apache/kafka/pull/7222 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (KAFKA-10370) WorkerSinkTask: IllegalStateException cased by consumer.seek(tp, offsets) when (tp, offsets) are supplied by WorkerSinkTaskContext

2020-08-21 Thread Ning Zhang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17181928#comment-17181928 ] Ning Zhang commented on KAFKA-10370: After looking at HDFS Sink connector https://g

[jira] [Updated] (KAFKA-10020) KIP-616: Rename implicit Serdes instances in kafka-streams-scala

2020-08-21 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bill Bejeck updated KAFKA-10020: Fix Version/s: 2.7.0 > KIP-616: Rename implicit Serdes instances in kafka-streams-scala >

[jira] [Commented] (KAFKA-10421) Kafka Producer deadlocked on get() call

2020-08-21 Thread Ranadeep Deb (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17181973#comment-17181973 ] Ranadeep Deb commented on KAFKA-10421: -- I can definitely test a newer version. But

[GitHub] [kafka] jolshan opened a new pull request #9205: MINOR: Fix typo in example

2020-08-21 Thread GitBox
jolshan opened a new pull request #9205: URL: https://github.com/apache/kafka/pull/9205 The ducker-ak test example includes a file path that does not exist. I fixed to be the correct path. This is an automated message from t

[GitHub] [kafka] ableegoldman commented on pull request #8834: MINOR: Do not disable heartbeat during Rebalance

2020-08-21 Thread GitBox
ableegoldman commented on pull request #8834: URL: https://github.com/apache/kafka/pull/8834#issuecomment-678432871 Hey @guozhangwang , any progress on this? This is an automated message from the Apache Git Service. To respon

[GitHub] [kafka] omkreddy merged pull request #9205: MINOR: Fix typo in example

2020-08-21 Thread GitBox
omkreddy merged pull request #9205: URL: https://github.com/apache/kafka/pull/9205 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] mjsax commented on pull request #9204: KAFKA-6181 Examining log messages with {{--deep-iteration}} should show superset of fields

2020-08-21 Thread GitBox
mjsax commented on pull request #9204: URL: https://github.com/apache/kafka/pull/9204#issuecomment-678445541 Call for review @hachikuji @cmccabe (seem to be an easy one) This is an automated message from the Apache Git Servic

[jira] [Commented] (KAFKA-10186) Aborting transaction with pending data should throw non-fatal exception

2020-08-21 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17182086#comment-17182086 ] Matthias J. Sax commented on KAFKA-10186: - Thanks [~nym3r0s] – working on the co

[GitHub] [kafka] mjsax commented on a change in pull request #9121: KAFKA-10351: add tests for IOExceptions for GlobalStateManagerImpl/OffsetCheckpoint

2020-08-21 Thread GitBox
mjsax commented on a change in pull request #9121: URL: https://github.com/apache/kafka/pull/9121#discussion_r474877105 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImplTest.java ## @@ -180,6 +183,27 @@ public void shouldRe

[GitHub] [kafka] mjsax commented on pull request #9064: KAFKA-10205: Documentation and handling of non deterministic Topologies

2020-08-21 Thread GitBox
mjsax commented on pull request #9064: URL: https://github.com/apache/kafka/pull/9064#issuecomment-678450380 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] mjsax commented on a change in pull request #9000: KAFKA-10036 Improve handling and documentation of Suppliers

2020-08-21 Thread GitBox
mjsax commented on a change in pull request #9000: URL: https://github.com/apache/kafka/pull/9000#discussion_r474886689 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilderTest.java ## @@ -175,6 +177,12 @@ public void testAdd

[GitHub] [kafka] mjsax commented on a change in pull request #9000: KAFKA-10036 Improve handling and documentation of Suppliers

2020-08-21 Thread GitBox
mjsax commented on a change in pull request #9000: URL: https://github.com/apache/kafka/pull/9000#discussion_r474887535 ## File path: streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamImplTest.java ## @@ -1865,6 +1865,17 @@ public void shouldNotAllowNull

[GitHub] [kafka] mjsax commented on pull request #9000: KAFKA-10036 Improve handling and documentation of Suppliers

2020-08-21 Thread GitBox
mjsax commented on pull request #9000: URL: https://github.com/apache/kafka/pull/9000#issuecomment-678452210 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] abbccdda commented on pull request #9161: KAFKA-10385 - Remove no print stat when on detailed stat mode on Consumer Perf

2020-08-21 Thread GitBox
abbccdda commented on pull request #9161: URL: https://github.com/apache/kafka/pull/9161#issuecomment-678454054 @ijuma Do we have any possible dependency on the consumer performance stats? I personally think the change is safe, just want to double check. --

[GitHub] [kafka] abbccdda commented on a change in pull request #9102: KAFKA-10326 Both serializer and deserializer should be able to see th…

2020-08-21 Thread GitBox
abbccdda commented on a change in pull request #9102: URL: https://github.com/apache/kafka/pull/9102#discussion_r474892245 ## File path: clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java ## @@ -2511,4 +2511,39 @@ public void testEnforceRebalanceTr

[GitHub] [kafka] mjsax commented on pull request #9186: KAFKA-10277: Allow null keys with non-null mappedKey in KStreamKGlobalTable join

2020-08-21 Thread GitBox
mjsax commented on pull request #9186: URL: https://github.com/apache/kafka/pull/9186#issuecomment-678455265 Thanks for the PR @JoelWee -- Not exactly sure what NPE test you have in mind, but feel free to add a new test class `src/test/java/org/apache/kafka/streams/kstream/internals/KStrea

[GitHub] [kafka] mjsax commented on pull request #9186: KAFKA-10277: Allow null keys with non-null mappedKey in KStreamKGlobalTable join

2020-08-21 Thread GitBox
mjsax commented on pull request #9186: URL: https://github.com/apache/kafka/pull/9186#issuecomment-678455951 @ableegoldman Can you help to review? This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [kafka] mjsax merged pull request #9028: KAFKA-10035: Safer conversion of consumer timeout parameters

2020-08-21 Thread GitBox
mjsax merged pull request #9028: URL: https://github.com/apache/kafka/pull/9028 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] mjsax commented on pull request #9028: KAFKA-10035: Safer conversion of consumer timeout parameters

2020-08-21 Thread GitBox
mjsax commented on pull request #9028: URL: https://github.com/apache/kafka/pull/9028#issuecomment-678457711 Thanks for the patch @serjchebotarev! Merged to `trunk`. This is an automated message from the Apache Git Service. T

[GitHub] [kafka] vvcephei commented on a change in pull request #8955: KAFKA-10020: Create a new version of a scala Serdes without name clash (KIP-616)

2020-08-21 Thread GitBox
vvcephei commented on a change in pull request #8955: URL: https://github.com/apache/kafka/pull/8955#discussion_r474898311 ## File path: streams/streams-scala/src/main/scala/org/apache/kafka/streams/scala/Serdes.scala ## @@ -24,6 +24,7 @@ import java.util import org.apache.ka

[GitHub] [kafka] mjsax merged pull request #9146: KAFKA-10316 Updated Kafka Streams upgrade-guide.html

2020-08-21 Thread GitBox
mjsax merged pull request #9146: URL: https://github.com/apache/kafka/pull/9146 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] mjsax commented on pull request #9146: KAFKA-10316 Updated Kafka Streams upgrade-guide.html

2020-08-21 Thread GitBox
mjsax commented on pull request #9146: URL: https://github.com/apache/kafka/pull/9146#issuecomment-678459181 Thanks for the PR @johnthotekat! -- Merged to `trunk`. Congrats to completing KIP-648. This is an automated m

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

2020-08-21 Thread GitBox
mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r474930329 ## File path: core/src/main/scala/kafka/server/AlterIsrChannelManager.scala ## @@ -0,0 +1,132 @@ +package kafka.server + +import java.util +import java.util.

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

2020-08-21 Thread GitBox
mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r474934833 ## File path: core/src/main/scala/kafka/server/AlterIsrChannelManager.scala ## @@ -0,0 +1,132 @@ +package kafka.server + +import java.util +import java.util.

[GitHub] [kafka] ableegoldman commented on a change in pull request #9186: KAFKA-10277: Allow null keys with non-null mappedKey in KStreamKGlobalTable join

2020-08-21 Thread GitBox
ableegoldman commented on a change in pull request #9186: URL: https://github.com/apache/kafka/pull/9186#discussion_r474931289 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKTableJoinProcessor.java ## @@ -58,29 +60,46 @@ public void init

[jira] [Commented] (KAFKA-10186) Aborting transaction with pending data should throw non-fatal exception

2020-08-21 Thread Gokul Srinivas (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17182133#comment-17182133 ] Gokul Srinivas commented on KAFKA-10186: [~mjsax] Understood. thank you. I'll cl

[GitHub] [kafka] soarez commented on a change in pull request #9000: KAFKA-10036 Improve handling and documentation of Suppliers

2020-08-21 Thread GitBox
soarez commented on a change in pull request #9000: URL: https://github.com/apache/kafka/pull/9000#discussion_r474950526 ## File path: streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamImplTest.java ## @@ -1865,6 +1865,17 @@ public void shouldNotAllowNul

[GitHub] [kafka] rondagostino commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

2020-08-21 Thread GitBox
rondagostino commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r474950597 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/DescribeUserScramCredentialsResult.java ## @@ -0,0 +1,50 @@ +/* + * Licensed to the

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

2020-08-21 Thread GitBox
mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r474934833 ## File path: core/src/main/scala/kafka/server/AlterIsrChannelManager.scala ## @@ -0,0 +1,132 @@ +package kafka.server + +import java.util +import java.util.

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

2020-08-21 Thread GitBox
mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r474959176 ## File path: core/src/main/scala/kafka/server/AlterIsrChannelManager.scala ## @@ -0,0 +1,132 @@ +package kafka.server + +import java.util +import java.util.

[jira] [Commented] (KAFKA-10357) Handle accidental deletion of repartition-topics as exceptional failure

2020-08-21 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17182142#comment-17182142 ] Sophie Blee-Goldman commented on KAFKA-10357: - I'm a little less concerned a

[GitHub] [kafka] ableegoldman commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

2020-08-21 Thread GitBox
ableegoldman commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r474966465 ## File path: streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregateTest.java ## @@ -0,0 +1,579 @@ +/* + * Lic

[GitHub] [kafka] ableegoldman commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

2020-08-21 Thread GitBox
ableegoldman commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r474977836 ## File path: streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregateTest.java ## @@ -0,0 +1,579 @@ +/* + * Lic

[jira] [Commented] (KAFKA-10410) OnRestoreStart disappeared from StateRestoreCallback in 2.6.0 and reappeared in a useless place

2020-08-21 Thread Mark Shelton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17182163#comment-17182163 ] Mark Shelton commented on KAFKA-10410: -- The problem is that since 2.6 the StateRest

[GitHub] [kafka] abbccdda commented on a change in pull request #8846: KAFKA-9800: [KIP-580] Client Exponential Backoff Implementation

2020-08-21 Thread GitBox
abbccdda commented on a change in pull request #8846: URL: https://github.com/apache/kafka/pull/8846#discussion_r474843042 ## File path: clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java ## @@ -84,6 +84,14 @@ public static final String RETRY_BACKOF

[GitHub] [kafka] ableegoldman commented on a change in pull request #9138: KAFKA-9929: Support backward iterator on WindowStore

2020-08-21 Thread GitBox
ableegoldman commented on a change in pull request #9138: URL: https://github.com/apache/kafka/pull/9138#discussion_r475014135 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/AbstractRocksDBSegmentedBytesStore.java ## @@ -72,22 +86,40 @@

[GitHub] [kafka] vvcephei commented on pull request #9137: KAFKA-9929: Support reverse iterator on KeyValueStore

2020-08-21 Thread GitBox
vvcephei commented on pull request #9137: URL: https://github.com/apache/kafka/pull/9137#issuecomment-678575081 It looks like java 14 only failed while attempting to download some docs from Oracle, and java 8 failed on this unrelated test: `org.apache.kafka.clients.admin.KafkaAdminClientTe

[GitHub] [kafka] vvcephei merged pull request #9137: KAFKA-9929: Support reverse iterator on KeyValueStore

2020-08-21 Thread GitBox
vvcephei merged pull request #9137: URL: https://github.com/apache/kafka/pull/9137 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] chia7712 commented on a change in pull request #9102: KAFKA-10326 Both serializer and deserializer should be able to see th…

2020-08-21 Thread GitBox
chia7712 commented on a change in pull request #9102: URL: https://github.com/apache/kafka/pull/9102#discussion_r475041700 ## File path: clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java ## @@ -2511,4 +2511,39 @@ public void testEnforceRebalanceTr

[GitHub] [kafka] chia7712 commented on pull request #9182: KAFKA-10403 Replace scala collection by java collection in generating…

2020-08-21 Thread GitBox
chia7712 commented on pull request #9182: URL: https://github.com/apache/kafka/pull/9182#issuecomment-678589736 failed tests pass on my local This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [kafka] chia7712 commented on pull request #9162: MINOR: refactor Log to get rid of "return" in nested anonymous function

2020-08-21 Thread GitBox
chia7712 commented on pull request #9162: URL: https://github.com/apache/kafka/pull/9162#issuecomment-678590561 ```testMetadataRetries``` is traced by #9091 This is an automated message from the Apache Git Service. To respond

[GitHub] [kafka] chia7712 edited a comment on pull request #9162: MINOR: refactor Log to get rid of "return" in nested anonymous function

2020-08-21 Thread GitBox
chia7712 edited a comment on pull request #9162: URL: https://github.com/apache/kafka/pull/9162#issuecomment-678590561 ```testMetadataRetries``` is traced by #9091 ```DynamicConnectionQuotaTest.testDynamicListenerConnectionCreationRateQuota``` pass on my local

[GitHub] [kafka] ijuma commented on pull request #9202: KAFKA-10401: Fix the currentStateTimeStamp doesn't get set correctly

2020-08-21 Thread GitBox
ijuma commented on pull request #9202: URL: https://github.com/apache/kafka/pull/9202#issuecomment-678594470 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [kafka] ijuma commented on a change in pull request #9202: KAFKA-10401: Fix the currentStateTimeStamp doesn't get set correctly

2020-08-21 Thread GitBox
ijuma commented on a change in pull request #9202: URL: https://github.com/apache/kafka/pull/9202#discussion_r475046516 ## File path: core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala ## @@ -1401,16 +1401,17 @@ object GroupMetadataManager { val vers