chia7712 opened a new pull request #9134:
URL: https://github.com/apache/kafka/pull/9134
this is a bit optimization of converting producer responses. Those array
buffers need initial capacity to avoid growing continually if the request
carries a bunch of small messages and those messages a
tom1299 opened a new pull request #9135:
URL: https://github.com/apache/kafka/pull/9135
I'm a newbie to the Kafka project and going through the examples. Along the
way I did a very small refactoring to the Producer class:
* Convert the Callback class into a method
The aim was to s
tombentley commented on pull request #8878:
URL: https://github.com/apache/kafka/pull/8878#issuecomment-670404348
Thinking about, it we could avoid breaking existing links by generating both
old and new style ids: `whatever.config.name`. WDYT @mimaison @omkreddy?
-
tombentley opened a new pull request #9136:
URL: https://github.com/apache/kafka/pull/9136
See KIP-632.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
tombentley commented on pull request #9136:
URL: https://github.com/apache/kafka/pull/9136#issuecomment-670438137
@omkreddy, @mimaison, @rajinisivaram, @kkonstantine, @dajac thanks for
voting on the KIP. I'd be grateful for review.
-
Kevin Tibi created KAFKA-10372:
--
Summary: [JAVA 11] Unrecognized VM option PrintGCDateStamps
Key: KAFKA-10372
URL: https://issues.apache.org/jira/browse/KAFKA-10372
Project: Kafka
Issue Type: Bu
[
https://issues.apache.org/jira/browse/KAFKA-10372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Tibi updated KAFKA-10372:
---
Labels: bug (was: )
> [JAVA 11] Unrecognized VM option PrintGCDateStamps
>
[
https://issues.apache.org/jira/browse/KAFKA-10372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Tibi updated KAFKA-10372:
---
Fix Version/s: 2.6.1
> [JAVA 11] Unrecognized VM option PrintGCDateStamps
>
[
https://issues.apache.org/jira/browse/KAFKA-10372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Tibi updated KAFKA-10372:
---
Description:
Hello,
I can't start kafka with JAVA 11.
{code:java}
kafka-server-start.sh[2721]:
[
https://issues.apache.org/jira/browse/KAFKA-10372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Tibi updated KAFKA-10372:
---
Priority: Blocker (was: Major)
> [JAVA 11] Unrecognized VM option PrintGCDateStamps
> -
[
https://issues.apache.org/jira/browse/KAFKA-9366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dongjin Lee updated KAFKA-9366:
---
Summary: Upgrade log4j to log4j2 (was: please consider upgrade log4j to
log4j2 due to critical secur
[
https://issues.apache.org/jira/browse/KAFKA-10372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Tibi resolved KAFKA-10372.
Resolution: Abandoned
error from ansible role which override script.
> [JAVA 11] Unrecognized VM
azher khan created KAFKA-10373:
--
Summary: Kafka Reassign Partition is stuck with Java OutOfMemory
error
Key: KAFKA-10373
URL: https://issues.apache.org/jira/browse/KAFKA-10373
Project: Kafka
Is
rajinisivaram commented on a change in pull request #9032:
URL: https://github.com/apache/kafka/pull/9032#discussion_r467052269
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java
##
@@ -4071,6 +4081,168 @@ void handleFailure(Throwable thro
[
https://issues.apache.org/jira/browse/KAFKA-10352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17173151#comment-17173151
]
Dongjin Lee commented on KAFKA-10352:
-
Hi [~dorbae],
It seems like you are using `/
[
https://issues.apache.org/jira/browse/KAFKA-10329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17173179#comment-17173179
]
Dongjin Lee commented on KAFKA-10329:
-
Hi [~rhauch],
It seems like this issue is re
jeqo opened a new pull request #9137:
URL: https://github.com/apache/kafka/pull/9137
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing stra
jeqo opened a new pull request #9138:
URL: https://github.com/apache/kafka/pull/9138
Depends on https://github.com/apache/kafka/pull/9137
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
jeqo opened a new pull request #9139:
URL: https://github.com/apache/kafka/pull/9139
Depends on https://github.com/apache/kafka/pull/9138
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
hachikuji commented on a change in pull request #7222:
URL: https://github.com/apache/kafka/pull/7222#discussion_r467139256
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/SubscriptionState.java
##
@@ -406,6 +407,10 @@ synchronized void maybeSee
jeqo commented on pull request #8976:
URL: https://github.com/apache/kafka/pull/8976#issuecomment-670601289
@ableegoldman great feedback. It makes sense to group changes in 3 different
PRs. As there is dependencies between stores, let's start with KeyValue, then
Window and finally Session
dajac opened a new pull request #9140:
URL: https://github.com/apache/kafka/pull/9140
https://github.com/apache/kafka/pull/8672 introduced a bug leading to
crashing the replica fetcher threads. The issue is that
https://github.com/apache/kafka/pull/8672 deletes the Partitions prior to
sto
jeqo closed pull request #8976:
URL: https://github.com/apache/kafka/pull/8976
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
jeqo commented on pull request #8976:
URL: https://github.com/apache/kafka/pull/8976#issuecomment-670601500
Closing in favor of #9137, #9138 and #9139
This is an automated message from the Apache Git Service.
To respond to t
[
https://issues.apache.org/jira/browse/KAFKA-10370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ning Zhang updated KAFKA-10370:
---
Description:
In WorkerSinkTask.java, when we want the consumer to start consuming from
certain offs
hachikuji commented on pull request #9140:
URL: https://github.com/apache/kafka/pull/9140#issuecomment-670606960
ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
David Jacot created KAFKA-10374:
---
Summary: Add concurrency tests for the ReplicaManager
Key: KAFKA-10374
URL: https://issues.apache.org/jira/browse/KAFKA-10374
Project: Kafka
Issue Type: Improv
dajac commented on pull request #9140:
URL: https://github.com/apache/kafka/pull/9140#issuecomment-670607229
Jira: https://issues.apache.org/jira/browse/KAFKA-10374
This is an automated message from the Apache Git Service.
To
omkreddy closed pull request #9050:
URL: https://github.com/apache/kafka/pull/9050
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
ableegoldman commented on pull request #8976:
URL: https://github.com/apache/kafka/pull/8976#issuecomment-670624337
Awesome, thanks @jeqo ! Let me know when the first PR is ready for review
again (or is it ready now?)
This i
omkreddy commented on pull request #8878:
URL: https://github.com/apache/kafka/pull/8878#issuecomment-670626828
ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
mimaison commented on pull request #9131:
URL: https://github.com/apache/kafka/pull/9131#issuecomment-670634953
Thanks @mjsax, I wasn't expecting a review this quickly! Sorry for not fully
checking the changes before opening the PR.
lct45 opened a new pull request #9141:
URL: https://github.com/apache/kafka/pull/9141
Updated `CogroupedStreamAggregateBuilder` to have individual builders
depending on the windowed aggregation, or lack thereof. This replaced passing
in all options into the builder, with all but the curren
hachikuji commented on a change in pull request #7222:
URL: https://github.com/apache/kafka/pull/7222#discussion_r467143222
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java
##
@@ -1120,17 +1123,28 @@ Node selectReadReplica(TopicParti
lbradstreet closed pull request #9123:
URL: https://github.com/apache/kafka/pull/9123
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
lbradstreet commented on a change in pull request #7222:
URL: https://github.com/apache/kafka/pull/7222#discussion_r467187874
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/SubscriptionState.java
##
@@ -422,10 +421,13 @@ synchronized int numAss
hachikuji merged pull request #9110:
URL: https://github.com/apache/kafka/pull/9110
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
rondagostino commented on a change in pull request #9032:
URL: https://github.com/apache/kafka/pull/9032#discussion_r467191680
##
File path: core/src/main/scala/kafka/admin/ConfigCommand.scala
##
@@ -508,7 +563,15 @@ object ConfigCommand extends Config {
val entityStr
mimaison commented on a change in pull request #8295:
URL: https://github.com/apache/kafka/pull/8295#discussion_r467193718
##
File path:
clients/src/test/java/org/apache/kafka/common/requests/RequestResponseTest.java
##
@@ -1251,15 +1267,28 @@ private ListOffsetRequest createL
mimaison commented on a change in pull request #8295:
URL: https://github.com/apache/kafka/pull/8295#discussion_r467194925
##
File path:
clients/src/test/java/org/apache/kafka/common/requests/RequestResponseTest.java
##
@@ -1221,28 +1226,39 @@ private DeleteGroupsResponse
cre
mimaison commented on pull request #8295:
URL: https://github.com/apache/kafka/pull/8295#issuecomment-670643947
@abbccdda I've addressed your comments, can you take another look?
This is an automated message from the Apache G
[
https://issues.apache.org/jira/browse/KAFKA-10223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17173403#comment-17173403
]
Dongjoon Hyun commented on KAFKA-10223:
---
Hi, [~rsivaram]. Is this only 2.6.0 issue
mimaison commented on a change in pull request #9136:
URL: https://github.com/apache/kafka/pull/9136#discussion_r467206725
##
File path:
clients/src/main/java/org/apache/kafka/common/config/provider/DirectoryConfigProvider.java
##
@@ -0,0 +1,98 @@
+/*
+ * Licensed to the Apach
cmccabe commented on a change in pull request #9103:
URL: https://github.com/apache/kafka/pull/9103#discussion_r467214507
##
File path:
core/src/test/scala/integration/kafka/api/AuthorizerIntegrationTest.scala
##
@@ -497,10 +497,10 @@ class AuthorizerIntegrationTest extends Ba
abbccdda commented on a change in pull request #9103:
URL: https://github.com/apache/kafka/pull/9103#discussion_r467215647
##
File path:
core/src/test/scala/integration/kafka/api/AuthorizerIntegrationTest.scala
##
@@ -497,10 +497,10 @@ class AuthorizerIntegrationTest extends B
skaundinya15 opened a new pull request #9142:
URL: https://github.com/apache/kafka/pull/9142
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
The current impl
ableegoldman commented on a change in pull request #9141:
URL: https://github.com/apache/kafka/pull/9141#discussion_r467210400
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/CogroupedStreamAggregateBuilder.java
##
@@ -47,18 +47,96 @@
Cogrou
skaundinya15 opened a new pull request #9143:
URL: https://github.com/apache/kafka/pull/9143
Currently the way we calculate the number of total consumed messages for the
verifiable consumer overcounts the number of actually consumed messages. This
PR is to fix that to ensure we count the n
mjsax commented on a change in pull request #9039:
URL: https://github.com/apache/kafka/pull/9039#discussion_r467231847
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/KStreamAggregationIntegrationTest.java
##
@@ -459,6 +460,95 @@ public void shouldGro
mjsax commented on a change in pull request #9133:
URL: https://github.com/apache/kafka/pull/9133#discussion_r467233225
##
File path: streams/src/main/java/org/apache/kafka/streams/KeyQueryMetadata.java
##
@@ -50,32 +50,65 @@ public KeyQueryMetadata(final HostInfo activeHost, f
johnthotekat commented on a change in pull request #9133:
URL: https://github.com/apache/kafka/pull/9133#discussion_r467235567
##
File path: streams/src/main/java/org/apache/kafka/streams/KeyQueryMetadata.java
##
@@ -50,32 +50,65 @@ public KeyQueryMetadata(final HostInfo active
lct45 commented on a change in pull request #9141:
URL: https://github.com/apache/kafka/pull/9141#discussion_r467236081
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/CogroupedStreamAggregateBuilder.java
##
@@ -47,18 +47,96 @@
CogroupedStre
johnthotekat commented on a change in pull request #9133:
URL: https://github.com/apache/kafka/pull/9133#discussion_r467236707
##
File path: streams/src/main/java/org/apache/kafka/streams/KeyQueryMetadata.java
##
@@ -50,32 +50,65 @@ public KeyQueryMetadata(final HostInfo active
johnthotekat commented on a change in pull request #9133:
URL: https://github.com/apache/kafka/pull/9133#discussion_r467236707
##
File path: streams/src/main/java/org/apache/kafka/streams/KeyQueryMetadata.java
##
@@ -50,32 +50,65 @@ public KeyQueryMetadata(final HostInfo active
mjsax commented on pull request #9028:
URL: https://github.com/apache/kafka/pull/9028#issuecomment-670689958
Retest this please.
This is an automated message from the Apache Git Service.
To respond to the message, please log
mjsax commented on a change in pull request #9133:
URL: https://github.com/apache/kafka/pull/9133#discussion_r467244495
##
File path: streams/src/main/java/org/apache/kafka/streams/KeyQueryMetadata.java
##
@@ -50,32 +50,65 @@ public KeyQueryMetadata(final HostInfo activeHost, f
cmccabe commented on pull request #9103:
URL: https://github.com/apache/kafka/pull/9103#issuecomment-670693346
I think it would be good to split this PR up a little bit. It seems like we
could have a split like this:
PR 1. `Add flag to the RequestContext` and `Add initial principal
lct45 commented on a change in pull request #9039:
URL: https://github.com/apache/kafka/pull/9039#discussion_r467260318
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java
##
@@ -0,0 +1,389 @@
+/*
+ * Licensed to th
rondagostino commented on a change in pull request #9142:
URL: https://github.com/apache/kafka/pull/9142#discussion_r467263885
##
File path: tests/kafkatest/services/kafka/kafka.py
##
@@ -503,7 +503,7 @@ def create_topic(self, topic_cfg, node=None,
use_zk_to_create_topic=True)
dielhennr commented on a change in pull request #9101:
URL: https://github.com/apache/kafka/pull/9101#discussion_r467273920
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java
##
@@ -504,6 +515,7 @@ public void onSuccess(Byt
skaundinya15 commented on a change in pull request #9142:
URL: https://github.com/apache/kafka/pull/9142#discussion_r467274037
##
File path: tests/kafkatest/services/kafka/kafka.py
##
@@ -503,7 +503,7 @@ def create_topic(self, topic_cfg, node=None,
use_zk_to_create_topic=True)
mjsax commented on a change in pull request #8964:
URL: https://github.com/apache/kafka/pull/8964#discussion_r466716421
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/AbstractTask.java
##
@@ -49,6 +61,30 @@
this.stateDirectory = state
ableegoldman commented on a change in pull request #9039:
URL: https://github.com/apache/kafka/pull/9039#discussion_r467296111
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/KStreamAggregationIntegrationTest.java
##
@@ -459,6 +460,95 @@ public void sh
soondenana commented on pull request #9140:
URL: https://github.com/apache/kafka/pull/9140#issuecomment-670730240
I can confirm that this fixes the issue. I ran system test 18 times and
didn't hit this issue. Without this fix, when I run the system test 10 times I
hit the issue 2 times.
mjsax commented on pull request #9141:
URL: https://github.com/apache/kafka/pull/9141#issuecomment-670745736
Retest this please.
This is an automated message from the Apache Git Service.
To respond to the message, please log
hachikuji merged pull request #9140:
URL: https://github.com/apache/kafka/pull/9140
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
[
https://issues.apache.org/jira/browse/KAFKA-10371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson resolved KAFKA-10371.
-
Resolution: Fixed
> Partition reassignments can result in crashed ReplicaFetcherThreads.
[
https://issues.apache.org/jira/browse/KAFKA-10371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson updated KAFKA-10371:
Affects Version/s: (was: 2.7.0)
> Partition reassignments can result in crashed Replic
abbccdda opened a new pull request #9144:
URL: https://github.com/apache/kafka/pull/9144
Add the redirection supporting fields, including:
1. initial principal name
2. initial client id
3. the flag to indicate whether a given request is coming from the control
plane in a secure
cmccabe commented on a change in pull request #9144:
URL: https://github.com/apache/kafka/pull/9144#discussion_r467330529
##
File path:
clients/src/main/java/org/apache/kafka/common/requests/RequestHeader.java
##
@@ -37,11 +37,22 @@ public RequestHeader(Struct struct, short he
cmccabe commented on a change in pull request #9144:
URL: https://github.com/apache/kafka/pull/9144#discussion_r467330705
##
File path:
clients/src/main/java/org/apache/kafka/server/authorizer/AuthorizableRequestContext.java
##
@@ -69,4 +69,11 @@
* Returns the correlatio
cmccabe commented on a change in pull request #9144:
URL: https://github.com/apache/kafka/pull/9144#discussion_r467330968
##
File path: core/src/main/scala/kafka/network/RequestChannel.scala
##
@@ -309,7 +309,10 @@ object RequestChannel extends Logging {
}
}
-class Reques
cmccabe commented on a change in pull request #9144:
URL: https://github.com/apache/kafka/pull/9144#discussion_r467331218
##
File path: core/src/main/scala/kafka/network/SocketServer.scala
##
@@ -88,15 +88,17 @@ class SocketServer(val config: KafkaConfig,
private val memoryP
cmccabe commented on a change in pull request #9144:
URL: https://github.com/apache/kafka/pull/9144#discussion_r467331218
##
File path: core/src/main/scala/kafka/network/SocketServer.scala
##
@@ -88,15 +88,17 @@ class SocketServer(val config: KafkaConfig,
private val memoryP
[
https://issues.apache.org/jira/browse/KAFKA-10370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ning Zhang updated KAFKA-10370:
---
Description:
In WorkerSinkTask.java, when we want the consumer to start consuming from
certain offs
[
https://issues.apache.org/jira/browse/KAFKA-10370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ning Zhang updated KAFKA-10370:
---
Description:
In WorkerSinkTask.java, when we want the consumer to consume from certain
offsets, rat
ning2008wisc opened a new pull request #9145:
URL: https://github.com/apache/kafka/pull/9145
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
ning2008wisc commented on pull request #9145:
URL: https://github.com/apache/kafka/pull/9145#issuecomment-670820575
As mentioned in
https://stackoverflow.com/questions/54480715/no-current-assignment-for-partition-occurs-even-after-poll-in-kafka,
another potential resolution could be "call
mjsax commented on a change in pull request #8964:
URL: https://github.com/apache/kafka/pull/8964#discussion_r467291346
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StandbyTask.java
##
@@ -93,9 +90,7 @@ public boolean isActive() {
publi
johnthotekat opened a new pull request #9146:
URL: https://github.com/apache/kafka/pull/9146
* This PR updates the upgrade guide for the changes in
https://github.com/apache/kafka/pull/9120.
* Added the details on KIP-648 to 2.7.0 upgrade notes -
docs/streams/upgrade-guide.html.
@mjs
johnthotekat closed pull request #9133:
URL: https://github.com/apache/kafka/pull/9133
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
johnthotekat commented on pull request #9133:
URL: https://github.com/apache/kafka/pull/9133#issuecomment-670823191
This branch got a little messed up during the rebase :(
Raised another PR https://github.com/apache/kafka/pull/9146
-
johnthotekat edited a comment on pull request #9133:
URL: https://github.com/apache/kafka/pull/9133#issuecomment-670823191
Closing this PR. Raised another PR https://github.com/apache/kafka/pull/9146
.
This branch got a little messed up during the rebase :(
---
ning2008wisc removed a comment on pull request #9145:
URL: https://github.com/apache/kafka/pull/9145#issuecomment-670820575
As mentioned in
https://stackoverflow.com/questions/54480715/no-current-assignment-for-partition-occurs-even-after-poll-in-kafka,
another potential resolution could b
84 matches
Mail list logo
