[
https://issues.apache.org/jira/browse/KAFKA-10366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17172139#comment-17172139
]
Sören Henning commented on KAFKA-10366:
---
I guess, this is also related to KAFKA-96
Mickael Maison created KAFKA-10367:
--
Summary: Allow running the Streams demo app with a config file
Key: KAFKA-10367
URL: https://issues.apache.org/jira/browse/KAFKA-10367
Project: Kafka
Iss
mimaison opened a new pull request #9131:
URL: https://github.com/apache/kafka/pull/9131
Update the 3 WordCount demos to accept a configuration file. I kept the
changes to the minimum as the point of these samples is not to add a lot of
logic for parsing arguments and handling usage errors
serjchebotarev commented on pull request #9028:
URL: https://github.com/apache/kafka/pull/9028#issuecomment-669823727
@vvcephei & @mjsax this one seems to get stalled a bit - could you let me
know if anything else is to be corrected here or should we move on with
retesting the changes?
-
tombentley commented on pull request #8878:
URL: https://github.com/apache/kafka/pull/8878#issuecomment-669856151
@omkreddy any progress on this?
This is an automated message from the Apache Git Service.
To respond to the mes
[
https://issues.apache.org/jira/browse/KAFKA-9629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17172256#comment-17172256
]
Tom Bentley commented on KAFKA-9629:
[~mumrah] the PR has been merged, so this can be
omkreddy commented on pull request #9050:
URL: https://github.com/apache/kafka/pull/9050#issuecomment-669866356
ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
hanmingze created KAFKA-10368:
-
Summary: Rack aware assignment results not balanced
Key: KAFKA-10368
URL: https://issues.apache.org/jira/browse/KAFKA-10368
Project: Kafka
Issue Type: Improvement
lct45 commented on a change in pull request #9039:
URL: https://github.com/apache/kafka/pull/9039#discussion_r466425932
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/CogroupedStreamAggregateBuilder.java
##
@@ -132,16 +135,19 @@
[
https://issues.apache.org/jira/browse/KAFKA-10368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
hanmingze updated KAFKA-10368:
--
Description:
When the number of broker in two rack is inconsistent, the assignment results
is not bal
[
https://issues.apache.org/jira/browse/KAFKA-10368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
hanmingze updated KAFKA-10368:
--
Description:
When the number of broker in two rack is inconsistent, the assignment results
is not bal
[
https://issues.apache.org/jira/browse/KAFKA-10368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
hanmingze updated KAFKA-10368:
--
Description:
When the number of broker in two rack is inconsistent, the assignment results
is not bal
[
https://issues.apache.org/jira/browse/KAFKA-10368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
hanmingze updated KAFKA-10368:
--
Priority: Major (was: Minor)
> Rack aware assignment results not balanced
> -
[
https://issues.apache.org/jira/browse/KAFKA-10368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
hanmingze updated KAFKA-10368:
--
Description:
When the number of broker in two rack is inconsistent, the assignment results
is not bal
omkreddy commented on a change in pull request #9050:
URL: https://github.com/apache/kafka/pull/9050#discussion_r466455643
##
File path: core/src/main/scala/kafka/controller/KafkaController.scala
##
@@ -1986,101 +1965,125 @@ private[controller] class ControllerStats extends
Ka
guillaumebort opened a new pull request #9132:
URL: https://github.com/apache/kafka/pull/9132
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of tes
dajac commented on pull request #9114:
URL: https://github.com/apache/kafka/pull/9114#issuecomment-669977494
@junrao I have updated the KIP and posted an update to the thread in the
mailing list.
This is an automated message
stanislavkozlovski commented on pull request #9079:
URL: https://github.com/apache/kafka/pull/9079#issuecomment-669992453
@ijuma considering this is causing the system test to be flaky, is it worth
backporting? It seems like the test is present since 1.1
--
junrao merged pull request #9114:
URL: https://github.com/apache/kafka/pull/9114
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[
https://issues.apache.org/jira/browse/KAFKA-10186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17172514#comment-17172514
]
Gokul Srinivas commented on KAFKA-10186:
[~mjsax] [~ableegoldman]
I've created
[
https://issues.apache.org/jira/browse/KAFKA-10186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17172514#comment-17172514
]
Gokul Srinivas edited comment on KAFKA-10186 at 8/6/20, 4:25 PM:
-
mjsax commented on pull request #9131:
URL: https://github.com/apache/kafka/pull/9131#issuecomment-670039989
Checkstyle error:
```
> Task :streams:examples:checkstyleMain FAILED
02:46:32 [ant:checkstyle] [ERROR]
/home/jenkins/jenkins-slave/workspace/kafka-pr-jdk11-scala2.13/streams
hachikuji commented on a change in pull request #9110:
URL: https://github.com/apache/kafka/pull/9110#discussion_r466550492
##
File path: core/src/main/scala/kafka/log/Log.scala
##
@@ -2227,13 +2210,16 @@ class Log(@volatile private var _dir: File,
* @param segments The log
abbccdda commented on a change in pull request #9103:
URL: https://github.com/apache/kafka/pull/9103#discussion_r466582281
##
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##
@@ -2982,12 +3089,33 @@ class KafkaApis(val requestChannel: RequestChannel,
mjsax commented on a change in pull request #9131:
URL: https://github.com/apache/kafka/pull/9131#discussion_r466596054
##
File path:
streams/examples/src/main/java/org/apache/kafka/streams/examples/wordcount/WordCountDemo.java
##
@@ -47,18 +49,23 @@
public static final S
Ivan Ponomarev created KAFKA-10369:
--
Summary: Introduce Distinct operation in KStream
Key: KAFKA-10369
URL: https://issues.apache.org/jira/browse/KAFKA-10369
Project: Kafka
Issue Type: Impro
mjsax merged pull request #9120:
URL: https://github.com/apache/kafka/pull/9120
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
mjsax commented on pull request #9120:
URL: https://github.com/apache/kafka/pull/9120#issuecomment-670094310
Thanks for the KIP and PR @johnthotekat. Merged to `trunk`.
This is an automated message from the Apache Git Service
mjsax commented on pull request #9120:
URL: https://github.com/apache/kafka/pull/9120#issuecomment-670095558
One more thing: could you do a second PR to update the docs accordingly? We
should list the KIP at lest in `docs/streams/upgrade-guide.html` (there should
be already a section for 2
[
https://issues.apache.org/jira/browse/KAFKA-10369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ivan Ponomarev updated KAFKA-10369:
---
Description:
Message deduplication is a common task.
One example: we might have multiple da
dhruvilshah3 commented on a change in pull request #9110:
URL: https://github.com/apache/kafka/pull/9110#discussion_r466601556
##
File path: core/src/main/scala/kafka/log/Log.scala
##
@@ -2227,13 +2210,16 @@ class Log(@volatile private var _dir: File,
* @param segments The
mjsax merged pull request #9127:
URL: https://github.com/apache/kafka/pull/9127
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
mjsax commented on pull request #9127:
URL: https://github.com/apache/kafka/pull/9127#issuecomment-670098130
Merged to `trunk` and cherry-picked to `2.6`.
This is an automated message from the Apache Git Service.
To respond t
mjsax merged pull request #9060:
URL: https://github.com/apache/kafka/pull/9060
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
junrao commented on pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#issuecomment-670113688
@chia7712 : If we could solve the issue by simplifying DelayedOperation, it
would be ideal. I am not sure how your proposal avoids the above potential
deadlock. Could you provide a
hachikuji commented on pull request #9110:
URL: https://github.com/apache/kafka/pull/9110#issuecomment-670127847
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please l
hachikuji commented on pull request #9110:
URL: https://github.com/apache/kafka/pull/9110#issuecomment-670126784
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
ableegoldman commented on a change in pull request #9039:
URL: https://github.com/apache/kafka/pull/9039#discussion_r466618450
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/CogroupedStreamAggregateBuilder.java
##
@@ -132,16 +135,19 @@
[
https://issues.apache.org/jira/browse/KAFKA-10366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17172633#comment-17172633
]
Sophie Blee-Goldman commented on KAFKA-10366:
-
Yeah, there are two related p
dielhennr commented on a change in pull request #9101:
URL: https://github.com/apache/kafka/pull/9101#discussion_r466653159
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java
##
@@ -504,6 +515,7 @@ public void onSuccess(Byt
CEikermann commented on pull request #7539:
URL: https://github.com/apache/kafka/pull/7539#issuecomment-670164657
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
CEikermann removed a comment on pull request #7539:
URL: https://github.com/apache/kafka/pull/7539#issuecomment-670164684
Would be nice to merge this
Is anything open for this merge request before it can be merged?
Thi
rondagostino commented on a change in pull request #9032:
URL: https://github.com/apache/kafka/pull/9032#discussion_r466681231
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java
##
@@ -4071,6 +4081,168 @@ void handleFailure(Throwable throw
dielhennr commented on a change in pull request #9101:
URL: https://github.com/apache/kafka/pull/9101#discussion_r466653159
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java
##
@@ -504,6 +515,7 @@ public void onSuccess(Byt
dielhennr commented on a change in pull request #9101:
URL: https://github.com/apache/kafka/pull/9101#discussion_r466653159
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java
##
@@ -504,6 +515,7 @@ public void onSuccess(Byt
[
https://issues.apache.org/jira/browse/KAFKA-10349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Boyang Chen updated KAFKA-10349:
Description:
As stated in KIP-590, we would disallow new admin client to discover the
controller
unsubscribe
abbccdda commented on a change in pull request #9103:
URL: https://github.com/apache/kafka/pull/9103#discussion_r466714423
##
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##
@@ -2982,12 +3089,33 @@ class KafkaApis(val requestChannel: RequestChannel,
mjsax commented on a change in pull request #8964:
URL: https://github.com/apache/kafka/pull/8964#discussion_r466716421
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/AbstractTask.java
##
@@ -49,6 +61,30 @@
this.stateDirectory = state
mjsax commented on a change in pull request #8964:
URL: https://github.com/apache/kafka/pull/8964#discussion_r466717212
##
File path:
streams/src/test/java/org/apache/kafka/streams/tests/EosTestDriver.java
##
@@ -379,9 +379,18 @@ private static void verifyReceivedAllRecords(fi
mjsax commented on a change in pull request #8964:
URL: https://github.com/apache/kafka/pull/8964#discussion_r466717608
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java
##
@@ -344,40 +343,41 @@ public void resume() {
}
hachikuji commented on pull request #9110:
URL: https://github.com/apache/kafka/pull/9110#issuecomment-670239077
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please l
LMnet commented on pull request #8955:
URL: https://github.com/apache/kafka/pull/8955#issuecomment-670265314
I added `nullSerde` and rebased branch to the current trunk.
This is an automated message from the Apache Git Servic
[
https://issues.apache.org/jira/browse/KAFKA-10369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-10369:
Component/s: streams
> Introduce Distinct operation in KStream
> -
[
https://issues.apache.org/jira/browse/KAFKA-10369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-10369:
Labels: kip (was: )
> Introduce Distinct operation in KStream
> -
Ning Zhang created KAFKA-10370:
--
Summary: WorkerSinkTask: IllegalStateException cased by
consumer.seek(tp, offsets) when (tp, offsets) are supplied by
WorkerSinkTaskContext
Key: KAFKA-10370
URL: https://issues.apach
[
https://issues.apache.org/jira/browse/KAFKA-10370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ning Zhang updated KAFKA-10370:
---
Description:
In WorkerSinkTask.java, when we want the consumer to start consuming from
certain offs
ableegoldman commented on pull request #9094:
URL: https://github.com/apache/kafka/pull/9094#issuecomment-670281342
Hey @guozhangwang
Thanks for the review. You have some high-level questions so I'll try to
answer them here but let me know if you want to sync offline.
> the only
Steve Rodrigues created KAFKA-10371:
---
Summary: Partition reassignments can result in crashed
ReplicaFetcherThreads.
Key: KAFKA-10371
URL: https://issues.apache.org/jira/browse/KAFKA-10371
Project: K
ableegoldman edited a comment on pull request #9094:
URL: https://github.com/apache/kafka/pull/9094#issuecomment-670281342
Hey @guozhangwang
Thanks for the review. You have some high-level questions so I'll try to
answer them here but let me know if you want to sync offline.
edit
ableegoldman commented on pull request #9094:
URL: https://github.com/apache/kafka/pull/9094#issuecomment-670282246
Oh I think I misread your original comment, editing my response above
This is an automated message from the A
ableegoldman edited a comment on pull request #9094:
URL: https://github.com/apache/kafka/pull/9094#issuecomment-670281342
Hey @guozhangwang
Thanks for the review. You have some high-level questions so I'll try to
answer them here but let me know if you want to sync offline.
> th
chia7712 commented on pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#issuecomment-670293057
> Could you provide a bit more detail?
The new deadlock you mentioned is caused by PR. This PR introduces extra
lock (```ReentrantLock```) to ```DelayedJoin``` (By contrast
johnthotekat opened a new pull request #9133:
URL: https://github.com/apache/kafka/pull/9133
* Added the details on KIP-648 to 2.7.0 upgrade notes -
`docs/streams/upgrade-guide.html`
@mjsax
This is an automated mess
johnthotekat commented on pull request #9133:
URL: https://github.com/apache/kafka/pull/9133#issuecomment-670322175
@mjsax I've checked the actual documentations and just to make sure I've
also checked for the occurrence of the deprecated methods throughout the repo
and found none (except
johnthotekat commented on pull request #9120:
URL: https://github.com/apache/kafka/pull/9120#issuecomment-670322541
@mjsax Made the changes and raised PR :
https://github.com/apache/kafka/pull/9133
Checked the actual documentations, we're good here.
--
[
https://issues.apache.org/jira/browse/KAFKA-10371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot reassigned KAFKA-10371:
---
Assignee: David Jacot
> Partition reassignments can result in crashed ReplicaFetcherThreads
67 matches
Mail list logo
