vvcephei merged pull request #9066:
URL: https://github.com/apache/kafka/pull/9066
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
guozhangwang commented on pull request #9084:
URL: https://github.com/apache/kafka/pull/9084#issuecomment-664698317
@abbccdda The exception is thrown from the consumer.poll, and the caller of
the consumer could be expecting specific exceptions, e.g. TaskMigratedException
will be handled sp
dajac commented on a change in pull request #9072:
URL: https://github.com/apache/kafka/pull/9072#discussion_r461123154
##
File path:
clients/src/main/java/org/apache/kafka/common/metrics/stats/TokenBucket.java
##
@@ -0,0 +1,150 @@
+/*
+ * Licensed to the Apache Software Found
guozhangwang commented on a change in pull request #8964:
URL: https://github.com/apache/kafka/pull/8964#discussion_r461266795
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StateManagerUtil.java
##
@@ -38,13 +41,39 @@
*/
final class StateM
rgroothuijsen commented on pull request #9089:
URL: https://github.com/apache/kafka/pull/9089#issuecomment-665171345
@rhauch No problem, thanks for the help! I used the version from the Eclipse
home page, but this one has much nicer formatting as well.
rgroothuijsen opened a new pull request #9089:
URL: https://github.com/apache/kafka/pull/9089
Jersey has changed its license from CDDL to EPLv2 starting from version
2.28. This PR updates the included license information to reflect this.
---
jeffkbkim commented on a change in pull request #9050:
URL: https://github.com/apache/kafka/pull/9050#discussion_r461742057
##
File path: core/src/main/scala/kafka/controller/KafkaController.scala
##
@@ -1986,101 +1965,125 @@ private[controller] class ControllerStats extends
K
guozhangwang commented on pull request #8964:
URL: https://github.com/apache/kafka/pull/8964#issuecomment-664688329
@ableegoldman @vvcephei I've thought about controlling the frequency of
flushing, and I've decided to expose another public config to let users
specify. But I'd defer that to
junrao commented on pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#issuecomment-664652669
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
rgibaiev edited a comment on pull request #8575:
URL: https://github.com/apache/kafka/pull/8575#issuecomment-665225469
Any update? @rhauch
This is an automated message from the Apache Git Service.
To respond to the message,
guozhangwang commented on pull request #9087:
URL: https://github.com/apache/kafka/pull/9087#issuecomment-665171108
For correctness I agree; though for some tests we cover the rebalance
triggered by member dropping out of the group and hence reducing the session
timeout also largely reduce
rhauch commented on pull request #9066:
URL: https://github.com/apache/kafka/pull/9066#issuecomment-665065731
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
apovzner commented on a change in pull request #9072:
URL: https://github.com/apache/kafka/pull/9072#discussion_r461297706
##
File path:
clients/src/main/java/org/apache/kafka/common/metrics/stats/TokenBucket.java
##
@@ -0,0 +1,150 @@
+/*
+ * Licensed to the Apache Software Fo
huxihx commented on pull request #8984:
URL: https://github.com/apache/kafka/pull/8984#issuecomment-664804260
Ping @omkreddy @mimaison for review.
This is an automated message from the Apache Git Service.
To respond to the me
rhauch commented on pull request #8575:
URL: https://github.com/apache/kafka/pull/8575#issuecomment-665303585
This PR has a conflict that has to be resolved first.
Also, KIP-581 must be passed before this can be merged. See the discussion
thread for the KIP.
---
guozhangwang edited a comment on pull request #9011:
URL: https://github.com/apache/kafka/pull/9011#issuecomment-665182983
@hachikuji That's what I was wondering as well. From the logs we have:
https://issues.apache.org/jira/secure/attachment/13008127/consumer5.log.2020-07-22.log
If
mumrah commented on a change in pull request #9050:
URL: https://github.com/apache/kafka/pull/9050#discussion_r461709093
##
File path: core/src/main/scala/kafka/controller/KafkaController.scala
##
@@ -1986,101 +1965,125 @@ private[controller] class ControllerStats extends
Kafk
dajac opened a new pull request #9091:
URL: https://github.com/apache/kafka/pull/9091
I have seem them failing locally from times to times. It seems that the
changes made in https://github.com/apache/kafka/pull/8864 have made them more
fragile. I have updated them to be more reliable.
showuon opened a new pull request #9096:
URL: https://github.com/apache/kafka/pull/9096
Recently, I tried to read the codes to understand what the
`constrainedAssign` and `generalAssign` method is doing, but it is so difficult
and suffering due to the complexity of the algorithm. And then
viktorsomogyi commented on pull request #4090:
URL: https://github.com/apache/kafka/pull/4090#issuecomment-664920356
Also the jdk11&scala2.13 build timed out due to another test:
```
12:49:33 org.apache.kafka.streams.processor.internals.GlobalStreamThreadTest
> shouldDieOnInvalidOffse
guozhangwang commented on pull request #9011:
URL: https://github.com/apache/kafka/pull/9011#issuecomment-665182983
That's what I was wondering as well. From the logs we have:
https://issues.apache.org/jira/secure/attachment/13008127/consumer5.log.2020-07-22.log
If you search for `Re
rhauch merged pull request #9089:
URL: https://github.com/apache/kafka/pull/9089
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
tombentley commented on pull request #8312:
URL: https://github.com/apache/kafka/pull/8312#issuecomment-664832499
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
tombentley commented on pull request #9007:
URL: https://github.com/apache/kafka/pull/9007#issuecomment-664836543
@mimaison done, thanks.
This is an automated message from the Apache Git Service.
To respond to the message, pl
ableegoldman commented on a change in pull request #8964:
URL: https://github.com/apache/kafka/pull/8964#discussion_r461229173
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StateManagerUtil.java
##
@@ -38,13 +41,39 @@
*/
final class StateM
dajac commented on pull request #9072:
URL: https://github.com/apache/kafka/pull/9072#issuecomment-664923691
@apovzner Thanks for your comments. I have updated the PR to incorporate
your feedback. I have also fixed a bug in unrecord and added the javadoc.
-
cyrusv opened a new pull request #9093:
URL: https://github.com/apache/kafka/pull/9093
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing st
sasakitoa commented on pull request #9081:
URL: https://github.com/apache/kafka/pull/9081#issuecomment-664725165
Thank you for kindness comments. I updated to improve java doc and related
test code.
This is an automated mess
huxihx edited a comment on pull request #8984:
URL: https://github.com/apache/kafka/pull/8984#issuecomment-664804260
Ping @omkreddy @mimaison @dajac for review.
This is an automated message from the Apache Git Service.
To re
dajac commented on pull request #9091:
URL: https://github.com/apache/kafka/pull/9091#issuecomment-664848664
@chia7712 Ack. I reverted `testMetadataRetries` back to the original version
prior to #8864. That test is specific for the retries so it doesn't make sense
to remove the retries con
mjsax commented on pull request #9086:
URL: https://github.com/apache/kafka/pull/9086#issuecomment-664684265
Merged to `trunk` and cherry-picked to `2.6`, `2.5`, `2.4`, and `2.3`
branches.
This is an automated message from t
cmccabe commented on a change in pull request #9012:
URL: https://github.com/apache/kafka/pull/9012#discussion_r461884961
##
File path:
core/src/main/scala/kafka/server/BrokerToControllerChannelManager.scala
##
@@ -0,0 +1,211 @@
+/*
+ * Licensed to the Apache Software Foundati
rhauch commented on pull request #9051:
URL: https://github.com/apache/kafka/pull/9051#issuecomment-665124035
This was also cherry-picked to `2.6`, but that branch has been frozen while
we try to release AK 2.6.0. However, given that this is low-risk, I'll leave it
on `2.6` and update
[KA
ableegoldman commented on pull request #9094:
URL: https://github.com/apache/kafka/pull/9094#issuecomment-665394762
call for review @vvcephei @cadonna @guozhangwang
This is an automated message from the Apache Git Service.
T
rhauch commented on pull request #9089:
URL: https://github.com/apache/kafka/pull/9089#issuecomment-665168618
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
codelabor opened a new pull request #9090:
URL: https://github.com/apache/kafka/pull/9090
In most of 'toString()' methods,'=' is used instead of ' = ', so I followed
the convention.
Actually, if you print 'ProducerRecord' and 'ConsumerRecord', the pattern
looks different and looks s
hachikuji commented on a change in pull request #9047:
URL: https://github.com/apache/kafka/pull/9047#discussion_r461114945
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java
##
@@ -292,21 +278,36 @@ private void restor
rgibaiev commented on pull request #8575:
URL: https://github.com/apache/kafka/pull/8575#issuecomment-665225469
Any update?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
showuon commented on pull request #9062:
URL: https://github.com/apache/kafka/pull/9062#issuecomment-664801932
hi @feyman2016 @huxihx , could you help review this small PR? Thanks.
This is an automated message from the Apach
dajac commented on pull request #9092:
URL: https://github.com/apache/kafka/pull/9092#issuecomment-664996150
@rajinisivaram I have updated an existing test to use 1.5 instead of 2 to
verify this.
https://github.com/apache/kafka/pull/9092/files#diff-296d7b93103356535b8b891f019e4651R113.
-
vvcephei commented on pull request #9004:
URL: https://github.com/apache/kafka/pull/9004#issuecomment-664740837
Thanks for the review, @abbccdda ! I've addressed your feedback.
This is an automated message from the Apache Git
vvcephei commented on a change in pull request #9047:
URL: https://github.com/apache/kafka/pull/9047#discussion_r461143961
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java
##
@@ -275,31 +259,70 @@ private void restore
chia7712 edited a comment on pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#issuecomment-665149860
```streams_standby_replica_test``` ->
https://issues.apache.org/jira/browse/KAFKA-10287
I will take a look at ```streams_broker_bounce_test```
(https://issues.apac
cadonna commented on pull request #9087:
URL: https://github.com/apache/kafka/pull/9087#issuecomment-664621717
@abbccdda Looking at this test class again, I even think that we could set
session timeout and heartbeat interval to default for all tests. The main
motivation to reduce them was
abbccdda commented on pull request #9012:
URL: https://github.com/apache/kafka/pull/9012#issuecomment-665410633
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
abbccdda commented on a change in pull request #9004:
URL: https://github.com/apache/kafka/pull/9004#discussion_r462057744
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java
##
@@ -764,12 +764,12 @@ private void connec
cmccabe commented on pull request #9012:
URL: https://github.com/apache/kafka/pull/9012#issuecomment-665288947
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
ableegoldman opened a new pull request #9094:
URL: https://github.com/apache/kafka/pull/9094
Adds avg, min, and max e2e latency metrics at the new TRACE level. Also adds
the missing `avg` task-level metric at the INFO level.
abbccdda edited a comment on pull request #9012:
URL: https://github.com/apache/kafka/pull/9012#issuecomment-665410633
Got 2/3 green, with one jenkins job terminated unexpectedly.
https://builds.apache.org/job/kafka-pr-jdk11-scala2.13/7602/console
-
abbccdda commented on pull request #9081:
URL: https://github.com/apache/kafka/pull/9081#issuecomment-665157437
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
abbccdda commented on a change in pull request #9081:
URL: https://github.com/apache/kafka/pull/9081#discussion_r461313377
##
File path: core/src/test/scala/integration/kafka/api/TransactionsTest.scala
##
@@ -406,6 +406,26 @@ class TransactionsTest extends KafkaServerTestHarnes
mjsax commented on pull request #9047:
URL: https://github.com/apache/kafka/pull/9047#issuecomment-664773350
@vvcephei @abbccdda @guozhangwang @hachikuji -- I updated this PR according
to your discussions. Needed to squash for rebasing to resolve conflicts.
---
vvcephei commented on a change in pull request #9004:
URL: https://github.com/apache/kafka/pull/9004#discussion_r461271276
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java
##
@@ -880,40 +880,41 @@ public synchronized
cyrusv closed pull request #9093:
URL: https://github.com/apache/kafka/pull/9093
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
chia7712 commented on pull request #9066:
URL: https://github.com/apache/kafka/pull/9066#issuecomment-664764918
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
showuon commented on pull request #9096:
URL: https://github.com/apache/kafka/pull/9096#issuecomment-665472409
@ableegoldman @vahidhashemian , please help review this PR to add comments
to the assign methods. Thanks.
This is
dajac opened a new pull request #9092:
URL: https://github.com/apache/kafka/pull/9092
First tests have shown that `controller_mutation_rate` can be quite low
(e.g. around 1) in clusters with multiple tenants. At the moment, the rate is
defined as a Long which limits the possible low values
chia7712 commented on pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#issuecomment-665149860
```streams_standby_replica_test``` ->
https://issues.apache.org/jira/browse/KAFKA-10287
I will take a look at ```streams_broker_bounce_test```
--
hachikuji commented on a change in pull request #9008:
URL: https://github.com/apache/kafka/pull/9008#discussion_r461173162
##
File path: clients/src/main/resources/common/message/FetchRequest.json
##
@@ -55,35 +55,35 @@
"about": "The minimum bytes to accumulate in the r
abbccdda commented on pull request #9001:
URL: https://github.com/apache/kafka/pull/9001#issuecomment-665189199
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
bob-barrett commented on a change in pull request #9054:
URL: https://github.com/apache/kafka/pull/9054#discussion_r461721737
##
File path: core/src/main/scala/kafka/log/LogManager.scala
##
@@ -932,6 +927,7 @@ class LogManager(logDirs: Seq[File],
val logsToCheckpoint =
guozhangwang commented on pull request #9083:
URL: https://github.com/apache/kafka/pull/9083#issuecomment-664699699
cc @ableegoldman @mjsax
This is an automated message from the Apache Git Service.
To respond to the message,
abbccdda commented on a change in pull request #9047:
URL: https://github.com/apache/kafka/pull/9047#discussion_r462047068
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java
##
@@ -274,30 +252,74 @@ private void restore
vvcephei commented on pull request #9066:
URL: https://github.com/apache/kafka/pull/9066#issuecomment-665126186
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
yeralin commented on pull request #6592:
URL: https://github.com/apache/kafka/pull/6592#issuecomment-665078937
Any updates?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
sasakitoa commented on a change in pull request #9081:
URL: https://github.com/apache/kafka/pull/9081#discussion_r461264833
##
File path: core/src/test/scala/integration/kafka/api/TransactionsTest.scala
##
@@ -406,6 +406,26 @@ class TransactionsTest extends KafkaServerTestHarne
rajinisivaram commented on pull request #9092:
URL: https://github.com/apache/kafka/pull/9092#issuecomment-664990134
ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log o
mjsax commented on pull request #6592:
URL: https://github.com/apache/kafka/pull/6592#issuecomment-665304810
@yeralin -- your PR is in my review queue. Not sure how quickly I will find
time to have a look though atm -- maybe next week, but I can't promise.
guozhangwang commented on pull request #9081:
URL: https://github.com/apache/kafka/pull/9081#issuecomment-664690277
Any blocking APIs should be covered by the `max.block.ms` so I think this is
rather a bug-fix.
This is an au
mjsax commented on a change in pull request #9047:
URL: https://github.com/apache/kafka/pull/9047#discussion_r461302625
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java
##
@@ -275,31 +259,70 @@ private void restoreSta
abbccdda opened a new pull request #9095:
URL: https://github.com/apache/kafka/pull/9095
In the unit test `shouldDieOnInvalidOffsetExceptionDuringStartup` for JDK
11, we spotted a case where a global stream thread startup would stall if it
fails immediately upon the first poll. The reason
pan3793 commented on pull request #8575:
URL: https://github.com/apache/kafka/pull/8575#issuecomment-665405076
Fixed the mail thread, do you have any comments on the discussion and KIP
doc? @rhauch
This is an automated mess
ableegoldman commented on a change in pull request #9094:
URL: https://github.com/apache/kafka/pull/9094#discussion_r461993688
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/AdminClientConfig.java
##
@@ -198,7 +198,7 @@
.def
guozhangwang commented on pull request #8993:
URL: https://github.com/apache/kafka/pull/8993#issuecomment-665190912
Sorry for the long delay @vvcephei , the PR lgtm!
This is an automated message from the Apache Git Service.
T
junrao commented on pull request #8936:
URL: https://github.com/apache/kafka/pull/8936#issuecomment-665148070
I think we agreed to change the logic to do the index sanity check on index
opening.
This is an automated message
Tomasz Bradło created KAFKA-10322:
-
Summary: InMemoryWindowStore restore keys format incompatibility
(lack of sequenceNumber in keys on topic)
Key: KAFKA-10322
URL: https://issues.apache.org/jira/browse/KAFKA-1032
[
https://issues.apache.org/jira/browse/KAFKA-6733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17167207#comment-17167207
]
Badai Aqrandista commented on KAFKA-6733:
-
I did a bad merge on PR 8909. So I've
yazgoo created KAFKA-10323:
--
Summary: NullPointerException during rebalance
Key: KAFKA-10323
URL: https://issues.apache.org/jira/browse/KAFKA-10323
Project: Kafka
Issue Type: Bug
Component
[
https://issues.apache.org/jira/browse/KAFKA-9273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17167321#comment-17167321
]
Albert Lowis commented on KAFKA-9273:
-
Hi [~bbejeck] , [~sujayopensource] I am a newb
[
https://issues.apache.org/jira/browse/KAFKA-9273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17167349#comment-17167349
]
Bill Bejeck commented on KAFKA-9273:
Hi [~albert02lowis],
Thanks for your interes
Tommy Becker created KAFKA-10324:
Summary: Pre-0.11 consumers can get stuck when messages are
downconverted from V2 format
Key: KAFKA-10324
URL: https://issues.apache.org/jira/browse/KAFKA-10324
Proje
[
https://issues.apache.org/jira/browse/KAFKA-10324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17167357#comment-17167357
]
Tommy Becker commented on KAFKA-10324:
--
We have some legacy applications whose cons
[
https://issues.apache.org/jira/browse/KAFKA-10324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17167369#comment-17167369
]
Ismael Juma commented on KAFKA-10324:
-
Thanks for the report. Looks like this issue
[
https://issues.apache.org/jira/browse/KAFKA-10324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17167371#comment-17167371
]
Tommy Becker commented on KAFKA-10324:
--
Thanks for the response [~ijuma]. Yes, thes
[
https://issues.apache.org/jira/browse/KAFKA-10324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17167387#comment-17167387
]
Jason Gustafson commented on KAFKA-10324:
-
[~twbecker] Thanks for the report. I'
gwenshap commented on pull request #9054:
URL: https://github.com/apache/kafka/pull/9054#issuecomment-665773125
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please lo
soarez commented on pull request #9000:
URL: https://github.com/apache/kafka/pull/9000#issuecomment-665668720
@mjsax what can we do to proceed?
This is an automated message from the Apache Git Service.
To respond to the messa
badaiaqrandista commented on pull request #4807:
URL: https://github.com/apache/kafka/pull/4807#issuecomment-665660018
Closing this PR as it has been superseded by PR 9099
(https://github.com/apache/kafka/pull/9099).
This is
chia7712 commented on pull request #9096:
URL: https://github.com/apache/kafka/pull/9096#issuecomment-665504255
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please lo
mumrah commented on a change in pull request #9012:
URL: https://github.com/apache/kafka/pull/9012#discussion_r462352682
##
File path:
core/src/main/scala/kafka/server/BrokerToControllerChannelManager.scala
##
@@ -0,0 +1,188 @@
+/*
+ * Licensed to the Apache Software Foundatio
mumrah commented on a change in pull request #9008:
URL: https://github.com/apache/kafka/pull/9008#discussion_r462364719
##
File path:
clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java
##
@@ -366,225 +255,128 @@ public FetchResponse(Errors error,
abbccdda commented on pull request #9012:
URL: https://github.com/apache/kafka/pull/9012#issuecomment-665757647
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
guozhangwang commented on pull request #9087:
URL: https://github.com/apache/kafka/pull/9087#issuecomment-665779451
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
badaiaqrandista opened a new pull request #9099:
URL: https://github.com/apache/kafka/pull/9099
Implementation of KIP-431 - Support of printing additional ConsumerRecord
fields in DefaultMessageFormatter
https://cwiki.apache.org/confluence/display/KAFKA/KIP-431%3A+Support+of+printin
cadonna commented on a change in pull request #9094:
URL: https://github.com/apache/kafka/pull/9094#discussion_r462327050
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java
##
@@ -227,6 +234,14 @@ protected Bytes keyBytes(fin
[
https://issues.apache.org/jira/browse/KAFKA-10324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17167400#comment-17167400
]
Tommy Becker commented on KAFKA-10324:
--
[~hachikuji] wrt why the broker does not se
mumrah commented on pull request #9008:
URL: https://github.com/apache/kafka/pull/9008#issuecomment-665795947
I ran a console consumer perf test (at @hachikuji's suggestion) and took a
profile.
