hachikuji commented on a change in pull request #9047: URL: https://github.com/apache/kafka/pull/9047#discussion_r461114945
########## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java ########## @@ -292,21 +278,36 @@ private void restoreState(final StateRestoreCallback stateRestoreCallback, while (offset < highWatermark) { try { - final ConsumerRecords<byte[], byte[]> records = globalConsumer.poll(pollTime); + final ConsumerRecords<byte[], byte[]> records = + globalConsumer.poll(pollTimePlusRequestTimeoutPlusTaskTimeout); Review comment: It does seem a bit weird here to add in the request timeout. Not sure I follow the reasoning behind that... ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org