showuon commented on pull request #8885:
URL: https://github.com/apache/kafka/pull/8885#issuecomment-661675572
hi @omkreddy , looks like @hachikuji is not available recently. Do you think
we still need other people's comment? I think this change should be pretty
straightforward and safe. T
showuon commented on pull request #9029:
URL: https://github.com/apache/kafka/pull/9029#issuecomment-661675952
Thanks @ning2008wisc ! @mimaison , do you have any comments for this PR?
Thanks.
This is an automated message fro
[
https://issues.apache.org/jira/browse/KAFKA-8037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161796#comment-17161796
]
Matthias J. Sax commented on KAFKA-8037:
I believe that the optimization is still
mjsax commented on a change in pull request #9047:
URL: https://github.com/apache/kafka/pull/9047#discussion_r457889242
##
File path: streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java
##
@@ -523,6 +524,8 @@
public static final String STATE_DIR_CONFIG = "sta
mjsax opened a new pull request #9047:
URL: https://github.com/apache/kafka/pull/9047
- part of KIP-572
- removed the usage of `retries` in `GlobalStateManger`
- instead of retries the new `task.timeout.ms` config is used
Second PR for KIP-572 (cf. #8864)
Call for revi
[
https://issues.apache.org/jira/browse/KAFKA-9724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161857#comment-17161857
]
bright.zhou commented on KAFKA-9724:
When merge this to Kafka 2.4.x? Have any plan?
rajinisivaram commented on a change in pull request #8768:
URL: https://github.com/apache/kafka/pull/8768#discussion_r457944837
##
File path:
clients/src/main/java/org/apache/kafka/common/metrics/MetricConfig.java
##
@@ -97,5 +99,13 @@ public MetricConfig recordLevel(Sensor.Re
rajinisivaram commented on pull request #8768:
URL: https://github.com/apache/kafka/pull/8768#issuecomment-661729947
ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log o
rajinisivaram merged pull request #9044:
URL: https://github.com/apache/kafka/pull/9044
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
rajinisivaram commented on pull request #9044:
URL: https://github.com/apache/kafka/pull/9044#issuecomment-661749475
@omkreddy Thanks for the review, merging to trunk.
This is an automated message from the Apache Git Service.
[
https://issues.apache.org/jira/browse/KAFKA-10279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rajini Sivaram resolved KAFKA-10279.
Reviewer: Manikumar
Resolution: Fixed
> Allow dynamic update of certificates with ad
rajinisivaram commented on pull request #8933:
URL: https://github.com/apache/kafka/pull/8933#issuecomment-661761899
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, plea
kowshik commented on a change in pull request #9001:
URL: https://github.com/apache/kafka/pull/9001#discussion_r457809543
##
File path: clients/src/main/java/org/apache/kafka/clients/admin/Admin.java
##
@@ -1214,6 +1214,70 @@ default AlterClientQuotasResult
alterClientQuotas(C
kowshik commented on a change in pull request #9001:
URL: https://github.com/apache/kafka/pull/9001#discussion_r457986837
##
File path:
core/src/test/scala/unit/kafka/server/UpdateFinalizedFeaturesTest.scala
##
@@ -0,0 +1,450 @@
+package kafka.server
Review comment:
Do
kowshik commented on a change in pull request #9001:
URL: https://github.com/apache/kafka/pull/9001#discussion_r457821195
##
File path:
clients/src/main/java/org/apache/kafka/common/requests/ApiVersionsResponse.java
##
@@ -177,15 +214,33 @@ public static ApiVersionsResponse
c
rajinisivaram commented on a change in pull request #8968:
URL: https://github.com/apache/kafka/pull/8968#discussion_r457953384
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/CreatePartitionsOptions.java
##
@@ -48,4 +49,21 @@ public CreatePartitionsOptions
omkreddy commented on pull request #9046:
URL: https://github.com/apache/kafka/pull/9046#issuecomment-661811555
@rajinisivaram Thanks for the review. Merging to trunk.
This is an automated message from the Apache Git Service.
omkreddy closed pull request #9046:
URL: https://github.com/apache/kafka/pull/9046
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
[
https://issues.apache.org/jira/browse/KAFKA-7025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Paulo César updated KAFKA-7025:
---
Comment: was deleted
(was: Have progress in this issue?
* [|https://issues.apache.org/jira/secure/Ad
[
https://issues.apache.org/jira/browse/KAFKA-7025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161979#comment-17161979
]
Paulo César commented on KAFKA-7025:
Have progress in this issue?
* [|https://issues
[
https://issues.apache.org/jira/browse/KAFKA-7025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161978#comment-17161978
]
Paulo César commented on KAFKA-7025:
Have progress in this issue?
> Android client s
dajac commented on a change in pull request #8968:
URL: https://github.com/apache/kafka/pull/8968#discussion_r458059973
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/CreatePartitionsOptions.java
##
@@ -30,6 +30,7 @@
public class CreatePartitionsOptions ex
dajac commented on pull request #8968:
URL: https://github.com/apache/kafka/pull/8968#issuecomment-661828919
@rajinisivaram Thanks for the review. I have updated the PR to address your
feedback. Regarding the test case that you suggested, I have added test cases
but I am 100% sure that the
omkreddy commented on pull request #9022:
URL: https://github.com/apache/kafka/pull/9022#issuecomment-661829854
ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
serjchebotarev commented on a change in pull request #9028:
URL: https://github.com/apache/kafka/pull/9028#discussion_r458064223
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/ResetIntegrationTest.java
##
@@ -68,52 +92,224 @@ public void after() throw
chia7712 commented on pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#issuecomment-661862318
@junrao Could you run system tests on both trunk and this PR?
the tests which fail frequently on my local are shown below.
1. transactions_test.py #9026
1. group_m
ijuma commented on pull request #9026:
URL: https://github.com/apache/kafka/pull/9026#issuecomment-661865679
Is this ready to be merged?
This is an automated message from the Apache Git Service.
To respond to the message, ple
[
https://issues.apache.org/jira/browse/KAFKA-7025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ismael Juma updated KAFKA-7025:
---
Attachment: image-2020-07-21-06-42-03-140.png
> Android client support
> --
>
>
[
https://issues.apache.org/jira/browse/KAFKA-7025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17162049#comment-17162049
]
Ismael Juma commented on KAFKA-7025:
[~Pccesar] What Android API do you provide suppo
urbandan commented on pull request #8957:
URL: https://github.com/apache/kafka/pull/8957#issuecomment-661892966
ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
rajinisivaram commented on pull request #8954:
URL: https://github.com/apache/kafka/pull/8954#issuecomment-661906846
Connect test failure unrelated, merging to trunk.
This is an automated message from the Apache Git Service.
rajinisivaram merged pull request #8954:
URL: https://github.com/apache/kafka/pull/8954
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
vvcephei commented on pull request #9047:
URL: https://github.com/apache/kafka/pull/9047#issuecomment-661924465
Test failures:
```
kafka.api.PlaintextAdminIntegrationTest.testAlterReplicaLogDirs failed, log
available in
/home/jenkins/jenkins-slave/workspace/kafka-pr-jdk11-scala2.13/c
vvcephei commented on a change in pull request #9047:
URL: https://github.com/apache/kafka/pull/9047#discussion_r458173651
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java
##
@@ -184,32 +217,21 @@ public void register
rajinisivaram commented on pull request #8768:
URL: https://github.com/apache/kafka/pull/8768#issuecomment-661935552
There is one test failure in
`kafka.network.DynamicConnectionQuotaTest.testDynamicListenerConnectionCreationRateQuota`
that is related to the PR.
-
[
https://issues.apache.org/jira/browse/KAFKA-7516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17162167#comment-17162167
]
Paulo César commented on KAFKA-7516:
Have progress in this issue?
* [|https://issues
[
https://issues.apache.org/jira/browse/KAFKA-7516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17162167#comment-17162167
]
Paulo César edited comment on KAFKA-7516 at 7/21/20, 4:48 PM:
-
rajinisivaram commented on pull request #8933:
URL: https://github.com/apache/kafka/pull/8933#issuecomment-661986912
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, plea
mjsax commented on a change in pull request #8864:
URL: https://github.com/apache/kafka/pull/8864#discussion_r458266432
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaStatusBackingStore.java
##
@@ -148,6 +148,7 @@ public KafkaStatusBackingSto
[
https://issues.apache.org/jira/browse/KAFKA-10297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-10297:
Description:
In 2.7.0 release, producer config `retries` gets deprecated via KIP-572.
Con
kkonstantine opened a new pull request #9048:
URL: https://github.com/apache/kafka/pull/9048
https://github.com/classgraph/classgraph is a more recent and more actively
developed classpath scanning library.
I'll be doing some testing and performance benchmarking before I open this
[
https://issues.apache.org/jira/browse/KAFKA-10271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dima R updated KAFKA-10271:
---
Summary: Performance regression while fetching a key from a single
partition (was: Performance degradation
abbccdda opened a new pull request #9049:
URL: https://github.com/apache/kafka/pull/9049
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrad
jamiealquiza commented on pull request #1596:
URL: https://github.com/apache/kafka/pull/1596#issuecomment-662051029
Found this issue while browsing for something else, but fwiw my
[topicmappr](https://github.com/DataDog/kafka-kit/tree/master/cmd/topicmappr)
cli tool does exactly this: `top
mjsax commented on pull request #8864:
URL: https://github.com/apache/kafka/pull/8864#issuecomment-662055495
Thanks @vvcephei -- I don't think we need tickets. I will use this PR as
reference itself to make sure we address all TODO that are added.
-
mjsax merged pull request #8864:
URL: https://github.com/apache/kafka/pull/8864
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[
https://issues.apache.org/jira/browse/KAFKA-7106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Roesler updated KAFKA-7106:
Comment: was deleted
(was: guozhangwang commented on pull request #7670: KAFKA-7106: Not hide the
John Roesler created KAFKA-10298:
Summary: Replace Windows with a proper interface
Key: KAFKA-10298
URL: https://issues.apache.org/jira/browse/KAFKA-10298
Project: Kafka
Issue Type: Improveme
mjsax commented on a change in pull request #8864:
URL: https://github.com/apache/kafka/pull/8864#discussion_r458345947
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java
##
@@ -74,6 +74,7 @@
private final OffsetCh
mjsax commented on a change in pull request #8864:
URL: https://github.com/apache/kafka/pull/8864#discussion_r458346124
##
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImplTest.java
##
@@ -612,6 +612,7 @@ public boolean lockGl
abbccdda commented on a change in pull request #9012:
URL: https://github.com/apache/kafka/pull/9012#discussion_r458356891
##
File path:
core/src/main/scala/kafka/server/BrokerToControllerChannelManager.scala
##
@@ -0,0 +1,211 @@
+/*
+ * Licensed to the Apache Software Foundat
abbccdda commented on a change in pull request #9012:
URL: https://github.com/apache/kafka/pull/9012#discussion_r458356772
##
File path:
core/src/main/scala/kafka/server/BrokerToControllerChannelManager.scala
##
@@ -0,0 +1,211 @@
+/*
+ * Licensed to the Apache Software Foundat
mumrah commented on a change in pull request #9008:
URL: https://github.com/apache/kafka/pull/9008#discussion_r458382935
##
File path:
clients/src/main/java/org/apache/kafka/common/protocol/RecordsWriter.java
##
@@ -0,0 +1,141 @@
+/*
+ * Licensed to the Apache Software Foundat
ableegoldman commented on a change in pull request #8964:
URL: https://github.com/apache/kafka/pull/8964#discussion_r458282421
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorStateManager.java
##
@@ -454,6 +456,41 @@ public void flush(
mjsax commented on a change in pull request #9047:
URL: https://github.com/apache/kafka/pull/9047#discussion_r458481231
##
File path: docs/streams/developer-guide/config-streams.html
##
@@ -203,7 +203,7 @@ bootstrap.serverscommit.interval.ms
Low
-The fr
mjsax commented on a change in pull request #9047:
URL: https://github.com/apache/kafka/pull/9047#discussion_r458481315
##
File path: docs/streams/developer-guide/config-streams.html
##
@@ -308,15 +308,10 @@ bootstrap.serversThe replication factor for changelog topics and
repa
mjsax commented on a change in pull request #9047:
URL: https://github.com/apache/kafka/pull/9047#discussion_r458481381
##
File path: docs/streams/developer-guide/config-streams.html
##
@@ -326,13 +321,18 @@ bootstrap.serversstate.cleanup.delay.ms
Low
mjsax commented on a change in pull request #9047:
URL: https://github.com/apache/kafka/pull/9047#discussion_r458481626
##
File path: docs/upgrade.html
##
@@ -23,8 +23,8 @@ Notable changes in 2
The configuration parameter retries is deprecated for the
producer, admin, a
mjsax commented on a change in pull request #9047:
URL: https://github.com/apache/kafka/pull/9047#discussion_r458481521
##
File path: docs/streams/upgrade-guide.html
##
@@ -95,11 +95,12 @@ Streams API
-The configuration parameter retries is deprecated in
mjsax commented on a change in pull request #9047:
URL: https://github.com/apache/kafka/pull/9047#discussion_r458481794
##
File path:
streams/src/main/java/org/apache/kafka/streams/errors/RetryableErrorException.java
##
@@ -0,0 +1,26 @@
+/*
+ * Licensed to the Apache Software
mjsax commented on a change in pull request #9047:
URL: https://github.com/apache/kafka/pull/9047#discussion_r458482045
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java
##
@@ -58,30 +60,33 @@
* of Global State Store
mjsax commented on a change in pull request #9047:
URL: https://github.com/apache/kafka/pull/9047#discussion_r458482408
##
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImplTest.java
##
@@ -612,72 +617,521 @@ public boolean loc
mjsax commented on a change in pull request #9047:
URL: https://github.com/apache/kafka/pull/9047#discussion_r458482803
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java
##
@@ -131,11 +135,40 @@ public void setGlobalPr
mjsax commented on a change in pull request #9047:
URL: https://github.com/apache/kafka/pull/9047#discussion_r458482846
##
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImplTest.java
##
@@ -612,72 +617,521 @@ public boolean loc
mjsax commented on a change in pull request #9047:
URL: https://github.com/apache/kafka/pull/9047#discussion_r458483023
##
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImplTest.java
##
@@ -612,72 +617,521 @@ public boolean loc
mjsax commented on a change in pull request #9047:
URL: https://github.com/apache/kafka/pull/9047#discussion_r458483259
##
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImplTest.java
##
@@ -612,72 +617,521 @@ public boolean loc
mjsax commented on pull request #9047:
URL: https://github.com/apache/kafka/pull/9047#issuecomment-662192375
@vvcephei Updated this PR.
This is an automated message from the Apache Git Service.
To respond to the message, plea
jeffkbkim opened a new pull request #9050:
URL: https://github.com/apache/kafka/pull/9050
JIRA: https://issues.apache.org/jira/browse/KAFKA-10193
* add `preempt(): Unit` method for all `ControllerEvent` so that all events
(and future events) must implement it
* for events that have ca
huxihx opened a new pull request #9051:
URL: https://github.com/apache/kafka/pull/9051
https://issues.apache.org/jira/browse/KAFKA-10268
Currently, ConfigCommand's `--delete-config` API does not restore the config
to default value, no matter at broker-level or broker-default level. B
[
https://issues.apache.org/jira/browse/KAFKA-10269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17162444#comment-17162444
]
huxihx commented on KAFKA-10269:
[~d-t-w] Thanks for reporting and feel free to take thi
[
https://issues.apache.org/jira/browse/KAFKA-9343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shuo Zhang resolved KAFKA-9343.
---
> Add ps command for Kafka and zookeeper process on z/OS.
> -
[
https://issues.apache.org/jira/browse/KAFKA-10134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jerry Wei updated KAFKA-10134:
--
Attachment: consumer4.log.2020-07-22.log
> High CPU issue during rebalance in Kafka consumer after upg
[
https://issues.apache.org/jira/browse/KAFKA-10134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jerry Wei updated KAFKA-10134:
--
Attachment: consumer5.log.2020-07-22.log
> High CPU issue during rebalance in Kafka consumer after upg
[
https://issues.apache.org/jira/browse/KAFKA-10134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jerry Wei updated KAFKA-10134:
--
Attachment: (was: consumer4.log.2020-07-22.log)
> High CPU issue during rebalance in Kafka consume
[
https://issues.apache.org/jira/browse/KAFKA-10134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17162450#comment-17162450
]
Jerry Wei commented on KAFKA-10134:
---
[~guozhang] refer to the attached file (consumer5
huxihx commented on pull request #9051:
URL: https://github.com/apache/kafka/pull/9051#issuecomment-662260819
@rajinisivaram Please review this patch. Thanks.
This is an automated message from the Apache Git Service.
To respo
76 matches
Mail list logo
