[GitHub] [kafka] rajinisivaram commented on a change in pull request #8968: KAFKA-10164; Throttle Create Topic, Create Partition and Delete Topic Operations (KIP-599, Part II, Admin Changes)

[GitBox]

rajinisivaram commented on a change in pull request #8968:
URL: https://github.com/apache/kafka/pull/8968#discussion_r457953384



##########
File path: 
clients/src/main/java/org/apache/kafka/clients/admin/CreatePartitionsOptions.java
##########
@@ -48,4 +49,21 @@ public CreatePartitionsOptions validateOnly(boolean 
validateOnly) {
         this.validateOnly = validateOnly;
         return this;
     }
-}
\ No newline at end of file
+
+    /**
+     * Set the retry QuotaViolatedException to indicate whether 
QuotaViolatedException

Review comment:
       Several comments refer to QuotaViolatedException which is not an actual 
exception

##########
File path: 
clients/src/main/java/org/apache/kafka/clients/admin/CreatePartitionsOptions.java
##########
@@ -30,6 +30,7 @@
 public class CreatePartitionsOptions extends 
AbstractOptions<CreatePartitionsOptions> {
 
     private boolean validateOnly = false;
+    private boolean retryQuotaViolatedException = true;

Review comment:
       Since the exception being retried is called 
ThrottlingQuotaExceededException, maybe this should say `retryOnQuotaViolation` 
or something like that without referring to the exception?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org