[jira] [Created] (KAFKA-10226) KStream without SASL information should return error in confluent cloud

2020-07-02 Thread Werner Daehn (Jira)
Werner Daehn created KAFKA-10226: Summary: KStream without SASL information should return error in confluent cloud Key: KAFKA-10226 URL: https://issues.apache.org/jira/browse/KAFKA-10226 Project: Kafk

[GitHub] [kafka] mimaison commented on a change in pull request #8921: KAFKA-10160: Kafka MM2 consumer configuration

2020-07-02 Thread GitBox
mimaison commented on a change in pull request #8921: URL: https://github.com/apache/kafka/pull/8921#discussion_r448872352 ## File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorConnectorConfig.java ## @@ -67,6 +67,8 @@ protected static final Str

[jira] [Created] (KAFKA-10227) Enforce cleanup policy to only contain compact or delete once

2020-07-02 Thread Mickael Maison (Jira)
Mickael Maison created KAFKA-10227: -- Summary: Enforce cleanup policy to only contain compact or delete once Key: KAFKA-10227 URL: https://issues.apache.org/jira/browse/KAFKA-10227 Project: Kafka

[GitHub] [kafka] mimaison commented on a change in pull request #8604: KIP-597: MirrorMaker2 internal topics Formatters

2020-07-02 Thread GitBox
mimaison commented on a change in pull request #8604: URL: https://github.com/apache/kafka/pull/8604#discussion_r448979596 ## File path: core/src/main/scala/kafka/tools/ConsoleConsumer.scala ## @@ -309,7 +308,7 @@ object ConsoleConsumer extends Logging { formatterArgs.s

[GitHub] [kafka] mimaison commented on a change in pull request #8604: KIP-597: MirrorMaker2 internal topics Formatters

2020-07-02 Thread GitBox
mimaison commented on a change in pull request #8604: URL: https://github.com/apache/kafka/pull/8604#discussion_r448980591 ## File path: core/src/main/scala/kafka/tools/ConsoleConsumer.scala ## @@ -466,7 +465,9 @@ class DefaultMessageFormatter extends MessageFormatter { var

[GitHub] [kafka] mimaison commented on a change in pull request #8604: KIP-597: MirrorMaker2 internal topics Formatters

2020-07-02 Thread GitBox
mimaison commented on a change in pull request #8604: URL: https://github.com/apache/kafka/pull/8604#discussion_r448982505 ## File path: core/src/main/scala/kafka/tools/ConsoleConsumer.scala ## @@ -560,20 +561,18 @@ class LoggingMessageFormatter extends MessageFormatter with L

[GitHub] [kafka] mimaison commented on pull request #8604: KIP-597: MirrorMaker2 internal topics Formatters

2020-07-02 Thread GitBox
mimaison commented on pull request #8604: URL: https://github.com/apache/kafka/pull/8604#issuecomment-652991020 @kkonstantine I see you approved but did not merge. Was there any reason? This is an automated message from the A

[jira] [Comment Edited] (KAFKA-9247) ERROR - NoSuchMethodError: org.apache.zookeeper.ZooKeeper.multi

2020-07-02 Thread Amit (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17149509#comment-17149509 ] Amit edited comment on KAFKA-9247 at 7/2/20, 1:33 PM: -- [~ijuma]  Ple

[GitHub] [kafka] vvcephei commented on pull request #8963: KAFKA-10017: fix flaky EosBetaUpgradeIntegrationTest

2020-07-02 Thread GitBox
vvcephei commented on pull request #8963: URL: https://github.com/apache/kafka/pull/8963#issuecomment-653036631 Test this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] vvcephei commented on a change in pull request #8963: KAFKA-10017: fix flaky EosBetaUpgradeIntegrationTest

2020-07-02 Thread GitBox
vvcephei commented on a change in pull request #8963: URL: https://github.com/apache/kafka/pull/8963#discussion_r449041784 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/EosBetaUpgradeIntegrationTest.java ## @@ -837,6 +866,11 @@ public void init(final

[GitHub] [kafka] kkonstantine commented on pull request #8604: KIP-597: MirrorMaker2 internal topics Formatters

2020-07-02 Thread GitBox
kkonstantine commented on pull request #8604: URL: https://github.com/apache/kafka/pull/8604#issuecomment-653051628 If it’s a committer’s PR I think the common practice is to leave the responsibility of merging to the author of the PR. +1 --

[GitHub] [kafka] mimaison commented on pull request #8295: KAFKA-9627: Replace ListOffset request/response with automated protocol

2020-07-02 Thread GitBox
mimaison commented on pull request #8295: URL: https://github.com/apache/kafka/pull/8295#issuecomment-653096791 @dajac I've rebased on trunk This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] mimaison commented on pull request #8604: KIP-597: MirrorMaker2 internal topics Formatters

2020-07-02 Thread GitBox
mimaison commented on pull request #8604: URL: https://github.com/apache/kafka/pull/8604#issuecomment-653099210 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] tombentley opened a new pull request #8975: MINOR: Document that max.block.ms affects some transaction methods

2020-07-02 Thread GitBox
tombentley opened a new pull request #8975: URL: https://github.com/apache/kafka/pull/8975 The documentation for max.block.ms said it affected only send() and partitionsFor(), but it actually also affects initTransactions(), abortTransaction() and commitTransaction(). So rework the

[GitHub] [kafka] tombentley commented on pull request #8975: MINOR: Document that max.block.ms affects some transaction methods

2020-07-02 Thread GitBox
tombentley commented on pull request #8975: URL: https://github.com/apache/kafka/pull/8975#issuecomment-653110666 @hachikuji please could you review this? This is an automated message from the Apache Git Service. To respond t

[GitHub] [kafka] jeqo opened a new pull request #8976: KIP-617: Allow Kafka Streams State Stores to be iterated backwards

2020-07-02 Thread GitBox
jeqo opened a new pull request #8976: URL: https://github.com/apache/kafka/pull/8976 KIP reference implementation. *Summary of testing strategy (including rationale) for the feature or bug fix. Unit and/or integration tests are expected for any behaviour change and system tes

[GitHub] [kafka] jeqo commented on pull request #8634: Reverse iterator for WindowStore

2020-07-02 Thread GitBox
jeqo commented on pull request #8634: URL: https://github.com/apache/kafka/pull/8634#issuecomment-653115501 Closing in favor of https://github.com/apache/kafka/pull/8976 This is an automated message from the Apache Git Servic

[GitHub] [kafka] jeqo closed pull request #8634: Reverse iterator for WindowStore

2020-07-02 Thread GitBox
jeqo closed pull request #8634: URL: https://github.com/apache/kafka/pull/8634 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[jira] [Created] (KAFKA-10228) producer: NETWORK_EXCEPTION is thrown instead of a request timeout

2020-07-02 Thread Christian Becker (Jira)
Christian Becker created KAFKA-10228: Summary: producer: NETWORK_EXCEPTION is thrown instead of a request timeout Key: KAFKA-10228 URL: https://issues.apache.org/jira/browse/KAFKA-10228 Project: K

[jira] [Updated] (KAFKA-10228) producer: NETWORK_EXCEPTION is thrown instead of a request timeout

2020-07-02 Thread Christian Becker (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Becker updated KAFKA-10228: - Description: We're currently seeing an issue with the java client (producer), when messa

[jira] [Updated] (KAFKA-10228) producer: NETWORK_EXCEPTION is thrown instead of a request timeout

2020-07-02 Thread Christian Becker (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Becker updated KAFKA-10228: - Description: We're currently seeing an issue with the java client (producer), when messa

[jira] [Updated] (KAFKA-10228) producer: NETWORK_EXCEPTION is thrown instead of a request timeout

2020-07-02 Thread Christian Becker (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Becker updated KAFKA-10228: - Description: We're currently seeing an issue with the java client (producer), when messa

[GitHub] [kafka] jmalizia-branch commented on a change in pull request #8936: KAFKA-10207: Fixed padded timeindex causing premature data deletion

2020-07-02 Thread GitBox
jmalizia-branch commented on a change in pull request #8936: URL: https://github.com/apache/kafka/pull/8936#discussion_r449181257 ## File path: core/src/test/scala/unit/kafka/log/TimeIndexTest.scala ## @@ -148,5 +148,39 @@ class TimeIndexTest { idx.close() } -} + /

[jira] [Created] (KAFKA-10229) Kafka stream dies when earlier shut down node leaves group, no errors logged on client

2020-07-02 Thread Raman Gupta (Jira)
Raman Gupta created KAFKA-10229: --- Summary: Kafka stream dies when earlier shut down node leaves group, no errors logged on client Key: KAFKA-10229 URL: https://issues.apache.org/jira/browse/KAFKA-10229

[jira] [Updated] (KAFKA-10229) Kafka stream dies for no apparent reason, no errors logged on client or server

2020-07-02 Thread Raman Gupta (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raman Gupta updated KAFKA-10229: Summary: Kafka stream dies for no apparent reason, no errors logged on client or server (was: Kaf

[GitHub] [kafka] hachikuji commented on pull request #8970: MINOR: Improve logging around initial log loading

2020-07-02 Thread GitBox
hachikuji commented on pull request #8970: URL: https://github.com/apache/kafka/pull/8970#issuecomment-653151889 @ijuma Thanks for reviewing. Comments addressed. This is an automated message from the Apache Git Service. To re

[GitHub] [kafka] ijuma commented on a change in pull request #8970: MINOR: Improve logging around initial log loading

2020-07-02 Thread GitBox
ijuma commented on a change in pull request #8970: URL: https://github.com/apache/kafka/pull/8970#discussion_r449193775 ## File path: core/src/main/scala/kafka/log/LogManager.scala ## @@ -379,7 +396,7 @@ class LogManager(logDirs: Seq[File], threadPools.foreach(_.shutdown

[GitHub] [kafka] abbccdda commented on pull request #8963: KAFKA-10017: fix flaky EosBetaUpgradeIntegrationTest

2020-07-02 Thread GitBox
abbccdda commented on pull request #8963: URL: https://github.com/apache/kafka/pull/8963#issuecomment-653158158 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [kafka] abbccdda commented on pull request #8712: KAFKA-10006: Don't create internal topics when LeaderNotAvailableException

2020-07-02 Thread GitBox
abbccdda commented on pull request #8712: URL: https://github.com/apache/kafka/pull/8712#issuecomment-653159433 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[jira] [Commented] (KAFKA-9831) Failing test: EosIntegrationTest.shouldNotViolateEosIfOneTaskFailsWithState[exactly_once_beta]

2020-07-02 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17150516#comment-17150516 ] Boyang Chen commented on KAFKA-9831: Failed again:  [https://builds.apache.org/job/k

[GitHub] [kafka] abbccdda commented on pull request #8712: KAFKA-10006: Don't create internal topics when LeaderNotAvailableException

2020-07-02 Thread GitBox
abbccdda commented on pull request #8712: URL: https://github.com/apache/kafka/pull/8712#issuecomment-653159837 Tracked in https://issues.apache.org/jira/browse/KAFKA-9831 This is an automated message from the Apache Git Ser

[jira] [Assigned] (KAFKA-6520) When a Kafka Stream can't communicate with the server, it's Status stays RUNNING

2020-07-02 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Chen reassigned KAFKA-6520: -- Assignee: Milind Jain > When a Kafka Stream can't communicate with the server, it's Status sta

[jira] [Assigned] (KAFKA-6520) When a Kafka Stream can't communicate with the server, it's Status stays RUNNING

2020-07-02 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Chen reassigned KAFKA-6520: -- Assignee: Vince Mu (was: Milind Jain) > When a Kafka Stream can't communicate with the server

[jira] [Commented] (KAFKA-6520) When a Kafka Stream can't communicate with the server, it's Status stays RUNNING

2020-07-02 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17150519#comment-17150519 ] Boyang Chen commented on KAFKA-6520: [~VinceMu] Gave you contributor permission and a

[GitHub] [kafka] ableegoldman commented on pull request #8963: KAFKA-10017: fix flaky EosBetaUpgradeIntegrationTest

2020-07-02 Thread GitBox
ableegoldman commented on pull request #8963: URL: https://github.com/apache/kafka/pull/8963#issuecomment-653176567 > Seems still got 3 failures, while 1/3 green @abbccdda Did the EosBetaUpgradeIntegrationTest fail 3 times? Did you get the link or stacktrace before kicking off tests

[GitHub] [kafka] ableegoldman commented on a change in pull request #8963: KAFKA-10017: fix flaky EosBetaUpgradeIntegrationTest

2020-07-02 Thread GitBox
ableegoldman commented on a change in pull request #8963: URL: https://github.com/apache/kafka/pull/8963#discussion_r449219621 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/EosBetaUpgradeIntegrationTest.java ## @@ -837,6 +866,11 @@ public void init(f

[GitHub] [kafka] ableegoldman commented on a change in pull request #8963: KAFKA-10017: fix flaky EosBetaUpgradeIntegrationTest

2020-07-02 Thread GitBox
ableegoldman commented on a change in pull request #8963: URL: https://github.com/apache/kafka/pull/8963#discussion_r449220447 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/EosBetaUpgradeIntegrationTest.java ## @@ -147,6 +152,25 @@ private final

[GitHub] [kafka] ableegoldman commented on a change in pull request #8963: KAFKA-10017: fix flaky EosBetaUpgradeIntegrationTest

2020-07-02 Thread GitBox
ableegoldman commented on a change in pull request #8963: URL: https://github.com/apache/kafka/pull/8963#discussion_r449223048 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/EosBetaUpgradeIntegrationTest.java ## @@ -837,6 +866,11 @@ public void init(f

[GitHub] [kafka] ableegoldman commented on a change in pull request #8962: KAFKA-10166: checkpoint recycled standbys and ignore empty rocksdb base directory

2020-07-02 Thread GitBox
ableegoldman commented on a change in pull request #8962: URL: https://github.com/apache/kafka/pull/8962#discussion_r449227732 ## File path: streams/src/test/java/org/apache/kafka/streams/state/internals/OffsetCheckpointTest.java ## @@ -91,20 +94,38 @@ public void shouldSkipNe

[GitHub] [kafka] ableegoldman edited a comment on pull request #8963: KAFKA-10017: fix flaky EosBetaUpgradeIntegrationTest

2020-07-02 Thread GitBox
ableegoldman edited a comment on pull request #8963: URL: https://github.com/apache/kafka/pull/8963#issuecomment-653176567 > Seems still got 3 failures, while 1/3 green @abbccdda Did the EosBetaUpgradeIntegrationTest fail 3 times? Did you get the link or stacktrace before kicking off

[GitHub] [kafka] abbccdda commented on a change in pull request #8795: KAFKA-10095: Simplify calls in LogCleanerManagerTest

2020-07-02 Thread GitBox
abbccdda commented on a change in pull request #8795: URL: https://github.com/apache/kafka/pull/8795#discussion_r449259997 ## File path: core/src/test/scala/unit/kafka/log/LogCleanerManagerTest.scala ## @@ -571,12 +571,12 @@ class LogCleanerManagerTest extends Logging { cl

[GitHub] [kafka] abbccdda commented on pull request #8295: KAFKA-9627: Replace ListOffset request/response with automated protocol

2020-07-02 Thread GitBox
abbccdda commented on pull request #8295: URL: https://github.com/apache/kafka/pull/8295#issuecomment-653215499 retest this please This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [kafka] abbccdda commented on pull request #8712: KAFKA-10006: Don't create internal topics when LeaderNotAvailableException

2020-07-02 Thread GitBox
abbccdda commented on pull request #8712: URL: https://github.com/apache/kafka/pull/8712#issuecomment-653216172 Still only flaky tests are failing, merging. This is an automated message from the Apache Git Service. To respond

[GitHub] [kafka] abbccdda merged pull request #8712: KAFKA-10006: Don't create internal topics when LeaderNotAvailableException

2020-07-02 Thread GitBox
abbccdda merged pull request #8712: URL: https://github.com/apache/kafka/pull/8712 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[jira] [Commented] (KAFKA-10228) producer: NETWORK_EXCEPTION is thrown instead of a request timeout

2020-07-02 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17150583#comment-17150583 ] Chia-Ping Tsai commented on KAFKA-10228: It seems the timeout is processed by cl

[GitHub] [kafka] chia7712 commented on pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

2020-07-02 Thread GitBox
chia7712 commented on pull request #8657: URL: https://github.com/apache/kafka/pull/8657#issuecomment-653224351 > core/transactions_test core/downgrade_test core/upgrade_test those are flaky on my local as well. @junrao Should I fix all flaky before merging this PR?

[GitHub] [kafka] junrao commented on pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

2020-07-02 Thread GitBox
junrao commented on pull request #8657: URL: https://github.com/apache/kafka/pull/8657#issuecomment-653227128 @chia7712 : Thanks for the investigation. You don't need to fix all those flaky tests. It would be helpful if you could file separate jiras to track them, if not already. Ov

[GitHub] [kafka] chia7712 commented on pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

2020-07-02 Thread GitBox
chia7712 commented on pull request #8657: URL: https://github.com/apache/kafka/pull/8657#issuecomment-653232232 > Overall, do you think there is no new system test failure introduced by this PR? I did not observe obvious relation between flaky and this PR. I have filed 4 PRs to fix

[GitHub] [kafka] vvcephei commented on a change in pull request #8963: KAFKA-10017: fix flaky EosBetaUpgradeIntegrationTest

2020-07-02 Thread GitBox
vvcephei commented on a change in pull request #8963: URL: https://github.com/apache/kafka/pull/8963#discussion_r449281005 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/EosBetaUpgradeIntegrationTest.java ## @@ -147,6 +152,25 @@ private final Ato

[GitHub] [kafka] vvcephei commented on a change in pull request #8963: KAFKA-10017: fix flaky EosBetaUpgradeIntegrationTest

2020-07-02 Thread GitBox
vvcephei commented on a change in pull request #8963: URL: https://github.com/apache/kafka/pull/8963#discussion_r449280874 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/EosBetaUpgradeIntegrationTest.java ## @@ -837,6 +866,11 @@ public void init(final

[GitHub] [kafka] vvcephei commented on a change in pull request #8963: KAFKA-10017: fix flaky EosBetaUpgradeIntegrationTest

2020-07-02 Thread GitBox
vvcephei commented on a change in pull request #8963: URL: https://github.com/apache/kafka/pull/8963#discussion_r449282334 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/EosBetaUpgradeIntegrationTest.java ## @@ -837,6 +866,11 @@ public void init(final

[GitHub] [kafka] vvcephei commented on pull request #8963: KAFKA-10017: fix flaky EosBetaUpgradeIntegrationTest

2020-07-02 Thread GitBox
vvcephei commented on pull request #8963: URL: https://github.com/apache/kafka/pull/8963#issuecomment-653235811 Retest this please This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [kafka] vvcephei commented on pull request #8963: KAFKA-10017: fix flaky EosBetaUpgradeIntegrationTest

2020-07-02 Thread GitBox
vvcephei commented on pull request #8963: URL: https://github.com/apache/kafka/pull/8963#issuecomment-653235610 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [kafka] vvcephei commented on pull request #8963: KAFKA-10017: fix flaky EosBetaUpgradeIntegrationTest

2020-07-02 Thread GitBox
vvcephei commented on pull request #8963: URL: https://github.com/apache/kafka/pull/8963#issuecomment-653236124 When we merge this, we should cherry-pick it to 2.6 and remove the ignore. This is an automated message from the

[GitHub] [kafka] ijuma commented on pull request #8963: KAFKA-10017: fix flaky EosBetaUpgradeIntegrationTest

2020-07-02 Thread GitBox
ijuma commented on pull request #8963: URL: https://github.com/apache/kafka/pull/8963#issuecomment-653241923 It would be good to run this in a loop locally 100 times (or something like that) to check that it's truly stable.

[GitHub] [kafka] vvcephei commented on pull request #8938: KAFKA-10173: Use SmokeTest for upgrade system tests

2020-07-02 Thread GitBox
vvcephei commented on pull request #8938: URL: https://github.com/apache/kafka/pull/8938#issuecomment-653255715 The full streams suite completed. There was just one unrelated failure: http://confluent-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/2020-07-01--001.159363

[GitHub] [kafka] vvcephei commented on pull request #8938: KAFKA-10173: Use SmokeTest for upgrade system tests

2020-07-02 Thread GitBox
vvcephei commented on pull request #8938: URL: https://github.com/apache/kafka/pull/8938#issuecomment-653256091 The test failures were just the usual suspects: ``` org.apache.kafka.connect.mirror.MirrorConnectorsIntegrationTest.testOneWayReplicationWithAutorOffsetSync1 org.apache.

[GitHub] [kafka] vvcephei merged pull request #8938: KAFKA-10173: Use SmokeTest for upgrade system tests

2020-07-02 Thread GitBox
vvcephei merged pull request #8938: URL: https://github.com/apache/kafka/pull/8938 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] vvcephei commented on pull request #8938: KAFKA-10173: Use SmokeTest for upgrade system tests

2020-07-02 Thread GitBox
vvcephei commented on pull request #8938: URL: https://github.com/apache/kafka/pull/8938#issuecomment-653256554 Thanks, @guozhangwang ! I'll start the process of backporting this. This is an automated message from the

[GitHub] [kafka] vvcephei commented on pull request #8971: MINOR: prune the metadata upgrade test matrix

2020-07-02 Thread GitBox
vvcephei commented on pull request #8971: URL: https://github.com/apache/kafka/pull/8971#issuecomment-653256665 Hey @guozhangwang , now that https://github.com/apache/kafka/pull/8938 is finished, do you have any time to take a look at this one?

[GitHub] [kafka] vvcephei commented on pull request #8971: MINOR: prune the metadata upgrade test matrix

2020-07-02 Thread GitBox
vvcephei commented on pull request #8971: URL: https://github.com/apache/kafka/pull/8971#issuecomment-653257513 Since I resolved a conflict, I'm re-running: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4011/console -

[GitHub] [kafka] Johnny-Malizia commented on a change in pull request #8936: KAFKA-10207: Fixed padded timeindex causing premature data deletion

2020-07-02 Thread GitBox
Johnny-Malizia commented on a change in pull request #8936: URL: https://github.com/apache/kafka/pull/8936#discussion_r449317904 ## File path: core/src/test/scala/unit/kafka/log/TimeIndexTest.scala ## @@ -148,5 +148,39 @@ class TimeIndexTest { idx.close() } -} + /*

[GitHub] [kafka] jmalizia-branch commented on a change in pull request #8936: KAFKA-10207: Fixed padded timeindex causing premature data deletion

2020-07-02 Thread GitBox
jmalizia-branch commented on a change in pull request #8936: URL: https://github.com/apache/kafka/pull/8936#discussion_r449181257 ## File path: core/src/test/scala/unit/kafka/log/TimeIndexTest.scala ## @@ -148,5 +148,39 @@ class TimeIndexTest { idx.close() } -} + /

[GitHub] [kafka] chia7712 commented on pull request #8944: KAFKA-10209 fix flaky connect_rest_test.py

2020-07-02 Thread GitBox
chia7712 commented on pull request #8944: URL: https://github.com/apache/kafka/pull/8944#issuecomment-653293914 ping for reviewing this straightforward PR :) This is an automated message from the Apache Git Service. To respon

[GitHub] [kafka] jiameixie commented on pull request #8943: KAFKA-10196: Add missing '--version' option to producer-performance

2020-07-02 Thread GitBox
jiameixie commented on pull request #8943: URL: https://github.com/apache/kafka/pull/8943#issuecomment-653352435 Call for review @ijuma This is an automated message from the Apache Git Service. To respond to the message, ple

[jira] [Created] (KAFKA-10230) Include min.insync.replicas in MetadataResponse to make Producer smarter in determining unavailable partitions

2020-07-02 Thread Arvin Zheng (Jira)
Arvin Zheng created KAFKA-10230: --- Summary: Include min.insync.replicas in MetadataResponse to make Producer smarter in determining unavailable partitions Key: KAFKA-10230 URL: https://issues.apache.org/jira/browse/K

[GitHub] [kafka] abbccdda commented on pull request #8939: MINOR: rename class `RecordTimeDefintion` to `RecordTimeDefinition`

2020-07-02 Thread GitBox
abbccdda commented on pull request #8939: URL: https://github.com/apache/kafka/pull/8939#issuecomment-653364949 retest this please This is an automated message from the Apache Git Service. To respond to the message, please lo

[jira] [Commented] (KAFKA-10228) producer: NETWORK_EXCEPTION is thrown instead of a request timeout

2020-07-02 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17150745#comment-17150745 ] Chia-Ping Tsai commented on KAFKA-10228: The code to resolve this issue is simpl