ableegoldman commented on a change in pull request #8962:
URL: https://github.com/apache/kafka/pull/8962#discussion_r449227732
##########
File path:
streams/src/test/java/org/apache/kafka/streams/state/internals/OffsetCheckpointTest.java
##########
@@ -91,20 +94,38 @@ public void shouldSkipNegativeOffsetsDuringRead() throws
IOException {
offsets.put(new TopicPartition(topic, 0), -1L);
writeVersion0(offsets, file);
+ assertTrue(checkpoint.read().isEmpty());
Review comment:
This is kind of awkward, we forgot actually read the checkpoint here
🤦♀️
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
