[GitHub] [kafka] ijuma commented on pull request #8915: MINOR; Iterate over the partitions only once when building LeaderAndIsrRequest

2020-06-29 Thread GitBox
ijuma commented on pull request #8915: URL: https://github.com/apache/kafka/pull/8915#issuecomment-650978942 One job passed, the other two had unrelated test failures. This is an automated message from the Apache Git Service.

[GitHub] [kafka] ijuma merged pull request #8915: MINOR; Iterate over the partitions only once when building LeaderAndIsrRequest

2020-06-29 Thread GitBox
ijuma merged pull request #8915: URL: https://github.com/apache/kafka/pull/8915 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] dengziming commented on pull request #8941: KAFKA-10195: Move offset management code out of ConsumerCoordinator

2020-06-29 Thread GitBox
dengziming commented on pull request #8941: URL: https://github.com/apache/kafka/pull/8941#issuecomment-650987242 Hi, @abbccdda , Thank you for your reply, here are some of my understandings: 1. `ConsumerCoordinator` has 3 main parts, below are interactions between the 3 parts.

[GitHub] [kafka] ijuma commented on pull request #8579: KAFKA-9930: Prevent ReplicaFetcherThread from throwing UnknownTopicOrPartitionException upon topic creation and deletion.

2020-06-29 Thread GitBox
ijuma commented on pull request #8579: URL: https://github.com/apache/kafka/pull/8579#issuecomment-650999166 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [kafka] prgitpr opened a new pull request #8945: To avoid potential dead loop in KafkaConsumerProducerDemo

2020-06-29 Thread GitBox
prgitpr opened a new pull request #8945: URL: https://github.com/apache/kafka/pull/8945 To avoid potential dead loop in KafkaConsumerProducerDemo Motivation: If main throws InterruptedException After consumerThread start , the consumerThread will not shutdown .

[GitHub] [kafka] prgitpr closed pull request #8945: To avoid potential dead loop in KafkaConsumerProducerDemo

2020-06-29 Thread GitBox
prgitpr closed pull request #8945: URL: https://github.com/apache/kafka/pull/8945 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [kafka] prgitpr opened a new pull request #8946: To avoid potential dead loop in KafkaConsumerProducerDemo

2020-06-29 Thread GitBox
prgitpr opened a new pull request #8946: URL: https://github.com/apache/kafka/pull/8946 To avoid potential dead loop in KafkaConsumerProducerDemo Motivation: If main throws InterruptedException After consumerThread start , the consumerThread will not shutdown . Modifica

[jira] [Commented] (KAFKA-9953) support multiple consumerGroupCoordinators in TransactionManager

2020-06-29 Thread Joost van de Wijgerd (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17147635#comment-17147635 ] Joost van de Wijgerd commented on KAFKA-9953: - Hi [~bchen225242] , I agree

[jira] [Created] (KAFKA-10210) Use templated log message for LogContext

2020-06-29 Thread Fabian Lange (Jira)
Fabian Lange created KAFKA-10210: Summary: Use templated log message for LogContext Key: KAFKA-10210 URL: https://issues.apache.org/jira/browse/KAFKA-10210 Project: Kafka Issue Type: Bug

[jira] [Updated] (KAFKA-10210) Use templated log message for LogContext

2020-06-29 Thread Fabian Lange (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Lange updated KAFKA-10210: - Description: We are using an error aggregation framework which uses the log4j/slf4j log message

[jira] [Created] (KAFKA-10211) Add DirectoryConfigProvider

2020-06-29 Thread Tom Bentley (Jira)
Tom Bentley created KAFKA-10211: --- Summary: Add DirectoryConfigProvider Key: KAFKA-10211 URL: https://issues.apache.org/jira/browse/KAFKA-10211 Project: Kafka Issue Type: Improvement

[GitHub] [kafka] dajac commented on a change in pull request #8808: KAFKA-10109: Fix double AdminClient creation in AclCommand

2020-06-29 Thread GitBox
dajac commented on a change in pull request #8808: URL: https://github.com/apache/kafka/pull/8808#discussion_r446893874 ## File path: core/src/test/scala/unit/kafka/admin/AclCommandTest.scala ## @@ -130,22 +132,61 @@ class AclCommandTest extends ZooKeeperTestHarness with Loggi

[jira] [Created] (KAFKA-10212) Describing a topic with the TopicCommand fails if unauthorised to use ListPartitionReassignments API

2020-06-29 Thread David Jacot (Jira)
David Jacot created KAFKA-10212: --- Summary: Describing a topic with the TopicCommand fails if unauthorised to use ListPartitionReassignments API Key: KAFKA-10212 URL: https://issues.apache.org/jira/browse/KAFKA-10212

[GitHub] [kafka] dajac opened a new pull request #8947: KAFKA-10212; Describing a topic with the TopicCommand fails if unauthorised to use ListPartitionReassignments API

2020-06-29 Thread GitBox
dajac opened a new pull request #8947: URL: https://github.com/apache/kafka/pull/8947 Since https://issues.apache.org/jira/browse/KAFKA-8834, describing topics with the TopicCommand requires privileges to use ListPartitionReassignments or fails to describe the topics with the following err

[GitHub] [kafka] omkreddy commented on a change in pull request #8885: KAFKA-8264: decrease the record size for flaky test

2020-06-29 Thread GitBox
omkreddy commented on a change in pull request #8885: URL: https://github.com/apache/kafka/pull/8885#discussion_r446976087 ## File path: core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala ## @@ -800,7 +800,7 @@ class PlaintextConsumerTest extends BaseConsumer

[GitHub] [kafka] omkreddy commented on pull request #8885: KAFKA-8264: decrease the record size for flaky test

2020-06-29 Thread GitBox
omkreddy commented on pull request #8885: URL: https://github.com/apache/kafka/pull/8885#issuecomment-651125144 retest this please This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [kafka] vinothchandar opened a new pull request #8948: KAFKA-10174: Prefer --bootstrap-server for configs command in ducker …

2020-06-29 Thread GitBox
vinothchandar opened a new pull request #8948: URL: https://github.com/apache/kafka/pull/8948 …tests - Preferred when version >= 2.6.0 - Small renaming to make context clearer *More detailed description of your change, if necessary. The PR title and PR message become

[jira] [Created] (KAFKA-10213) Prefer --bootstrap-server in ducktape tests for Kafka clients

2020-06-29 Thread Vinoth Chandar (Jira)
Vinoth Chandar created KAFKA-10213: -- Summary: Prefer --bootstrap-server in ducktape tests for Kafka clients Key: KAFKA-10213 URL: https://issues.apache.org/jira/browse/KAFKA-10213 Project: Kafka

[GitHub] [kafka] sasukerui commented on pull request #8942: modify the judgment condition in KafkaApis getTopicMetadata

2020-06-29 Thread GitBox
sasukerui commented on pull request #8942: URL: https://github.com/apache/kafka/pull/8942#issuecomment-651137328 > Thanks for the PR. Is this causing incorrect behavior or is it just a clean-up? Please note that PRs should target the master branch. Thanks for your answer, I will pay atte

[GitHub] [kafka] omkreddy commented on pull request #8947: KAFKA-10212; Describing a topic with the TopicCommand fails if unauthorised to use ListPartitionReassignments API

2020-06-29 Thread GitBox
omkreddy commented on pull request #8947: URL: https://github.com/apache/kafka/pull/8947#issuecomment-651140150 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] tombentley commented on a change in pull request #8808: KAFKA-10109: Fix double AdminClient creation in AclCommand

2020-06-29 Thread GitBox
tombentley commented on a change in pull request #8808: URL: https://github.com/apache/kafka/pull/8808#discussion_r447002522 ## File path: core/src/test/scala/unit/kafka/admin/AclCommandTest.scala ## @@ -130,22 +132,61 @@ class AclCommandTest extends ZooKeeperTestHarness with

[jira] [Assigned] (KAFKA-5235) GetOffsetShell: retrieve offsets for all given topics and partitions with single request to the broker

2020-06-29 Thread Daniel Urban (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-5235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Urban reassigned KAFKA-5235: --- Assignee: Daniel Urban > GetOffsetShell: retrieve offsets for all given topics and partition

[jira] [Updated] (KAFKA-10212) Describing a topic with the TopicCommand fails if unauthorised to use ListPartitionReassignments API

2020-06-29 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch updated KAFKA-10212: -- Fix Version/s: 2.5.1 2.6.0 > Describing a topic with the TopicCommand fails

[jira] [Created] (KAFKA-10214) fix flaky zookeeper_tls_test.py

2020-06-29 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-10214: -- Summary: fix flaky zookeeper_tls_test.py Key: KAFKA-10214 URL: https://issues.apache.org/jira/browse/KAFKA-10214 Project: Kafka Issue Type: Bug

[jira] [Updated] (KAFKA-10214) fix flaky zookeeper_tls_test.py

2020-06-29 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-10214: --- Description: After https://github.com/apache/kafka/commit/3661f981fff2653aaf1d5ee0b6dde3410b

[GitHub] [kafka] chia7712 opened a new pull request #8949: KAFKA-10214 fix flaky zookeeper_tls_test.py

2020-06-29 Thread GitBox
chia7712 opened a new pull request #8949: URL: https://github.com/apache/kafka/pull/8949 After https://github.com/apache/kafka/commit/3661f981fff2653aaf1d5ee0b6dde3410b5498db,  security_config is cached. Hence, the later changes to security flag can't impact the security_config used by lat

[GitHub] [kafka] chia7712 edited a comment on pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

2020-06-29 Thread GitBox
chia7712 edited a comment on pull request #8657: URL: https://github.com/apache/kafka/pull/8657#issuecomment-650923843 1. connect_rest_test.py is traced by #8944 2. zookeeper_tls_test.py is traced by #8949 This is an autom

[jira] [Updated] (KAFKA-5235) GetOffsetShell: retrieve offsets for all given topics and partitions with single request to the broker

2020-06-29 Thread Daniel Urban (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-5235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Urban updated KAFKA-5235: Description: Currently, GetOffsetShell only allows fetching the offsets of a single topic with an o

[GitHub] [kafka] omkreddy commented on pull request #8947: KAFKA-10212: Describing a topic with the TopicCommand fails if unauthorised to use ListPartitionReassignments API

2020-06-29 Thread GitBox
omkreddy commented on pull request #8947: URL: https://github.com/apache/kafka/pull/8947#issuecomment-651157483 retest this please This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [kafka] sasukerui opened a new pull request #8950: Optimize the judgment condition of TopicMetadata parameters

2020-06-29 Thread GitBox
sasukerui opened a new pull request #8950: URL: https://github.com/apache/kafka/pull/8950 Optimize the judgment condition of TopicMetadata parameters. Judgment has been made in the method handleTopicMetadataRequest. like authorizedTopics.isEmpty if (authorizedTopics.isEmpty)

[jira] [Commented] (KAFKA-10158) Fix flaky kafka.admin.TopicCommandWithAdminClientTest#testDescribeUnderReplicatedPartitionsWhenReassignmentIsInProgress

2020-06-29 Thread Lucas Bradstreet (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17147861#comment-17147861 ] Lucas Bradstreet commented on KAFKA-10158: -- I think the problem here is subtly

[GitHub] [kafka] vvcephei commented on pull request #8881: KIP-557: Add emit on change support to Kafka Streams

2020-06-29 Thread GitBox
vvcephei commented on pull request #8881: URL: https://github.com/apache/kafka/pull/8881#issuecomment-651188643 Hey again @ConcurrencyPractitioner . I'm sorry to say that I still haven't been able to review. It was a long week last week, resolving a subtle and complex bug around upgrading

[jira] [Created] (KAFKA-10215) MockProcessorContext doesn't work with SessionStores

2020-06-29 Thread John Roesler (Jira)
John Roesler created KAFKA-10215: Summary: MockProcessorContext doesn't work with SessionStores Key: KAFKA-10215 URL: https://issues.apache.org/jira/browse/KAFKA-10215 Project: Kafka Issue Ty

[jira] [Updated] (KAFKA-10215) MockProcessorContext doesn't work with SessionStores

2020-06-29 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-10215: - Description: The recommended pattern for testing custom Processor implementations is to use the

[jira] [Updated] (KAFKA-10215) MockProcessorContext doesn't work with SessionStores

2020-06-29 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-10215: - Description: The recommended pattern for testing custom Processor implementations is to use the

[jira] [Commented] (KAFKA-10200) MockProcessorContext doesn't work with WindowStores

2020-06-29 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17147885#comment-17147885 ] John Roesler commented on KAFKA-10200: -- Created and linked https://issues.apache.or

[GitHub] [kafka] dajac commented on pull request #8947: KAFKA-10212: Describing a topic with the TopicCommand fails if unauthorised to use ListPartitionReassignments API

2020-06-29 Thread GitBox
dajac commented on pull request #8947: URL: https://github.com/apache/kafka/pull/8947#issuecomment-651198590 @omkreddy I have opened https://github.com/apache/kafka/pull/8951 for 2.5. This is an automated message from the Apa

[GitHub] [kafka] dajac opened a new pull request #8951: KAFKA-10212: Describing a topic with the TopicCommand fails if unauthorised to use ListPartitionReassignments API (targeting 2.5 branch)

2020-06-29 Thread GitBox
dajac opened a new pull request #8951: URL: https://github.com/apache/kafka/pull/8951 See https://github.com/apache/kafka/pull/8947 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status -

[GitHub] [kafka] omkreddy commented on pull request #8951: KAFKA-10212: Describing a topic with the TopicCommand fails if unauthorised to use ListPartitionReassignments API (targeting 2.5 branch)

2020-06-29 Thread GitBox
omkreddy commented on pull request #8951: URL: https://github.com/apache/kafka/pull/8951#issuecomment-651199956 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Commented] (KAFKA-10158) Fix flaky kafka.admin.TopicCommandWithAdminClientTest#testDescribeUnderReplicatedPartitionsWhenReassignmentIsInProgress

2020-06-29 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17147895#comment-17147895 ] Chia-Ping Tsai commented on KAFKA-10158: [~lucasbradstreet] not sure whether I h

[GitHub] [kafka] vvcephei commented on a change in pull request #8927: KAFKA-10200: Fix testability of PAPI with windowed stores

2020-06-29 Thread GitBox
vvcephei commented on a change in pull request #8927: URL: https://github.com/apache/kafka/pull/8927#discussion_r447071419 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorContextUtils.java ## @@ -0,0 +1,39 @@ +/* + * Licensed to the Ap

[jira] [Commented] (KAFKA-10158) Fix flaky kafka.admin.TopicCommandWithAdminClientTest#testDescribeUnderReplicatedPartitionsWhenReassignmentIsInProgress

2020-06-29 Thread Lucas Bradstreet (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17147907#comment-17147907 ] Lucas Bradstreet commented on KAFKA-10158: -- For me that check passes and the fo

[jira] [Created] (KAFKA-10216) Loosen permission for listing reassignments

2020-06-29 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-10216: --- Summary: Loosen permission for listing reassignments Key: KAFKA-10216 URL: https://issues.apache.org/jira/browse/KAFKA-10216 Project: Kafka Issue Type:

[jira] [Created] (KAFKA-10217) Move nodeLevelSensor and storeLevelSensor methods from StreamsMetricsImpl to StreamsMetrics

2020-06-29 Thread John Roesler (Jira)
John Roesler created KAFKA-10217: Summary: Move nodeLevelSensor and storeLevelSensor methods from StreamsMetricsImpl to StreamsMetrics Key: KAFKA-10217 URL: https://issues.apache.org/jira/browse/KAFKA-10217

[GitHub] [kafka] cadonna commented on a change in pull request #8927: KAFKA-10200: Fix testability of PAPI with windowed stores

2020-06-29 Thread GitBox
cadonna commented on a change in pull request #8927: URL: https://github.com/apache/kafka/pull/8927#discussion_r447080512 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorContextUtils.java ## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apa

[jira] [Updated] (KAFKA-10216) Loosen permission for listing reassignments

2020-06-29 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson updated KAFKA-10216: Description: Currently listing partition reassignments requires Cluster Describe permissio

[jira] [Commented] (KAFKA-10158) Fix flaky kafka.admin.TopicCommandWithAdminClientTest#testDescribeUnderReplicatedPartitionsWhenReassignmentIsInProgress

2020-06-29 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17147909#comment-17147909 ] Chia-Ping Tsai commented on KAFKA-10158: Any suggestion about fixing the throttl

[jira] [Updated] (KAFKA-10217) Move nodeLevelSensor and storeLevelSensor methods from StreamsMetricsImpl to StreamsMetrics

2020-06-29 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-10217: - Labels: kip-required newbie (was: newbie,) > Move nodeLevelSensor and storeLevelSensor methods

[jira] [Assigned] (KAFKA-10216) Loosen permission for listing reassignments

2020-06-29 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot reassigned KAFKA-10216: --- Assignee: David Jacot > Loosen permission for listing reassignments > -

[jira] [Updated] (KAFKA-10217) Move nodeLevelSensor and storeLevelSensor methods from StreamsMetricsImpl to StreamsMetrics

2020-06-29 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-10217: - Description: StreamsMetricsImpl contains several convenience methods for safely registering sen

[GitHub] [kafka] vvcephei commented on pull request #8927: KAFKA-10200: Fix testability of PAPI with windowed stores

2020-06-29 Thread GitBox
vvcephei commented on pull request #8927: URL: https://github.com/apache/kafka/pull/8927#issuecomment-651214440 Ok, @cadonna and @ableegoldman , I've addressed your feedback. WDYT? This is an automated message from the Apache

[jira] [Assigned] (KAFKA-10091) Improve task idling

2020-06-29 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman reassigned KAFKA-10091: --- Assignee: Sophie Blee-Goldman > Improve task idling > --- >

[GitHub] [kafka] abbccdda commented on pull request #8913: KAFKA-10191 fix flaky StreamsOptimizedTest - call KafkaStreams#cleanU…

2020-06-29 Thread GitBox
abbccdda commented on pull request #8913: URL: https://github.com/apache/kafka/pull/8913#issuecomment-651219971 retest this please This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [kafka] chia7712 commented on pull request #8913: KAFKA-10191 fix flaky StreamsOptimizedTest - call KafkaStreams#cleanU…

2020-06-29 Thread GitBox
chia7712 commented on pull request #8913: URL: https://github.com/apache/kafka/pull/8913#issuecomment-651221459 > Have you verified this test fix on local with docker? Yep. It passes on my local. Waiting for the report of https://jenkins.confluent.io/job/system-test-kafka-branch-bui

[GitHub] [kafka] ableegoldman commented on pull request #8913: KAFKA-10191 fix flaky StreamsOptimizedTest - call KafkaStreams#cleanU…

2020-06-29 Thread GitBox
ableegoldman commented on pull request #8913: URL: https://github.com/apache/kafka/pull/8913#issuecomment-651225638 AWS has been having "Increased Network Provisioning Latencies" so all the system tests I tried to kick off over the past few days have failed. I'll try one more time and if

[jira] [Commented] (KAFKA-10158) Fix flaky kafka.admin.TopicCommandWithAdminClientTest#testDescribeUnderReplicatedPartitionsWhenReassignmentIsInProgress

2020-06-29 Thread Lucas Bradstreet (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17147923#comment-17147923 ] Lucas Bradstreet commented on KAFKA-10158: -- [~chia7712] I'm quite sure what the

[GitHub] [kafka] omkreddy commented on pull request #8947: KAFKA-10212: Describing a topic with the TopicCommand fails if unauthorised to use ListPartitionReassignments API

2020-06-29 Thread GitBox
omkreddy commented on pull request #8947: URL: https://github.com/apache/kafka/pull/8947#issuecomment-651228126 @dajac We have ambiguous reference error for scala 2.12 ``` 21:45:50 > Task :core:compileTestScala 21:45:50 [Error] /home/jenkins/jenkins-slave/workspace/kafka-pr-jdk

[GitHub] [kafka] dajac commented on pull request #8947: KAFKA-10212: Describing a topic with the TopicCommand fails if unauthorised to use ListPartitionReassignments API

2020-06-29 Thread GitBox
dajac commented on pull request #8947: URL: https://github.com/apache/kafka/pull/8947#issuecomment-651233750 @omkreddy I just pushed a fix. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] dajac commented on pull request #8295: KAFKA-9627: Replace ListOffset request/response with automated protocol

2020-06-29 Thread GitBox
dajac commented on pull request #8295: URL: https://github.com/apache/kafka/pull/8295#issuecomment-651234640 @mimaison Any progress on the rebase? ;) This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] omkreddy commented on pull request #8947: KAFKA-10212: Describing a topic with the TopicCommand fails if unauthorised to use ListPartitionReassignments API

2020-06-29 Thread GitBox
omkreddy commented on pull request #8947: URL: https://github.com/apache/kafka/pull/8947#issuecomment-651237942 retest this please This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [kafka] abbccdda commented on pull request #8925: KAFKA-9974: Integration test shouldApplyUpdatesToStandbyStore; Make produce-sync flush

2020-06-29 Thread GitBox
abbccdda commented on pull request #8925: URL: https://github.com/apache/kafka/pull/8925#issuecomment-651243387 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[jira] [Commented] (KAFKA-10158) Fix flaky kafka.admin.TopicCommandWithAdminClientTest#testDescribeUnderReplicatedPartitionsWhenReassignmentIsInProgress

2020-06-29 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17147967#comment-17147967 ] Boyang Chen commented on KAFKA-10158: - failed again: [https://builds.apache.org/job/

[jira] [Commented] (KAFKA-10216) Loosen permission for listing reassignments

2020-06-29 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17147971#comment-17147971 ] Colin McCabe commented on KAFKA-10216: -- +1 > Loosen permission for listing reassig

[GitHub] [kafka] omkreddy commented on pull request #8947: KAFKA-10212: Describing a topic with the TopicCommand fails if unauthorised to use ListPartitionReassignments API

2020-06-29 Thread GitBox
omkreddy commented on pull request #8947: URL: https://github.com/apache/kafka/pull/8947#issuecomment-651248917 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] rajinisivaram commented on pull request #8683: KAFKA-9893: Configurable TCP connection timeout and improve the initial metadata fetch

2020-06-29 Thread GitBox
rajinisivaram commented on pull request #8683: URL: https://github.com/apache/kafka/pull/8683#issuecomment-651250337 retest this please This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [kafka] rajinisivaram commented on pull request #8683: KAFKA-9893: Configurable TCP connection timeout and improve the initial metadata fetch

2020-06-29 Thread GitBox
rajinisivaram commented on pull request #8683: URL: https://github.com/apache/kafka/pull/8683#issuecomment-651250018 retest this please This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [kafka] andrewchoi5 opened a new pull request #8479: KAFKA-9769: Finish operations for leaderEpoch-updated partitions up to point ZK Exception

2020-06-29 Thread GitBox
andrewchoi5 opened a new pull request #8479: URL: https://github.com/apache/kafka/pull/8479 KAFKA-9769: Finish operations for leaderEpoch-updated partitions up to point ZK Exception occurs. https://issues.apache.org/jira/browse/KAFKA-9769 For example, in such case, we will have th

[GitHub] [kafka] andrewchoi5 commented on pull request #8479: KAFKA-9769: Finish operations for leaderEpoch-updated partitions up to point ZK Exception

2020-06-29 Thread GitBox
andrewchoi5 commented on pull request #8479: URL: https://github.com/apache/kafka/pull/8479#issuecomment-651253198 Thanks for the review @junrao -- let me know if there's anything else for revision. This is an automated mess

[GitHub] [kafka] andrewchoi5 commented on pull request #8479: KAFKA-9769: Finish operations for leaderEpoch-updated partitions up to point ZK Exception

2020-06-29 Thread GitBox
andrewchoi5 commented on pull request #8479: URL: https://github.com/apache/kafka/pull/8479#issuecomment-651253282 Closed by accident. This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [kafka] andrewchoi5 closed pull request #8479: KAFKA-9769: Finish operations for leaderEpoch-updated partitions up to point ZK Exception

2020-06-29 Thread GitBox
andrewchoi5 closed pull request #8479: URL: https://github.com/apache/kafka/pull/8479 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [kafka] kkonstantine commented on pull request #8893: MINOR: Upgrade jetty to 9.4.30.v20200611

2020-06-29 Thread GitBox
kkonstantine commented on pull request #8893: URL: https://github.com/apache/kafka/pull/8893#issuecomment-651258204 2/3 builds are green, while the other one failed with 3 flaky MM2 tests. Thanks @ijuma This is an automa

[GitHub] [kafka] abbccdda opened a new pull request #8952: MINOR: Add toString for RocksDbWindowBytesStoreSupplier

2020-06-29 Thread GitBox
abbccdda opened a new pull request #8952: URL: https://github.com/apache/kafka/pull/8952 We are missing a `toString` logic in the RocksDbWindowBytesStoreSupplier, such that the error log wasn't able to print out the supplier's actual config: ``` Exception in thread "main" org.apac

[GitHub] [kafka] abbccdda commented on pull request #8952: MINOR: Add toString for RocksDbWindowBytesStoreSupplier

2020-06-29 Thread GitBox
abbccdda commented on pull request #8952: URL: https://github.com/apache/kafka/pull/8952#issuecomment-651258911 @ableegoldman @cadonna @vvcephei Call for review This is an automated message from the Apache Git Service. To res

[GitHub] [kafka] kkonstantine merged pull request #8893: MINOR: Upgrade jetty to 9.4.30.v20200611

2020-06-29 Thread GitBox
kkonstantine merged pull request #8893: URL: https://github.com/apache/kafka/pull/8893 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Assigned] (KAFKA-10205) NullPointerException in StreamTask (Kafka Streams 2.5.0)

2020-06-29 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler reassigned KAFKA-10205: Assignee: John Roesler > NullPointerException in StreamTask (Kafka Streams 2.5.0) > -

[GitHub] [kafka] cgetzen commented on pull request #8930: Mirror Maker 2: offset-syncs variable

2020-06-29 Thread GitBox
cgetzen commented on pull request #8930: URL: https://github.com/apache/kafka/pull/8930#issuecomment-651268347 Much appreciated. Another property is the heartbeats topic. I will create the KIP as soon as I get my head around all the different types of configs and how they work together.

[jira] [Commented] (KAFKA-10194) run the reset tool between stopping StreamsOptimizedTest and starting the new one

2020-06-29 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17148030#comment-17148030 ] John Roesler commented on KAFKA-10194: -- Hey [~chia7712] , can we just include this

[jira] [Updated] (KAFKA-10216) Loosen permission for listing reassignments

2020-06-29 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Chen updated KAFKA-10216: Component/s: core > Loosen permission for listing reassignments >

[GitHub] [kafka] C0urante commented on a change in pull request #8910: KAFKA-10188: Prevent SinkTask::preCommit from being called after SinkTask::stop

2020-06-29 Thread GitBox
C0urante commented on a change in pull request #8910: URL: https://github.com/apache/kafka/pull/8910#discussion_r447162953 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSinkTask.java ## @@ -138,6 +139,7 @@ public WorkerSinkTask(ConnectorTas

[GitHub] [kafka] ableegoldman commented on pull request #8913: KAFKA-10191 fix flaky StreamsOptimizedTest - call KafkaStreams#cleanU…

2020-06-29 Thread GitBox
ableegoldman commented on pull request #8913: URL: https://github.com/apache/kafka/pull/8913#issuecomment-651283162 Hey @chia7712 , since we're held up by the system tests anyway can we just go ahead and put in the full fix I mentioned on the original ticket? ie, run the reset tool between

[GitHub] [kafka] ableegoldman opened a new pull request #8953: MINOR: re-enable EosBetaUpgradeIntegrationTest

2020-06-29 Thread GitBox
ableegoldman opened a new pull request #8953: URL: https://github.com/apache/kafka/pull/8953 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [kafka] lct45 commented on pull request #8929: KAFKA-4996: Fix findbugs multithreaded correctness warnings for streams

2020-06-29 Thread GitBox
lct45 commented on pull request #8929: URL: https://github.com/apache/kafka/pull/8929#issuecomment-651329753 @vvcephei @abbccdda this should be ready to be tested then merged! This is an automated message from the Apache Git

[GitHub] [kafka] kkonstantine merged pull request #8894: KAFKA-9509: Increase timeout when consuming records to fix flaky test in MM2

2020-06-29 Thread GitBox
kkonstantine merged pull request #8894: URL: https://github.com/apache/kafka/pull/8894 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] abbccdda commented on a change in pull request #8953: MINOR: re-enable EosBetaUpgradeIntegrationTest

2020-06-29 Thread GitBox
abbccdda commented on a change in pull request #8953: URL: https://github.com/apache/kafka/pull/8953#discussion_r447234048 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/utils/IntegrationTestUtils.java ## @@ -594,7 +594,7 @@ public static void waitFor

[GitHub] [kafka] guozhangwang commented on pull request #8953: MINOR: re-enable EosBetaUpgradeIntegrationTest

2020-06-29 Thread GitBox
guozhangwang commented on pull request #8953: URL: https://github.com/apache/kafka/pull/8953#issuecomment-651345158 LGTM. This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [kafka] guozhangwang merged pull request #8953: MINOR: re-enable EosBetaUpgradeIntegrationTest

2020-06-29 Thread GitBox
guozhangwang merged pull request #8953: URL: https://github.com/apache/kafka/pull/8953 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] ConcurrencyPractitioner commented on pull request #8881: KIP-557: Add emit on change support to Kafka Streams

2020-06-29 Thread GitBox
ConcurrencyPractitioner commented on pull request #8881: URL: https://github.com/apache/kafka/pull/8881#issuecomment-651346146 @vvcephei Thanks for the thorough breakdown on what's going on! :) I will take a look at the other operators then. :) ---

[GitHub] [kafka] kkonstantine commented on pull request #8859: MINOR: Upgrade jetty to 9.4.27.v20200227 and jersey to 2.31

2020-06-29 Thread GitBox
kkonstantine commented on pull request #8859: URL: https://github.com/apache/kafka/pull/8859#issuecomment-651355001 Hi @akatona84 It's not clear to me why this would go to a patch/bugfix release branch. Do we have a good reason to backport? Additionally (and independently), note

[GitHub] [kafka] abbccdda commented on pull request #8952: MINOR: Add toString for RocksDbWindowBytesStoreSupplier

2020-06-29 Thread GitBox
abbccdda commented on pull request #8952: URL: https://github.com/apache/kafka/pull/8952#issuecomment-651357330 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [kafka] akatona84 commented on pull request #8859: MINOR: Upgrade jetty to 9.4.27.v20200227 and jersey to 2.31

2020-06-29 Thread GitBox
akatona84 commented on pull request #8859: URL: https://github.com/apache/kafka/pull/8859#issuecomment-651364492 Hi @kkonstantine , thx for explaining and taking care of these commits. I was just hoping we could have it in 2.5.1 too. I'll check CVEs related to the jetty version used in

[GitHub] [kafka] rondagostino commented on pull request #8949: KAFKA-10214 fix flaky zookeeper_tls_test.py

2020-06-29 Thread GitBox
rondagostino commented on pull request #8949: URL: https://github.com/apache/kafka/pull/8949#issuecomment-651367068 @chia7712 The link in the description https://github.com/apache/kafka/commit/3661f981fff2653aaf1d5ee0b6dde3410b5498db,%C2%A0security_config does not resolve for me -- can you

[jira] [Updated] (KAFKA-6508) Look into optimizing StreamPartitionAssignor StandbyTask Assignment

2020-06-29 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman updated KAFKA-6508: --- Fix Version/s: 2.6.0 > Look into optimizing StreamPartitionAssignor StandbyTask Assig

[jira] [Resolved] (KAFKA-6508) Look into optimizing StreamPartitionAssignor StandbyTask Assignment

2020-06-29 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman resolved KAFKA-6508. Resolution: Fixed This should be addressed via KIP-441 > Look into optimizing Stre

[GitHub] [kafka] vvcephei commented on pull request #8929: KAFKA-4996: Fix findbugs multithreaded correctness warnings for streams

2020-06-29 Thread GitBox
vvcephei commented on pull request #8929: URL: https://github.com/apache/kafka/pull/8929#issuecomment-651387931 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [kafka] vvcephei commented on pull request #8929: KAFKA-4996: Fix findbugs multithreaded correctness warnings for streams

2020-06-29 Thread GitBox
vvcephei commented on pull request #8929: URL: https://github.com/apache/kafka/pull/8929#issuecomment-651388235 Retest this please This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [kafka] vvcephei commented on pull request #8927: KAFKA-10200: Fix testability of PAPI with windowed stores

2020-06-29 Thread GitBox
vvcephei commented on pull request #8927: URL: https://github.com/apache/kafka/pull/8927#issuecomment-651388934 Test failures were unrelated: org.apache.kafka.connect.mirror.MirrorConnectorsIntegrationTest.testReplication Th

[GitHub] [kafka] tdanylchuk edited a comment on pull request #7283: KAFKA-8862: Use consistent exception messages for nonexistent partition

2020-06-29 Thread GitBox
tdanylchuk edited a comment on pull request #7283: URL: https://github.com/apache/kafka/pull/7283#issuecomment-651390594 +1 for having this in master This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] tdanylchuk commented on pull request #7283: KAFKA-8862: Use consistent exception messages for nonexistent partition

2020-06-29 Thread GitBox
tdanylchuk commented on pull request #7283: URL: https://github.com/apache/kafka/pull/7283#issuecomment-651390594 + 1 for having this in master This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [kafka] abbccdda commented on pull request #8952: MINOR: Add toString for RocksDbWindowBytesStoreSupplier

2020-06-29 Thread GitBox
abbccdda commented on pull request #8952: URL: https://github.com/apache/kafka/pull/8952#issuecomment-651391283 @ableegoldman There is already one in the `InMemoryWindowBytesStoreSupplier` This is an automated message from th

[GitHub] [kafka] guozhangwang commented on pull request #8925: KAFKA-9974: Integration test shouldApplyUpdatesToStandbyStore; Make produce-sync flush

2020-06-29 Thread GitBox
guozhangwang commented on pull request #8925: URL: https://github.com/apache/kafka/pull/8925#issuecomment-651396758 test this This is an automated message from the Apache Git Service. To respond to the message, please log on

  1   2   >