[ 
https://issues.apache.org/jira/browse/KAFKA-10158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17147907#comment-17147907
 ] 

Lucas Bradstreet commented on KAFKA-10158:
------------------------------------------

For me that check passes and the following check fails:
{code:java}
val underReplicatedOutput = TestUtils.grabConsoleOutput( 
topicService.describeTopic(new 
TopicCommandOptions(Array("--under-replicated-partitions")))) 
assertEquals(s"--under-replicated-partitions shouldn't return anything: 
'$underReplicatedOutput'", "", underReplicatedOutput) {code}
 

When this check fails the reassignment is usually finishing because the 
replication throttle didn't quite work the way the test expects it to. The 
throttle doesn't work because only one fetch request is required to get the 
follower into sync.

That said, I think depending on the timing I could see the lines you point to 
failing too.

> Fix flaky 
> kafka.admin.TopicCommandWithAdminClientTest#testDescribeUnderReplicatedPartitionsWhenReassignmentIsInProgress
> -----------------------------------------------------------------------------------------------------------------------
>
>                 Key: KAFKA-10158
>                 URL: https://issues.apache.org/jira/browse/KAFKA-10158
>             Project: Kafka
>          Issue Type: Bug
>          Components: unit tests
>            Reporter: Chia-Ping Tsai
>            Assignee: Chia-Ping Tsai
>            Priority: Minor
>             Fix For: 2.7.0
>
>
> Altering the assignments is a async request so it is possible that the 
> reassignment is still in progress when we start to verify the 
> "under-replicated-partitions". In order to make it stable, it needs a wait 
> for the reassignment completion before verifying the topic command with 
> "under-replicated-partitions".



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to