[jira] [Commented] (KAFKA-10173) BufferUnderflowException during Kafka Streams Upgrade

2020-06-22 Thread Karsten Schnitter (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17141736#comment-17141736 ] Karsten Schnitter commented on KAFKA-10173: --- Hi [~vvcephei], The application

[GitHub] [kafka] chia7712 edited a comment on pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

2020-06-22 Thread GitBox
chia7712 edited a comment on pull request #8657: URL: https://github.com/apache/kafka/pull/8657#issuecomment-647233460 > This is a second run of the system tests. http://testing.confluent.io/confluent-kafka-branch-builder-system-test-results/?prefix=2020-06-19--001.1592614513--chia7712--fix

[jira] [Created] (KAFKA-10191) fix flaky StreamsOptimizedTest

2020-06-22 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-10191: -- Summary: fix flaky StreamsOptimizedTest Key: KAFKA-10191 URL: https://issues.apache.org/jira/browse/KAFKA-10191 Project: Kafka Issue Type: Test

[GitHub] [kafka] chia7712 commented on pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

2020-06-22 Thread GitBox
chia7712 commented on pull request #8657: URL: https://github.com/apache/kafka/pull/8657#issuecomment-647352301 I have filed https://issues.apache.org/jira/browse/KAFKA-10191 to trace ```StreamsOptimizedTest``` This is an au

[jira] [Updated] (KAFKA-10191) fix flaky StreamsOptimizedTest

2020-06-22 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-10191: --- Description: {quote}Exception in thread "StreamsOptimizedTest-53c7d3b1-12b2-4d02-90b1-15757

[GitHub] [kafka] michael-carter-instaclustr commented on pull request #8844: KAFKA-9887 fix failed task or connector count on startup failure

2020-06-22 Thread GitBox
michael-carter-instaclustr commented on pull request #8844: URL: https://github.com/apache/kafka/pull/8844#issuecomment-647356784 Thanks for reviewing this @C0urante. "if the framework successfully instantiates a connector and is able to call start on it, should that alone qualify as

[GitHub] [kafka] michael-carter-instaclustr commented on a change in pull request #8844: KAFKA-9887 fix failed task or connector count on startup failure

2020-06-22 Thread GitBox
michael-carter-instaclustr commented on a change in pull request #8844: URL: https://github.com/apache/kafka/pull/8844#discussion_r443385491 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java ## @@ -289,7 +285,6 @@ public void startConnect

[GitHub] [kafka] michael-carter-instaclustr commented on a change in pull request #8844: KAFKA-9887 fix failed task or connector count on startup failure

2020-06-22 Thread GitBox
michael-carter-instaclustr commented on a change in pull request #8844: URL: https://github.com/apache/kafka/pull/8844#discussion_r443385639 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java ## @@ -562,7 +556,6 @@ public boolean startTask

[GitHub] [kafka] michael-carter-instaclustr commented on a change in pull request #8844: KAFKA-9887 fix failed task or connector count on startup failure

2020-06-22 Thread GitBox
michael-carter-instaclustr commented on a change in pull request #8844: URL: https://github.com/apache/kafka/pull/8844#discussion_r443385901 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerMetricsGroup.java ## @@ -0,0 +1,204 @@ +/* + * Licens

[GitHub] [kafka] michael-carter-instaclustr commented on a change in pull request #8844: KAFKA-9887 fix failed task or connector count on startup failure

2020-06-22 Thread GitBox
michael-carter-instaclustr commented on a change in pull request #8844: URL: https://github.com/apache/kafka/pull/8844#discussion_r443386418 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerMetricsGroup.java ## @@ -0,0 +1,204 @@ +/* + * Licens

[GitHub] [kafka] michael-carter-instaclustr commented on a change in pull request #8844: KAFKA-9887 fix failed task or connector count on startup failure

2020-06-22 Thread GitBox
michael-carter-instaclustr commented on a change in pull request #8844: URL: https://github.com/apache/kafka/pull/8844#discussion_r443386551 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerMetricsGroup.java ## @@ -0,0 +1,204 @@ +/* + * Licens

[GitHub] [kafka] itantiger commented on pull request #8753: KAFKA-10043:Some parameters will be overwritten which was configured …

2020-06-22 Thread GitBox
itantiger commented on pull request #8753: URL: https://github.com/apache/kafka/pull/8753#issuecomment-647359639 @ijuma Can you take a look at this (since you requested it in #8390 )? This is an automated message from the Ap

[GitHub] [kafka] michael-carter-instaclustr commented on a change in pull request #8844: KAFKA-9887 fix failed task or connector count on startup failure

2020-06-22 Thread GitBox
michael-carter-instaclustr commented on a change in pull request #8844: URL: https://github.com/apache/kafka/pull/8844#discussion_r443387368 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerTask.java ## @@ -56,7 +56,7 @@ private static fi

[jira] [Commented] (KAFKA-10173) BufferUnderflowException during Kafka Streams Upgrade

2020-06-22 Thread Karsten Schnitter (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17141983#comment-17141983 ] Karsten Schnitter commented on KAFKA-10173: --- Hi [~vvcephei], after trying for

[jira] [Comment Edited] (KAFKA-10173) BufferUnderflowException during Kafka Streams Upgrade

2020-06-22 Thread Karsten Schnitter (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17141983#comment-17141983 ] Karsten Schnitter edited comment on KAFKA-10173 at 6/22/20, 12:21 PM:

[GitHub] [kafka] mimaison commented on pull request #8604: KIP-597: MirrorMaker2 internal topics Formatters

2020-06-22 Thread GitBox
mimaison commented on pull request #8604: URL: https://github.com/apache/kafka/pull/8604#issuecomment-647618474 @kkonstantine @omkreddy Can you take a look? Thanks This is an automated message from the Apache Git Service. To

[jira] [Commented] (KAFKA-10191) fix flaky StreamsOptimizedTest

2020-06-22 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142237#comment-17142237 ] Sophie Blee-Goldman commented on KAFKA-10191: - This looks like it could be a

[jira] [Resolved] (KAFKA-10138) Prefer --bootstrap-server for reassign_partitions command in ducktape tests

2020-06-22 Thread Vinoth Chandar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinoth Chandar resolved KAFKA-10138. Resolution: Fixed > Prefer --bootstrap-server for reassign_partitions command in ducktape

[jira] [Updated] (KAFKA-10191) fix flaky StreamsOptimizedTest

2020-06-22 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-10191: Component/s: unit tests streams > fix flaky StreamsOptimizedTest > --

[jira] [Commented] (KAFKA-10191) fix flaky StreamsOptimizedTest

2020-06-22 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142285#comment-17142285 ] Sophie Blee-Goldman commented on KAFKA-10191: - Hey [~chia7712], you don't ha

[jira] [Comment Edited] (KAFKA-10191) fix flaky StreamsOptimizedTest

2020-06-22 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142285#comment-17142285 ] Sophie Blee-Goldman edited comment on KAFKA-10191 at 6/22/20, 5:29 PM: ---

[jira] [Commented] (KAFKA-10191) fix flaky StreamsOptimizedTest

2020-06-22 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142291#comment-17142291 ] Sophie Blee-Goldman commented on KAFKA-10191: - I think this could be caused

[jira] [Assigned] (KAFKA-9974) Flaky Test OptimizedKTableIntegrationTest#shouldApplyUpdatesToStandbyStore

2020-06-22 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler reassigned KAFKA-9974: --- Assignee: Guozhang Wang > Flaky Test OptimizedKTableIntegrationTest#shouldApplyUpdatesToStan

[jira] [Commented] (KAFKA-10191) fix flaky StreamsOptimizedTest

2020-06-22 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142301#comment-17142301 ] Jun Rao commented on KAFKA-10191: - This test failure occurred  [http://testing.confluent

[jira] [Assigned] (KAFKA-10184) Flaky HighAvailabilityTaskAssignorIntegrationTest.shouldScaleOutWithWarmupTasksAndPersistentStores

2020-06-22 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler reassigned KAFKA-10184: Assignee: John Roesler > Flaky > HighAvailabilityTaskAssignorIntegrationTest.shouldScale

[jira] [Updated] (KAFKA-10191) fix flaky StreamsOptimizedTest

2020-06-22 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-10191: - Priority: Blocker (was: Major) > fix flaky StreamsOptimizedTest > -

[jira] [Updated] (KAFKA-10191) fix flaky StreamsOptimizedTest

2020-06-22 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-10191: - Fix Version/s: 2.6.0 > fix flaky StreamsOptimizedTest > -- > >

[GitHub] [kafka] junrao commented on pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

2020-06-22 Thread GitBox
junrao commented on pull request #8657: URL: https://github.com/apache/kafka/pull/8657#issuecomment-647688705 It seems we just fixed a bunch of client compatibility related failures in https://github.com/apache/kafka/pull/8841. Another 18 test failures were due to TLSv1.3 and are tracked i

[GitHub] [kafka] C0urante commented on a change in pull request #8844: KAFKA-9887 fix failed task or connector count on startup failure

2020-06-22 Thread GitBox
C0urante commented on a change in pull request #8844: URL: https://github.com/apache/kafka/pull/8844#discussion_r443742947 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java ## @@ -289,7 +285,6 @@ public void startConnector(

[GitHub] [kafka] C0urante commented on a change in pull request #8844: KAFKA-9887 fix failed task or connector count on startup failure

2020-06-22 Thread GitBox
C0urante commented on a change in pull request #8844: URL: https://github.com/apache/kafka/pull/8844#discussion_r443756424 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerTask.java ## @@ -56,7 +56,7 @@ private static final String THREAD_

[GitHub] [kafka] C0urante commented on pull request #8844: KAFKA-9887 fix failed task or connector count on startup failure

2020-06-22 Thread GitBox
C0urante commented on pull request #8844: URL: https://github.com/apache/kafka/pull/8844#issuecomment-647707645 Thanks for the insight @michael-carter-instaclustr. This type of direct user feedback and perspective is invaluable! I'm convinced that your interpretation is likely the more use

[GitHub] [kafka] mjsax commented on a change in pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

2020-06-22 Thread GitBox
mjsax commented on a change in pull request #8900: URL: https://github.com/apache/kafka/pull/8900#discussion_r443759806 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -679,58 +675,75 @@ private void cleanupTask(final Tas

[GitHub] [kafka] mjsax commented on a change in pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

2020-06-22 Thread GitBox
mjsax commented on a change in pull request #8900: URL: https://github.com/apache/kafka/pull/8900#discussion_r443760619 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -679,58 +675,75 @@ private void cleanupTask(final Tas

[GitHub] [kafka] mjsax commented on pull request #8022: KAFKA 8382: Add TimestampedSessionStore

2020-06-22 Thread GitBox
mjsax commented on pull request #8022: URL: https://github.com/apache/kafka/pull/8022#issuecomment-647711505 I am not aware of any particular use-case that needs this feature atm. If you really want to work on it, feel free to do and we will try to review the PR. But it would be low priori

[GitHub] [kafka] mjsax commented on pull request #8029: KAFKA-8147: Add changelog topic configuration to KTable suppress

2020-06-22 Thread GitBox
mjsax commented on pull request #8029: URL: https://github.com/apache/kafka/pull/8029#issuecomment-647713849 There is a directory `docs` -- with sub-directory `streams` (cf https://github.com/apache/kafka/tree/trunk/docs). As this PR implements a KIP, you should update `docs/streams

[GitHub] [kafka] mjsax commented on pull request #8887: KAFKA-10135: Extract Task#executeAndMaybeSwallow to be a general utility function into TaskManager…

2020-06-22 Thread GitBox
mjsax commented on pull request #8887: URL: https://github.com/apache/kafka/pull/8887#issuecomment-647718486 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] mjsax commented on a change in pull request #8887: KAFKA-10135: Extract Task#executeAndMaybeSwallow to be a general utility function into TaskManager…

2020-06-22 Thread GitBox
mjsax commented on a change in pull request #8887: URL: https://github.com/apache/kafka/pull/8887#discussion_r443768571 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -1048,4 +1042,28 @@ public String toString(final Stri

[GitHub] [kafka] d8tltanc commented on a change in pull request #8683: KAFKA-9893: Configurable TCP connection timeout and improve the initial metadata fetch

2020-06-22 Thread GitBox
d8tltanc commented on a change in pull request #8683: URL: https://github.com/apache/kafka/pull/8683#discussion_r443769782 ## File path: clients/src/main/java/org/apache/kafka/clients/ClusterConnectionStates.java ## @@ -158,9 +175,15 @@ public InetAddress currentAddress(String

[GitHub] [kafka] d8tltanc commented on a change in pull request #8683: KAFKA-9893: Configurable TCP connection timeout and improve the initial metadata fetch

2020-06-22 Thread GitBox
d8tltanc commented on a change in pull request #8683: URL: https://github.com/apache/kafka/pull/8683#discussion_r443770204 ## File path: clients/src/main/java/org/apache/kafka/clients/ClusterConnectionStates.java ## @@ -300,30 +325,47 @@ public AuthenticationException authent

[GitHub] [kafka] d8tltanc commented on a change in pull request #8683: KAFKA-9893: Configurable TCP connection timeout and improve the initial metadata fetch

2020-06-22 Thread GitBox
d8tltanc commented on a change in pull request #8683: URL: https://github.com/apache/kafka/pull/8683#discussion_r443769844 ## File path: clients/src/main/java/org/apache/kafka/clients/ClusterConnectionStates.java ## @@ -158,9 +175,15 @@ public InetAddress currentAddress(String

[GitHub] [kafka] d8tltanc commented on a change in pull request #8683: KAFKA-9893: Configurable TCP connection timeout and improve the initial metadata fetch

2020-06-22 Thread GitBox
d8tltanc commented on a change in pull request #8683: URL: https://github.com/apache/kafka/pull/8683#discussion_r443774588 ## File path: clients/src/main/java/org/apache/kafka/clients/ClusterConnectionStates.java ## @@ -357,6 +399,38 @@ private NodeConnectionState nodeState(St

[jira] [Commented] (KAFKA-10191) fix flaky StreamsOptimizedTest

2020-06-22 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142361#comment-17142361 ] Sophie Blee-Goldman commented on KAFKA-10191: - Awesome, thanks Jun. I think

[GitHub] [kafka] abbccdda commented on pull request #8725: KAFKA-9608: Transaction Event Simulation Test

2020-06-22 Thread GitBox
abbccdda commented on pull request #8725: URL: https://github.com/apache/kafka/pull/8725#issuecomment-647731489 retest this please This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [kafka] abbccdda opened a new pull request #8725: KAFKA-9608: Transaction Event Simulation Test

2020-06-22 Thread GitBox
abbccdda opened a new pull request #8725: URL: https://github.com/apache/kafka/pull/8725 Start the basic template for transaction event simulation. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI bu

[GitHub] [kafka] abbccdda closed pull request #8725: KAFKA-9608: Transaction Event Simulation Test

2020-06-22 Thread GitBox
abbccdda closed pull request #8725: URL: https://github.com/apache/kafka/pull/8725 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] d8tltanc commented on a change in pull request #8683: KAFKA-9893: Configurable TCP connection timeout and improve the initial metadata fetch

2020-06-22 Thread GitBox
d8tltanc commented on a change in pull request #8683: URL: https://github.com/apache/kafka/pull/8683#discussion_r443785134 ## File path: clients/src/main/java/org/apache/kafka/clients/ClusterConnectionStates.java ## @@ -357,6 +398,36 @@ private NodeConnectionState nodeState(St

[GitHub] [kafka] d8tltanc commented on a change in pull request #8683: KAFKA-9893: Configurable TCP connection timeout and improve the initial metadata fetch

2020-06-22 Thread GitBox
d8tltanc commented on a change in pull request #8683: URL: https://github.com/apache/kafka/pull/8683#discussion_r443785134 ## File path: clients/src/main/java/org/apache/kafka/clients/ClusterConnectionStates.java ## @@ -357,6 +398,36 @@ private NodeConnectionState nodeState(St

[GitHub] [kafka] d8tltanc commented on a change in pull request #8683: KAFKA-9893: Configurable TCP connection timeout and improve the initial metadata fetch

2020-06-22 Thread GitBox
d8tltanc commented on a change in pull request #8683: URL: https://github.com/apache/kafka/pull/8683#discussion_r443785134 ## File path: clients/src/main/java/org/apache/kafka/clients/ClusterConnectionStates.java ## @@ -357,6 +398,36 @@ private NodeConnectionState nodeState(St

[GitHub] [kafka] d8tltanc commented on a change in pull request #8683: KAFKA-9893: Configurable TCP connection timeout and improve the initial metadata fetch

2020-06-22 Thread GitBox
d8tltanc commented on a change in pull request #8683: URL: https://github.com/apache/kafka/pull/8683#discussion_r443785134 ## File path: clients/src/main/java/org/apache/kafka/clients/ClusterConnectionStates.java ## @@ -357,6 +398,36 @@ private NodeConnectionState nodeState(St

[GitHub] [kafka] abbccdda commented on pull request #8845: KAFKA-10126:Add a warning message for ConsumerPerformance

2020-06-22 Thread GitBox
abbccdda commented on pull request #8845: URL: https://github.com/apache/kafka/pull/8845#issuecomment-647739314 test this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] d8tltanc commented on a change in pull request #8683: KAFKA-9893: Configurable TCP connection timeout and improve the initial metadata fetch

2020-06-22 Thread GitBox
d8tltanc commented on a change in pull request #8683: URL: https://github.com/apache/kafka/pull/8683#discussion_r443793290 ## File path: clients/src/main/java/org/apache/kafka/clients/ClusterConnectionStates.java ## @@ -357,6 +345,37 @@ private NodeConnectionState nodeState(St

[GitHub] [kafka] d8tltanc commented on a change in pull request #8683: KAFKA-9893: Configurable TCP connection timeout and improve the initial metadata fetch

2020-06-22 Thread GitBox
d8tltanc commented on a change in pull request #8683: URL: https://github.com/apache/kafka/pull/8683#discussion_r443794598 ## File path: clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java ## @@ -103,6 +103,12 @@ Utils.join(SecurityProtocol.names()

[GitHub] [kafka] d8tltanc commented on a change in pull request #8683: KAFKA-9893: Configurable TCP connection timeout and improve the initial metadata fetch

2020-06-22 Thread GitBox
d8tltanc commented on a change in pull request #8683: URL: https://github.com/apache/kafka/pull/8683#discussion_r443806341 ## File path: clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java ## @@ -185,4 +191,9 @@ public static void warnIfDeprecatedDnsLookup

[GitHub] [kafka] d8tltanc commented on a change in pull request #8683: KAFKA-9893: Configurable TCP connection timeout and improve the initial metadata fetch

2020-06-22 Thread GitBox
d8tltanc commented on a change in pull request #8683: URL: https://github.com/apache/kafka/pull/8683#discussion_r443807553 ## File path: clients/src/main/java/org/apache/kafka/clients/NetworkClient.java ## @@ -771,7 +794,7 @@ private void processDisconnection(List responses,

[GitHub] [kafka] ableegoldman commented on a change in pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

2020-06-22 Thread GitBox
ableegoldman commented on a change in pull request #8900: URL: https://github.com/apache/kafka/pull/8900#discussion_r443808226 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -522,7 +522,7 @@ private void close(final boole

[GitHub] [kafka] ableegoldman commented on a change in pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

2020-06-22 Thread GitBox
ableegoldman commented on a change in pull request #8900: URL: https://github.com/apache/kafka/pull/8900#discussion_r443809040 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -69,7 +68,6 @@ private final ChangelogRea

[GitHub] [kafka] ableegoldman commented on a change in pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

2020-06-22 Thread GitBox
ableegoldman commented on a change in pull request #8900: URL: https://github.com/apache/kafka/pull/8900#discussion_r443809040 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -69,7 +68,6 @@ private final ChangelogRea

[GitHub] [kafka] ableegoldman commented on a change in pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

2020-06-22 Thread GitBox
ableegoldman commented on a change in pull request #8900: URL: https://github.com/apache/kafka/pull/8900#discussion_r443828344 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java ## @@ -267,7 +283,17 @@ public void close()

[jira] [Commented] (KAFKA-10105) Regression in group coordinator dealing with flaky clients joining while leaving

2020-06-22 Thread Gokul Ramanan Subramanian (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142419#comment-17142419 ] Gokul Ramanan Subramanian commented on KAFKA-10105: --- [~william_reynold

[jira] [Updated] (KAFKA-10189) Reset metric EventQueueTimeMs

2020-06-22 Thread Jeff Kim (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Kim updated KAFKA-10189: - Description: The metric [EventQueueTimeMs|[https://github.com/apache/kafka/blob/trunk/core/src/main/sca

[jira] [Updated] (KAFKA-10189) Reset metric EventQueueTimeMs

2020-06-22 Thread Jeff Kim (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Kim updated KAFKA-10189: - Description: The metric [EventQueueTimeMs|[http://github.com/apache/kafka/blob/trunk/core/src/main/scal

[jira] [Updated] (KAFKA-10189) Reset metric EventQueueTimeMs

2020-06-22 Thread Jeff Kim (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Kim updated KAFKA-10189: - Description: The metric [EventQueueTimeMs|[http://github.com/apache/kafka/blob/trunk/core/src/main/scal

[jira] [Updated] (KAFKA-10189) Reset metric EventQueueTimeMs

2020-06-22 Thread Jeff Kim (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Kim updated KAFKA-10189: - Description: The metric [EventQueueTimeMs|[http://github.com/apache/kafka/blob/trunk/core/src/main/scal

[jira] [Updated] (KAFKA-10189) Reset metric EventQueueTimeMs

2020-06-22 Thread Jeff Kim (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Kim updated KAFKA-10189: - Description: The metric [EventQueueTimeMs|https://github.com/apache/kafka/blob/trunk/core/src/main/scal

[jira] [Updated] (KAFKA-10189) Reset metric EventQueueTimeMs

2020-06-22 Thread Jeff Kim (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Kim updated KAFKA-10189: - Description: The metric [EventQueueTimeMs|https://github.com/apache/kafka/blob/trunk/core/src/main/scal

[GitHub] [kafka] abbccdda commented on pull request #8887: KAFKA-10135: Extract Task#executeAndMaybeSwallow to be a general utility function into TaskManager…

2020-06-22 Thread GitBox
abbccdda commented on pull request #8887: URL: https://github.com/apache/kafka/pull/8887#issuecomment-647778576 Only one flaky test failed: ``` org.apache.kafka.connect.integration.BlockingConnectorTest.testBlockInConnectorStop ```

[jira] [Created] (KAFKA-10192) Flaky test BlockingConnectorTest#testBlockInConnectorStop

2020-06-22 Thread Boyang Chen (Jira)
Boyang Chen created KAFKA-10192: --- Summary: Flaky test BlockingConnectorTest#testBlockInConnectorStop Key: KAFKA-10192 URL: https://issues.apache.org/jira/browse/KAFKA-10192 Project: Kafka Issue

[GitHub] [kafka] abbccdda commented on a change in pull request #8887: KAFKA-10135: Extract Task#executeAndMaybeSwallow to be a general utility function into TaskManager…

2020-06-22 Thread GitBox
abbccdda commented on a change in pull request #8887: URL: https://github.com/apache/kafka/pull/8887#discussion_r443837837 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -1048,4 +1042,28 @@ public String toString(final S

[jira] [Commented] (KAFKA-10055) Add shared internal utility class for Streams module

2020-06-22 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142429#comment-17142429 ] Boyang Chen commented on KAFKA-10055: - Need to move to the shared utility class as w

[jira] [Comment Edited] (KAFKA-10055) Add shared internal utility class for Streams module

2020-06-22 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142429#comment-17142429 ] Boyang Chen edited comment on KAFKA-10055 at 6/22/20, 9:32 PM: ---

[GitHub] [kafka] abbccdda commented on pull request #8174: KAFKA-9439: add KafkaProducer API unit tests

2020-06-22 Thread GitBox
abbccdda commented on pull request #8174: URL: https://github.com/apache/kafka/pull/8174#issuecomment-647782852 retest this please This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [kafka] guozhangwang commented on a change in pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

2020-06-22 Thread GitBox
guozhangwang commented on a change in pull request #8900: URL: https://github.com/apache/kafka/pull/8900#discussion_r443847867 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -69,7 +68,6 @@ private final ChangelogRea

[GitHub] [kafka] guozhangwang commented on a change in pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

2020-06-22 Thread GitBox
guozhangwang commented on a change in pull request #8900: URL: https://github.com/apache/kafka/pull/8900#discussion_r443849945 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java ## @@ -267,7 +283,17 @@ public void close()

[GitHub] [kafka] ableegoldman commented on a change in pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

2020-06-22 Thread GitBox
ableegoldman commented on a change in pull request #8900: URL: https://github.com/apache/kafka/pull/8900#discussion_r443850536 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -679,58 +675,75 @@ private void cleanupTask(fi

[GitHub] [kafka] ableegoldman commented on a change in pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

2020-06-22 Thread GitBox
ableegoldman commented on a change in pull request #8900: URL: https://github.com/apache/kafka/pull/8900#discussion_r443851041 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -542,7 +542,12 @@ private void close(final bool

[GitHub] [kafka] ableegoldman commented on a change in pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

2020-06-22 Thread GitBox
ableegoldman commented on a change in pull request #8900: URL: https://github.com/apache/kafka/pull/8900#discussion_r443852154 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -679,58 +675,75 @@ private void cleanupTask(fi

[GitHub] [kafka] ableegoldman commented on a change in pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

2020-06-22 Thread GitBox
ableegoldman commented on a change in pull request #8900: URL: https://github.com/apache/kafka/pull/8900#discussion_r443852676 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -679,58 +675,75 @@ private void cleanupTask(fi

[GitHub] [kafka] ableegoldman commented on a change in pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

2020-06-22 Thread GitBox
ableegoldman commented on a change in pull request #8900: URL: https://github.com/apache/kafka/pull/8900#discussion_r443854106 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/EosIntegrationTest.java ## @@ -203,6 +208,34 @@ public void shouldBeAbleToRu

[GitHub] [kafka] ableegoldman commented on a change in pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

2020-06-22 Thread GitBox
ableegoldman commented on a change in pull request #8900: URL: https://github.com/apache/kafka/pull/8900#discussion_r443854750 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/EosIntegrationTest.java ## @@ -203,6 +208,34 @@ public void shouldBeAbleToRu

[GitHub] [kafka] ableegoldman commented on a change in pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

2020-06-22 Thread GitBox
ableegoldman commented on a change in pull request #8900: URL: https://github.com/apache/kafka/pull/8900#discussion_r443855976 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/EosIntegrationTest.java ## @@ -203,6 +208,34 @@ public void shouldBeAbleToRu

[GitHub] [kafka] abbccdda commented on a change in pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

2020-06-22 Thread GitBox
abbccdda commented on a change in pull request #8900: URL: https://github.com/apache/kafka/pull/8900#discussion_r443855731 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java ## @@ -250,10 +250,26 @@ public void flush() {

[jira] [Created] (KAFKA-10193) Add preemption for ControllerEvent that have callbacks

2020-06-22 Thread Jeff Kim (Jira)
Jeff Kim created KAFKA-10193: Summary: Add preemption for ControllerEvent that have callbacks Key: KAFKA-10193 URL: https://issues.apache.org/jira/browse/KAFKA-10193 Project: Kafka Issue Type: Bu

[jira] [Updated] (KAFKA-10193) Add preemption for controller events that have callbacks

2020-06-22 Thread Jeff Kim (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Kim updated KAFKA-10193: - Summary: Add preemption for controller events that have callbacks (was: Add preemption for ControllerEv

[jira] [Commented] (KAFKA-10055) Add shared internal utility class for Streams module

2020-06-22 Thread Vito Jeng (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142451#comment-17142451 ] Vito Jeng commented on KAFKA-10055: --- [~bchen225242] Got it. > Add shared internal uti

[jira] [Commented] (KAFKA-10173) BufferUnderflowException during Kafka Streams Upgrade

2020-06-22 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142460#comment-17142460 ] John Roesler commented on KAFKA-10173: -- Wow, thanks for that great information, [~k

[GitHub] [kafka] ableegoldman commented on a change in pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

2020-06-22 Thread GitBox
ableegoldman commented on a change in pull request #8900: URL: https://github.com/apache/kafka/pull/8900#discussion_r443864310 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java ## @@ -267,7 +283,17 @@ public void close()

[jira] [Commented] (KAFKA-10105) Regression in group coordinator dealing with flaky clients joining while leaving

2020-06-22 Thread Gokul Ramanan Subramanian (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142467#comment-17142467 ] Gokul Ramanan Subramanian commented on KAFKA-10105: --- [~ableegoldman] c

[GitHub] [kafka] abbccdda merged pull request #8887: KAFKA-10135: Extract Task#executeAndMaybeSwallow to be a general utility function into TaskManager…

2020-06-22 Thread GitBox
abbccdda merged pull request #8887: URL: https://github.com/apache/kafka/pull/8887 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] abbccdda commented on pull request #8832: KAFKA-9377: Refactor StreamsPartitionAssignor Repartition Count Logic

2020-06-22 Thread GitBox
abbccdda commented on pull request #8832: URL: https://github.com/apache/kafka/pull/8832#issuecomment-647809159 test this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] mjsax commented on a change in pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

2020-06-22 Thread GitBox
mjsax commented on a change in pull request #8900: URL: https://github.com/apache/kafka/pull/8900#discussion_r443871712 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java ## @@ -267,7 +283,17 @@ public void close() {

[GitHub] [kafka] mjsax commented on a change in pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

2020-06-22 Thread GitBox
mjsax commented on a change in pull request #8900: URL: https://github.com/apache/kafka/pull/8900#discussion_r443871959 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -542,7 +542,12 @@ private void close(final boolean cle

[jira] [Commented] (KAFKA-10105) Regression in group coordinator dealing with flaky clients joining while leaving

2020-06-22 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142478#comment-17142478 ] Sophie Blee-Goldman commented on KAFKA-10105: - It's possible. If you're able

[GitHub] [kafka] guozhangwang commented on a change in pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

2020-06-22 Thread GitBox
guozhangwang commented on a change in pull request #8900: URL: https://github.com/apache/kafka/pull/8900#discussion_r443873843 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java ## @@ -267,7 +283,17 @@ public void close()

[GitHub] [kafka] mjsax commented on a change in pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

2020-06-22 Thread GitBox
mjsax commented on a change in pull request #8900: URL: https://github.com/apache/kafka/pull/8900#discussion_r443875108 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java ## @@ -267,7 +283,17 @@ public void close() {

[GitHub] [kafka] mjsax commented on a change in pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

2020-06-22 Thread GitBox
mjsax commented on a change in pull request #8900: URL: https://github.com/apache/kafka/pull/8900#discussion_r443875108 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java ## @@ -267,7 +283,17 @@ public void close() {

[GitHub] [kafka] ableegoldman commented on a change in pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

2020-06-22 Thread GitBox
ableegoldman commented on a change in pull request #8900: URL: https://github.com/apache/kafka/pull/8900#discussion_r443877830 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java ## @@ -267,7 +283,17 @@ public void close()

[GitHub] [kafka] d8tltanc commented on a change in pull request #8683: KAFKA-9893: Configurable TCP connection timeout and improve the initial metadata fetch

2020-06-22 Thread GitBox
d8tltanc commented on a change in pull request #8683: URL: https://github.com/apache/kafka/pull/8683#discussion_r443888648 ## File path: clients/src/main/java/org/apache/kafka/common/utils/ExponentialBackoff.java ## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [kafka] d8tltanc commented on a change in pull request #8683: KAFKA-9893: Configurable TCP connection timeout and improve the initial metadata fetch

2020-06-22 Thread GitBox
d8tltanc commented on a change in pull request #8683: URL: https://github.com/apache/kafka/pull/8683#discussion_r443890115 ## File path: clients/src/main/java/org/apache/kafka/common/utils/ExponentialBackoff.java ## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [kafka] d8tltanc commented on a change in pull request #8683: KAFKA-9893: Configurable TCP connection timeout and improve the initial metadata fetch

2020-06-22 Thread GitBox
d8tltanc commented on a change in pull request #8683: URL: https://github.com/apache/kafka/pull/8683#discussion_r443891445 ## File path: clients/src/test/java/org/apache/kafka/clients/ClusterConnectionStatesTest.java ## @@ -321,4 +325,37 @@ public void testIsPreparingConnectio

[GitHub] [kafka] d8tltanc commented on a change in pull request #8683: KAFKA-9893: Configurable TCP connection timeout and improve the initial metadata fetch

2020-06-22 Thread GitBox
d8tltanc commented on a change in pull request #8683: URL: https://github.com/apache/kafka/pull/8683#discussion_r443903133 ## File path: clients/src/test/java/org/apache/kafka/clients/ClusterConnectionStatesTest.java ## @@ -321,4 +325,37 @@ public void testIsPreparingConnectio

  1   2   >