ableegoldman commented on a change in pull request #8900:
URL: https://github.com/apache/kafka/pull/8900#discussion_r443851041
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java
##########
@@ -542,7 +542,12 @@ private void close(final boolean clean) {
"state manager close",
log);
- executeAndMaybeSwallow(clean, recordCollector::close, "record
collector close", log);
+ executeAndMaybeSwallow(
+ clean,
+ clean ? recordCollector::closeClean :
recordCollector::closeDirty,
Review comment:
I'm just following the pattern we use elsewhere with
`closeDirty`/`closeClean`. Personally I think it does make the code a bit more
readable so you don't have to then go and look up what the boolean argument to
`RecordCollector#close` actually is
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
