chia7712 commented on a change in pull request #8900:
URL: https://github.com/apache/kafka/pull/8900#discussion_r442671271
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java
##
@@ -267,7 +283,17 @@ public void close() {
chia7712 commented on pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#issuecomment-646487562
@junrao thanks for all your reviews.
> I triggered a system test on this PR.
https://jenkins.confluent.io/job/system-test-kafka-branch-builder/3970/
How to see the
[
https://issues.apache.org/jira/browse/KAFKA-8266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17140304#comment-17140304
]
David Jacot commented on KAFKA-8266:
Thanks for reporting [~mjsax]. I just checked th
chia7712 opened a new pull request #8901:
URL: https://github.com/apache/kafka/pull/8901
InvalidTxnTimeoutException is what produced by broker due to illegal txn
timeout.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify
[
https://issues.apache.org/jira/browse/KAFKA-10179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17140328#comment-17140328
]
Bruno Cadonna commented on KAFKA-10179:
---
[~desai.p.rohan] While I find the idea of
dajac commented on a change in pull request #8683:
URL: https://github.com/apache/kafka/pull/8683#discussion_r442725547
##
File path:
clients/src/main/java/org/apache/kafka/clients/ClusterConnectionStates.java
##
@@ -357,6 +399,38 @@ private NodeConnectionState nodeState(Strin
rajinisivaram commented on a change in pull request #8683:
URL: https://github.com/apache/kafka/pull/8683#discussion_r442808154
##
File path:
clients/src/main/java/org/apache/kafka/clients/ClusterConnectionStates.java
##
@@ -158,9 +175,15 @@ public InetAddress currentAddress(S
ijuma commented on pull request #8850:
URL: https://github.com/apache/kafka/pull/8850#issuecomment-646631148
I guess a downside is that we would always generate the string even if
logging was only at the warn level.
This is
ijuma commented on pull request #8899:
URL: https://github.com/apache/kafka/pull/8899#issuecomment-646631428
Flaky test failure:
>
org.apache.kafka.connect.mirror.MirrorConnectorsIntegrationTest.testReplication
Th
ijuma edited a comment on pull request #8899:
URL: https://github.com/apache/kafka/pull/8899#issuecomment-646631428
Flaky test failure:
>
org.apache.kafka.connect.mirror.MirrorConnectorsIntegrationTest.testReplication
ijuma commented on a change in pull request #4090:
URL: https://github.com/apache/kafka/pull/4090#discussion_r442838520
##
File path: core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala
##
@@ -1609,14 +1610,15 @@ object ReassignPartitionsCommand extends Logging {
ijuma commented on a change in pull request #4090:
URL: https://github.com/apache/kafka/pull/4090#discussion_r442839342
##
File path: core/src/main/scala/kafka/utils/Json.scala
##
@@ -65,6 +63,16 @@ object Json {
catch { case e: JsonProcessingException => Left(e) }
}
ijuma commented on a change in pull request #4090:
URL: https://github.com/apache/kafka/pull/4090#discussion_r442839793
##
File path: core/src/test/scala/unit/kafka/admin/ReassignPartitionsUnitTest.scala
##
@@ -641,4 +642,21 @@ class ReassignPartitionsUnitTest {
assertTrue
ijuma merged pull request #8899:
URL: https://github.com/apache/kafka/pull/8899
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
junrao commented on pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#issuecomment-646685855
@chia7712 : The system test results can be found in
http://testing.confluent.io/confluent-kafka-branch-builder-system-test-results/?prefix=2020-06-18--001.1592550132--chia7712--fix_
cadonna opened a new pull request #8902:
URL: https://github.com/apache/kafka/pull/8902
Until now we always passed the default changelog topic name
to the state serdes. However, for optimized source tables
and global tables the changelog topic is the source topic.
Most serdes do
cadonna commented on pull request #8902:
URL: https://github.com/apache/kafka/pull/8902#issuecomment-646686398
Call for review: @mjsax @vvcephei
This is an automated message from the Apache Git Service.
To respond to the mes
[
https://issues.apache.org/jira/browse/KAFKA-10148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna resolved KAFKA-10148.
---
Resolution: Fixed
> Kafka Streams Restores too few Records with eos-beta Enabled
>
guozhangwang merged pull request #8890:
URL: https://github.com/apache/kafka/pull/8890
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
chia7712 commented on pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#issuecomment-646718970
> Could you take a look and see if it's related to this PR? I will trigger
another run just to see if any of those failures were transient.
I compare the failed tests to
h
Manish Maheshwari created KAFKA-10187:
-
Summary: Support Read Only Kafka Topics / Clusters
Key: KAFKA-10187
URL: https://issues.apache.org/jira/browse/KAFKA-10187
Project: Kafka
Issue Typ
chia7712 edited a comment on pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#issuecomment-646718970
> Could you take a look and see if it's related to this PR? I will trigger
another run just to see if any of those failures were transient.
I compare the failed test
[
https://issues.apache.org/jira/browse/KAFKA-10187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Manish Maheshwari updated KAFKA-10187:
--
Summary: Read Only Kafka Topics / Clusters (was: Support Read Only Kafka
Topics / Clu
guozhangwang commented on a change in pull request #8896:
URL: https://github.com/apache/kafka/pull/8896#discussion_r442931356
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StoreChangelogReader.java
##
@@ -458,9 +462,48 @@ public void restore
[
https://issues.apache.org/jira/browse/KAFKA-10187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Manish Maheshwari updated KAFKA-10187:
--
Description:
Request to support Read Only Kafka Topics / Read Only Kafka Clusters.
Th
vvcephei opened a new pull request #8903:
URL: https://github.com/apache/kafka/pull/8903
There's currently no good way to look into the changelog for a suppression
buffer,
since the format is a binary schema.
This POC tool would allow scanning over the changelog and parsing the
r
vvcephei commented on pull request #8903:
URL: https://github.com/apache/kafka/pull/8903#issuecomment-646798478
As a POC, I've verfied this tool by hand by dumping the log from a
suppression over windowed data:
`consumer.properties`:
```
bootstrap.servers=localhost:9092
key.
hachikuji commented on a change in pull request #8891:
URL: https://github.com/apache/kafka/pull/8891#discussion_r442980855
##
File path: core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala
##
@@ -1685,10 +1702,9 @@ object ReassignPartitionsCommand extends Logging {
hachikuji commented on a change in pull request #8891:
URL: https://github.com/apache/kafka/pull/8891#discussion_r442981281
##
File path: core/src/main/scala/kafka/controller/KafkaController.scala
##
@@ -647,8 +647,14 @@ class KafkaController(val config: KafkaConfig,
i
Chris Egerton created KAFKA-10188:
-
Summary: Sink task preCommit method gets called after task is
stopped
Key: KAFKA-10188
URL: https://issues.apache.org/jira/browse/KAFKA-10188
Project: Kafka
vvcephei commented on a change in pull request #8890:
URL: https://github.com/apache/kafka/pull/8890#discussion_r442998201
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/StandbyTaskEOSIntegrationTest.java
##
@@ -151,6 +173,198 @@ private KafkaStreams
vvcephei commented on a change in pull request #8896:
URL: https://github.com/apache/kafka/pull/8896#discussion_r44376
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StoreChangelogReader.java
##
@@ -415,19 +418,20 @@ public void restore()
guozhangwang commented on a change in pull request #8900:
URL: https://github.com/apache/kafka/pull/8900#discussion_r442997760
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java
##
@@ -267,7 +283,17 @@ public void close()
guozhangwang commented on a change in pull request #8896:
URL: https://github.com/apache/kafka/pull/8896#discussion_r443001288
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StoreChangelogReader.java
##
@@ -415,19 +418,20 @@ public void restor
vvcephei commented on a change in pull request #8896:
URL: https://github.com/apache/kafka/pull/8896#discussion_r443001442
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StoreChangelogReader.java
##
@@ -458,9 +462,48 @@ public void restore() {
cmccabe commented on pull request #8898:
URL: https://github.com/apache/kafka/pull/8898#issuecomment-646819881
LGTM
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
[
https://issues.apache.org/jira/browse/KAFKA-9995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17140763#comment-17140763
]
Guozhang Wang commented on KAFKA-9995:
--
Hello James, sorry for the late reply.
Your
guozhangwang commented on a change in pull request #8896:
URL: https://github.com/apache/kafka/pull/8896#discussion_r443004192
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StoreChangelogReader.java
##
@@ -458,9 +462,48 @@ public void restore
vvcephei commented on a change in pull request #8896:
URL: https://github.com/apache/kafka/pull/8896#discussion_r443005504
##
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/StoreChangelogReaderTest.java
##
@@ -223,6 +227,7 @@ public void
shouldI
vvcephei commented on pull request #8896:
URL: https://github.com/apache/kafka/pull/8896#issuecomment-646823870
Unrelated failure:
`org.apache.kafka.connect.mirror.MirrorConnectorsIntegrationTest.testReplication`
This is
vvcephei merged pull request #8896:
URL: https://github.com/apache/kafka/pull/8896
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
[
https://issues.apache.org/jira/browse/KAFKA-10185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Roesler updated KAFKA-10185:
-
Description:
Currently, restoration progress is only visible at debug level in the
Consumer's F
[
https://issues.apache.org/jira/browse/KAFKA-10185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Roesler updated KAFKA-10185:
-
Fix Version/s: 2.7.0
> Streams should log summarized restoration information at info level
> ---
cmccabe merged pull request #8898:
URL: https://github.com/apache/kafka/pull/8898
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
vvcephei opened a new pull request #8904:
URL: https://github.com/apache/kafka/pull/8904
Ports #8896 to 2.5
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation
vvcephei commented on pull request #8904:
URL: https://github.com/apache/kafka/pull/8904#issuecomment-646837766
Hey @guozhangwang , can you also take a look at this port?
This is an automated message from the Apache Git Servi
mjsax commented on a change in pull request #8890:
URL: https://github.com/apache/kafka/pull/8890#discussion_r443021214
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/StandbyTaskEOSIntegrationTest.java
##
@@ -162,6 +376,8 @@ private Properties props(f
[
https://issues.apache.org/jira/browse/KAFKA-9891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax resolved KAFKA-9891.
Resolution: Fixed
> Invalid state store content after task migration with exactly_once and
mjsax merged pull request #8886:
URL: https://github.com/apache/kafka/pull/8886
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
vvcephei commented on a change in pull request #8890:
URL: https://github.com/apache/kafka/pull/8890#discussion_r443022016
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/StandbyTaskEOSIntegrationTest.java
##
@@ -162,6 +376,8 @@ private Properties prop
mjsax commented on a change in pull request #8890:
URL: https://github.com/apache/kafka/pull/8890#discussion_r443024395
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/StandbyTaskEOSIntegrationTest.java
##
@@ -162,6 +376,8 @@ private Properties props(f
vvcephei commented on a change in pull request #8890:
URL: https://github.com/apache/kafka/pull/8890#discussion_r443028417
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/StandbyTaskEOSIntegrationTest.java
##
@@ -162,6 +376,8 @@ private Properties prop
mjsax commented on pull request #8865:
URL: https://github.com/apache/kafka/pull/8865#issuecomment-646862985
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
mjsax commented on pull request #8865:
URL: https://github.com/apache/kafka/pull/8865#issuecomment-646863212
@vvcephei As you are +1, I am going to merge after Jenkins passed.
This is an automated message from the Apache Git
mjsax commented on a change in pull request #8902:
URL: https://github.com/apache/kafka/pull/8902#discussion_r443055363
##
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/internals/graph/TableSourceNodeTest.java
##
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apa
mjsax commented on pull request #8871:
URL: https://github.com/apache/kafka/pull/8871#issuecomment-646872790
Thanks for the cleanup @vitojeng!
This is an automated message from the Apache Git Service.
To respond to the messag
mjsax merged pull request #8871:
URL: https://github.com/apache/kafka/pull/8871
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
mjsax closed pull request #8553:
URL: https://github.com/apache/kafka/pull/8553
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
mjsax commented on pull request #8553:
URL: https://github.com/apache/kafka/pull/8553#issuecomment-646873238
The other PRs got merged. Closing this PR.
This is an automated message from the Apache Git Service.
To respond to t
[
https://issues.apache.org/jira/browse/KAFKA-7500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17140849#comment-17140849
]
Ryanne Dolan commented on KAFKA-7500:
-
[~har5havardhan] I think that is unlikely, giv
vvcephei opened a new pull request #8905:
URL: https://github.com/apache/kafka/pull/8905
Instead of relying on RecordHeader.equals, it is more reliable to use
Arrays.equals
on the header values.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and impl
mjsax commented on pull request #8890:
URL: https://github.com/apache/kafka/pull/8890#issuecomment-646878784
Cherry-picked to `2.6`.
This is an automated message from the Apache Git Service.
To respond to the message, please
vvcephei commented on a change in pull request #8905:
URL: https://github.com/apache/kafka/pull/8905#discussion_r443062971
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/InMemoryTimeOrderedKeyValueBuffer.java
##
@@ -339,7 +341,7 @@ private void re
[
https://issues.apache.org/jira/browse/KAFKA-10173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17140863#comment-17140863
]
John Roesler commented on KAFKA-10173:
--
Hi [~karsten.schnitter] ,
I've had a chanc
[
https://issues.apache.org/jira/browse/KAFKA-10173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17140865#comment-17140865
]
John Roesler edited comment on KAFKA-10173 at 6/19/20, 10:29 PM:
-
[
https://issues.apache.org/jira/browse/KAFKA-10173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17140865#comment-17140865
]
John Roesler commented on KAFKA-10173:
--
[~rhauch]and [~mjsax] , you can consider my
[
https://issues.apache.org/jira/browse/KAFKA-10173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Roesler updated KAFKA-10173:
-
Priority: Major (was: Blocker)
> BufferUnderflowException during Kafka Streams Upgrade
> --
Jeff Kim created KAFKA-10189:
Summary: Reset metric EventQueueTimeMs
Key: KAFKA-10189
URL: https://issues.apache.org/jira/browse/KAFKA-10189
Project: Kafka
Issue Type: Bug
Components:
mjsax commented on a change in pull request #8900:
URL: https://github.com/apache/kafka/pull/8900#discussion_r443067211
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java
##
@@ -267,7 +283,17 @@ public void close() {
mjsax merged pull request #8865:
URL: https://github.com/apache/kafka/pull/8865
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[
https://issues.apache.org/jira/browse/KAFKA-10185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Roesler updated KAFKA-10185:
-
Fix Version/s: 2.6.0
> Streams should log summarized restoration information at info level
> ---
[
https://issues.apache.org/jira/browse/KAFKA-9509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17140914#comment-17140914
]
Luke Chen commented on KAFKA-9509:
--
PR: [https://github.com/apache/kafka/pull/8894]
feyman2016 commented on a change in pull request #8887:
URL: https://github.com/apache/kafka/pull/8887#discussion_r443096402
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##
@@ -1048,4 +1042,28 @@ public String toString(final
zhaohaidao commented on pull request #8549:
URL: https://github.com/apache/kafka/pull/8549#issuecomment-646932428
> Resilience Improvement With Old Brokers
When the client is on the latest version but the broker is old, the client
shall still see INVALID_PRODUCER_EPOCH from produce respo
zhaohaidao edited a comment on pull request #8549:
URL: https://github.com/apache/kafka/pull/8549#issuecomment-646932428
> Resilience Improvement With Old Brokers
When the client is on the latest version but the broker is old, the client
shall still see INVALID_PRODUCER_EPOCH from produc
feyman2016 commented on a change in pull request #8832:
URL: https://github.com/apache/kafka/pull/8832#discussion_r443097670
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java
##
@@ -514,65 +554,81 @@ private boolean
feyman2016 commented on a change in pull request #8832:
URL: https://github.com/apache/kafka/pull/8832#discussion_r443097860
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java
##
@@ -514,65 +554,81 @@ private boolean
jianjianjiao opened a new pull request #8906:
URL: https://github.com/apache/kafka/pull/8906
It looks to be a bug that Kafka broker's dynamic configs for replication,
like follower.replication.throttled.rate, leader.replication.throttled.rate and
replica.alter.log.dirs.io.max.bytes.per.sec
Rong Tang created KAFKA-10190:
-
Summary: Replication throttling configs cannot be set at
entity-default
Key: KAFKA-10190
URL: https://issues.apache.org/jira/browse/KAFKA-10190
Project: Kafka
Iss
[
https://issues.apache.org/jira/browse/KAFKA-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rong Tang updated KAFKA-10190:
--
Flags: (was: Patch)
> Replication throttling configs cannot be set at entity-default
> -
[
https://issues.apache.org/jira/browse/KAFKA-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rong Tang updated KAFKA-10190:
--
Flags: Patch
> Replication throttling configs cannot be set at entity-default
> --
[
https://issues.apache.org/jira/browse/KAFKA-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rong Tang updated KAFKA-10190:
--
Affects Version/s: (was: 2.5.0)
2.6.0
> Replication throttling configs cann
feyman2016 commented on pull request #8832:
URL: https://github.com/apache/kafka/pull/8832#issuecomment-646943356
@abbccdda Updated to fix the TopicsInfo non-keyable issue.
However, this impl will not pass test:
`KTableKTableForeignKeyInnerJoinMultiIntegrationTest#shouldInnerJoinMultiPar
feyman2016 commented on a change in pull request #8887:
URL: https://github.com/apache/kafka/pull/8887#discussion_r443105822
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##
@@ -741,29 +741,23 @@ void shutdown(final boolean c
84 matches
Mail list logo
