feyman2016 commented on pull request #8832: URL: https://github.com/apache/kafka/pull/8832#issuecomment-646943356
@abbccdda Updated to fix the TopicsInfo non-keyable issue. However, this impl will not pass test: `KTableKTableForeignKeyInnerJoinMultiIntegrationTest#shouldInnerJoinMultiPartitionQueryable` and will stackoverflow because of infinite recursive call. Checked it a little bit, it is because there are cycle in the built graph: ``` TopicsInfoA -> Internal topic 22 -> TopicsInfo B -> Internal topic 30 -> TopicsInfo A ``` in the current impl, it won't fail because it will find the `numOfRepartitions` for a topics unless none of its upstream topics' `numOfRepartitions` can be found. I'm not sure if we have the assumption that there will be no cycle in the graph built with TopicsInfo and TopicsNode, if yes, I think the test `shouldInnerJoinMultiPartitionQueryable` should be fixed, if not, I will update the algo to consider the cycle handling. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
