[GitHub] [kafka] tonytony2020 opened a new pull request #8770: Update quickstart.html

2020-06-01 Thread GitBox
tonytony2020 opened a new pull request #8770: URL: https://github.com/apache/kafka/pull/8770 Fix v2.4.x~v2.5.x console producer script doesn't supports `--bootstrap-server` option. We should use `--broker-list` instead. *More detailed description of your change, if necessary.

[GitHub] [kafka] nizhikov commented on a change in pull request #8695: KAFKA-9320: Enable TLSv1.3 by default (KIP-573)

2020-06-01 Thread GitBox
nizhikov commented on a change in pull request #8695: URL: https://github.com/apache/kafka/pull/8695#discussion_r433091643 ## File path: tests/kafkatest/services/security/security_config.py ## @@ -259,6 +267,9 @@ def setup_node(self, node): if self.has_sasl:

[GitHub] [kafka] nizhikov commented on a change in pull request #8695: KAFKA-9320: Enable TLSv1.3 by default (KIP-573)

2020-06-01 Thread GitBox
nizhikov commented on a change in pull request #8695: URL: https://github.com/apache/kafka/pull/8695#discussion_r433097896 ## File path: tests/kafkatest/services/kafka/kafka.py ## @@ -354,15 +358,16 @@ def start_cmd(self, node): def start_node(self, node, timeout_sec=60)

[GitHub] [kafka] nizhikov commented on a change in pull request #8695: KAFKA-9320: Enable TLSv1.3 by default (KIP-573)

2020-06-01 Thread GitBox
nizhikov commented on a change in pull request #8695: URL: https://github.com/apache/kafka/pull/8695#discussion_r433102140 ## File path: clients/src/test/java/org/apache/kafka/common/network/SslTransportLayerTest.java ## @@ -580,7 +581,16 @@ public void testTLSDefaults() throw

[jira] [Commented] (KAFKA-10067) Provide API to detect cluster nodes version

2020-06-01 Thread Tom Bentley (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17120828#comment-17120828 ] Tom Bentley commented on KAFKA-10067: - But the same argument applies: "having a publ

[jira] [Updated] (KAFKA-9320) Enable TLSv1.3 by default and disable some of the older protocols

2020-06-01 Thread Nikolay Izhikov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nikolay Izhikov updated KAFKA-9320: --- Attachment: report.txt > Enable TLSv1.3 by default and disable some of the older protocols >

[jira] [Commented] (KAFKA-9320) Enable TLSv1.3 by default and disable some of the older protocols

2020-06-01 Thread Nikolay Izhikov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17120838#comment-17120838 ] Nikolay Izhikov commented on KAFKA-9320: I ran the following tests: * tests/kafk

[jira] [Commented] (KAFKA-9320) Enable TLSv1.3 by default and disable some of the older protocols

2020-06-01 Thread Nikolay Izhikov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17120842#comment-17120842 ] Nikolay Izhikov commented on KAFKA-9320: Log from the failed test: {noformat} [2

[GitHub] [kafka] nizhikov commented on pull request #8695: KAFKA-9320: Enable TLSv1.3 by default (KIP-573)

2020-06-01 Thread GitBox
nizhikov commented on pull request #8695: URL: https://github.com/apache/kafka/pull/8695#issuecomment-636705289 @ijuma I ran the following tests: * tests/kafkatest/tests/tools/log4j_appender_test.py * tests/kafkatest/tests/core/upgrade_test.py * tests/kafkatest/tests/core/mi

[GitHub] [kafka] chia7712 commented on a change in pull request #8769: KAFKA-10074: Improve performance of `matchingAcls`

2020-06-01 Thread GitBox
chia7712 commented on a change in pull request #8769: URL: https://github.com/apache/kafka/pull/8769#discussion_r433123896 ## File path: core/src/main/scala/kafka/security/authorizer/AclAuthorizer.scala ## @@ -63,9 +64,14 @@ object AclAuthorizer { def exists: Boolean = zkV

[GitHub] [kafka] skaundinya15 commented on pull request #8421: KAFKA-9800: [KIP-580] Admin Client Exponential Backoff Implementation

2020-06-01 Thread GitBox
skaundinya15 commented on pull request #8421: URL: https://github.com/apache/kafka/pull/8421#issuecomment-636725117 @ijuma @abbccdda Initially the idea was to tackle one client at a time while making the patches for this KIP. With respect to creating an overarching module that can be used

[jira] [Commented] (KAFKA-10067) Provide API to detect cluster nodes version

2020-06-01 Thread Yanming Zhou (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17120899#comment-17120899 ] Yanming Zhou commented on KAFKA-10067: -- I don't think so, all relational database p

[jira] [Comment Edited] (KAFKA-10067) Provide API to detect cluster nodes version

2020-06-01 Thread Yanming Zhou (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17120899#comment-17120899 ] Yanming Zhou edited comment on KAFKA-10067 at 6/1/20, 9:49 AM: ---

[jira] [Commented] (KAFKA-560) Garbage Collect obsolete topics

2020-06-01 Thread Goltseva Taisiia (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17120958#comment-17120958 ] Goltseva Taisiia commented on KAFKA-560: I'm looking for an option on Kafka for au

[jira] [Commented] (KAFKA-9320) Enable TLSv1.3 by default and disable some of the older protocols

2020-06-01 Thread Nikolay Izhikov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17120985#comment-17120985 ] Nikolay Izhikov commented on KAFKA-9320: replication_test after last edits. {nofo

[jira] [Created] (KAFKA-10075) Kafka client stucks after Kafka-cluster unavailability

2020-06-01 Thread Dmitry Mischenko (Jira)
Dmitry Mischenko created KAFKA-10075: Summary: Kafka client stucks after Kafka-cluster unavailability Key: KAFKA-10075 URL: https://issues.apache.org/jira/browse/KAFKA-10075 Project: Kafka

[jira] [Updated] (KAFKA-10075) Kafka client stucks after Kafka-cluster unavailability

2020-06-01 Thread Dmitry Mischenko (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dmitry Mischenko updated KAFKA-10075: - Description: Several times we got an issue with kafka-client. What happened: We have K

[GitHub] [kafka] ijuma commented on pull request #8769: KAFKA-10074: Improve performance of `matchingAcls`

2020-06-01 Thread GitBox
ijuma commented on pull request #8769: URL: https://github.com/apache/kafka/pull/8769#issuecomment-636871374 The issue affecting the Scala 2.12 build is unrelated. Looks like Gradle exited while running Streams tests. This i

[GitHub] [kafka] ijuma commented on a change in pull request #8769: KAFKA-10074: Improve performance of `matchingAcls`

2020-06-01 Thread GitBox
ijuma commented on a change in pull request #8769: URL: https://github.com/apache/kafka/pull/8769#discussion_r433245510 ## File path: core/src/main/scala/kafka/security/authorizer/AclAuthorizer.scala ## @@ -63,9 +64,14 @@ object AclAuthorizer { def exists: Boolean = zkVers

[GitHub] [kafka] ijuma commented on a change in pull request #8769: KAFKA-10074: Improve performance of `matchingAcls`

2020-06-01 Thread GitBox
ijuma commented on a change in pull request #8769: URL: https://github.com/apache/kafka/pull/8769#discussion_r433248217 ## File path: core/src/main/scala/kafka/security/authorizer/AclAuthorizer.scala ## @@ -63,9 +64,14 @@ object AclAuthorizer { def exists: Boolean = zkVers

[GitHub] [kafka] ijuma commented on a change in pull request #8769: KAFKA-10074: Improve performance of `matchingAcls`

2020-06-01 Thread GitBox
ijuma commented on a change in pull request #8769: URL: https://github.com/apache/kafka/pull/8769#discussion_r433248217 ## File path: core/src/main/scala/kafka/security/authorizer/AclAuthorizer.scala ## @@ -63,9 +64,14 @@ object AclAuthorizer { def exists: Boolean = zkVers

[jira] [Commented] (KAFKA-6520) When a Kafka Stream can't communicate with the server, it's Status stays RUNNING

2020-06-01 Thread Vince Mu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17121035#comment-17121035 ] Vince Mu commented on KAFKA-6520: - My approach for this would be to create a new metric,

[GitHub] [kafka] ijuma merged pull request #8769: KAFKA-10074: Improve performance of `matchingAcls`

2020-06-01 Thread GitBox
ijuma merged pull request #8769: URL: https://github.com/apache/kafka/pull/8769 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Resolved] (KAFKA-10074) Improve performance of `matchingAcls`

2020-06-01 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma resolved KAFKA-10074. - Reviewer: Rajini Sivaram Resolution: Fixed > Improve performance of `matchingAcls` > -

[GitHub] [kafka] ijuma commented on a change in pull request #8695: KAFKA-9320: Enable TLSv1.3 by default (KIP-573)

2020-06-01 Thread GitBox
ijuma commented on a change in pull request #8695: URL: https://github.com/apache/kafka/pull/8695#discussion_r433253088 ## File path: clients/src/test/java/org/apache/kafka/common/network/SslVersionsTransportLayerTest.java ## @@ -54,21 +54,16 @@ List values = new Arra

[GitHub] [kafka] astubbs opened a new pull request #8771: Add explanation for disabling forwarding from value transformers

2020-06-01 Thread GitBox
astubbs opened a new pull request #8771: URL: https://github.com/apache/kafka/pull/8771 Improve code to be self documenting, in cases where forwarding of messages is disabled due to the type of processor being used, This is

[GitHub] [kafka] ijuma commented on a change in pull request #8695: KAFKA-9320: Enable TLSv1.3 by default (KIP-573)

2020-06-01 Thread GitBox
ijuma commented on a change in pull request #8695: URL: https://github.com/apache/kafka/pull/8695#discussion_r433260716 ## File path: clients/src/test/java/org/apache/kafka/common/network/SslTransportLayerTest.java ## @@ -622,6 +632,108 @@ public void testUnsupportedTLSVersion

[jira] [Created] (KAFKA-10076) Doc prefixed vs. non-prefix configs

2020-06-01 Thread Ron Dagostino (Jira)
Ron Dagostino created KAFKA-10076: - Summary: Doc prefixed vs. non-prefix configs Key: KAFKA-10076 URL: https://issues.apache.org/jira/browse/KAFKA-10076 Project: Kafka Issue Type: Improvement

[GitHub] [kafka] nizhikov commented on a change in pull request #8695: KAFKA-9320: Enable TLSv1.3 by default (KIP-573)

2020-06-01 Thread GitBox
nizhikov commented on a change in pull request #8695: URL: https://github.com/apache/kafka/pull/8695#discussion_r433265356 ## File path: clients/src/test/java/org/apache/kafka/common/network/SslVersionsTransportLayerTest.java ## @@ -54,21 +54,16 @@ List values = new A

[GitHub] [kafka] ijuma commented on a change in pull request #8695: KAFKA-9320: Enable TLSv1.3 by default (KIP-573)

2020-06-01 Thread GitBox
ijuma commented on a change in pull request #8695: URL: https://github.com/apache/kafka/pull/8695#discussion_r433266555 ## File path: clients/src/test/java/org/apache/kafka/common/network/SslTransportLayerTest.java ## @@ -622,6 +632,108 @@ public void testUnsupportedTLSVersion

[GitHub] [kafka] nizhikov commented on a change in pull request #8695: KAFKA-9320: Enable TLSv1.3 by default (KIP-573)

2020-06-01 Thread GitBox
nizhikov commented on a change in pull request #8695: URL: https://github.com/apache/kafka/pull/8695#discussion_r433270767 ## File path: clients/src/test/java/org/apache/kafka/common/network/SslTransportLayerTest.java ## @@ -622,6 +632,108 @@ public void testUnsupportedTLSVers

[GitHub] [kafka] nizhikov commented on a change in pull request #8695: KAFKA-9320: Enable TLSv1.3 by default (KIP-573)

2020-06-01 Thread GitBox
nizhikov commented on a change in pull request #8695: URL: https://github.com/apache/kafka/pull/8695#discussion_r433270767 ## File path: clients/src/test/java/org/apache/kafka/common/network/SslTransportLayerTest.java ## @@ -622,6 +632,108 @@ public void testUnsupportedTLSVers

[GitHub] [kafka] ijuma commented on a change in pull request #8695: KAFKA-9320: Enable TLSv1.3 by default (KIP-573)

2020-06-01 Thread GitBox
ijuma commented on a change in pull request #8695: URL: https://github.com/apache/kafka/pull/8695#discussion_r433271076 ## File path: clients/src/test/java/org/apache/kafka/common/network/SslTransportLayerTest.java ## @@ -580,7 +581,16 @@ public void testTLSDefaults() throws E

[GitHub] [kafka] nizhikov commented on a change in pull request #8695: KAFKA-9320: Enable TLSv1.3 by default (KIP-573)

2020-06-01 Thread GitBox
nizhikov commented on a change in pull request #8695: URL: https://github.com/apache/kafka/pull/8695#discussion_r433272524 ## File path: tests/kafkatest/tests/core/replication_test.py ## @@ -126,9 +126,11 @@ def min_cluster_size(self): security_protocol="SASL_SSL",

[GitHub] [kafka] ijuma commented on a change in pull request #8695: KAFKA-9320: Enable TLSv1.3 by default (KIP-573)

2020-06-01 Thread GitBox
ijuma commented on a change in pull request #8695: URL: https://github.com/apache/kafka/pull/8695#discussion_r433274613 ## File path: clients/src/test/java/org/apache/kafka/common/network/SslTransportLayerTest.java ## @@ -580,7 +581,16 @@ public void testTLSDefaults() throws E

[GitHub] [kafka] ijuma commented on a change in pull request #8695: KAFKA-9320: Enable TLSv1.3 by default (KIP-573)

2020-06-01 Thread GitBox
ijuma commented on a change in pull request #8695: URL: https://github.com/apache/kafka/pull/8695#discussion_r433279649 ## File path: clients/src/test/java/org/apache/kafka/common/network/SslTransportLayerTest.java ## @@ -580,7 +581,16 @@ public void testTLSDefaults() throws E

[GitHub] [kafka] ijuma commented on a change in pull request #8695: KAFKA-9320: Enable TLSv1.3 by default (KIP-573)

2020-06-01 Thread GitBox
ijuma commented on a change in pull request #8695: URL: https://github.com/apache/kafka/pull/8695#discussion_r433279701 ## File path: clients/src/test/java/org/apache/kafka/common/network/SslTransportLayerTest.java ## @@ -622,6 +632,108 @@ public void testUnsupportedTLSVersion

[GitHub] [kafka] ijuma commented on a change in pull request #8695: KAFKA-9320: Enable TLSv1.3 by default (KIP-573)

2020-06-01 Thread GitBox
ijuma commented on a change in pull request #8695: URL: https://github.com/apache/kafka/pull/8695#discussion_r433283096 ## File path: clients/src/test/java/org/apache/kafka/common/network/SslTransportLayerTest.java ## @@ -622,6 +632,108 @@ public void testUnsupportedTLSVersion

[GitHub] [kafka] ijuma commented on a change in pull request #8695: KAFKA-9320: Enable TLSv1.3 by default (KIP-573)

2020-06-01 Thread GitBox
ijuma commented on a change in pull request #8695: URL: https://github.com/apache/kafka/pull/8695#discussion_r433282708 ## File path: clients/src/test/java/org/apache/kafka/common/network/SslTransportLayerTest.java ## @@ -622,6 +632,108 @@ public void testUnsupportedTLSVersion

[GitHub] [kafka] ijuma commented on a change in pull request #8695: KAFKA-9320: Enable TLSv1.3 by default (KIP-573)

2020-06-01 Thread GitBox
ijuma commented on a change in pull request #8695: URL: https://github.com/apache/kafka/pull/8695#discussion_r433283509 ## File path: clients/src/test/java/org/apache/kafka/common/network/SslVersionsTransportLayerTest.java ## @@ -54,21 +54,16 @@ List values = new Arra

[GitHub] [kafka] nizhikov commented on a change in pull request #8695: KAFKA-9320: Enable TLSv1.3 by default (KIP-573)

2020-06-01 Thread GitBox
nizhikov commented on a change in pull request #8695: URL: https://github.com/apache/kafka/pull/8695#discussion_r433283367 ## File path: clients/src/test/java/org/apache/kafka/common/network/SslTransportLayerTest.java ## @@ -622,6 +632,108 @@ public void testUnsupportedTLSVers

[GitHub] [kafka] vvcephei commented on a change in pull request #8764: KAFKA-10049: Fixed FKJ bug where wrapped serdes are set incorrectly when using default StreamsConfig serdes

2020-06-01 Thread GitBox
vvcephei commented on a change in pull request #8764: URL: https://github.com/apache/kafka/pull/8764#discussion_r433284161 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/KTableKTableForeignKeyJoinMaterializationIntegrationTest.java ## @@ -77,11 +83,12

[GitHub] [kafka] rajinisivaram commented on pull request #7956: KAFKA-9392; Clarify deleteAcls javadoc and add test for create/delete timing

2020-06-01 Thread GitBox
rajinisivaram commented on pull request #7956: URL: https://github.com/apache/kafka/pull/7956#issuecomment-636928160 @omkreddy Thanks for the review. Moved the comment to AclAuthorizer. Merging to trunk. This is an automated

[GitHub] [kafka] rajinisivaram merged pull request #7956: KAFKA-9392; Clarify deleteAcls javadoc and add test for create/delete timing

2020-06-01 Thread GitBox
rajinisivaram merged pull request #7956: URL: https://github.com/apache/kafka/pull/7956 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] vvcephei commented on pull request #7693: MINOR: Fix Streams EOS system tests by adding clean-up of state dir

2020-06-01 Thread GitBox
vvcephei commented on pull request #7693: URL: https://github.com/apache/kafka/pull/7693#issuecomment-636933382 I'm seeing some failures on older branches, so I'm cherry-picking back. Cherry-picked to 2.3. Confirmed the test worked locally: ``` [INFO:2020-06-01 08:43:27,309]: Ru

[GitHub] [kafka] vvcephei commented on pull request #7693: MINOR: Fix Streams EOS system tests by adding clean-up of state dir

2020-06-01 Thread GitBox
vvcephei commented on pull request #7693: URL: https://github.com/apache/kafka/pull/7693#issuecomment-636946808 Cherry picked to 2.2: ``` test_id: kafkatest.tests.streams.streams_eos_test.StreamsEo

[GitHub] [kafka] nizhikov commented on a change in pull request #8695: KAFKA-9320: Enable TLSv1.3 by default (KIP-573)

2020-06-01 Thread GitBox
nizhikov commented on a change in pull request #8695: URL: https://github.com/apache/kafka/pull/8695#discussion_r49180 ## File path: clients/src/test/java/org/apache/kafka/common/network/SslTransportLayerTest.java ## @@ -622,6 +632,108 @@ public void testUnsupportedTLSVers

[jira] [Resolved] (KAFKA-9392) Document and add test for deleteAcls that match single/multiple resources

2020-06-01 Thread Rajini Sivaram (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajini Sivaram resolved KAFKA-9392. --- Reviewer: Manikumar Resolution: Fixed > Document and add test for deleteAcls that match

[GitHub] [kafka] nizhikov commented on a change in pull request #8695: KAFKA-9320: Enable TLSv1.3 by default (KIP-573)

2020-06-01 Thread GitBox
nizhikov commented on a change in pull request #8695: URL: https://github.com/apache/kafka/pull/8695#discussion_r433351684 ## File path: clients/src/test/java/org/apache/kafka/common/network/SslTransportLayerTest.java ## @@ -622,6 +632,108 @@ public void testUnsupportedTLSVers

[jira] [Commented] (KAFKA-9891) Invalid state store content after task migration with exactly_once and standby replicas

2020-06-01 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17121149#comment-17121149 ] Boyang Chen commented on KAFKA-9891: [~mateuszjadczyk] If we commit keyOne, then it *

[GitHub] [kafka] nizhikov commented on a change in pull request #8695: KAFKA-9320: Enable TLSv1.3 by default (KIP-573)

2020-06-01 Thread GitBox
nizhikov commented on a change in pull request #8695: URL: https://github.com/apache/kafka/pull/8695#discussion_r433352122 ## File path: clients/src/test/java/org/apache/kafka/common/network/SslTransportLayerTest.java ## @@ -580,7 +581,16 @@ public void testTLSDefaults() throw

[jira] [Commented] (KAFKA-9717) KafkaStreams#metrics() method randomly throws NullPointerException

2020-06-01 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17121152#comment-17121152 ] Chia-Ping Tsai commented on KAFKA-9717: --- [~Bataitis] Have you tried the newer kafka

[GitHub] [kafka] chia7712 commented on a change in pull request #8759: KAFKA-10066: TestOutputTopic should pass record headers into deserializers

2020-06-01 Thread GitBox
chia7712 commented on a change in pull request #8759: URL: https://github.com/apache/kafka/pull/8759#discussion_r433364776 ## File path: streams/test-utils/src/main/java/org/apache/kafka/streams/TopologyTestDriver.java ## @@ -906,8 +906,8 @@ public void advanceWallClockTime(fi

[jira] [Created] (KAFKA-10077) Filter downstream of state-store results in suprious tombstones

2020-06-01 Thread Andy Coates (Jira)
Andy Coates created KAFKA-10077: --- Summary: Filter downstream of state-store results in suprious tombstones Key: KAFKA-10077 URL: https://issues.apache.org/jira/browse/KAFKA-10077 Project: Kafka

[jira] [Updated] (KAFKA-10077) Filter downstream of state-store results in suprious tombstones

2020-06-01 Thread Andy Coates (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Coates updated KAFKA-10077: Description: Adding a `filter` call downstream of anything that has a state store, e.g. a table s

[GitHub] [kafka] ableegoldman opened a new pull request #8772: MINOR: clarify exception throwing in allStorePartitionLags javadocs

2020-06-01 Thread GitBox
ableegoldman opened a new pull request #8772: URL: https://github.com/apache/kafka/pull/8772 Followup to https://github.com/apache/kafka/pull/8738, backporting the javadocs to 2.5 This is an automated message from the Apache

[GitHub] [kafka] ableegoldman commented on pull request #8738: MINOR: remove unnecessary timeout for admin request

2020-06-01 Thread GitBox
ableegoldman commented on pull request #8738: URL: https://github.com/apache/kafka/pull/8738#issuecomment-637012071 Fair enough: https://github.com/apache/kafka/pull/8772 This is an automated message from the Apache Git Servi

[GitHub] [kafka] ableegoldman commented on pull request #8772: MINOR: clarify exception throwing in allStorePartitionLags javadocs

2020-06-01 Thread GitBox
ableegoldman commented on pull request #8772: URL: https://github.com/apache/kafka/pull/8772#issuecomment-637012129 @mjsax This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] bdbyrne edited a comment on pull request #8717: KAFKA-10033: Throw UnknownTopicOrPartitionException when modifying a non-existent topic's config

2020-06-01 Thread GitBox
bdbyrne edited a comment on pull request #8717: URL: https://github.com/apache/kafka/pull/8717#issuecomment-637016443 > Thanks for the PR @bdbyrne, I'm curious why we don't consider fixing the `AdminZkClient#validateTopicConfig` thrown exception type, but fix its caller instead. And in fac

[GitHub] [kafka] bdbyrne commented on pull request #8717: KAFKA-10033: Throw UnknownTopicOrPartitionException when modifying a non-existent topic's config

2020-06-01 Thread GitBox
bdbyrne commented on pull request #8717: URL: https://github.com/apache/kafka/pull/8717#issuecomment-637016443 > Thanks for the PR @bdbyrne, I'm curious why we don't consider fixing the `AdminZkClient#validateTopicConfig` thrown exception type, but fix its caller instead. And in fact we ha

[jira] [Commented] (KAFKA-9494) Include data type of the config in ConfigEntry

2020-06-01 Thread Travis Bischel (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17121211#comment-17121211 ] Travis Bischel commented on KAFKA-9494: --- Thanks! > Include data type of the config

[jira] [Resolved] (KAFKA-10010) Should make state store registration idempotent

2020-06-01 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Chen resolved KAFKA-10010. - Resolution: Fixed > Should make state store registration idempotent > --

[jira] [Resolved] (KAFKA-10011) lockedTaskDirectories should be cleared when task gets closed dirty in HandleLostAll

2020-06-01 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Chen resolved KAFKA-10011. - Resolution: Fixed > lockedTaskDirectories should be cleared when task gets closed dirty in > Ha

[GitHub] [kafka] twmb commented on pull request #8668: KAFKA-9987: optimize sticky assignment algorithm for same-subscription case

2020-06-01 Thread GitBox
twmb commented on pull request #8668: URL: https://github.com/apache/kafka/pull/8668#issuecomment-637026123 From what I can tell, this looks good to me. This loses one mostly insignificant "optimization" that does not really affect anything in reality: prior, if an old-generation member is

[jira] [Commented] (KAFKA-6502) Kafka streams deserialization handler not committing offsets on error records

2020-06-01 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17121235#comment-17121235 ] Matthias J. Sax commented on KAFKA-6502: [~guozhang] I think this issue is fixed

[jira] [Comment Edited] (KAFKA-6502) Kafka streams deserialization handler not committing offsets on error records

2020-06-01 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17121235#comment-17121235 ] Matthias J. Sax edited comment on KAFKA-6502 at 6/1/20, 6:30 PM: --

[GitHub] [kafka] ijuma commented on a change in pull request #8695: KAFKA-9320: Enable TLSv1.3 by default (KIP-573)

2020-06-01 Thread GitBox
ijuma commented on a change in pull request #8695: URL: https://github.com/apache/kafka/pull/8695#discussion_r433413250 ## File path: clients/src/test/java/org/apache/kafka/common/network/SslTransportLayerTest.java ## @@ -732,11 +614,8 @@ public void testUnsupportedCiphers() t

[GitHub] [kafka] vvcephei commented on pull request #7693: MINOR: Fix Streams EOS system tests by adding clean-up of state dir

2020-06-01 Thread GitBox
vvcephei commented on pull request #7693: URL: https://github.com/apache/kafka/pull/7693#issuecomment-637046212 Cherry-picked to 2.1: ``` test_id: kafkatest.tests.streams.streams_eos_test.StreamsEosTest.test_rebalance_complex status: PASS run time: 3 minutes 41.565 seco

[jira] [Updated] (KAFKA-9821) Partition may skip assignment with static members and incremental rebalances

2020-06-01 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman updated KAFKA-9821: --- Component/s: (was: streams) > Partition may skip assignment with static members a

[jira] [Created] (KAFKA-10078) Partition may skip assignment with static members and incremental rebalances

2020-06-01 Thread Sophie Blee-Goldman (Jira)
Sophie Blee-Goldman created KAFKA-10078: --- Summary: Partition may skip assignment with static members and incremental rebalances Key: KAFKA-10078 URL: https://issues.apache.org/jira/browse/KAFKA-10078

[jira] [Updated] (KAFKA-9821) Partition may skip assignment with static members and incremental rebalances

2020-06-01 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman updated KAFKA-9821: --- Description: When static membership (KIP-345) and incremental rebalancing (KIP-429) a

[jira] [Updated] (KAFKA-10078) Stream tasks may skip assignment with static members and incremental rebalances

2020-06-01 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman updated KAFKA-10078: Summary: Stream tasks may skip assignment with static members and incremental reba

[jira] [Updated] (KAFKA-10078) Stream tasks may skip assignment with static members and incremental rebalances

2020-06-01 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman updated KAFKA-10078: Fix Version/s: (was: 2.6.0) > Stream tasks may skip assignment with static mem

[jira] [Updated] (KAFKA-9821) Stream task may skip assignment with static members and incremental rebalances

2020-06-01 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman updated KAFKA-9821: --- Labels: (was: need-kip) > Stream task may skip assignment with static members and i

[jira] [Updated] (KAFKA-9821) Stream task may skip assignment with static members and incremental rebalances

2020-06-01 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman updated KAFKA-9821: --- Summary: Stream task may skip assignment with static members and incremental rebalanc

[jira] [Updated] (KAFKA-10078) Stream tasks may skip assignment with static members and incremental rebalances

2020-06-01 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman updated KAFKA-10078: Component/s: (was: streams) consumer > Stream tasks may skip

[jira] [Assigned] (KAFKA-9821) Stream task may skip assignment with static members and incremental rebalances

2020-06-01 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman reassigned KAFKA-9821: -- Assignee: Sophie Blee-Goldman > Stream task may skip assignment with static me

[jira] [Updated] (KAFKA-9821) Stream task may skip assignment with static members and incremental rebalances

2020-06-01 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman updated KAFKA-9821: --- Fix Version/s: 2.6.0 > Stream task may skip assignment with static members and increm

[jira] [Updated] (KAFKA-9821) Stream task may skip assignment with static members and incremental rebalances

2020-06-01 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman updated KAFKA-9821: --- Component/s: (was: consumer) streams > Stream task may skip assi

[jira] [Updated] (KAFKA-10078) Partition may skip assignment with static members and incremental rebalances

2020-06-01 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman updated KAFKA-10078: Summary: Partition may skip assignment with static members and incremental rebalan

[jira] [Updated] (KAFKA-9821) Stream task may skip assignment with static members and incremental rebalances

2020-06-01 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman updated KAFKA-9821: --- Affects Version/s: 2.4.0 > Stream task may skip assignment with static members and in

[jira] [Resolved] (KAFKA-9821) Stream task may skip assignment with static members and incremental rebalances

2020-06-01 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman resolved KAFKA-9821. Resolution: Fixed > Stream task may skip assignment with static members and increme

[jira] [Updated] (KAFKA-10078) Partition may skip assignment with static members and incremental rebalances

2020-06-01 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman updated KAFKA-10078: Description: When static membership (KIP-345) and incremental rebalancing (KIP-429

[jira] [Assigned] (KAFKA-10078) Partition may skip assignment with static members and incremental rebalances

2020-06-01 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman reassigned KAFKA-10078: --- Assignee: (was: Sophie Blee-Goldman) > Partition may skip assignment wi

[jira] [Updated] (KAFKA-9821) Stream task may skip assignment with static members and incremental rebalances

2020-06-01 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman updated KAFKA-9821: --- Description: When static membership (KIP-345) and incremental rebalancing (KIP-429) a

[jira] [Commented] (KAFKA-6502) Kafka streams deserialization handler not committing offsets on error records

2020-06-01 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17121269#comment-17121269 ] Guozhang Wang commented on KAFKA-6502: -- I think it is not fixed via KAFKA-6607 since

[GitHub] [kafka] vvcephei commented on pull request #7693: MINOR: Fix Streams EOS system tests by adding clean-up of state dir

2020-06-01 Thread GitBox
vvcephei commented on pull request #7693: URL: https://github.com/apache/kafka/pull/7693#issuecomment-637057829 Cherry-picked to 2.0 (along with #6898) ``` test_id: kafkatest.tests.streams.streams_eos_test.StreamsEosTest.test_rebalance_complex status: PASS run time:

[jira] [Created] (KAFKA-10079) Support high availability for in-memory stores

2020-06-01 Thread Sophie Blee-Goldman (Jira)
Sophie Blee-Goldman created KAFKA-10079: --- Summary: Support high availability for in-memory stores Key: KAFKA-10079 URL: https://issues.apache.org/jira/browse/KAFKA-10079 Project: Kafka

[GitHub] [kafka] junrao commented on a change in pull request #8680: KAFKA-10027: Implement read path for feature versioning system (KIP-584)

2020-06-01 Thread GitBox
junrao commented on a change in pull request #8680: URL: https://github.com/apache/kafka/pull/8680#discussion_r432781217 ## File path: core/src/main/scala/kafka/zk/ZkData.scala ## @@ -22,7 +22,7 @@ import java.util.Properties import com.fasterxml.jackson.annotation.JsonPrope

[GitHub] [kafka] guozhangwang commented on pull request #8764: KAFKA-10049: Fixed FKJ bug where wrapped serdes are set incorrectly when using default StreamsConfig serdes

2020-06-01 Thread GitBox
guozhangwang commented on pull request #8764: URL: https://github.com/apache/kafka/pull/8764#issuecomment-637075135 test this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] vvcephei commented on pull request #7693: MINOR: Fix Streams EOS system tests by adding clean-up of state dir

2020-06-01 Thread GitBox
vvcephei commented on pull request #7693: URL: https://github.com/apache/kafka/pull/7693#issuecomment-637087091 Cherry-picked to 1.1 (along with #6797 and #6898 so that it's possible to actually run the test in docker) ``` test_id: kafkatest.tests.streams.streams_eos_test.Stre

[jira] [Assigned] (KAFKA-10077) Filter downstream of state-store results in suprious tombstones

2020-06-01 Thread Andy Coates (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Coates reassigned KAFKA-10077: --- Assignee: Andy Coates > Filter downstream of state-store results in suprious tombstones > -

[GitHub] [kafka] vvcephei commented on pull request #7693: MINOR: Fix Streams EOS system tests by adding clean-up of state dir

2020-06-01 Thread GitBox
vvcephei commented on pull request #7693: URL: https://github.com/apache/kafka/pull/7693#issuecomment-637093964 Cherry-picked to 1.0 (along with #6797 and #6898) ``` test_id: kafkatest.tests.streams.streams_eos_test.StreamsEosTest.test_rebalance_complex status: PASS run t

[jira] [Updated] (KAFKA-10068) Verify HighAvailabilityTaskAssignor performance with large clusters and topologies

2020-06-01 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-10068: - Fix Version/s: 2.6.0 > Verify HighAvailabilityTaskAssignor performance with large clusters and

[jira] [Commented] (KAFKA-10068) Verify HighAvailabilityTaskAssignor performance with large clusters and topologies

2020-06-01 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17121323#comment-17121323 ] John Roesler commented on KAFKA-10068: -- Thanks, [~ableegoldman] , that is indeed wh

[jira] [Updated] (KAFKA-10079) Improve thread-level stickiness of stateful tasks

2020-06-01 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman updated KAFKA-10079: Summary: Improve thread-level stickiness of stateful tasks (was: Support high ava

[jira] [Updated] (KAFKA-10079) Improve thread-level stickiness of stateful tasks

2020-06-01 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman updated KAFKA-10079: Description: Now that KAFKA-9501 is fixed, we should make sure that KIP-441 will w

[GitHub] [kafka] bellemare commented on a change in pull request #8764: KAFKA-10049: Fixed FKJ bug where wrapped serdes are set incorrectly when using default StreamsConfig serdes

2020-06-01 Thread GitBox
bellemare commented on a change in pull request #8764: URL: https://github.com/apache/kafka/pull/8764#discussion_r433486418 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/SinkNode.java ## @@ -66,10 +66,13 @@ public void init(final InternalProc

[GitHub] [kafka] vvcephei commented on a change in pull request #8764: KAFKA-10049: Fixed FKJ bug where wrapped serdes are set incorrectly when using default StreamsConfig serdes

2020-06-01 Thread GitBox
vvcephei commented on a change in pull request #8764: URL: https://github.com/apache/kafka/pull/8764#discussion_r433487031 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/SubscriptionWrapperSerde.java ## @@ -63,9 +63,9 @@ public Su

[GitHub] [kafka] bellemare commented on a change in pull request #8764: KAFKA-10049: Fixed FKJ bug where wrapped serdes are set incorrectly when using default StreamsConfig serdes

2020-06-01 Thread GitBox
bellemare commented on a change in pull request #8764: URL: https://github.com/apache/kafka/pull/8764#discussion_r433486855 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/KTableKTableForeignKeyJoinMaterializationIntegrationTest.java ## @@ -94,15 +101,

  1   2   >