chia7712 commented on a change in pull request #8759:
URL: https://github.com/apache/kafka/pull/8759#discussion_r432919211
##
File path:
streams/test-utils/src/main/java/org/apache/kafka/streams/TopologyTestDriver.java
##
@@ -906,8 +906,8 @@ public void advanceWallClockTime(fi
[
https://issues.apache.org/jira/browse/KAFKA-8480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17120460#comment-17120460
]
Debraj Manna commented on KAFKA-8480:
-
Does this affect latest Kafka 2.5.0 also? If y
nikepakou opened a new pull request #8763:
URL: https://github.com/apache/kafka/pull/8763
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing
nikepakou closed pull request #8763:
URL: https://github.com/apache/kafka/pull/8763
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
feyman2016 commented on a change in pull request #8760:
URL: https://github.com/apache/kafka/pull/8760#discussion_r432951034
##
File path: docs/streams/developer-guide/app-reset-tool.html
##
@@ -56,7 +56,8 @@
Prerequisites
-A
feyman2016 commented on pull request #8760:
URL: https://github.com/apache/kafka/pull/8760#issuecomment-636476681
@abbccdda Screenshots as below, please kindly check, thanks!
https://user-images.githubusercontent.com/23044946/83354407-ff2a5480-a38a-11ea-9ccb-7b1df4b98210.png";>
https:/
feyman2016 commented on a change in pull request #8760:
URL: https://github.com/apache/kafka/pull/8760#discussion_r432951274
##
File path: docs/streams/developer-guide/app-reset-tool.html
##
@@ -117,6 +118,9 @@ Step 1: Run the application reset tool
feyman2016 edited a comment on pull request #8760:
URL: https://github.com/apache/kafka/pull/8760#issuecomment-636476681
@abbccdda Thanks for the review! Screenshots as below, please kindly check~
https://user-images.githubusercontent.com/23044946/83354407-ff2a5480-a38a-11ea-9ccb-7b1df4b9
bellemare opened a new pull request #8764:
URL: https://github.com/apache/kafka/pull/8764
Bug Details:
Mistakenly setting the value serde to the key serde for an internal wrapped
serde in the FKJ workflow.
Testing:
Added integration test to use a non-primitive Serde, in th
[
https://issues.apache.org/jira/browse/KAFKA-10063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17120562#comment-17120562
]
Chia-Ping Tsai commented on KAFKA-10063:
[~hachikuji] Could I take over this iss
[
https://issues.apache.org/jira/browse/KAFKA-10049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17120564#comment-17120564
]
Adam Bellemare commented on KAFKA-10049:
Thanks [~amicngh] for finding and repor
[
https://issues.apache.org/jira/browse/KAFKA-10049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17120563#comment-17120563
]
Adam Bellemare commented on KAFKA-10049:
PR is up.
> KTable-KTable Foreign Key
HaiyuanZhao created KAFKA-10073:
---
Summary: EndTxn wait until markers compelete
Key: KAFKA-10073
URL: https://issues.apache.org/jira/browse/KAFKA-10073
Project: Kafka
Issue Type: Sub-task
[
https://issues.apache.org/jira/browse/KAFKA-10073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
HaiyuanZhao reassigned KAFKA-10073:
---
Assignee: HaiyuanZhao
> EndTxn wait until markers compelete
> -
zhaohaidao opened a new pull request #8765:
URL: https://github.com/apache/kafka/pull/8765
First change of KAFKA-9878: endTxn wait until markers compelete
This is an automated message from the Apache Git Service.
To r
[
https://issues.apache.org/jira/browse/KAFKA-10060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17120571#comment-17120571
]
Chia-Ping Tsai commented on KAFKA-10060:
> I think the expired offsets one can b
[
https://issues.apache.org/jira/browse/KAFKA-10060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17120574#comment-17120574
]
Ismael Juma commented on KAFKA-10060:
-
Sure!
> Kafka is logging too verbosely at th
ijuma commented on pull request #8421:
URL: https://github.com/apache/kafka/pull/8421#issuecomment-636487549
ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
ijuma commented on pull request #8421:
URL: https://github.com/apache/kafka/pull/8421#issuecomment-636487648
@d8tltanc are you planning to address the latest set of comments from
@skaundinya15?
This is an automated message f
ijuma commented on pull request #8421:
URL: https://github.com/apache/kafka/pull/8421#issuecomment-636488043
Also, I think it would be good to tackle the producer and consumer at the
same time to make sure we're building a reusable implementation instead of
something specific to the AdminC
ijuma commented on a change in pull request #8421:
URL: https://github.com/apache/kafka/pull/8421#discussion_r432958968
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java
##
@@ -683,21 +686,65 @@ public Node provide() {
}
}
ijuma opened a new pull request #8766:
URL: https://github.com/apache/kafka/pull/8766
It improves decompression speed:
>For x64 cpus, expect a speed bump of at least +5%, and up to +10% in
favorable cases.
>ARM cpus receive more benefit, with speed improvements ranging from +15%
chia7712 commented on a change in pull request #8767:
URL: https://github.com/apache/kafka/pull/8767#discussion_r432961149
##
File path:
core/src/test/scala/unit/kafka/coordinator/group/GroupMetadataManagerTest.scala
##
@@ -85,21 +82,47 @@ class GroupMetadataManagerTest {
[
https://issues.apache.org/jira/browse/KAFKA-10060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17120582#comment-17120582
]
Chia-Ping Tsai commented on KAFKA-10060:
https://github.com/apache/kafka/pull/87
chia7712 opened a new pull request #8767:
URL: https://github.com/apache/kafka/pull/8767
address @ijuma
[comment](https://issues.apache.org/jira/browse/KAFKA-10060?focusedCommentId=17118992&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17118992)
> I thin
ijuma commented on a change in pull request #8767:
URL: https://github.com/apache/kafka/pull/8767#discussion_r432961140
##
File path:
core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala
##
@@ -786,7 +786,9 @@ class GroupMetadataManager(brokerId: Int,
chia7712 commented on a change in pull request #8767:
URL: https://github.com/apache/kafka/pull/8767#discussion_r432963158
##
File path:
core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala
##
@@ -786,7 +786,9 @@ class GroupMetadataManager(brokerId: Int,
[
https://issues.apache.org/jira/browse/KAFKA-9494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17120634#comment-17120634
]
Travis Bischel commented on KAFKA-9494:
---
It may be beneficial to update the KIP to
stanislavkozlovski commented on a change in pull request #8724:
URL: https://github.com/apache/kafka/pull/8724#discussion_r432986275
##
File path: core/src/main/scala/kafka/controller/ControllerContext.scala
##
@@ -391,6 +404,54 @@ class ControllerContext {
partitionsForTo
ijuma merged pull request #8605:
URL: https://github.com/apache/kafka/pull/8605
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
ijuma commented on a change in pull request #8695:
URL: https://github.com/apache/kafka/pull/8695#discussion_r432987394
##
File path: tests/kafkatest/services/kafka/kafka.py
##
@@ -354,15 +358,16 @@ def start_cmd(self, node):
def start_node(self, node, timeout_sec=60):
ijuma commented on a change in pull request #8695:
URL: https://github.com/apache/kafka/pull/8695#discussion_r432987691
##
File path: tests/kafkatest/tests/core/replication_test.py
##
@@ -126,9 +126,11 @@ def min_cluster_size(self):
security_protocol="SASL_SSL",
c
[
https://issues.apache.org/jira/browse/KAFKA-9148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17120645#comment-17120645
]
adam Retter commented on KAFKA-9148:
How are you guys finding the newer RocksDB versi
ijuma commented on pull request #8695:
URL: https://github.com/apache/kafka/pull/8695#issuecomment-636536255
@nizhikov Have you had a chance to run the system tests with Java 11?
This is an automated message from the Apache G
ijuma merged pull request #8766:
URL: https://github.com/apache/kafka/pull/8766
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
ijuma commented on pull request #8767:
URL: https://github.com/apache/kafka/pull/8767#issuecomment-636536464
Unrelated flaky test failure:
`kafka.api.PlaintextAdminIntegrationTest.testAlterReplicaLogDirs`
This is an au
ijuma merged pull request #8767:
URL: https://github.com/apache/kafka/pull/8767
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[
https://issues.apache.org/jira/browse/KAFKA-9987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17108705#comment-17108705
]
Travis Bischel edited comment on KAFKA-9987 at 5/31/20, 11:19 PM:
-
apovzner opened a new pull request #8768:
URL: https://github.com/apache/kafka/pull/8768
This PR implements the part of KIP-612 that adds broker configurations for
broker-wide and per-listener connection creation rate limits and enforces these
limits.
### Committer Checklist (exclud
[
https://issues.apache.org/jira/browse/KAFKA-9987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17120656#comment-17120656
]
Hai Lin commented on KAFKA-9987:
Thanks [~ableegoldman], will take a look at the PR. You
[
https://issues.apache.org/jira/browse/KAFKA-10067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17120657#comment-17120657
]
Yanming Zhou commented on KAFKA-10067:
--
I'm talking about release version not api v
Ismael Juma created KAFKA-10074:
---
Summary: Improve performance of `matchingAcls`
Key: KAFKA-10074
URL: https://issues.apache.org/jira/browse/KAFKA-10074
Project: Kafka
Issue Type: Improvement
[
https://issues.apache.org/jira/browse/KAFKA-10074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17120660#comment-17120660
]
Ismael Juma commented on KAFKA-10074:
-
cc [~rhauch]
> Improve performance of `match
ijuma opened a new pull request #8769:
URL: https://github.com/apache/kafka/pull/8769
This PR reduces allocations by using a plain old `foreach` in
`matchingAcls` and improves `AclSeqs.find` to only search the inner
collections that are required to find a match (instead of searching al
feyman2016 commented on pull request #8760:
URL: https://github.com/apache/kafka/pull/8760#issuecomment-636584556
@abbccdda Thanks a lot for the review!
This is an automated message from the Apache Git Service.
To respond to
jiameixie commented on pull request #8489:
URL: https://github.com/apache/kafka/pull/8489#issuecomment-636587134
@cmccabe What tests should be done? Thanks
This is an automated message from the Apache Git Service.
To respond
AshishRoyJava commented on pull request #8633:
URL: https://github.com/apache/kafka/pull/8633#issuecomment-636624709
Any update here??
This is an automated message from the Apache Git Service.
To respond to the message, pleas
mjsax commented on a change in pull request #8759:
URL: https://github.com/apache/kafka/pull/8759#discussion_r433054885
##
File path:
streams/test-utils/src/main/java/org/apache/kafka/streams/TopologyTestDriver.java
##
@@ -906,8 +906,8 @@ public void advanceWallClockTime(final
mjsax commented on a change in pull request #8759:
URL: https://github.com/apache/kafka/pull/8759#discussion_r433055097
##
File path:
streams/test-utils/src/test/java/org/apache/kafka/streams/TopologyTestDriverTest.java
##
@@ -711,6 +715,56 @@ public void shouldUseSourceSpecif
mjsax commented on a change in pull request #8759:
URL: https://github.com/apache/kafka/pull/8759#discussion_r433055994
##
File path:
streams/test-utils/src/test/java/org/apache/kafka/streams/TopologyTestDriverTest.java
##
@@ -711,6 +715,56 @@ public void shouldUseSourceSpecif
[
https://issues.apache.org/jira/browse/KAFKA-9494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17120782#comment-17120782
]
Shailesh Panwar commented on KAFKA-9494:
Updated
> Include data type of the conf
51 matches
Mail list logo
