mjsax commented on a change in pull request #8759:
URL: https://github.com/apache/kafka/pull/8759#discussion_r433055994
##########
File path:
streams/test-utils/src/test/java/org/apache/kafka/streams/TopologyTestDriverTest.java
##########
@@ -711,6 +715,56 @@ public void shouldUseSourceSpecificDeserializers() {
assertThat(result2.getValue(), equalTo(source2Value));
}
+ @Test
+ public void shouldPassRecordHeadersIntoDeSerializers() {
Review comment:
We don't verify that header are deserialized -- we just verify that the
right function is called, that hands the header into the deserializer (ie, to
allow used to read them as metadata).
I guess we should use mocks for the deserializers, but not for the
serializers. Thus, not using mocks make the test use the same patter for both
what seems "nicer".
> Moreover, we could build a customized boolean deserializer which outputs
true when the header is provided, or false otherwise.
Would this make the test simpler? I personally doubt it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
